205821 2020-01-06 11:38:49 -0800 Test history links on the dashboard should go to the new results database 2020-01-22 08:59:36 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ryanhaddad jlewis3 aakash_jain ap jbedard jlewis3 webkit-bot-watchers-bugzilla webkit-bug-importer oldest_to_newest 1603180 0 ryanhaddad 2020-01-06 11:38:49 -0800 Test history links on the dashboard should go to the new results database (results.webkit.org). They currently point to the old one (webkit-test-results.webkit.org). Steps to reproduce: 1. Open https://build.webkit.org/dashboard/ 2. Hover over a bubble with layout test failures 3. Click the history link next to a test name 4. Observe that the results are displayed on webkit-test-results.webkit.org instead of the new results.webkit.org 1603181 1 webkit-bug-importer 2020-01-06 11:39:37 -0800 <rdar://problem/58348821> 1609241 2 388341 jlewis3 2020-01-21 13:28:50 -0800 Created attachment 388341 Patch 1609242 3 jlewis3 2020-01-21 13:31:25 -0800 There are a bunch of unittest failures but they are from existing failures, I'm working on a patch to help fix those in a separate bug: https://bugs.webkit.org/show_bug.cgi?id=206548 1609244 4 388341 aakash_jain 2020-01-21 13:33:50 -0800 Comment on attachment 388341 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=388341&action=review Can you provide an example of before and after url for test failure? > Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:50 > + return 'https://results.webkit.org/?suite=layout-tests&test=' + encodeURIComponent(testsParameter); Do we need the '/' in 'results.webkit.org/'? 1609248 5 jlewis3 2020-01-21 13:43:34 -0800 so this is a sample url for results.webkit https://results.webkit.org/?suite=layout-tests&test=http%2Ftests%2Fappcache%2Fabort-cache-onprogress.html It used to be this https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#tests= given that, I assumed it does. 1609307 6 388341 jbedard 2020-01-21 14:48:29 -0800 Comment on attachment 388341 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=388341&action=review >> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:50 >> + return 'https://results.webkit.org/?suite=layout-tests&test=' + encodeURIComponent(testsParameter); > > Do we need the '/' in 'results.webkit.org/'? It it pedantically correct, but we don't need it. 1609565 7 jlewis3 2020-01-22 08:59:36 -0800 Committed r254925: <https://trac.webkit.org/changeset/254925> 388341 2020-01-21 13:28:50 -0800 2020-01-21 14:48:29 -0800 Patch bug-205821-20200121132849.patch text/plain 5477 jlewis3 U3VidmVyc2lvbiBSZXZpc2lvbjogMjU0ODU1CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggOWJiODM2MTFmZWM4MDM3ZDAwMTM2ZDNhMTdkNmFmMDYw ZjUyMzE5MS4uOGMxNDQ0OTJkZGY2ZWExOTUwZWMwZTc5NTBmN2M4Mjc2ZGMyMmE2ZiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIy IEBACisyMDIwLTAxLTIxICBNYXR0IExld2lzICA8amxld2lzM0BhcHBsZS5jb20+CisKKyAgICAg ICAgVGVzdCBoaXN0b3J5IGxpbmtzIG9uIHRoZSBkYXNoYm9hcmQgc2hvdWxkIGdvIHRvIHRoZSBu ZXcgcmVzdWx0cyBkYXRhYmFzZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MjA1ODIxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgTWFkZSBjaGFuZ2VzIHRvIHRoZSB2YXJpb3VzIGxvY2F0aW9ucyB0aGF0IHdl IHVzZSB0aGUgb2xkIGRhdGFiYXNlIGluIHRoZSBtYWluIGRhc2hib2FyZAorICAgICAgICBhbmQg dGVzdCByZXN1bHRzIHBhZ2VzLgorICAgICAgICAKKyAgICAgICAgKiBCdWlsZFNsYXZlU3VwcG9y dC9idWlsZC53ZWJraXQub3JnLWNvbmZpZy9wdWJsaWNfaHRtbC9UZXN0RmFpbHVyZXMvc2NyaXB0 cy91aS5qczoKKyAgICAgICAgKHVpLnVybEZvckZsYWtpbmVzc0Rhc2hib2FyZCk6CisgICAgICAg ICogQnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1jb25maWcvcHVibGljX2h0bWwv VGVzdEZhaWx1cmVzL3NjcmlwdHMvdWkvcmVzdWx0cy5qczoKKyAgICAgICAgKHVpLnJlc3VsdHMu Rmxha2luZXNzRGF0YS5iYXNlLl9oYW5kbGVNZXNzYWdlKToKKyAgICAgICAgKiBCdWlsZFNsYXZl U3VwcG9ydC9idWlsZC53ZWJraXQub3JnLWNvbmZpZy9wdWJsaWNfaHRtbC9kYXNoYm9hcmQvU2Ny aXB0cy9XZWJLaXRUZXN0SGlzdG9yeS5qczoKKyAgICAgICAgKFRlc3RIaXN0b3J5KToKKyAgICAg ICAgKFRlc3RIaXN0b3J5LnByb3RvdHlwZS5oaXN0b3J5UGFnZVVSTEZvclRlc3QpOgorICAgICAg ICAqIEJ1aWxkU2xhdmVTdXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29uZmlnL3RlbXBsYXRlcy9y b290Lmh0bWw6CisKIDIwMjAtMDEtMjAgIEFha2FzaCBKYWluICA8YWFrYXNoX2phaW5AYXBwbGUu Y29tPgogCiAgICAgICAgIFtld3NdIEFkZCBidWlsZCBhbmQgbGF5b3V0LXRlc3Qgc3RlcHMgZm9y IGNvbW1pdC1xdWV1ZSBpbiBuZXcgZXdzCmRpZmYgLS1naXQgYS9Ub29scy9CdWlsZFNsYXZlU3Vw cG9ydC9idWlsZC53ZWJraXQub3JnLWNvbmZpZy9wdWJsaWNfaHRtbC9UZXN0RmFpbHVyZXMvc2Ny aXB0cy91aS5qcyBiL1Rvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29u ZmlnL3B1YmxpY19odG1sL1Rlc3RGYWlsdXJlcy9zY3JpcHRzL3VpLmpzCmluZGV4IDEzMzU4YTUz YWIwZTIyZmEzOTY0YzczMWQ4MDIwOTljYmM5OTVkNjMuLmZjM2QyOTRjNTdjNzMxMWEwMDc0Y2I2 YjczYzE5MWM3ZjZmMGNhZWYgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2J1 aWxkLndlYmtpdC5vcmctY29uZmlnL3B1YmxpY19odG1sL1Rlc3RGYWlsdXJlcy9zY3JpcHRzL3Vp LmpzCisrKyBiL1Rvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29uZmln L3B1YmxpY19odG1sL1Rlc3RGYWlsdXJlcy9zY3JpcHRzL3VpLmpzCkBAIC00Nyw3ICs0Nyw3IEBA IHVpLnVybEZvclRlc3QgPSBmdW5jdGlvbih0ZXN0TmFtZSkKIHVpLnVybEZvckZsYWtpbmVzc0Rh c2hib2FyZCA9IGZ1bmN0aW9uKG9wdF90ZXN0TmFtZUxpc3QpCiB7CiAgICAgdmFyIHRlc3RzUGFy YW1ldGVyID0gb3B0X3Rlc3ROYW1lTGlzdCA/IG9wdF90ZXN0TmFtZUxpc3Quam9pbignLCcpIDog Jyc7Ci0gICAgcmV0dXJuICdodHRwczovL3dlYmtpdC10ZXN0LXJlc3VsdHMud2Via2l0Lm9yZy9k YXNoYm9hcmRzL2ZsYWtpbmVzc19kYXNoYm9hcmQuaHRtbCN0ZXN0cz0nICsgZW5jb2RlVVJJQ29t cG9uZW50KHRlc3RzUGFyYW1ldGVyKTsKKyAgICByZXR1cm4gJ2h0dHBzOi8vcmVzdWx0cy53ZWJr aXQub3JnLz9zdWl0ZT1sYXlvdXQtdGVzdHMmdGVzdD0nICsgZW5jb2RlVVJJQ29tcG9uZW50KHRl c3RzUGFyYW1ldGVyKTsKIH0KIAogdWkudXJsRm9yRW1iZWRkZWRGbGFraW5lc3NEYXNoYm9hcmQg PSBmdW5jdGlvbihvcHRfdGVzdE5hbWVMaXN0KQpkaWZmIC0tZ2l0IGEvVG9vbHMvQnVpbGRTbGF2 ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1jb25maWcvcHVibGljX2h0bWwvVGVzdEZhaWx1cmVz L3NjcmlwdHMvdWkvcmVzdWx0cy5qcyBiL1Rvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2J1aWxkLndl YmtpdC5vcmctY29uZmlnL3B1YmxpY19odG1sL1Rlc3RGYWlsdXJlcy9zY3JpcHRzL3VpL3Jlc3Vs dHMuanMKaW5kZXggNTI1NTQyMDcxYmYzMDg3ZGU1MDkwYmU5MzYzOThmZTczZDYyY2E4Mi4uMTFm YWRhMTMzNzk4ODllMTc0ODI5NGEwM2VkYTk4YzljYjU3MWI2MiAxMDA2NDQKLS0tIGEvVG9vbHMv QnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1jb25maWcvcHVibGljX2h0bWwvVGVz dEZhaWx1cmVzL3NjcmlwdHMvdWkvcmVzdWx0cy5qcworKysgYi9Ub29scy9CdWlsZFNsYXZlU3Vw cG9ydC9idWlsZC53ZWJraXQub3JnLWNvbmZpZy9wdWJsaWNfaHRtbC9UZXN0RmFpbHVyZXMvc2Ny aXB0cy91aS9yZXN1bHRzLmpzCkBAIC0yMDcsNyArMjA3LDcgQEAgdWkucmVzdWx0cy5GbGFraW5l c3NEYXRhID0gYmFzZS5leHRlbmRzKCdpZnJhbWUnLCB7CiAgICAgICAgIC8vIENoZWNrIGZvciBu dWxsIGV2ZW50Lm9yaWdpbiBzbyB0aGF0IHRoZSB1bml0dGVzdHMgY2FuIGdldCBwYXN0IHRoaXMg cG9pbnQuCiAgICAgICAgIC8vIEZJWE1FOiBJcyB0aGlzIHNhZmU/IEluIHByYWN0aWNlLCB0aGVy ZSdzIG5vIG1lYW5pbmdmdWwgaGFybSB0aGF0IGNhbiBjb21lIGZyb20KICAgICAgICAgLy8gYSBt YWxpY2lvdXMgcGFnZSBzZW5kaW5nIHVzIGhlaWdodENoYW5nZWQgY29tbWFuZHMsIHNvIGl0IGRv ZXNuJ3QgcmVhbGx5IG1hdHRlci4KLSAgICAgICAgaWYgKGV2ZW50Lm9yaWdpbiAhPT0gJ251bGwn ICYmIGV2ZW50Lm9yaWdpbiAhPSAnaHR0cHM6Ly93ZWJraXQtdGVzdC1yZXN1bHRzLndlYmtpdC5v cmcnKSB7CisgICAgICAgIGlmIChldmVudC5vcmlnaW4gIT09ICdudWxsJyAmJiBldmVudC5vcmln aW4gIT0gJ2h0dHBzOi8vcmVzdWx0cy53ZWJraXQub3JnJykgewogICAgICAgICAgICAgY29uc29s ZS5sb2coJ0ludmFsaWQgb3JpZ2luOiAnICsgZXZlbnQub3JpZ2luKTsKICAgICAgICAgICAgIHJl dHVybjsKICAgICAgICAgfQpkaWZmIC0tZ2l0IGEvVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvYnVp bGQud2Via2l0Lm9yZy1jb25maWcvcHVibGljX2h0bWwvZGFzaGJvYXJkL1NjcmlwdHMvV2ViS2l0 VGVzdEhpc3RvcnkuanMgYi9Ub29scy9CdWlsZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJraXQub3Jn LWNvbmZpZy9wdWJsaWNfaHRtbC9kYXNoYm9hcmQvU2NyaXB0cy9XZWJLaXRUZXN0SGlzdG9yeS5q cwppbmRleCAzODg0NGIwMTRjODllZjY5ZjgxMjI2MjJmZGVjOGE4Y2Y0YjEyYjJkLi4wMjM5OThh YmU4YTlhMWQzODFjYzViM2NjYmQwMDlmMTUxMTcyM2M1IDEwMDY0NAotLS0gYS9Ub29scy9CdWls ZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJraXQub3JnLWNvbmZpZy9wdWJsaWNfaHRtbC9kYXNoYm9h cmQvU2NyaXB0cy9XZWJLaXRUZXN0SGlzdG9yeS5qcworKysgYi9Ub29scy9CdWlsZFNsYXZlU3Vw cG9ydC9idWlsZC53ZWJraXQub3JnLWNvbmZpZy9wdWJsaWNfaHRtbC9kYXNoYm9hcmQvU2NyaXB0 cy9XZWJLaXRUZXN0SGlzdG9yeS5qcwpAQCAtMjUsNyArMjUsNyBAQAogCiBUZXN0SGlzdG9yeSA9 IGZ1bmN0aW9uKCkKIHsKLSAgICB0aGlzLl9iYXNlVVJMID0gImh0dHBzOi8vd2Via2l0LXRlc3Qt cmVzdWx0cy53ZWJraXQub3JnL2Rhc2hib2FyZHMvZmxha2luZXNzX2Rhc2hib2FyZC5odG1sIjsK KyAgICB0aGlzLl9iYXNlVVJMID0gImh0dHBzOi8vcmVzdWx0cy53ZWJraXQub3JnIjsKIH07CiAK IEJhc2VPYmplY3QuYWRkQ29uc3RydWN0b3JGdW5jdGlvbnMoVGVzdEhpc3RvcnkpOwpAQCAtMzYs NiArMzYsNiBAQCBUZXN0SGlzdG9yeS5wcm90b3R5cGUgPSB7CiAKICAgICBoaXN0b3J5UGFnZVVS TEZvclRlc3Q6IGZ1bmN0aW9uKHBhdGgpCiAgICAgewotICAgICAgICByZXR1cm4gdGhpcy5fYmFz ZVVSTCArICIjc2hvd0FsbFJ1bnM9dHJ1ZSZ0ZXN0cz0iICsgZW5jb2RlVVJJQ29tcG9uZW50KHBh dGgpOworICAgICAgICByZXR1cm4gdGhpcy5fYmFzZVVSTCArICI/c3VpdGU9bGF5b3V0LXRlc3Rz JnRlc3Q9IiArIGVuY29kZVVSSUNvbXBvbmVudChwYXRoKTsKICAgICB9CiB9OwpkaWZmIC0tZ2l0 IGEvVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1jb25maWcvdGVtcGxh dGVzL3Jvb3QuaHRtbCBiL1Rvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2J1aWxkLndlYmtpdC5vcmct Y29uZmlnL3RlbXBsYXRlcy9yb290Lmh0bWwKaW5kZXggOWVkYTc3YWI5MDAxMTFhMzFiOGFhNjFk NWU3Mzg3OGYxOWMyMmJkYy4uMWZjZGEyNDgwODE5MDgwMWVlNjU1YmNlMWVmZjkwYmI3ZTFiNDcz MSAxMDA2NDQKLS0tIGEvVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1j b25maWcvdGVtcGxhdGVzL3Jvb3QuaHRtbAorKysgYi9Ub29scy9CdWlsZFNsYXZlU3VwcG9ydC9i dWlsZC53ZWJraXQub3JnLWNvbmZpZy90ZW1wbGF0ZXMvcm9vdC5odG1sCkBAIC0zNyw3ICszNyw3 IEBACiAKIDxoMj5UZXN0cyBhbmQgUGVyZm9ybWFuY2U8L2gyPgogPHVsPgotICA8bGk+PGEgaHJl Zj0iaHR0cHM6Ly93ZWJraXQtdGVzdC1yZXN1bHRzLndlYmtpdC5vcmcvZGFzaGJvYXJkcy9mbGFr aW5lc3NfZGFzaGJvYXJkLmh0bWwiPkZsYWtpbmVzcyBkYXNoYm9hcmQ8L2E+IChFeHRlcm5hbCBz aXRlKTwvbGk+CisgIDxsaT48YSBocmVmPSJodHRwczovL3Jlc3VsdHMud2Via2l0Lm9yZyI+Rmxh a2luZXNzIGRhc2hib2FyZDwvYT4gKEV4dGVybmFsIHNpdGUpPC9saT4KICAgPGxpPjxhIGhyZWY9 IkxlYWtzVmlld2VyIj5MZWFrcyBWaWV3ZXI8L2E+PC9saT4KICAgPGxpPjxhIGhyZWY9IlRlc3RG YWlsdXJlcyI+VGVzdCBGYWlsdXJlczwvYT48L2xpPgogICA8bGk+PGEgaHJlZj0iaHR0cHM6Ly9w ZXJmLndlYmtpdC5vcmcvIj5XZWJLaXQgUGVyZiBNb25pdG9yPC9hPiByZXN1bHRzIHN1Ym1pdHRl ZCBieSA8YSBocmVmPSJodHRwczovL2J1aWxkLndlYmtpdC5vcmcvd2F0ZXJmYWxsP3Nob3c9QXBw bGUlMjBZb3NlbWl0ZSUyMFJlbGVhc2UlMjBXSzIlMjAlMjhQZXJmJTI5JnNob3c9R1RLJTIwTGlu dXglMjA2NC1iaXQlMjBSZWxlYXNlJTIwJTI4UGVyZiUyOSI+cGVyZm9ybWFuY2UgYm90czwvYT48 L2xpPgo=