20582 2008-08-31 16:19:59 -0700 [Gtk] Link error on Mac OS X 2008-10-25 00:25:41 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Mac OS X 10.5 RESOLVED FIXED P2 Normal --- 1 mrgwen webkit-unassigned alp jmalonzo mh+webkit richard oldest_to_newest 89823 0 mrgwen 2008-08-31 16:19:59 -0700 I've this link error under MacOs when I try to build WebKit-GTK+ ld: unknown option: --version-script collect2: ld returned 1 exit status Solution from bdash from IRC : remove line 253 of GNUmakefile.am and rebuild someone went and made the makefile dependent on the GNU linker 89825 1 mrgwen 2008-08-31 16:24:01 -0700 *** Bug 20581 has been marked as a duplicate of this bug. *** 91096 2 23405 mh+webkit 2008-09-13 23:30:55 -0700 Created attachment 23405 patch Not tested, because I lack time to test right now, but this should work 91097 3 mh+webkit 2008-09-13 23:41:56 -0700 Note that we might want to invert the filtering, instead, and export all webkit_* and (to be defined) symbols, and use the libtool -export-symbols option that would also probably work on osx. 91325 4 alp 2008-09-15 23:37:37 -0700 (In reply to comment #3) > Note that we might want to invert the filtering, instead, and export all > webkit_* and (to be defined) symbols, and use the libtool -export-symbols > option that would also probably work on osx. > Do you want to have a go and see if that works or should we just get your fix in? If you do try that, remember to check the exported symbols to make sure it doesn't drop anything we make public at the moment. 91335 5 mh+webkit 2008-09-16 00:56:44 -0700 I'd go for it if I knew all the exported symbols patterns ;) 91384 6 23405 darin 2008-09-16 10:09:46 -0700 Comment on attachment 23405 patch Looks good. Even though I'm not an expert on the GTK port, I'm comfortable saying r=me. But needs a ChangeLog. I'm going to say review- because it's not fair to expect the committer to write the ChangeLog. 92110 7 richard 2008-09-22 06:26:46 -0700 The GNUmakefile.am part is not right, you can't have conditionals in the middle of LDFLAGS like that, it will not produce a correct makefile. I'll attach a correct version. 92111 8 23648 richard 2008-09-22 06:29:20 -0700 Created attachment 23648 Correct way to have conditional flags I also made a change to the configure.ac part, setting the os_gnu variable to no in the other case, to make it consistent with the other similar variables. 92324 9 jmalonzo 2008-09-23 05:24:42 -0700 Hi Richard Can you make your patch's flag '?' so it will go to the review queue? And kindly add a Changelog entry. Thanks. 92328 10 23703 richard 2008-09-23 06:37:40 -0700 Created attachment 23703 New version with changelog entry 92467 11 23703 alp 2008-09-23 21:50:48 -0700 Comment on attachment 23703 New version with changelog entry r=me 92478 12 jmalonzo 2008-09-24 00:44:47 -0700 landed in r36845 96647 13 mh+webkit 2008-10-24 23:29:23 -0700 +version_script = Wl,--version-script,$(srcdir)/symbols.filter The dash is missing before Wl, so this doesn't have any effect (I'm even surprised it doesn't break the build) 96651 14 jmalonzo 2008-10-25 00:25:41 -0700 Thanks Mike! Fixed in r37887. 23405 2008-09-13 23:30:55 -0700 2008-09-16 10:09:46 -0700 patch diff text/plain 1179 mh+webkit ZGlmZiAtLWdpdCBhL0dOVW1ha2VmaWxlLmFtIGIvR05VbWFrZWZpbGUuYW0KaW5kZXggZTI3NDI4 OS4uNGNiYjliMyAxMDA2NDQKLS0tIGEvR05VbWFrZWZpbGUuYW0KKysrIGIvR05VbWFrZWZpbGUu YW0KQEAgLTI1MCw3ICsyNTAsOSBAQCBsaWJ3ZWJraXRfMV8wX2xhX0NQUEZMQUdTID0gXAogbGli d2Via2l0XzFfMF9sYV9MREZMQUdTID0gXAogCSQoQ09WRVJBR0VfTERGTEFHUykgXAogCS12ZXJz aW9uLWluZm8gQExJQldFQktJVEdUS19WRVJTSU9OQCBcCitpZiBPU19HTlUKIAktV2wsLS12ZXJz aW9uLXNjcmlwdCwkKHNyY2Rpcikvc3ltYm9scy5maWx0ZXIgXAorZW5kaWYKIAkkKG5vX3VuZGVm aW5lZCkKIAogbGlid2Via2l0XzFfMF9sYV9MSUJBREQgPSBcCmRpZmYgLS1naXQgYS9jb25maWd1 cmUuYWMgYi9jb25maWd1cmUuYWMKaW5kZXggNTc5ODkxYy4uMDYwYTU5YiAxMDA2NDQKLS0tIGEv Y29uZmlndXJlLmFjCisrKyBiL2NvbmZpZ3VyZS5hYwpAQCAtNTEsNiArNTEsMTIgQEAgY2FzZSAi JGhvc3QiIGluCiAgICAgICAgOzsKIGVzYWMKIAorY2FzZSAiJGhvc3Rfb3MiIGluCisgICAgIGdu dSogfCBsaW51eCogfCBrKmJzZCotZ251KQorICAgICAgIG9zX2dudT15ZXMKKyAgICAgICA7Owor ZXNhYworCiAjIElmIENYWEZMQUdTIGFuZCBDRkxBR1MgYXJlIHVuc2V0LCBkZWZhdWx0IHRvIGVt cHR5LgogIyBUaGlzIGlzIHRvIHRlbGwgYXV0b21ha2Ugbm90IHRvIGluY2x1ZGUgJy1nJyBpZiBD WFhGTEFHUyBpcyBub3Qgc2V0CiAjIEZvciBtb3JlIGluZm8gLSBodHRwOi8vd3d3LmdudS5vcmcv c29mdHdhcmUvYXV0b21ha2UvbWFudWFsL2F1dG9jb25mLmh0bWwjQ18wMDJiXzAwMmItQ29tcGls ZXIKQEAgLTU2OCw2ICs1NzQsNyBAQCBmaQogQU1fQ09ORElUSU9OQUwoW09TX1dJTjMyXSxbdGVz dCAiJG9zX3dpbjMyIiA9ICJ5ZXMiXSkKIEFNX0NPTkRJVElPTkFMKFtPU19VTklYXSxbdGVzdCAi JG9zX3dpbjMyIiA9ICJubyJdKQogQU1fQ09ORElUSU9OQUwoW09TX0xJTlVYXSxbdGVzdCAiJG9z X2xpbnV4IiA9ICJ5ZXMiXSkKK0FNX0NPTkRJVElPTkFMKFtPU19HTlVdLFt0ZXN0ICIkb3NfZ251 IiA9ICJ5ZXMiXSkKIEFNX0NPTkRJVElPTkFMKFtPU19GUkVFQlNEXSxbdGVzdCAiJG9zX2ZyZWVi c2QiID0gInllcyJdKQogCiAjIHRhcmdldCBjb25kaXRpb25hbHMK 23648 2008-09-22 06:29:20 -0700 2008-09-23 06:37:40 -0700 Correct way to have conditional flags version-script.patch text/plain 1434 richard ZGlmZiAtLWdpdCBhL0dOVW1ha2VmaWxlLmFtIGIvR05VbWFrZWZpbGUuYW0KaW5kZXggNDU4Yjg1 NC4uNjAyOTM1NyAxMDA2NDQKLS0tIGEvR05VbWFrZWZpbGUuYW0KKysrIGIvR05VbWFrZWZpbGUu YW0KQEAgLTc4LDYgKzc4LDEwIEBAIGlmIE9TX1dJTjMyCiBub191bmRlZmluZWQgPSAtbm8tdW5k ZWZpbmVkCiBlbmRpZgogCitpZiBPU19HTlUKK3ZlcnNpb25fc2NyaXB0ID0gV2wsLS12ZXJzaW9u LXNjcmlwdCwkKHNyY2Rpcikvc3ltYm9scy5maWx0ZXIKK2VuZGlmCisKICMgU2hhcmVkIGxpYnJh cmllcwogbGliX0xUTElCUkFSSUVTID0gXAogCWxpYndlYmtpdC0xLjAubGEKQEAgLTIzOCw3ICsy NDIsNyBAQCBsaWJ3ZWJraXRfMV8wX2xhX0NQUEZMQUdTID0gXAogbGlid2Via2l0XzFfMF9sYV9M REZMQUdTID0gXAogCSQoQ09WRVJBR0VfTERGTEFHUykgXAogCS12ZXJzaW9uLWluZm8gQExJQldF QktJVEdUS19WRVJTSU9OQCBcCi0JLVdsLC0tdmVyc2lvbi1zY3JpcHQsJChzcmNkaXIpL3N5bWJv bHMuZmlsdGVyIFwKKwkkKHZlcnNpb25fc2NyaXB0KSBcCiAJJChub191bmRlZmluZWQpCiAKIGxp YndlYmtpdF8xXzBfbGFfTElCQUREID0gXApkaWZmIC0tZ2l0IGEvY29uZmlndXJlLmFjIGIvY29u ZmlndXJlLmFjCmluZGV4IDU1ZGRkYmQuLjg5NjI4MTQgMTAwNjQ0Ci0tLSBhL2NvbmZpZ3VyZS5h YworKysgYi9jb25maWd1cmUuYWMKQEAgLTUxLDYgKzUxLDE1IEBAIGNhc2UgIiRob3N0IiBpbgog ICAgICAgIDs7CiBlc2FjCiAKK2Nhc2UgIiRob3N0X29zIiBpbgorICAgICBnbnUqIHwgbGludXgq IHwgaypic2QqLWdudSkKKyAgICAgICBvc19nbnU9eWVzCisgICAgICAgOzsKKyAgICAgKikKKyAg ICAgICBvc19nbnU9bm8KKyAgICAgICA7OworZXNhYworCiAjIElmIENYWEZMQUdTIGFuZCBDRkxB R1MgYXJlIHVuc2V0LCBkZWZhdWx0IHRvIGVtcHR5LgogIyBUaGlzIGlzIHRvIHRlbGwgYXV0b21h a2Ugbm90IHRvIGluY2x1ZGUgJy1nJyBpZiBDWFhGTEFHUyBpcyBub3Qgc2V0CiAjIEZvciBtb3Jl IGluZm8gLSBodHRwOi8vd3d3LmdudS5vcmcvc29mdHdhcmUvYXV0b21ha2UvbWFudWFsL2F1dG9j b25mLmh0bWwjQ18wMDJiXzAwMmItQ29tcGlsZXIKQEAgLTU3Niw2ICs1ODUsNyBAQCBmaQogQU1f Q09ORElUSU9OQUwoW09TX1dJTjMyXSxbdGVzdCAiJG9zX3dpbjMyIiA9ICJ5ZXMiXSkKIEFNX0NP TkRJVElPTkFMKFtPU19VTklYXSxbdGVzdCAiJG9zX3dpbjMyIiA9ICJubyJdKQogQU1fQ09ORElU SU9OQUwoW09TX0xJTlVYXSxbdGVzdCAiJG9zX2xpbnV4IiA9ICJ5ZXMiXSkKK0FNX0NPTkRJVElP TkFMKFtPU19HTlVdLFt0ZXN0ICIkb3NfZ251IiA9ICJ5ZXMiXSkKIEFNX0NPTkRJVElPTkFMKFtP U19GUkVFQlNEXSxbdGVzdCAiJG9zX2ZyZWVic2QiID0gInllcyJdKQogCiAjIHRhcmdldCBjb25k aXRpb25hbHMK 23703 2008-09-23 06:37:40 -0700 2008-09-23 21:50:48 -0700 New version with changelog entry version-script2.patch text/plain 1953 richard ZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5nZUxvZwppbmRleCA3YmM5ZGQ0Li44YmEzNjc2 IDEwMDY0NAotLS0gYS9DaGFuZ2VMb2cKKysrIGIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAK KzIwMDgtMDktMjMgIFJpY2hhcmQgSHVsdCAgPHJpY2hhcmRAaW1lbmRpby5jb20+CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgbm9ib2R5CisKKyAgICAgICAgaHR0cDovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MjA1ODIKKwlbR3RrXSBMaW5rIGVycm9yIG9uIE1hYyBPUyBYCisKKwkq IEdOVW1ha2VmaWxlLmFtOiBPbmx5IHVzZSB0aGUgLXZlcnNpb24tc2NyaXB0IGZsYWcgZm9yIHRo ZSBnbnUKKwlsaW5rZXIuCisKKwkqIGNvbmZpZ3VyZS5hYzogQ2hlY2sgZm9yIEdOVSBPU2VzLgor CiAyMDA4LTA5LTE5ICBBbHAgVG9rZXIgIDxhbHBAbnVhbnRpLmNvbT4KIAogICAgICAgICBCdWls ZCBmaXggZm9yIHRoZSAnZ29sZCcgbGlua2VyIGFuZCByZWNlbnQgYmludXRpbHMuIE5ldyBiZWhh dmlvdXIKZGlmZiAtLWdpdCBhL0dOVW1ha2VmaWxlLmFtIGIvR05VbWFrZWZpbGUuYW0KaW5kZXgg NDU4Yjg1NC4uNjAyOTM1NyAxMDA2NDQKLS0tIGEvR05VbWFrZWZpbGUuYW0KKysrIGIvR05VbWFr ZWZpbGUuYW0KQEAgLTc4LDYgKzc4LDEwIEBAIGlmIE9TX1dJTjMyCiBub191bmRlZmluZWQgPSAt bm8tdW5kZWZpbmVkCiBlbmRpZgogCitpZiBPU19HTlUKK3ZlcnNpb25fc2NyaXB0ID0gV2wsLS12 ZXJzaW9uLXNjcmlwdCwkKHNyY2Rpcikvc3ltYm9scy5maWx0ZXIKK2VuZGlmCisKICMgU2hhcmVk IGxpYnJhcmllcwogbGliX0xUTElCUkFSSUVTID0gXAogCWxpYndlYmtpdC0xLjAubGEKQEAgLTIz OCw3ICsyNDIsNyBAQCBsaWJ3ZWJraXRfMV8wX2xhX0NQUEZMQUdTID0gXAogbGlid2Via2l0XzFf MF9sYV9MREZMQUdTID0gXAogCSQoQ09WRVJBR0VfTERGTEFHUykgXAogCS12ZXJzaW9uLWluZm8g QExJQldFQktJVEdUS19WRVJTSU9OQCBcCi0JLVdsLC0tdmVyc2lvbi1zY3JpcHQsJChzcmNkaXIp L3N5bWJvbHMuZmlsdGVyIFwKKwkkKHZlcnNpb25fc2NyaXB0KSBcCiAJJChub191bmRlZmluZWQp CiAKIGxpYndlYmtpdF8xXzBfbGFfTElCQUREID0gXApkaWZmIC0tZ2l0IGEvY29uZmlndXJlLmFj IGIvY29uZmlndXJlLmFjCmluZGV4IDU1ZGRkYmQuLjg5NjI4MTQgMTAwNjQ0Ci0tLSBhL2NvbmZp Z3VyZS5hYworKysgYi9jb25maWd1cmUuYWMKQEAgLTUxLDYgKzUxLDE1IEBAIGNhc2UgIiRob3N0 IiBpbgogICAgICAgIDs7CiBlc2FjCiAKK2Nhc2UgIiRob3N0X29zIiBpbgorICAgICBnbnUqIHwg bGludXgqIHwgaypic2QqLWdudSkKKyAgICAgICBvc19nbnU9eWVzCisgICAgICAgOzsKKyAgICAg KikKKyAgICAgICBvc19nbnU9bm8KKyAgICAgICA7OworZXNhYworCiAjIElmIENYWEZMQUdTIGFu ZCBDRkxBR1MgYXJlIHVuc2V0LCBkZWZhdWx0IHRvIGVtcHR5LgogIyBUaGlzIGlzIHRvIHRlbGwg YXV0b21ha2Ugbm90IHRvIGluY2x1ZGUgJy1nJyBpZiBDWFhGTEFHUyBpcyBub3Qgc2V0CiAjIEZv ciBtb3JlIGluZm8gLSBodHRwOi8vd3d3LmdudS5vcmcvc29mdHdhcmUvYXV0b21ha2UvbWFudWFs L2F1dG9jb25mLmh0bWwjQ18wMDJiXzAwMmItQ29tcGlsZXIKQEAgLTU3Niw2ICs1ODUsNyBAQCBm aQogQU1fQ09ORElUSU9OQUwoW09TX1dJTjMyXSxbdGVzdCAiJG9zX3dpbjMyIiA9ICJ5ZXMiXSkK IEFNX0NPTkRJVElPTkFMKFtPU19VTklYXSxbdGVzdCAiJG9zX3dpbjMyIiA9ICJubyJdKQogQU1f Q09ORElUSU9OQUwoW09TX0xJTlVYXSxbdGVzdCAiJG9zX2xpbnV4IiA9ICJ5ZXMiXSkKK0FNX0NP TkRJVElPTkFMKFtPU19HTlVdLFt0ZXN0ICIkb3NfZ251IiA9ICJ5ZXMiXSkKIEFNX0NPTkRJVElP TkFMKFtPU19GUkVFQlNEXSxbdGVzdCAiJG9zX2ZyZWVic2QiID0gInllcyJdKQogCiAjIHRhcmdl dCBjb25kaXRpb25hbHMK