205781 2020-01-05 14:26:21 -0800 Remove some #ifdefs related to iOS port of ANGLE 2020-01-08 18:46:14 -0800 1 1 1 Unclassified WebKit ANGLE WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 205618 1 kbr kbr commit-queue dino ews-watchlist graouts jdarpinian kondapallykalyan webkit-bug-importer oldest_to_newest 1602891 0 kbr 2020-01-05 14:26:21 -0800 With the port to the iOS Simulator in bug 205618, a couple of #ifdefs that were added to ANGLE for the iOS port should be able to be removed. They've been highlighted in this code review upstreaming the iOS port to the ANGLE repository: https://chromium-review.googlesource.com/1987278 We should try removing them, retest on both iOS hardware and the simulator, and if they're unnecessary, upstream their removal. 1604412 1 387172 kbr 2020-01-08 17:38:52 -0800 Created attachment 387172 Patch 1604415 2 kbr 2020-01-08 17:39:53 -0800 Dean: could you please test these changes on iOS hardware? They work in the iOS Simulator. This would help with the upstreaming of the iOS backend. Thanks! 1604416 3 ews-watchlist 2020-01-08 17:39:59 -0800 Note that there are important steps to take when updating ANGLE. See http://trac.webkit.org/wiki/UpdatingANGLE 1604469 4 387172 commit-queue 2020-01-08 18:45:08 -0800 Comment on attachment 387172 Patch Clearing flags on attachment: 387172 Committed r254249: <https://trac.webkit.org/changeset/254249> 1604470 5 commit-queue 2020-01-08 18:45:09 -0800 All reviewed patches have been landed. Closing bug. 1604471 6 webkit-bug-importer 2020-01-08 18:46:14 -0800 <rdar://problem/58430149> 387172 2020-01-08 17:38:52 -0800 2020-01-08 18:45:08 -0800 Patch bug-205781-20200108173851.patch text/plain 2872 kbr U3VidmVyc2lvbiBSZXZpc2lvbjogMjU0MjI4CmRpZmYgLS1naXQgYS9Tb3VyY2UvVGhpcmRQYXJ0 eS9BTkdMRS9DaGFuZ2VMb2cgYi9Tb3VyY2UvVGhpcmRQYXJ0eS9BTkdMRS9DaGFuZ2VMb2cKaW5k ZXggYTYzOGUyN2E1NzQ5NzUyZTc1MzUyODc0YThjYTA1YmYwMDE3MGI1Mi4uOTA3MzhmZjZmOWVm M2YzZTk0YzMwMjdiZjEwMWI1YWRjZDIwZDhjYiAxMDA2NDQKLS0tIGEvU291cmNlL1RoaXJkUGFy dHkvQU5HTEUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9UaGlyZFBhcnR5L0FOR0xFL0NoYW5nZUxv ZwpAQCAtMSwzICsxLDE5IEBACisyMDIwLTAxLTA4ICBLZW5uZXRoIFJ1c3NlbGwgIDxrYnJAY2hy b21pdW0ub3JnPgorCisgICAgICAgIFJlbW92ZSBzb21lICNpZmRlZnMgcmVsYXRlZCB0byBpT1Mg cG9ydCBvZiBBTkdMRQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MjA1NzgxCisKKyAgICAgICAgU2luY2UgdGhlIHBvcnQgdG8gdGhlIGlPUyBTaW11bGF0 b3IgaW4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIw NTYxOCAsIHRoZXNlICNpZmRlZnMKKyAgICAgICAgc2hvdWxkIG5vIGxvbmdlciBiZSBuZWVkZWQu CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBzcmMv Y29tbW9uL1BhY2tlZEVudW1zLmNwcDoKKyAgICAgICAgKGVnbF9nbDo6RUdMVGV4dHVyZVRhcmdl dFRvVGV4dHVyZVR5cGUpOgorICAgICAgICAqIHNyYy9saWJBTkdMRS92YWxpZGF0aW9uRVMyLmNw cDoKKyAgICAgICAgKGdsOjpWYWxpZGF0ZUZyYW1lYnVmZmVyVGV4dHVyZTJEKToKKwogMjAyMC0w MS0wNSAgS2VubmV0aCBSdXNzZWxsICA8a2JyQGNocm9taXVtLm9yZz4KIAogICAgICAgICBSRUdS RVNTSU9OIChyMjUzOTI2KTogRmxha3kgY3Jhc2hlcyBvbiB3ZWJnbC8xLjAuMy9jb25mb3JtYW5j ZS90ZXh0dXJlcy90ZXh0dXJlLWNvcHlpbmctZmVlZGJhY2stbG9vcHMuaHRtbCBhbmQgd2ViZ2wv Mi4wLjAvY29uZm9ybWFuY2UvdGV4dHVyZXMvbWlzYy90ZXh0dXJlLWNvcHlpbmctZmVlZGJhY2st bG9vcHMuaHRtbApkaWZmIC0tZ2l0IGEvU291cmNlL1RoaXJkUGFydHkvQU5HTEUvc3JjL2NvbW1v bi9QYWNrZWRFbnVtcy5jcHAgYi9Tb3VyY2UvVGhpcmRQYXJ0eS9BTkdMRS9zcmMvY29tbW9uL1Bh Y2tlZEVudW1zLmNwcAppbmRleCAwNzI4Y2EwMWEwNzNmMTQwODAyYTg0YjdlN2M3ODcwOTE5ZGUy Y2M5Li5kZDA5NDM1NjNkYjVkNThmOGY4MjRmZmNiNzc2NWExZmMyZmRlYWUyIDEwMDY0NAotLS0g YS9Tb3VyY2UvVGhpcmRQYXJ0eS9BTkdMRS9zcmMvY29tbW9uL1BhY2tlZEVudW1zLmNwcAorKysg Yi9Tb3VyY2UvVGhpcmRQYXJ0eS9BTkdMRS9zcmMvY29tbW9uL1BhY2tlZEVudW1zLmNwcApAQCAt Mzc0LDExICszNzQsNyBAQCBnbDo6VGV4dHVyZVR5cGUgRUdMVGV4dHVyZVRhcmdldFRvVGV4dHVy ZVR5cGUoRUdMZW51bSBlZ2xUYXJnZXQpCiAgICAgICAgICAgICByZXR1cm4gZ2w6OlRleHR1cmVU eXBlOjpfMkQ7CiAKICAgICAgICAgY2FzZSBFR0xfVEVYVFVSRV9SRUNUQU5HTEVfQU5HTEU6Ci0j aWYgZGVmaW5lZChBTkdMRV9QTEFURk9STV9JT1MpICYmICFkZWZpbmVkKEFOR0xFX1BMQVRGT1JN X01BQ0NBVEFMWVNUKQotICAgICAgICAgICAgcmV0dXJuIGdsOjpUZXh0dXJlVHlwZTo6XzJEOwot I2Vsc2UKICAgICAgICAgICAgIHJldHVybiBnbDo6VGV4dHVyZVR5cGU6OlJlY3RhbmdsZTsKLSNl bmRpZgogCiAgICAgICAgIGRlZmF1bHQ6CiAgICAgICAgICAgICBVTlJFQUNIQUJMRSgpOwpkaWZm IC0tZ2l0IGEvU291cmNlL1RoaXJkUGFydHkvQU5HTEUvc3JjL2xpYkFOR0xFL3ZhbGlkYXRpb25F UzIuY3BwIGIvU291cmNlL1RoaXJkUGFydHkvQU5HTEUvc3JjL2xpYkFOR0xFL3ZhbGlkYXRpb25F UzIuY3BwCmluZGV4IGU4ZjFmNTgxMzQzMDdiZjhhNTkyNmNmMTY1MTQ1NzM2YWQ5YTkwYjcuLmVj YzIzNDBmMDU0ZDY1ZTkwMTQ3YTkwYzg2MjUyMzg0ZDBkMTc0ZDYgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9UaGlyZFBhcnR5L0FOR0xFL3NyYy9saWJBTkdMRS92YWxpZGF0aW9uRVMyLmNwcAorKysgYi9T b3VyY2UvVGhpcmRQYXJ0eS9BTkdMRS9zcmMvbGliQU5HTEUvdmFsaWRhdGlvbkVTMi5jcHAKQEAg LTY1MjEsMTIgKzY1MjEsNyBAQCBib29sIFZhbGlkYXRlRnJhbWVidWZmZXJUZXh0dXJlMkQoQ29u dGV4dCAqY29udGV4dCwKICAgICAgICAgICAgICAgICAgICAgY29udGV4dC0+dmFsaWRhdGlvbkVy cm9yKEdMX0lOVkFMSURfVkFMVUUsIGtJbnZhbGlkTWlwTGV2ZWwpOwogICAgICAgICAgICAgICAg ICAgICByZXR1cm4gZmFsc2U7CiAgICAgICAgICAgICAgICAgfQotI2lmIGRlZmluZWQoQU5HTEVf UExBVEZPUk1fSU9TKSAmJiAhZGVmaW5lZChBTkdMRV9QTEFURk9STV9NQUNDQVRBTFlTVCkKLSAg ICAgICAgICAgICAgICBjb25zdCBUZXh0dXJlVHlwZSBleHBlY3RlZFR5cGUgeyBUZXh0dXJlVHlw ZTo6XzJEIH07Ci0jZWxzZQotICAgICAgICAgICAgICAgIGNvbnN0IFRleHR1cmVUeXBlIGV4cGVj dGVkVHlwZSB7IFRleHR1cmVUeXBlOjpSZWN0YW5nbGUgfTsKLSNlbmRpZgotICAgICAgICAgICAg ICAgIGlmICh0ZXgtPmdldFR5cGUoKSAhPSBleHBlY3RlZFR5cGUpCisgICAgICAgICAgICAgICAg aWYgKHRleC0+Z2V0VHlwZSgpICE9IFRleHR1cmVUeXBlOjpSZWN0YW5nbGUpCiAgICAgICAgICAg ICAgICAgewogICAgICAgICAgICAgICAgICAgICBjb250ZXh0LT52YWxpZGF0aW9uRXJyb3IoR0xf SU5WQUxJRF9PUEVSQVRJT04sIGtUZXh0dXJlVGFyZ2V0TWlzbWF0Y2gpOwogICAgICAgICAgICAg ICAgICAgICByZXR1cm4gZmFsc2U7Cg==