205777 2020-01-05 10:04:57 -0800 [GStreamer] mediastreamsrc ref sinked triggers critical warning in gst 1.17 2020-01-07 01:43:44 -0800 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 pnormand pnormand bugs-noreply cgarcia eric.carlson ews-watchlist glenn hta jer.noble philipj sergio tommyw tsaunier oldest_to_newest 1602865 0 pnormand 2020-01-05 10:04:57 -0800 (WebKitWebProcess:3252723): GStreamer-CRITICAL **: 18:02:42.388: The created element should be floating, this is probably caused by faulty bindings gdb) bt #0 0x00007f40fdc12e25 in _g_log_abort (breakpoint=1) at ../../../glib/gmessages.c:554 #1 0x00007f40fdc140e9 in g_logv (log_domain=0x7f40fe719cc0 <g_log_domain_gstreamer> "GStreamer", log_level=G_LOG_LEVEL_CRITICAL, format=<optimized out>, args=args@entry=0x7fffdb14ace0) at ../../../glib/gmessages.c:1373 #2 0x00007f40fdc142af in g_log (log_domain=<optimized out>, log_level=<optimized out>, format=<optimized out>) at ../../../glib/gmessages.c:1415 #3 0x00007f40fe67bfb6 in gst_element_factory_create (factory=0x5618e346bd70 [GstElementFactory], name=0x7f27845e3f37 "source") at ../subprojects/gstreamer/gst/gstelementfactory.c:393 #4 0x00007f40fe6ea779 in gst_element_make_from_uri (type=GST_URI_SRC, uri=0x5618e3705870 "mediastream://4b4dd861-8f24-43c4-8376-b8fd1d34bd9a", elementname=0x7f27845e3f37 "source", error=0x7fffdb14aea8) at ../subprojects/gstreamer/gst/gsturi.c:660 #5 0x00007f2784589af4 in gen_source_element (urisrc=0x5618e3679d30 [GstURISourceBin]) at ../subprojects/gst-plugins-base/gst/playback/gsturisourcebin.c:1425 #6 0x00007f278458c63f in setup_source (urisrc=0x5618e3679d30 [GstURISourceBin]) at ../subprojects/gst-plugins-base/gst/playback/gsturisourcebin.c:2135 #7 0x00007f278458eb23 in gst_uri_source_bin_change_state (element=0x5618e3679d30 [GstURISourceBin], transition=GST_STATE_CHANGE_READY_TO_PAUSED) at ../subprojects/gst-plugins-base/gst/playback/gsturisourcebin.c:2813 #8 0x00007f40fe678ffa in gst_element_change_state (element=0x5618e3679d30 [GstURISourceBin], transition=GST_STATE_CHANGE_READY_TO_PAUSED) at ../subprojects/gstreamer/gst/gstelement.c:3033 #9 0x00007f40fe678545 in gst_element_continue_state (element=0x5618e3679d30 [GstURISourceBin], ret=GST_STATE_CHANGE_SUCCESS) at ../subprojects/gstreamer/gst/gstelement.c:2741 #10 0x00007f40fe679324 in gst_element_change_state (element=0x5618e3679d30 [GstURISourceBin], transition=GST_STATE_CHANGE_NULL_TO_READY) at ../subprojects/gstreamer/gst/gstelement.c:3072 #11 0x00007f40fe678d88 in gst_element_set_state_func (element=0x5618e3679d30 [GstURISourceBin], state=GST_STATE_PAUSED) at ../subprojects/gstreamer/gst/gstelement.c:2987 #12 0x00007f40fe678984 in gst_element_set_state (element=0x5618e3679d30 [GstURISourceBin], state=GST_STATE_PAUSED) at ../subprojects/gstreamer/gst/gstelement.c:2888 #13 0x00007f40fe647f9f in gst_bin_element_set_state (bin=0x5618e3679870 [GstURIDecodeBin3], element=0x5618e3679d30 [GstURISourceBin], base_time=0, start_time=0, current=GST_STATE_READY, next=GST_STATE_PAUSED) at ../subprojects/gstreamer/gst/gstbin.c:2602 #14 0x00007f40fe649594 in gst_bin_change_state_func (element=0x5618e3679870 [GstURIDecodeBin3], transition=GST_STATE_CHANGE_READY_TO_PAUSED) at ../subprojects/gstreamer/gst/gstbin.c:2944 #15 0x00007f27845861f1 in gst_uri_decode_bin3_change_state (element=0x5618e3679870 [GstURIDecodeBin3], transition=GST_STATE_CHANGE_READY_TO_PAUSED) at ../subprojects/gst-plugins-base/gst/playback/gsturidecodebin3.c:1050 #16 0x00007f40fe678ffa in gst_element_change_state (element=0x5618e3679870 [GstURIDecodeBin3], transition=GST_STATE_CHANGE_READY_TO_PAUSED) at ../subprojects/gstreamer/gst/gstelement.c:3033 #17 0x00007f40fe678545 in gst_element_continue_state (element=0x5618e3679870 [GstURIDecodeBin3], ret=GST_STATE_CHANGE_SUCCESS) at ../subprojects/gstreamer/gst/gstelement.c:2741 #18 0x00007f40fe679324 in gst_element_change_state (element=0x5618e3679870 [GstURIDecodeBin3], transition=GST_STATE_CHANGE_NULL_TO_READY) at ../subprojects/gstreamer/gst/gstelement.c:3072 #19 0x00007f40fe678d88 in gst_element_set_state_func (element=0x5618e3679870 [GstURIDecodeBin3], state=GST_STATE_PAUSED) at ../subprojects/gstreamer/gst/gstelement.c:2987 #20 0x00007f40fe678984 in gst_element_set_state (element=0x5618e3679870 [GstURIDecodeBin3], state=GST_STATE_PAUSED) at ../subprojects/gstreamer/gst/gstelement.c:2888 #21 0x00007f27845b449c in activate_group (playbin=0x5618e3625660 [GstPlayBin3], group=0x5618e36258d0) at ../subprojects/gst-plugins-base/gst/playback/gstplaybin3.c:4537 #22 0x00007f27845b4fc7 in setup_next_source (playbin=0x5618e3625660 [GstPlayBin3]) at ../subprojects/gst-plugins-base/gst/playback/gstplaybin3.c:4727 #23 0x00007f27845b5f85 in gst_play_bin3_change_state (element=0x5618e3625660 [GstPlayBin3], transition=GST_STATE_CHANGE_READY_TO_PAUSED) at ../subprojects/gst-plugins-base/gst/playback/gstplaybin3.c:4952 #24 0x00007f40fe678ffa in gst_element_change_state (element=0x5618e3625660 [GstPlayBin3], transition=GST_STATE_CHANGE_READY_TO_PAUSED) at ../subprojects/gstreamer/gst/gstelement.c:3033 #25 0x00007f40fe678545 in gst_element_continue_state (element=0x5618e3625660 [GstPlayBin3], ret=GST_STATE_CHANGE_SUCCESS) at ../subprojects/gstreamer/gst/gstelement.c:2741 #26 0x00007f40fe679324 in gst_element_change_state (element=0x5618e3625660 [GstPlayBin3], transition=GST_STATE_CHANGE_NULL_TO_READY) at ../subprojects/gstreamer/gst/gstelement.c:3072 #27 0x00007f40fe678d88 in gst_element_set_state_func (element=0x5618e3625660 [GstPlayBin3], state=GST_STATE_PAUSED) at ../subprojects/gstreamer/gst/gstelement.c:2987 #28 0x00007f40fe678984 in gst_element_set_state (element=0x5618e3625660 [GstPlayBin3], state=GST_STATE_PAUSED) at ../subprojects/gstreamer/gst/gstelement.c:2888 #29 0x00007f4105982e88 in _ZN7WebCore27MediaPlayerPrivateGStreamer19changePipelineStateE8GstState () at /home/phil/WebKit/build-GTK-Release/lib/libwebkit2gtk-4.0.so.37 #30 0x00007f4105987f78 in _ZN7WebCore27MediaPlayerPrivateGStreamer10commitLoadEv () at /home/phil/WebKit/build-GTK-Release/lib/libwebkit2gtk-4.0.so.37 #31 0x00007f410599786c in _ZN7WebCore27MediaPlayerPrivateGStreamer8loadFullERKN3WTF6StringES4_ () at /home/phil/WebKit/build-GTK-Release/lib/libwebkit2gtk-4.0.so.37 #32 0x00007f4105997b31 in _ZN7WebCore27MediaPlayerPrivateGStreamer4loadERNS_18MediaStreamPrivateE () at /home/phil/WebKit/build-GTK-Release/lib/libwebkit2gtk-4.0.so.37 #33 0x00007f410533d173 in _ZN7WebCore11MediaPlayer23loadWithNextMediaEngineEPKNS_18MediaPlayerFactoryE () at /home/phil/WebKit/build-GTK-Release/lib/libwebkit2gtk-4.0.so.37 #34 0x00007f410534621d in _ZN7WebCore11MediaPlayer4loadERNS_18MediaStreamPrivateE () at /home/phil/WebKit/build-GTK-Release/lib/libwebkit2gtk-4.0.so.37 #35 0x00007f4104ed8787 in _ZN7WebCore16HTMLMediaElement12loadResourceERKN3WTF3URLERNS_11ContentTypeERKNS1_6StringE () at /home/phil/WebKit/build-GTK-Release/lib/libwebkit2gtk-4.0.so.37 #36 0x00007f4104ed9837 in _ZN3WTF6Detail15CallableWrapperIZN7WebCore16HTMLMediaElement19selectMediaResourceEvEUlvE_vJEE4callEv () at /home/phil/WebKit/build-GTK-Release/lib/libwebkit2gtk-4.0.so.37 #37 0x00007f41048edf84 in _ZN3WTF6Detail15CallableWrapperIZN7WebCore16GenericTaskQueueINS2_5TimerEE11enqueueTaskEONS_8FunctionIFvvEEEEUlvE_vJEE4callEv () at /home/phil/WebKit/build-GTK-Release/lib/libwebkit2gtk-4.0.so.37 #38 0x00007f410528f81c in _ZN7WebCore14TaskDispatcherINS_5TimerEE15dispatchOneTaskEv () at /home/phil/WebKit/build-GTK-Release/lib/libwebkit2gtk-4.0.so.37 #39 0x00007f410528f98d in _ZN7WebCore14TaskDispatcherINS_5TimerEE16sharedTimerFiredEv () at /home/phil/WebKit/build-GTK-Release/lib/libwebkit2gtk-4.0.so.37 #40 0x00007f410528fa39 in _ZN3WTF6Detail15CallableWrapperIZN7WebCore14TaskDispatcherINS2_5TimerEE11sharedTimerEvEUlvE_vJEE4callEv () at /home/phil/WebKit/build-GTK-Release/lib/libwebkit2gtk-4.0.so.37 #41 0x00007f4103de7afe in _ZN7WebCore5Timer5firedEv () at /home/phil/WebKit/build-GTK-Release/lib/libwebkit2gtk-4.0.so.37 #42 0x00007f41052bdcda in _ZN7WebCore12ThreadTimers24sharedTimerFiredInternalEv () at /home/phil/WebKit/build-GTK-Release/lib/libwebkit2gtk-4.0.so.37 #43 0x00007f41052bdd82 in _ZN3WTF6Detail15CallableWrapperIZN7WebCore12ThreadTimers14setSharedTimerEPNS2_11SharedTimerEEUlvE_vJEE4callEv () at /home/phil/WebKit/build-GTK-Release/lib/libwebkit2gtk-4.0.so.37 #44 0x00007f410529de4e in _ZN7WebCore21MainThreadSharedTimer5firedEv () at /home/phil/WebKit/build-GTK-Release/lib/libwebkit2gtk-4.0.so.37 #45 0x00007f41052a9b82 in _ZN3WTF7RunLoop5TimerIN7WebCore21MainThreadSharedTimerEE5firedEv () at /home/phil/WebKit/build-GTK-Release/lib/libwebkit2gtk-4.0.so.37 #46 0x00007f4101e3b8f4 in _ZZN3WTF7RunLoop9TimerBaseC4ERS0_ENUlPvE_4_FUNES3_ () at /home/phil/WebKit/build-GTK-Release/lib/libjavascriptcoregtk-4.0.so.18 #47 0x00007f4101e3b22b in _ZN3WTFUlP8_GSourcePFiPvES2_E_4_FUNES1_S4_S2_ () at /home/phil/WebKit/build-GTK-Release/lib/libjavascriptcoregtk-4.0.so.18 --Type <RET> for more, q to quit, c to continue without paging-- #48 0x00007f40fdc0cdee in g_main_dispatch (context=0x5618e2153120) at ../../../glib/gmain.c:3179 #49 0x00007f40fdc0cdee in g_main_context_dispatch (context=context@entry=0x5618e2153120) at ../../../glib/gmain.c:3844 #50 0x00007f40fdc0d1a0 in g_main_context_iterate (context=0x5618e2153120, block=block@entry=1, dispatch=dispatch@entry=1, self=<optimized out>) at ../../../glib/gmain.c:3917 #51 0x00007f40fdc0d473 in g_main_loop_run (loop=0x5618e231f130) at ../../../glib/gmain.c:4111 #52 0x00007f4101e3bd10 in _ZN3WTF7RunLoop3runEv () at /home/phil/WebKit/build-GTK-Release/lib/libjavascriptcoregtk-4.0.so.18 #53 0x00007f41042a7e86 in WebProcessMainUnix () at /home/phil/WebKit/build-GTK-Release/lib/libwebkit2gtk-4.0.so.37 #54 0x00005618e087aeae in main () 1602866 1 386793 pnormand 2020-01-05 10:06:16 -0800 Created attachment 386793 workaround With this patch we avoid the warning... WDYT Thibault? 1603000 2 386793 tsaunier 2020-01-06 04:38:14 -0800 Comment on attachment 386793 workaround I am fine with that yes. informal r+ fwiw this warning is not critical in latest GStreamer master, this was too much. 1603037 3 pnormand 2020-01-06 07:59:20 -0800 (In reply to Thibault Saunier from comment #2) > Comment on attachment 386793 [details] > workaround > > I am fine with that yes. informal r+ > > fwiw this warning is not critical in latest GStreamer master, this was too > much. Hum? Current state is, it *is* critical :) https://gitlab.freedesktop.org/gstreamer/gstreamer/commit/e79def14a5c47ef7c3660e17fd183d25dc82ae3f 1603090 4 tsaunier 2020-01-06 09:35:49 -0800 (In reply to Philippe Normand from comment #3) > (In reply to Thibault Saunier from comment #2) > > Comment on attachment 386793 [details] > > workaround > > > > I am fine with that yes. informal r+ > > > > fwiw this warning is not critical in latest GStreamer master, this was too > > much. > > Hum? Current state is, it *is* critical :) > https://gitlab.freedesktop.org/gstreamer/gstreamer/commit/ > e79def14a5c47ef7c3660e17fd183d25dc82ae3f Ah, I misremebered we had relaxed from critical to warning, but it was from assert to critical, sorry for the noise :-) Let's get that in I guess then. 1603108 5 386857 pnormand 2020-01-06 10:10:19 -0800 Created attachment 386857 Patch 1603109 6 386858 pnormand 2020-01-06 10:11:03 -0800 Created attachment 386858 Patch 1603490 7 pnormand 2020-01-07 01:43:44 -0800 Committed r254116: <https://trac.webkit.org/changeset/254116> 386793 2020-01-05 10:06:16 -0800 2020-01-06 10:10:11 -0800 workaround workaround.diff text/plain 1429 pnormand ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21lZGlhc3RyZWFtL2dzdHJlYW1l ci9HU3RyZWFtZXJNZWRpYVN0cmVhbVNvdXJjZS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9tZWRpYXN0cmVhbS9nc3RyZWFtZXIvR1N0cmVhbWVyTWVkaWFTdHJlYW1Tb3VyY2UuY3BwCmlu ZGV4IDQ1ZmQwZmY1Yzk1Li5hZDQyODIxNzU3MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vbWVkaWFzdHJlYW0vZ3N0cmVhbWVyL0dTdHJlYW1lck1lZGlhU3RyZWFtU291cmNl LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tZWRpYXN0cmVhbS9nc3RyZWFtZXIv R1N0cmVhbWVyTWVkaWFTdHJlYW1Tb3VyY2UuY3BwCkBAIC0xNjIsMjEgKzE2MiwyMSBAQCBwdWJs aWM6CiAgICAgV2ViS2l0TWVkaWFTdHJlYW1PYnNlcnZlcihXZWJLaXRNZWRpYVN0cmVhbVNyYyog c3JjKQogICAgICAgICA6IG1fbWVkaWFTdHJlYW1TcmMoc3JjKSB7IH0KIAotICAgIHZvaWQgY2hh cmFjdGVyaXN0aWNzQ2hhbmdlZCgpIGZpbmFsIHsgR1NUX0RFQlVHX09CSkVDVChtX21lZGlhU3Ry ZWFtU3JjLmdldCgpLCAicmVuZWdvdGlhdGlvbiBzaG91bGQgaGFwcGVuIik7IH0KKyAgICB2b2lk IGNoYXJhY3RlcmlzdGljc0NoYW5nZWQoKSBmaW5hbCB7IEdTVF9ERUJVR19PQkpFQ1QobV9tZWRp YVN0cmVhbVNyYywgInJlbmVnb3RpYXRpb24gc2hvdWxkIGhhcHBlbiIpOyB9CiAgICAgdm9pZCBh Y3RpdmVTdGF0dXNDaGFuZ2VkKCkgZmluYWwgeyB9CiAKICAgICB2b2lkIGRpZEFkZFRyYWNrKE1l ZGlhU3RyZWFtVHJhY2tQcml2YXRlJiB0cmFjaykgZmluYWwKICAgICB7Ci0gICAgICAgIHdlYmtp dE1lZGlhU3RyZWFtU3JjQWRkVHJhY2sobV9tZWRpYVN0cmVhbVNyYy5nZXQoKSwgJnRyYWNrLCBm YWxzZSk7CisgICAgICAgIHdlYmtpdE1lZGlhU3RyZWFtU3JjQWRkVHJhY2sobV9tZWRpYVN0cmVh bVNyYywgJnRyYWNrLCBmYWxzZSk7CiAgICAgfQogCiAgICAgdm9pZCBkaWRSZW1vdmVUcmFjayhN ZWRpYVN0cmVhbVRyYWNrUHJpdmF0ZSYgdHJhY2spIGZpbmFsCiAgICAgewotICAgICAgICB3ZWJr aXRNZWRpYVN0cmVhbVNyY1JlbW92ZVRyYWNrQnlUeXBlKG1fbWVkaWFTdHJlYW1TcmMuZ2V0KCks IHRyYWNrLnR5cGUoKSk7CisgICAgICAgIHdlYmtpdE1lZGlhU3RyZWFtU3JjUmVtb3ZlVHJhY2tC eVR5cGUobV9tZWRpYVN0cmVhbVNyYywgdHJhY2sudHlwZSgpKTsKICAgICB9CiAKIHByaXZhdGU6 Ci0gICAgR1JlZlB0cjxXZWJLaXRNZWRpYVN0cmVhbVNyYz4gbV9tZWRpYVN0cmVhbVNyYzsKKyAg ICBXZWJLaXRNZWRpYVN0cmVhbVNyYyogbV9tZWRpYVN0cmVhbVNyYzsKIH07CiAKIHR5cGVkZWYg c3RydWN0IF9XZWJLaXRNZWRpYVN0cmVhbVNyY0NsYXNzIFdlYktpdE1lZGlhU3RyZWFtU3JjQ2xh c3M7Cg== 386857 2020-01-06 10:10:19 -0800 2020-01-06 10:10:58 -0800 Patch bug-205777-20200106181017.patch text/plain 2526 pnormand U3VidmVyc2lvbiBSZXZpc2lvbjogMjU0MDU5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggM2NhNWY1YTk0MGFjYjI5 NWJlOTg2MjRmYWUyMDlkOTRjNTNjYmViYS4uOWE3NjhlZGZlMjdiZDkzYzk1MGU2NWVlNTA2ZTI3 MWNjY2JmNmExNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDIwLTAxLTA2ICBQaGls aXBwZSBOb3JtYW5kICA8cG5vcm1hbmRAaWdhbGlhLmNvbT4KKworICAgICAgICBbR1N0cmVhbWVy XSBtZWRpYXN0cmVhbXNyYyByZWYgc2lua2VkIHRyaWdnZXJzIGNyaXRpY2FsIHdhcm5pbmcgaW4g Z3N0IDEuMTcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTIwNTc3NworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg ICogcGxhdGZvcm0vbWVkaWFzdHJlYW0vZ3N0cmVhbWVyL0dTdHJlYW1lck1lZGlhU3RyZWFtU291 cmNlLmNwcDoKKyAgICAgICAgVXNlIGEgcmF3IHBvaW50ZXIgdG8ga2VlcCB0cmFjayBvZiB0aGUg c3JjIGVsZW1lbnQgaW4gdGhlIHRyYWNrCisgICAgICAgIG9ic2VydmVyLCBzaW1pbGFyaWx5IHRv IHRoZSBvdGhlciBvYnNlcnZlciBpbXBsZW1lbnRhdGlvbi4gVXNpbmcKKyAgICAgICAgR1JlZlB0 ciBoZXJlIHdvdWxkIGhhdmUgdGhlIHNpZGUgZWZmZWN0IG9mIHJlbW92aW5nIHRoZSBmbG9hdGlu ZworICAgICAgICByZWZlcmVuY2Ugb24gdGhlIGVsZW1lbnQgYW5kIHRyaWdnZXIgYSBjcml0aWNh bCBpbiBHU3RyZWFtZXIuCisKIDIwMjAtMDEtMDUgIFNpbW9uIEZyYXNlciAgPHNpbW9uLmZyYXNl ckBhcHBsZS5jb20+CiAKICAgICAgICAgUkVHUkVTU0lPTiAocjI1MjcyNCk6IFVuYWJsZSB0byB0 YXAgb24gcGxheSBidXR0b24gb24gZ29vZ2xlIHZpZGVvICdTZWUgdGhlIHRvcCBzZWFyY2ggdHJl bmRzIG9mIDIwMTknCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tZWRpYXN0 cmVhbS9nc3RyZWFtZXIvR1N0cmVhbWVyTWVkaWFTdHJlYW1Tb3VyY2UuY3BwIGIvU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vbWVkaWFzdHJlYW0vZ3N0cmVhbWVyL0dTdHJlYW1lck1lZGlhU3RyZWFt U291cmNlLmNwcAppbmRleCAwODNkNDQ3MjgzOWY5YmJjM2Y2OTQ2NmQxMWYzODQ5MTM2NjdjNmJk Li45ZWQ1ZmVhY2E1ZTRlYWZiNzFkNjM5NjVlNTk0YWE1ZTJlNDlhOWY4IDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tZWRpYXN0cmVhbS9nc3RyZWFtZXIvR1N0cmVhbWVyTWVk aWFTdHJlYW1Tb3VyY2UuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21lZGlhc3Ry ZWFtL2dzdHJlYW1lci9HU3RyZWFtZXJNZWRpYVN0cmVhbVNvdXJjZS5jcHAKQEAgLTE1MCwyMSAr MTUwLDIxIEBAIHB1YmxpYzoKICAgICBXZWJLaXRNZWRpYVN0cmVhbU9ic2VydmVyKFdlYktpdE1l ZGlhU3RyZWFtU3JjKiBzcmMpCiAgICAgICAgIDogbV9tZWRpYVN0cmVhbVNyYyhzcmMpIHsgfQog Ci0gICAgdm9pZCBjaGFyYWN0ZXJpc3RpY3NDaGFuZ2VkKCkgZmluYWwgeyBHU1RfREVCVUdfT0JK RUNUKG1fbWVkaWFTdHJlYW1TcmMuZ2V0KCksICJyZW5lZ290aWF0aW9uIHNob3VsZCBoYXBwZW4i KTsgfQorICAgIHZvaWQgY2hhcmFjdGVyaXN0aWNzQ2hhbmdlZCgpIGZpbmFsIHsgR1NUX0RFQlVH X09CSkVDVChtX21lZGlhU3RyZWFtU3JjLCAicmVuZWdvdGlhdGlvbiBzaG91bGQgaGFwcGVuIik7 IH0KICAgICB2b2lkIGFjdGl2ZVN0YXR1c0NoYW5nZWQoKSBmaW5hbCB7IH0KIAogICAgIHZvaWQg ZGlkQWRkVHJhY2soTWVkaWFTdHJlYW1UcmFja1ByaXZhdGUmIHRyYWNrKSBmaW5hbAogICAgIHsK LSAgICAgICAgd2Via2l0TWVkaWFTdHJlYW1TcmNBZGRUcmFjayhtX21lZGlhU3RyZWFtU3JjLmdl dCgpLCAmdHJhY2ssIGZhbHNlKTsKKyAgICAgICAgd2Via2l0TWVkaWFTdHJlYW1TcmNBZGRUcmFj ayhtX21lZGlhU3RyZWFtU3JjLCAmdHJhY2ssIGZhbHNlKTsKICAgICB9CiAKICAgICB2b2lkIGRp ZFJlbW92ZVRyYWNrKE1lZGlhU3RyZWFtVHJhY2tQcml2YXRlJiB0cmFjaykgZmluYWwKICAgICB7 Ci0gICAgICAgIHdlYmtpdE1lZGlhU3RyZWFtU3JjUmVtb3ZlVHJhY2tCeVR5cGUobV9tZWRpYVN0 cmVhbVNyYy5nZXQoKSwgdHJhY2sudHlwZSgpKTsKKyAgICAgICAgd2Via2l0TWVkaWFTdHJlYW1T cmNSZW1vdmVUcmFja0J5VHlwZShtX21lZGlhU3RyZWFtU3JjLCB0cmFjay50eXBlKCkpOwogICAg IH0KIAogcHJpdmF0ZToKLSAgICBHUmVmUHRyPFdlYktpdE1lZGlhU3RyZWFtU3JjPiBtX21lZGlh U3RyZWFtU3JjOworICAgIFdlYktpdE1lZGlhU3RyZWFtU3JjKiBtX21lZGlhU3RyZWFtU3JjOwog fTsKIAogdHlwZWRlZiBzdHJ1Y3QgX1dlYktpdE1lZGlhU3RyZWFtU3JjQ2xhc3MgV2ViS2l0TWVk aWFTdHJlYW1TcmNDbGFzczsK 386858 2020-01-06 10:11:03 -0800 2020-01-07 01:20:18 -0800 Patch bug-205777-20200106181101.patch text/plain 2534 pnormand U3VidmVyc2lvbiBSZXZpc2lvbjogMjU0MDU5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggM2NhNWY1YTk0MGFjYjI5 NWJlOTg2MjRmYWUyMDlkOTRjNTNjYmViYS4uOGZkZmFmOGYyMzM2Mjc3NWIyNDcwY2M5ZTFhNjdl OWE3YmZmNGRjOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDIwLTAxLTA2ICBQaGls aXBwZSBOb3JtYW5kICA8cG5vcm1hbmRAaWdhbGlhLmNvbT4KKworICAgICAgICBbR1N0cmVhbWVy XSBtZWRpYXN0cmVhbXNyYyByZWYgc2lua2VkIHRyaWdnZXJzIGNyaXRpY2FsIHdhcm5pbmcgaW4g Z3N0IDEuMTcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTIwNTc3NworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg ICogcGxhdGZvcm0vbWVkaWFzdHJlYW0vZ3N0cmVhbWVyL0dTdHJlYW1lck1lZGlhU3RyZWFtU291 cmNlLmNwcDoKKyAgICAgICAgVXNlIGEgcmF3IHBvaW50ZXIgdG8ga2VlcCB0cmFjayBvZiB0aGUg c3JjIGVsZW1lbnQgaW4gdGhlIHRyYWNrCisgICAgICAgIG9ic2VydmVyLCBzaW1pbGFyaWx5IHRv IHRoZSBvdGhlciBvYnNlcnZlciBpbXBsZW1lbnRhdGlvbi4gVXNpbmcKKyAgICAgICAgR1JlZlB0 ciBoZXJlIHdvdWxkIGhhdmUgdGhlIHNpZGUgZWZmZWN0IG9mIHJlbW92aW5nIHRoZSBmbG9hdGlu ZworICAgICAgICByZWZlcmVuY2Ugb24gdGhlIGVsZW1lbnQgYW5kIHRyaWdnZXIgYSBjcml0aWNh bCB3YXJuaW5nIGluIEdTdHJlYW1lci4KKwogMjAyMC0wMS0wNSAgU2ltb24gRnJhc2VyICA8c2lt b24uZnJhc2VyQGFwcGxlLmNvbT4KIAogICAgICAgICBSRUdSRVNTSU9OIChyMjUyNzI0KTogVW5h YmxlIHRvIHRhcCBvbiBwbGF5IGJ1dHRvbiBvbiBnb29nbGUgdmlkZW8gJ1NlZSB0aGUgdG9wIHNl YXJjaCB0cmVuZHMgb2YgMjAxOScKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L21lZGlhc3RyZWFtL2dzdHJlYW1lci9HU3RyZWFtZXJNZWRpYVN0cmVhbVNvdXJjZS5jcHAgYi9T b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tZWRpYXN0cmVhbS9nc3RyZWFtZXIvR1N0cmVhbWVyTWVk aWFTdHJlYW1Tb3VyY2UuY3BwCmluZGV4IDA4M2Q0NDcyODM5ZjliYmMzZjY5NDY2ZDExZjM4NDkx MzY2N2M2YmQuLjllZDVmZWFjYTVlNGVhZmI3MWQ2Mzk2NWU1OTRhYTVlMmU0OWE5ZjggMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21lZGlhc3RyZWFtL2dzdHJlYW1lci9HU3Ry ZWFtZXJNZWRpYVN0cmVhbVNvdXJjZS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v bWVkaWFzdHJlYW0vZ3N0cmVhbWVyL0dTdHJlYW1lck1lZGlhU3RyZWFtU291cmNlLmNwcApAQCAt MTUwLDIxICsxNTAsMjEgQEAgcHVibGljOgogICAgIFdlYktpdE1lZGlhU3RyZWFtT2JzZXJ2ZXIo V2ViS2l0TWVkaWFTdHJlYW1TcmMqIHNyYykKICAgICAgICAgOiBtX21lZGlhU3RyZWFtU3JjKHNy YykgeyB9CiAKLSAgICB2b2lkIGNoYXJhY3RlcmlzdGljc0NoYW5nZWQoKSBmaW5hbCB7IEdTVF9E RUJVR19PQkpFQ1QobV9tZWRpYVN0cmVhbVNyYy5nZXQoKSwgInJlbmVnb3RpYXRpb24gc2hvdWxk IGhhcHBlbiIpOyB9CisgICAgdm9pZCBjaGFyYWN0ZXJpc3RpY3NDaGFuZ2VkKCkgZmluYWwgeyBH U1RfREVCVUdfT0JKRUNUKG1fbWVkaWFTdHJlYW1TcmMsICJyZW5lZ290aWF0aW9uIHNob3VsZCBo YXBwZW4iKTsgfQogICAgIHZvaWQgYWN0aXZlU3RhdHVzQ2hhbmdlZCgpIGZpbmFsIHsgfQogCiAg ICAgdm9pZCBkaWRBZGRUcmFjayhNZWRpYVN0cmVhbVRyYWNrUHJpdmF0ZSYgdHJhY2spIGZpbmFs CiAgICAgewotICAgICAgICB3ZWJraXRNZWRpYVN0cmVhbVNyY0FkZFRyYWNrKG1fbWVkaWFTdHJl YW1TcmMuZ2V0KCksICZ0cmFjaywgZmFsc2UpOworICAgICAgICB3ZWJraXRNZWRpYVN0cmVhbVNy Y0FkZFRyYWNrKG1fbWVkaWFTdHJlYW1TcmMsICZ0cmFjaywgZmFsc2UpOwogICAgIH0KIAogICAg IHZvaWQgZGlkUmVtb3ZlVHJhY2soTWVkaWFTdHJlYW1UcmFja1ByaXZhdGUmIHRyYWNrKSBmaW5h bAogICAgIHsKLSAgICAgICAgd2Via2l0TWVkaWFTdHJlYW1TcmNSZW1vdmVUcmFja0J5VHlwZSht X21lZGlhU3RyZWFtU3JjLmdldCgpLCB0cmFjay50eXBlKCkpOworICAgICAgICB3ZWJraXRNZWRp YVN0cmVhbVNyY1JlbW92ZVRyYWNrQnlUeXBlKG1fbWVkaWFTdHJlYW1TcmMsIHRyYWNrLnR5cGUo KSk7CiAgICAgfQogCiBwcml2YXRlOgotICAgIEdSZWZQdHI8V2ViS2l0TWVkaWFTdHJlYW1TcmM+ IG1fbWVkaWFTdHJlYW1TcmM7CisgICAgV2ViS2l0TWVkaWFTdHJlYW1TcmMqIG1fbWVkaWFTdHJl YW1TcmM7CiB9OwogCiB0eXBlZGVmIHN0cnVjdCBfV2ViS2l0TWVkaWFTdHJlYW1TcmNDbGFzcyBX ZWJLaXRNZWRpYVN0cmVhbVNyY0NsYXNzOwo=