205773 2020-01-04 17:41:26 -0800 [LFC][Integration] Fix fast/repaint/simple-line-layout-shrinking-content.html 2020-01-05 07:36:48 -0800 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 zalan zalan bfulgham commit-queue esprehn+autocc ews-watchlist glenn koivisto kondapallykalyan pdr simon.fraser webkit-bug-importer zalan oldest_to_newest 1602804 0 zalan 2020-01-04 17:41:26 -0800 ssia 1602805 1 webkit-bug-importer 2020-01-04 17:41:46 -0800 <rdar://problem/58319960> 1602806 2 386777 zalan 2020-01-04 17:59:56 -0800 Created attachment 386777 Patch 1602825 3 386777 koivisto 2020-01-05 00:05:48 -0800 Comment on attachment 386777 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=386777&action=review > Source/WebCore/rendering/RenderBlockFlow.cpp:3724 > + repaintLogicalTop = contentBoxTop; > + repaintLogicalBottom = borderBoxBottom; Shouldn't both these be from the same box? 1602843 4 386777 commit-queue 2020-01-05 06:50:16 -0800 Comment on attachment 386777 Patch Clearing flags on attachment: 386777 Committed r254040: <https://trac.webkit.org/changeset/254040> 1602844 5 commit-queue 2020-01-05 06:50:18 -0800 All reviewed patches have been landed. Closing bug. 1602848 6 zalan 2020-01-05 07:36:48 -0800 (In reply to Antti Koivisto from comment #3) > Comment on attachment 386777 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=386777&action=review > > > Source/WebCore/rendering/RenderBlockFlow.cpp:3724 > > + repaintLogicalTop = contentBoxTop; > > + repaintLogicalBottom = borderBoxBottom; > > Shouldn't both these be from the same box? This repaint logic should really just be about the content box. Right now I am just matching SLL behavior. 386777 2020-01-04 17:59:56 -0800 2020-01-05 06:50:16 -0800 Patch bug-205773-20200104175956.patch text/plain 2192 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMjU0MDM0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZGNkOTY0NWZmNDRhZjFj ZWYwMTQ2MDhjZGJkMTY5OGRmNmMxNjQxNC4uMGIwMThmMjk0ZWQ3YzA4YWEzZmZlNGVmY2ZjMDNi MDIzYWZhMDY1YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDIwLTAxLTA0ICBaYWxh biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgW0xGQ11bSW50ZWdyYXRpb25d IEZpeCBmYXN0L3JlcGFpbnQvc2ltcGxlLWxpbmUtbGF5b3V0LXNocmlua2luZy1jb250ZW50Lmh0 bWwKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwNTc3 MworICAgICAgICA8cmRhcjovL3Byb2JsZW0vNTgzMTk5NjA+CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTGV0J3MgYWRkIHBhZGRpbmcgYW5kIGJvcmRl ciB0byB0aGUgcmVwYWludCByZWN0ICh3aGljaCBpcyBub3QgcXVpdGUgcmlnaHQgc2luY2UgYXQg dGhpcyBsZXZlbCByZWFwaW50IHJlY3Qgc2hvdWxkCisgICAgICAgIGJlIGFib3V0IHRoZSBjb250 ZW50IGNoYW5nZSwgYnV0IHRoYXQncyB3aGF0IFNMTCBkb2VzIGFuZCBpdCBmaXhlcyBzb21lIHJl cGFpbnQgaXNzdWVzIHdoZW4KKyAgICAgICAgdGhlIGJveCB3aXRoIHBhZGRpbmcvYm9yZGVyIHNo cmlua3MpLgorCisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlckJsb2NrRmxvdy5jcHA6CisgICAg ICAgIChXZWJDb3JlOjpSZW5kZXJCbG9ja0Zsb3c6OmxheW91dExGQ0xpbmVzKToKKwogMjAyMC0w MS0wNCAgWmFsYW4gQnVqdGFzICA8emFsYW5AYXBwbGUuY29tPgogCiAgICAgICAgIFtMRkNdW0lG Q10gRml4IGNvbXBvc2l0aW5nL21hc2tzL2NvbXBvc2l0aW5nLWNsaXAtcGF0aC1jaGFuZ2Utbm8t cmVwYWludC5odG1sCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVy QmxvY2tGbG93LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCbG9ja0Zsb3cu Y3BwCmluZGV4IDY4ZjZkZTI3NzA0YjNiMjk0ZjJiYzc2OTg1YmJiOTU0YTNlOWQ5ZjcuLmM0ZGJh NmU2MDBmMzE2MzVhN2NhYTIyMGFmN2M4MzBlODhmYTU2YWUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCbG9ja0Zsb3cuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3Jl L3JlbmRlcmluZy9SZW5kZXJCbG9ja0Zsb3cuY3BwCkBAIC0zNzE2LDE0ICszNzE2LDEzIEBAIHZv aWQgUmVuZGVyQmxvY2tGbG93OjpsYXlvdXRMRkNMaW5lcyhib29sLCBMYXlvdXRVbml0JiByZXBh aW50TG9naWNhbFRvcCwgTGF5b3V0CiAgICAgbGF5b3V0Rm9ybWF0dGluZ0NvbnRleHRMaW5lTGF5 b3V0LmxheW91dCgpOwogCiAgICAgYXV0byBjb250ZW50SGVpZ2h0ID0gbGF5b3V0Rm9ybWF0dGlu Z0NvbnRleHRMaW5lTGF5b3V0LmNvbnRlbnRMb2dpY2FsSGVpZ2h0KCk7Ci0gICAgYXV0byBjb250 ZW50VG9wID0gYm9yZGVyQW5kUGFkZGluZ0JlZm9yZSgpOwotICAgIGF1dG8gY29udGVudEJvdHRv bSA9IGNvbnRlbnRUb3AgKyBjb250ZW50SGVpZ2h0OwotICAgIGF1dG8gdG90YWxIZWlnaHQgPSBj b250ZW50Qm90dG9tICsgYm9yZGVyQW5kUGFkZGluZ0FmdGVyKCk7CisgICAgYXV0byBjb250ZW50 Qm94VG9wID0gYm9yZGVyQW5kUGFkZGluZ0JlZm9yZSgpOworICAgIGF1dG8gY29udGVudEJveEJv dHRvbSA9IGNvbnRlbnRCb3hUb3AgKyBjb250ZW50SGVpZ2h0OworICAgIGF1dG8gYm9yZGVyQm94 Qm90dG9tID0gY29udGVudEJveEJvdHRvbSArIGJvcmRlckFuZFBhZGRpbmdBZnRlcigpOwogCi0g ICAgcmVwYWludExvZ2ljYWxUb3AgPSBjb250ZW50VG9wOwotICAgIHJlcGFpbnRMb2dpY2FsQm90 dG9tID0gY29udGVudEJvdHRvbTsKLQotICAgIHNldExvZ2ljYWxIZWlnaHQodG90YWxIZWlnaHQp OworICAgIHJlcGFpbnRMb2dpY2FsVG9wID0gY29udGVudEJveFRvcDsKKyAgICByZXBhaW50TG9n aWNhbEJvdHRvbSA9IGJvcmRlckJveEJvdHRvbTsKKyAgICBzZXRMb2dpY2FsSGVpZ2h0KGJvcmRl ckJveEJvdHRvbSk7CiB9CiAjZW5kaWYKIAo=