205771 2020-01-04 17:14:18 -0800 [LFC][Integration] Fix compositing/masks/compositing-clip-path-change-no-repaint.html 2020-01-05 07:13:16 -0800 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 zalan zalan bfulgham commit-queue esprehn+autocc ews-watchlist glenn koivisto kondapallykalyan pdr simon.fraser webkit-bug-importer zalan oldest_to_newest 1602800 0 zalan 2020-01-04 17:14:18 -0800 ssia 1602801 1 webkit-bug-importer 2020-01-04 17:14:40 -0800 <rdar://problem/58319828> 1602803 2 386776 zalan 2020-01-04 17:24:26 -0800 Created attachment 386776 Patch 1602824 3 386776 koivisto 2020-01-05 00:00:12 -0800 Comment on attachment 386776 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=386776&action=review > Source/WebCore/ChangeLog:3 > + [LFC][IFC] Fix compositing/masks/compositing-clip-path-change-no-repaint.html [LFC][Integration] 1602826 4 386776 koivisto 2020-01-05 00:07:19 -0800 Comment on attachment 386776 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=386776&action=review > Source/WebCore/rendering/RenderBlockFlow.cpp:-2090 > if (diff >= StyleDifference::Repaint) { > - // FIXME: This could use a cheaper style-only test instead of SimpleLineLayout::canUseFor. > - if (selfNeedsLayout() || !simpleLineLayout() || !SimpleLineLayout::canUseFor(*this)) If we don't redo the layout then we need to push the style change to LFC too. 1602841 5 386785 zalan 2020-01-05 06:25:30 -0800 Created attachment 386785 Patch 1602846 6 386785 commit-queue 2020-01-05 07:13:15 -0800 Comment on attachment 386785 Patch Clearing flags on attachment: 386785 Committed r254041: <https://trac.webkit.org/changeset/254041> 1602847 7 commit-queue 2020-01-05 07:13:16 -0800 All reviewed patches have been landed. Closing bug. 386776 2020-01-04 17:24:26 -0800 2020-01-05 06:25:28 -0800 Patch bug-205771-20200104172425.patch text/plain 2224 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMjU0MDM0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZWQ2ZTVhZDAzMDJjYzdh ZDA0OTdhNjM4Y2U1MDFlNDAyYjI2MmZhMC4uZGNkOTY0NWZmNDRhZjFjZWYwMTQ2MDhjZGJkMTY5 OGRmNmMxNjQxNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDIwLTAxLTA0ICBaYWxh biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgW0xGQ11bSUZDXSBGaXggY29t cG9zaXRpbmcvbWFza3MvY29tcG9zaXRpbmctY2xpcC1wYXRoLWNoYW5nZS1uby1yZXBhaW50Lmh0 bWwKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwNTc3 MQorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNTgzMTk4Mjg+CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkIExGQyBsaW5lIGxheW91dCBjaGVjayB3 aGVuIGRlY2lkaW5nIHdoZXRoZXIgdGhlIGN1cnJlbnQgbGF5b3V0IHBhdGggbmVlZHMKKyAgICAg ICAgaW52YWxpZGF0aW9uIGFmdGVyIHN0eWxlIGNoYW5nZS4KKworICAgICAgICBPcmlnaW5hbCBw YXRjaCBieSBBbnR0aS4KKworICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJCbG9ja0Zsb3cuY3Bw OgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyQmxvY2tGbG93OjpzdHlsZURpZENoYW5nZSk6CisK IDIwMjAtMDEtMDQgIFphbGFuIEJ1anRhcyAgPHphbGFuQGFwcGxlLmNvbT4KIAogICAgICAgICBb U0xMXSBHZW5lcmF0ZSBydW5zIGZvciBwcmVzZXJ2ZWQgbmV3IGxpbmVzCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQmxvY2tGbG93LmNwcCBiL1NvdXJjZS9XZWJD b3JlL3JlbmRlcmluZy9SZW5kZXJCbG9ja0Zsb3cuY3BwCmluZGV4IDc0YzQwZGE5ZmJiNzJlMDgw M2U3ZjkwYzFhMmZhNzhmM2VlMTk0MzUuLjY4ZjZkZTI3NzA0YjNiMjk0ZjJiYzc2OTg1YmJiOTU0 YTNlOWQ5ZjcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCbG9j a0Zsb3cuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCbG9ja0Zsb3cu Y3BwCkBAIC0yMDg2LDggKzIwODYsMTkgQEAgdm9pZCBSZW5kZXJCbG9ja0Zsb3c6OnN0eWxlRGlk Q2hhbmdlKFN0eWxlRGlmZmVyZW5jZSBkaWZmLCBjb25zdCBSZW5kZXJTdHlsZSogb2wKICAgICB9 CiAKICAgICBpZiAoZGlmZiA+PSBTdHlsZURpZmZlcmVuY2U6OlJlcGFpbnQpIHsKLSAgICAgICAg Ly8gRklYTUU6IFRoaXMgY291bGQgdXNlIGEgY2hlYXBlciBzdHlsZS1vbmx5IHRlc3QgaW5zdGVh ZCBvZiBTaW1wbGVMaW5lTGF5b3V0OjpjYW5Vc2VGb3IuCi0gICAgICAgIGlmIChzZWxmTmVlZHNM YXlvdXQoKSB8fCAhc2ltcGxlTGluZUxheW91dCgpIHx8ICFTaW1wbGVMaW5lTGF5b3V0OjpjYW5V c2VGb3IoKnRoaXMpKQorICAgICAgICBhdXRvIHNob3VsZEludmFsaWRhdGVMaW5lTGF5b3V0UGF0 aCA9IFsmXSB7CisgICAgICAgICAgICBpZiAoc2VsZk5lZWRzTGF5b3V0KCkgfHwgY29tcGxleExp bmVMYXlvdXQoKSkKKyAgICAgICAgICAgICAgICByZXR1cm4gdHJ1ZTsKKyAgICAgICAgICAgIC8v IEZJWE1FOiBUaGlzIGNvdWxkIHVzZSBhIGNoZWFwZXIgc3R5bGUtb25seSB0ZXN0IGluc3RlYWQg b2YgU2ltcGxlTGluZUxheW91dDo6Y2FuVXNlRm9yLgorICAgICAgICAgICAgaWYgKHNpbXBsZUxp bmVMYXlvdXQoKSAmJiAhU2ltcGxlTGluZUxheW91dDo6Y2FuVXNlRm9yKCp0aGlzKSkKKyAgICAg ICAgICAgICAgICByZXR1cm4gdHJ1ZTsKKyNpZiBFTkFCTEUoTEFZT1VUX0ZPUk1BVFRJTkdfQ09O VEVYVCkKKyAgICAgICAgICAgIGlmIChsYXlvdXRGb3JtYXR0aW5nQ29udGV4dExpbmVMYXlvdXQo KSAmJiAhTGF5b3V0SW50ZWdyYXRpb246OkxpbmVMYXlvdXQ6OmNhblVzZUZvcigqdGhpcykpCisg ICAgICAgICAgICAgICAgcmV0dXJuIHRydWU7CisjZW5kaWYKKyAgICAgICAgICAgIHJldHVybiBm YWxzZTsKKyAgICAgICAgfTsKKyAgICAgICAgaWYgKHNob3VsZEludmFsaWRhdGVMaW5lTGF5b3V0 UGF0aCgpKQogICAgICAgICAgICAgaW52YWxpZGF0ZUxpbmVMYXlvdXRQYXRoKCk7CiAgICAgfQog Cg== 386785 2020-01-05 06:25:30 -0800 2020-01-05 07:13:15 -0800 Patch bug-205771-20200105062529.patch text/plain 2266 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMjU0MDM5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMDgwOTQwZjQyNGJiMTY3 ZmM2MmFlMmY2NDFkM2NlMTJkMTk5NDE0Yi4uOTI2Y2Q2NjBkZjQ2Mjk0OGI2YWI3ZmFiZDAwNzVj N2NkNDhhOTkzMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDIwLTAxLTA1ICBaYWxh biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgW0xGQ11bSW50ZWdyYXRpb25d IEZpeCBjb21wb3NpdGluZy9tYXNrcy9jb21wb3NpdGluZy1jbGlwLXBhdGgtY2hhbmdlLW5vLXJl cGFpbnQuaHRtbAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MjA1NzcxCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS81ODMxOTgyOD4KKworICAgICAgICBS ZXZpZXdlZCBieSBBbnR0aSBLb2l2aXN0by4KKworICAgICAgICBBZGQgTEZDIGxpbmUgbGF5b3V0 IGNoZWNrIHdoZW4gZGVjaWRpbmcgd2hldGhlciB0aGUgY3VycmVudCBsYXlvdXQgcGF0aCBuZWVk cworICAgICAgICBpbnZhbGlkYXRpb24gYWZ0ZXIgc3R5bGUgY2hhbmdlLgorCisgICAgICAgIE9y aWdpbmFsIHBhdGNoIGJ5IEFudHRpLgorCisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlckJsb2Nr Rmxvdy5jcHA6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJCbG9ja0Zsb3c6OnN0eWxlRGlkQ2hh bmdlKToKKwogMjAyMC0wMS0wNSAgeW91ZW5uIGZhYmxldCAgPHlvdWVubkBhcHBsZS5jb20+CiAK ICAgICAgICAgTWFrZSBNZWRpYVJlY29yZGVyUHJpdmF0ZSB1c2UgQ29tcGxldGlvbkhhbmRsZXIg Zm9yIHJldHJpZXZpbmcgZW5jb2RlZCBkYXRhCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9y ZW5kZXJpbmcvUmVuZGVyQmxvY2tGbG93LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9S ZW5kZXJCbG9ja0Zsb3cuY3BwCmluZGV4IDc0YzQwZGE5ZmJiNzJlMDgwM2U3ZjkwYzFhMmZhNzhm M2VlMTk0MzUuLjY4ZjZkZTI3NzA0YjNiMjk0ZjJiYzc2OTg1YmJiOTU0YTNlOWQ5ZjcgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCbG9ja0Zsb3cuY3BwCisrKyBi L1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCbG9ja0Zsb3cuY3BwCkBAIC0yMDg2LDgg KzIwODYsMTkgQEAgdm9pZCBSZW5kZXJCbG9ja0Zsb3c6OnN0eWxlRGlkQ2hhbmdlKFN0eWxlRGlm ZmVyZW5jZSBkaWZmLCBjb25zdCBSZW5kZXJTdHlsZSogb2wKICAgICB9CiAKICAgICBpZiAoZGlm ZiA+PSBTdHlsZURpZmZlcmVuY2U6OlJlcGFpbnQpIHsKLSAgICAgICAgLy8gRklYTUU6IFRoaXMg Y291bGQgdXNlIGEgY2hlYXBlciBzdHlsZS1vbmx5IHRlc3QgaW5zdGVhZCBvZiBTaW1wbGVMaW5l TGF5b3V0OjpjYW5Vc2VGb3IuCi0gICAgICAgIGlmIChzZWxmTmVlZHNMYXlvdXQoKSB8fCAhc2lt cGxlTGluZUxheW91dCgpIHx8ICFTaW1wbGVMaW5lTGF5b3V0OjpjYW5Vc2VGb3IoKnRoaXMpKQor ICAgICAgICBhdXRvIHNob3VsZEludmFsaWRhdGVMaW5lTGF5b3V0UGF0aCA9IFsmXSB7CisgICAg ICAgICAgICBpZiAoc2VsZk5lZWRzTGF5b3V0KCkgfHwgY29tcGxleExpbmVMYXlvdXQoKSkKKyAg ICAgICAgICAgICAgICByZXR1cm4gdHJ1ZTsKKyAgICAgICAgICAgIC8vIEZJWE1FOiBUaGlzIGNv dWxkIHVzZSBhIGNoZWFwZXIgc3R5bGUtb25seSB0ZXN0IGluc3RlYWQgb2YgU2ltcGxlTGluZUxh eW91dDo6Y2FuVXNlRm9yLgorICAgICAgICAgICAgaWYgKHNpbXBsZUxpbmVMYXlvdXQoKSAmJiAh U2ltcGxlTGluZUxheW91dDo6Y2FuVXNlRm9yKCp0aGlzKSkKKyAgICAgICAgICAgICAgICByZXR1 cm4gdHJ1ZTsKKyNpZiBFTkFCTEUoTEFZT1VUX0ZPUk1BVFRJTkdfQ09OVEVYVCkKKyAgICAgICAg ICAgIGlmIChsYXlvdXRGb3JtYXR0aW5nQ29udGV4dExpbmVMYXlvdXQoKSAmJiAhTGF5b3V0SW50 ZWdyYXRpb246OkxpbmVMYXlvdXQ6OmNhblVzZUZvcigqdGhpcykpCisgICAgICAgICAgICAgICAg cmV0dXJuIHRydWU7CisjZW5kaWYKKyAgICAgICAgICAgIHJldHVybiBmYWxzZTsKKyAgICAgICAg fTsKKyAgICAgICAgaWYgKHNob3VsZEludmFsaWRhdGVMaW5lTGF5b3V0UGF0aCgpKQogICAgICAg ICAgICAgaW52YWxpZGF0ZUxpbmVMYXlvdXRQYXRoKCk7CiAgICAgfQogCg==