205767 2020-01-04 13:11:41 -0800 JSON.parse should initialize wrapper object with [[DefineOwnProperty]] 2020-01-04 21:10:32 -0800 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Trivial --- 1 ashvayka ashvayka commit-queue darin ews-watchlist keith_miller mark.lam msaboff saam tzagallo webkit-bug-importer oldest_to_newest 1602778 0 ashvayka 2020-01-04 13:11:41 -0800 ECMA262: https://tc39.es/ecma262/#sec-json.parse (step 7.c) Test262: https://test262.report/browse/built-ins/JSON/parse/reviver-wrapper.js Currently, JSC performs [[Set]] instead, which is observable by a setter on Object.prototype (with empty String key). 1602780 1 386767 ashvayka 2020-01-04 13:49:23 -0800 Created attachment 386767 Patch 1602817 2 386767 commit-queue 2020-01-04 21:09:29 -0800 Comment on attachment 386767 Patch Clearing flags on attachment: 386767 Committed r254037: <https://trac.webkit.org/changeset/254037> 1602818 3 commit-queue 2020-01-04 21:09:31 -0800 All reviewed patches have been landed. Closing bug. 1602819 4 webkit-bug-importer 2020-01-04 21:10:32 -0800 <rdar://problem/58320851> 386767 2020-01-04 13:49:23 -0800 2020-01-04 21:09:29 -0800 Patch bug-205767-20200104234922.patch text/plain 3671 ashvayka SW5kZXg6IEpTVGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEpTVGVzdHMvQ2hhbmdlTG9n CShyZXZpc2lvbiAyNTQwMzQpCisrKyBKU1Rlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpA QCAtMSwzICsxLDEyIEBACisyMDIwLTAxLTA0ICBBbGV4ZXkgU2h2YXlrYSAgPHNodmFpa2FsZXNo QGdtYWlsLmNvbT4KKworICAgICAgICBKU09OLnBhcnNlIHNob3VsZCBpbml0aWFsaXplIHdyYXBw ZXIgb2JqZWN0IHdpdGggW1tEZWZpbmVPd25Qcm9wZXJ0eV1dCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDU3NjcKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHRlc3QyNjIvZXhwZWN0YXRpb25zLnlhbWw6 IE1hcmsgMiB0ZXN0IGNhc2VzIGFzIHBhc3NpbmcuCisKIDIwMjAtMDEtMDMgIEtlaXRoIE1pbGxl ciAgPGtlaXRoX21pbGxlckBhcHBsZS5jb20+CiAKICAgICAgICAgVXBkYXRlIHRlc3QyNjIgdGVz dHMgdG8gY29tbWl0IDE1N2IxOGQKSW5kZXg6IEpTVGVzdHMvdGVzdDI2Mi9leHBlY3RhdGlvbnMu eWFtbAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBKU1Rlc3RzL3Rlc3QyNjIvZXhwZWN0YXRpb25zLnlhbWwJKHJl dmlzaW9uIDI1NDAzMikKKysrIEpTVGVzdHMvdGVzdDI2Mi9leHBlY3RhdGlvbnMueWFtbAkod29y a2luZyBjb3B5KQpAQCAtMTEzMSw5ICsxMTMxLDYgQEAgdGVzdC9idWlsdC1pbnMvSlNPTi9wYXJz ZS9yZXZpdmVyLW9iamVjdAogdGVzdC9idWlsdC1pbnMvSlNPTi9wYXJzZS9yZXZpdmVyLW9iamVj dC1ub24tY29uZmlndXJhYmxlLXByb3AtY3JlYXRlLmpzOgogICBkZWZhdWx0OiAnVGVzdDI2MkVy cm9yOiBFeHBlY3RlZCBTYW1lVmFsdWUowqsyMsK7LCDCqzLCuykgdG8gYmUgdHJ1ZScKICAgc3Ry aWN0IG1vZGU6ICdUZXN0MjYyRXJyb3I6IEV4cGVjdGVkIFNhbWVWYWx1ZSjCqzIywrssIMKrMsK7 KSB0byBiZSB0cnVlJwotdGVzdC9idWlsdC1pbnMvSlNPTi9wYXJzZS9yZXZpdmVyLXdyYXBwZXIu anM6Ci0gIGRlZmF1bHQ6ICdUZXN0MjYyRXJyb3I6IFtbU2V0XV0gc2hvdWxkIG5vdCBiZSBjYWxs ZWQuJwotICBzdHJpY3QgbW9kZTogJ1Rlc3QyNjJFcnJvcjogW1tTZXRdXSBzaG91bGQgbm90IGJl IGNhbGxlZC4nCiB0ZXN0L2J1aWx0LWlucy9NYXAvcHJvdG8tZnJvbS1jdG9yLXJlYWxtLmpzOgog ICBkZWZhdWx0OiAnVGVzdDI2MkVycm9yOiBFeHBlY3RlZCBTYW1lVmFsdWUowqtbb2JqZWN0IE1h cF3Cuywgwqtbb2JqZWN0IE1hcF3CuykgdG8gYmUgdHJ1ZScKICAgc3RyaWN0IG1vZGU6ICdUZXN0 MjYyRXJyb3I6IEV4cGVjdGVkIFNhbWVWYWx1ZSjCq1tvYmplY3QgTWFwXcK7LCDCq1tvYmplY3Qg TWFwXcK7KSB0byBiZSB0cnVlJwpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxv Zwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCShyZXZpc2lv biAyNTQwMzIpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNv cHkpCkBAIC0xLDMgKzEsMTkgQEAKKzIwMjAtMDEtMDQgIEFsZXhleSBTaHZheWthICA8c2h2YWlr YWxlc2hAZ21haWwuY29tPgorCisgICAgICAgIEpTT04ucGFyc2Ugc2hvdWxkIGluaXRpYWxpemUg d3JhcHBlciBvYmplY3Qgd2l0aCBbW0RlZmluZU93blByb3BlcnR5XV0KKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwNTc2NworCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoaXMgcGF0Y2ggbWFrZXMgSlNPTi5w YXJzZSB1c2UgW1tEZWZpbmVPd25Qcm9wZXJ0eV1dIGluc3RlYWQgb2YgW1tTZXRdXSB0byBpbml0 aWFsaXplIHdyYXBwZXIgb2JqZWN0LAorICAgICAgICBhbGlnbmluZyBKU0Mgd2l0aCB0aGUgc3Bl YyAoc3RlcCA3LmMgb2YgaHR0cHM6Ly90YzM5LmVzL2VjbWEyNjIvI3NlYy1qc29uLnBhcnNlKSBh bmQgb3RoZXIgZW5naW5lcy4KKyAgICAgICAgUGVyZm9ybWluZyBbW1NldF1dIHdhcyBvYnNlcnZh YmxlIGJ5IGEgc2V0dGVyIG9uIE9iamVjdC5wcm90b3R5cGUgKHdpdGggZW1wdHkgU3RyaW5nIGtl eSkuCisgICAgICAgIEFsc28gcmVtb3ZlcyB0d28gZXh0cmEgZXhjZXB0aW9ucyBjaGVja3MuCisK KyAgICAgICAgKiBydW50aW1lL0pTT05PYmplY3QuY3BwOgorICAgICAgICAoSlNDOjpTdHJpbmdp Zmllcjo6c3RyaW5naWZ5KToKKyAgICAgICAgKEpTQzo6V2Fsa2VyOjp3YWxrKToKKwogMjAyMC0w MS0wMiAgWXVzdWtlIFN1enVraSAgPHlzdXp1a2lAYXBwbGUuY29tPgogCiAgICAgICAgIFtKU0Nd IE1hcmtlZEJsb2NrOjpIYW5kbGUgYW5kIEJsb2NrRGlyZWN0b3J5IHNob3VsZCBiZSBzaHJ1bmsK SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0pTT05PYmplY3QuY3BwCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0pTT05PYmplY3QuY3BwCShy ZXZpc2lvbiAyNTQwMzIpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9KU09OT2Jq ZWN0LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMjgwLDcgKzI4MCw2IEBAIEpTVmFsdWUgU3RyaW5n aWZpZXI6OnN0cmluZ2lmeShKU1ZhbHVlIHYKICAgICBKU09iamVjdCogb2JqZWN0ID0gbnVsbHB0 cjsKICAgICBpZiAoaXNDYWxsYWJsZVJlcGxhY2VyKCkpIHsKICAgICAgICAgb2JqZWN0ID0gY29u c3RydWN0RW1wdHlPYmplY3QobV9nbG9iYWxPYmplY3QpOwotICAgICAgICBSRVRVUk5fSUZfRVhD RVBUSU9OKHNjb3BlLCBqc1VuZGVmaW5lZCgpKTsKICAgICAgICAgb2JqZWN0LT5wdXREaXJlY3Qo dm0sIHZtLnByb3BlcnR5TmFtZXMtPmVtcHR5SWRlbnRpZmllciwgdmFsdWUpOwogICAgIH0KIApA QCAtNzk2LDkgKzc5NSw3IEBAIE5FVkVSX0lOTElORSBKU1ZhbHVlIFdhbGtlcjo6d2FsayhKU1Zh bHUKICAgICAgICAgc3RhdGVTdGFjay5yZW1vdmVMYXN0KCk7CiAgICAgfQogICAgIEpTT2JqZWN0 KiBmaW5hbEhvbGRlciA9IGNvbnN0cnVjdEVtcHR5T2JqZWN0KG1fZ2xvYmFsT2JqZWN0KTsKLSAg ICBQdXRQcm9wZXJ0eVNsb3Qgc2xvdChmaW5hbEhvbGRlcik7Ci0gICAgZmluYWxIb2xkZXItPm1l dGhvZFRhYmxlKHZtKS0+cHV0KGZpbmFsSG9sZGVyLCBtX2dsb2JhbE9iamVjdCwgdm0ucHJvcGVy dHlOYW1lcy0+ZW1wdHlJZGVudGlmaWVyLCBvdXRWYWx1ZSwgc2xvdCk7Ci0gICAgUkVUVVJOX0lG X0VYQ0VQVElPTihzY29wZSwgeyB9KTsKKyAgICBmaW5hbEhvbGRlci0+cHV0RGlyZWN0KHZtLCB2 bS5wcm9wZXJ0eU5hbWVzLT5lbXB0eUlkZW50aWZpZXIsIG91dFZhbHVlKTsKICAgICBSRUxFQVNF X0FORF9SRVRVUk4oc2NvcGUsIGNhbGxSZXZpdmVyKGZpbmFsSG9sZGVyLCBqc0VtcHR5U3RyaW5n KHZtKSwgb3V0VmFsdWUpKTsKIH0KIAo=