205764 2020-01-03 22:19:43 -0800 REGRESSION (r248734): different threads write m_storageMap of StorageAreaImpl at the same time 2020-01-07 16:17:43 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 sihui_liu sihui_liu achristensen beidson cdumez commit-queue mjs webkit-bug-importer oldest_to_newest 1602737 0 sihui_liu 2020-01-03 22:19:43 -0800 <rdar://problem/58179425> 1602738 1 386755 sihui_liu 2020-01-03 22:27:15 -0800 Created attachment 386755 Patch 1603408 2 386755 mjs 2020-01-06 18:49:44 -0800 Comment on attachment 386755 Patch r=me Is it possible to make a test case for this that fails even without ASAN? 1603812 3 sihui_liu 2020-01-07 15:03:05 -0800 (In reply to Maciej Stachowiak from comment #2) > Comment on attachment 386755 [details] > Patch > > r=me > > Is it possible to make a test case for this that fails even without ASAN? It could be hard to write a dedicated test due to the race condition, and it looks like usually we only change session of WebView between tests (reseting preferences between tests in DumpRenderTree), not in one test. 1603857 4 386755 commit-queue 2020-01-07 16:17:41 -0800 Comment on attachment 386755 Patch Clearing flags on attachment: 386755 Committed r254169: <https://trac.webkit.org/changeset/254169> 1603858 5 commit-queue 2020-01-07 16:17:43 -0800 All reviewed patches have been landed. Closing bug. 386755 2020-01-03 22:27:15 -0800 2020-01-07 16:17:41 -0800 Patch bug-205764-20200103222638.patch text/plain 2107 sihui_liu U3VidmVyc2lvbiBSZXZpc2lvbjogMjU0MDI4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0TGVn YWN5L0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXRMZWdhY3kvQ2hhbmdlTG9nCmluZGV4IGI3N2Q5 ZWIwNjA4YWE3NDFlODM1NzE4OWY5ZjZhNGQ4ZTFlYTA1YzYuLjU4NDllZTliMjFjZWI4MDAyZGE3 MWE5Y2MxMTNkZjIzZWM4YjE0YTkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXRMZWdhY3kvQ2hh bmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXRMZWdhY3kvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjEg QEAKKzIwMjAtMDEtMDMgIFNpaHVpIExpdSAgPHNpaHVpX2xpdUBhcHBsZS5jb20+CisKKyAgICAg ICAgUkVHUkVTU0lPTiAocjI0ODczNCk6IGRpZmZlcmVudCB0aHJlYWRzIHdyaXRlIG1fc3RvcmFn ZU1hcCBvZiBTdG9yYWdlQXJlYUltcGwgYXQgdGhlIHNhbWUgdGltZQorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjA1NzY0CisgICAgICAgIDxyZGFyOi8v cHJvYmxlbS81ODE3OTQyNT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBJbiBTdG9yYWdlQXJlYUltcGwsIHdlIGF2b2lkIG1vZGlmeWluZyBtX3N0b3Jh Z2VNYXAgZnJvbSBkaWZmZXJlbnQgdGhyZWFkcyBhdCB0aGUgc2FtZSB0aW1lIGJ5IGJsb2NraW5n IG1haW4gCisgICAgICAgIHRocmVhZCBhY2Nlc3MgdG8gaXQgdW50aWwgdGhlIHdyaXRlcyhpbXBv cnRpbmcgaXRlbXMpIG9mIHN0b3JhZ2UgdGhyZWFkIGlzIGRvbmUuCisKKyAgICAgICAgSW4gcjI0 ODczNCB3ZSBpbnRyb2R1Y2VkIGEgbmV3IGNhc2Ugd2hlcmUgdGhlIG1haW4gdGhyZWFkIGNvdWxk IG1vZGlmeSBtX3N0b3JhZ2VNYXAgZm9yIHNlc3Npb24gY2hhbmdlLCBidXQgd2UgCisgICAgICAg IGRpZG4ndCBhZGQgdGhlIHdhaXQgdGhlcmUuCisKKyAgICAgICAgKiBTdG9yYWdlL1N0b3JhZ2VB cmVhSW1wbC5jcHA6CisgICAgICAgIChXZWJLaXQ6OlN0b3JhZ2VBcmVhSW1wbDo6aW1wb3J0SXRl bXMpOgorICAgICAgICAoV2ViS2l0OjpTdG9yYWdlQXJlYUltcGw6OnNlc3Npb25DaGFuZ2VkKToK KwogMjAyMC0wMS0wMyAgU2ltb24gRnJhc2VyICA8c2ltb24uZnJhc2VyQGFwcGxlLmNvbT4KIAog ICAgICAgICBBZGQgc29tZSBzaGFyZWQgc2NoZW1lcyB0byB0aGUgV2ViS2l0Lnhjd29ya3NwYWNl CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0TGVnYWN5L1N0b3JhZ2UvU3RvcmFnZUFyZWFJbXBs LmNwcCBiL1NvdXJjZS9XZWJLaXRMZWdhY3kvU3RvcmFnZS9TdG9yYWdlQXJlYUltcGwuY3BwCmlu ZGV4IDQyY2M0ZGJkMDM5ZWM3MzU5MmM0NzYwZmNhZTFiYjhkNjgzZGM5OTQuLmU2NTM2NzllOTU2 OTZhY2ViODMxNDNkYjkzODIyM2MzMjUyYjBiZjQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXRM ZWdhY3kvU3RvcmFnZS9TdG9yYWdlQXJlYUltcGwuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXRMZWdh Y3kvU3RvcmFnZS9TdG9yYWdlQXJlYUltcGwuY3BwCkBAIC0xOTcsNiArMTk3LDcgQEAgYm9vbCBT dG9yYWdlQXJlYUltcGw6OmNvbnRhaW5zKGNvbnN0IFN0cmluZyYga2V5KQogdm9pZCBTdG9yYWdl QXJlYUltcGw6OmltcG9ydEl0ZW1zKEhhc2hNYXA8U3RyaW5nLCBTdHJpbmc+JiYgaXRlbXMpCiB7 CiAgICAgQVNTRVJUKCFtX2lzU2h1dGRvd24pOworICAgIEFTU0VSVCghaXNNYWluVGhyZWFkKCkp OwogCiAgICAgbV9zdG9yYWdlTWFwLT5pbXBvcnRJdGVtcyhXVEZNb3ZlKGl0ZW1zKSk7CiB9CkBA IC0yOTYsNiArMjk3LDkgQEAgdm9pZCBTdG9yYWdlQXJlYUltcGw6OnNlc3Npb25DaGFuZ2VkKGJv b2wgaXNOZXdTZXNzaW9uUGVyc2lzdGVudCkKIHsKICAgICBBU1NFUlQoaXNNYWluVGhyZWFkKCkp OwogCisgICAgLy8gSWYgaW1wb3J0IGlzIG5vdCBjb21wbGV0ZWQsIGJhY2tncm91bmQgc3RvcmFn ZSB0aHJlYWQgbWF5IGJlIG1vZGlmeWluZyBtX3N0b3JhZ2VNYXAuCisgICAgYmxvY2tVbnRpbElt cG9ydENvbXBsZXRlKCk7CisKICAgICB1bnNpZ25lZCBxdW90YSA9IG1fc3RvcmFnZU1hcC0+cXVv dGEoKTsKICAgICBtX3N0b3JhZ2VNYXAgPSBTdG9yYWdlTWFwOjpjcmVhdGUocXVvdGEpOwogCg==