205753 2020-01-03 15:37:36 -0800 The "ITP Database Backend" flag is not working correctly 2020-01-13 12:59:19 -0800 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED DUPLICATE 205844 InRadar P2 Normal --- 1 katherine_cheney katherine_cheney bfulgham dino webkit-bug-importer wilander oldest_to_newest 1602618 0 katherine_cheney 2020-01-03 15:37:36 -0800 Since being turned on-by-default, the ITP Database flag has stopped working correctly. 1602619 1 webkit-bug-importer 2020-01-03 15:38:58 -0800 <rdar://problem/58309011> 1602657 2 386730 katherine_cheney 2020-01-03 16:49:34 -0800 Created attachment 386730 Patch 1602893 3 386730 dino 2020-01-05 14:40:34 -0800 Comment on attachment 386730 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=386730&action=review > Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm:402 > + if (!isITPDatabaseEnabledValue) > + parameters.shouldEnableITPDatabase = m_defaultPageGroup->preferences().isITPDatabaseEnabled(); > + else > + parameters.shouldEnableITPDatabase = isITPDatabaseEnabledValue.boolValue; I think this conditional should be reversed. i.e. if the value from user prefs exists, use it, otherwise go to the page group defaults. 1603054 4 katherine_cheney 2020-01-06 08:41:17 -0800 (In reply to Dean Jackson from comment #3) > Comment on attachment 386730 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=386730&action=review > > > Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm:402 > > + if (!isITPDatabaseEnabledValue) > > + parameters.shouldEnableITPDatabase = m_defaultPageGroup->preferences().isITPDatabaseEnabled(); > > + else > > + parameters.shouldEnableITPDatabase = isITPDatabaseEnabledValue.boolValue; > > I think this conditional should be reversed. i.e. if the value from user > prefs exists, use it, otherwise go to the page group defaults. I agree, that order is more readable. I'll change it before landing. These api test failures also look concerning, I'll investigate. 1606005 5 katherine_cheney 2020-01-13 12:58:50 -0800 this was fixed (along with the failing api tests) in https://bugs.webkit.org/show_bug.cgi?id=205844 1606006 6 katherine_cheney 2020-01-13 12:59:19 -0800 *** This bug has been marked as a duplicate of bug 205844 *** 386730 2020-01-03 16:49:34 -0800 2020-01-13 12:58:38 -0800 Patch bug-205753-20200103164933.patch text/plain 6069 katherine_cheney U3VidmVyc2lvbiBSZXZpc2lvbjogMjU0MDE5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYWI3NDRjMDBhZTQ1MjQ4 NjhjNzRmMWVjNzQ0ZTJiYzEyZDczOTE4Ny4uOGM3NDY2NzQ2MzEwMDEzMjUxNTIyNzY4NjlkODUx OTFjNmU1ZGYxYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDIwLTAxLTAzICBLYXRl IENoZW5leSAgPGthdGhlcmluZV9jaGVuZXlAYXBwbGUuY29tPgorCisgICAgICAgIFRoZSAiSVRQ IERhdGFiYXNlIEJhY2tlbmQiIGZsYWcgaXMgbm90IHdvcmtpbmcgY29ycmVjdGx5CisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDU3NTMKKyAgICAgICAg PHJkYXI6Ly9wcm9ibGVtLzU4MzA5MDExPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIFRoZSBpc0lUUERhdGFiYXNlRW5hYmxlZCBib29sIGluIFJ1bnRp bWVFbmFibGVkRmVhdHVyZXMKKyAgICAgICAgbmV2ZXIgc2VlbXMgdG8gYmUgdXNlZC4gVGhpcyBw YXRjaCByZW1vdmVzIHRoaXMgYm9vbGVhbiBmcm9tCisgICAgICAgIFJ1bnRpbWVFbmFibGVkRmVh dHVyZXMgYW5kIGFkZHMgaXQgdG8gU2V0dGluZ3MueWFtbCB3aXRoIG90aGVyIElUUAorICAgICAg ICBEZWJ1ZyBtZW51IGZlYXR1cmVzLgorCisgICAgICAgICogcGFnZS9SdW50aW1lRW5hYmxlZEZl YXR1cmVzLmg6CisgICAgICAgIChXZWJDb3JlOjpSdW50aW1lRW5hYmxlZEZlYXR1cmVzOjpzZXRJ c0lUUERhdGFiYXNlRW5hYmxlZCk6IERlbGV0ZWQuCisgICAgICAgIChXZWJDb3JlOjpSdW50aW1l RW5hYmxlZEZlYXR1cmVzOjppc0lUUERhdGFiYXNlRW5hYmxlZCBjb25zdCk6IERlbGV0ZWQuCisg ICAgICAgICogcGFnZS9TZXR0aW5ncy55YW1sOgorCiAyMDIwLTAxLTAzICBQZW5nIExpdSAgPHBl bmcubGl1NkBhcHBsZS5jb20+CiAKICAgICAgICAgVXBkYXRlIHRoZSBSZW1vdGVNZWRpYVBsYXll ck1hbmFnZXJQcm94eTo6TG9hZCBYUEMgbWVzc2FnZSB0byBwcm92aWRlIHRoZSB1cGRhdGVkIFJl bW90ZU1lZGlhUGxheWVyQ29uZmlndXJhdGlvbiB0byB0aGUgd2ViIHByb2Nlc3MKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9DaGFuZ2VMb2cKaW5k ZXggMmEzM2M5NWNjYjM5MDNmODhkNGI1YmNjOGYxZjUzMTJlNmI3NzMzNi4uNDRmYTQwOWEzNTk4 M2RjOTI2YmZiNjUzNDhhNmVkZTk2YTUyMjQ4YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9D aGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyNCBAQAor MjAyMC0wMS0wMyAgS2F0ZSBDaGVuZXkgIDxrYXRoZXJpbmVfY2hlbmV5QGFwcGxlLmNvbT4KKwor ICAgICAgICBUaGUgIklUUCBEYXRhYmFzZSBCYWNrZW5kIiBmbGFnIGlzIG5vdCB3b3JraW5nIGNv cnJlY3RseQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MjA1NzUzCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS81ODMwOTAxMT4KKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBTaW5jZSBiZWluZyBvbi1ieS1kZWZh dWx0LCB0aGUgSVRQIERhdGFiYXNlIEJhY2tlbmQgZmxhZywgd2hlbgorICAgICAgICBlbmFibGVk LCB3YXMgbm90IHNob3dpbmcgdXAgaW4gdGhlIGRlZmF1bHRzIG1lbnUuIFRoaXMgd2FzIGNhdXNp bmcKKyAgICAgICAgdGhlIHVzZXIgZGVmYXVsdHMgbG9va3VwIHRvIHJldHVybiBhIHZhbHVlIG9m IDAsIGZhaWxpbmcgdG8gdHJpZ2dlciB0aGUKKyAgICAgICAgSVRQIGRhdGFiYXNlIGJhY2tlbmQu CisKKyAgICAgICAgVGhpcyBwYXRjaCBmaXJzdCBjaGVja3MgaWYgdGhlIHZhbHVlIGFwcGVhcnMg aW4gdGhlIGRlZmF1bHRzIG9iamVjdC4KKyAgICAgICAgSWYgbm90LCBpdCByZXR1cm5zIHRoZSBk ZWZhdWx0IFdlYiBQcmVmZXJlbmNlcyB2YWx1ZSwgb3RoZXJ3aXNlLCAKKyAgICAgICAgaXQgcmV0 dXJucyB0aGUgdmFsdWUgc3RvcmVkIGluIHRoZSBkZWZhdWx0cyBvYmplY3QuCisKKyAgICAgICAg KiBTaGFyZWQvV2ViUHJlZmVyZW5jZXMueWFtbDoKKyAgICAgICAgKiBVSVByb2Nlc3MvQ29jb2Ev V2ViUHJvY2Vzc1Bvb2xDb2NvYS5tbToKKyAgICAgICAgKFdlYktpdDo6V2ViUHJvY2Vzc1Bvb2w6 OnBsYXRmb3JtSW5pdGlhbGl6ZU5ldHdvcmtQcm9jZXNzKToKKwogMjAyMC0wMS0wMyAgUGVuZyBM aXUgIDxwZW5nLmxpdTZAYXBwbGUuY29tPgogCiAgICAgICAgIFVwZGF0ZSB0aGUgUmVtb3RlTWVk aWFQbGF5ZXJNYW5hZ2VyUHJveHk6OkxvYWQgWFBDIG1lc3NhZ2UgdG8gcHJvdmlkZSB0aGUgdXBk YXRlZCBSZW1vdGVNZWRpYVBsYXllckNvbmZpZ3VyYXRpb24gdG8gdGhlIHdlYiBwcm9jZXNzCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL1J1bnRpbWVFbmFibGVkRmVhdHVyZXMuaCBi L1NvdXJjZS9XZWJDb3JlL3BhZ2UvUnVudGltZUVuYWJsZWRGZWF0dXJlcy5oCmluZGV4IDYwYjc1 Njg1NTg4NWFlYmU3NmIyM2FmMTNjMDI4OGE4MjMzOTQ0ODAuLmFhMWQ0MmE5MDA3N2EwYWEyYzNm ZTFmZTZiODU4NGY5YmY2ZTEyMDUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvUnVu dGltZUVuYWJsZWRGZWF0dXJlcy5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvUnVudGltZUVu YWJsZWRGZWF0dXJlcy5oCkBAIC0xNDksOSArMTQ5LDYgQEAgcHVibGljOgogICAgIHZvaWQgc2V0 SXRwRGVidWdNb2RlRW5hYmxlZChib29sIGlzRW5hYmxlZCkgeyBtX2l0cERlYnVnTW9kZSA9IGlz RW5hYmxlZDsgfQogICAgIGJvb2wgaXRwRGVidWdNb2RlRW5hYmxlZCgpIGNvbnN0IHsgcmV0dXJu IG1faXRwRGVidWdNb2RlOyB9CiAKLSAgICB2b2lkIHNldElzSVRQRGF0YWJhc2VFbmFibGVkKGJv b2wgaXNFbmFibGVkKSB7IG1faXNJVFBEYXRhYmFzZUVuYWJsZWQgPSBpc0VuYWJsZWQ7IH0KLSAg ICBib29sIGlzSVRQRGF0YWJhc2VFbmFibGVkKCkgY29uc3QgeyByZXR1cm4gbV9pc0lUUERhdGFi YXNlRW5hYmxlZDsgfQotCiAgICAgdm9pZCBzZXRSZXN0cmljdGVkSFRUUFJlc3BvbnNlQWNjZXNz KGJvb2wgaXNFbmFibGVkKSB7IG1faXNSZXN0cmljdGVkSFRUUFJlc3BvbnNlQWNjZXNzID0gaXNF bmFibGVkOyB9CiAgICAgYm9vbCByZXN0cmljdGVkSFRUUFJlc3BvbnNlQWNjZXNzKCkgY29uc3Qg eyByZXR1cm4gbV9pc1Jlc3RyaWN0ZWRIVFRQUmVzcG9uc2VBY2Nlc3M7IH0KIApAQCAtNTcyLDgg KzU2OSw2IEBAIHByaXZhdGU6CiAgICAgT3B0aW9uYWw8Ym9vbD4gbV90b3VjaEV2ZW50c0VuYWJs ZWQ7CiAjZW5kaWYKIAotICAgIGJvb2wgbV9pc0lUUERhdGFiYXNlRW5hYmxlZCB7IHRydWUgfTsK LQogICAgIGJvb2wgbV9yZWZlcnJlclBvbGljeUF0dHJpYnV0ZUVuYWJsZWQgeyBmYWxzZSB9Owog ICAgIGJvb2wgbV9pbnRlcnJ1cHRBdWRpb09uUGFnZVZpc2liaWxpdHlDaGFuZ2VFbmFibGVkIHsg ZmFsc2UgfTsKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGFnZS9TZXR0aW5ncy55YW1s IGIvU291cmNlL1dlYkNvcmUvcGFnZS9TZXR0aW5ncy55YW1sCmluZGV4IDZkNTljMjlkNWZlMDQy MThlYTg1Mzk5MGMzYzZiN2RhNWRiOGRiZDIuLmI0OWVhZDM0N2EzZjc3ODEzYWJiNTA2N2FiMDBi MDBhNjYwZDZiNjAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvU2V0dGluZ3MueWFt bAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL1NldHRpbmdzLnlhbWwKQEAgLTkxMSw2ICs5MTEs OSBAQCBsZWdhY3lHZXRVc2VyTWVkaWFFbmFibGVkOgogaXNJbkFwcEJyb3dzZXJQcml2YWN5RW5h YmxlZDoKICAgaW5pdGlhbDogZmFsc2UKIAoraXNJVFBEYXRhYmFzZUVuYWJsZWQ6CisgIGluaXRp YWw6IHRydWUKKwogIyBEZXByZWNhdGVkCiAKIGljZUNhbmRpZGF0ZUZpbHRlcmluZ0VuYWJsZWQ6 CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1NoYXJlZC9XZWJQcmVmZXJlbmNlcy55YW1sIGIv U291cmNlL1dlYktpdC9TaGFyZWQvV2ViUHJlZmVyZW5jZXMueWFtbAppbmRleCA0ODAxODQ3ZGM5 ZTM1OWJiZmQ2YzVkNDNiZjc1YzNjNGM4YTU0MGQ3Li5mNTdhZjRkZTAyMTIzNzA0ZjAwOTkxYjM1 ZDhmYjU2NTcyN2VhMGVjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1NoYXJlZC9XZWJQcmVm ZXJlbmNlcy55YW1sCisrKyBiL1NvdXJjZS9XZWJLaXQvU2hhcmVkL1dlYlByZWZlcmVuY2VzLnlh bWwKQEAgLTE1MjksNyArMTUyOSw2IEBAIElzSVRQRGF0YWJhc2VFbmFibGVkOgogICBkZWZhdWx0 VmFsdWU6IHRydWUKICAgaHVtYW5SZWFkYWJsZU5hbWU6ICJJVFAgRGF0YWJhc2UgQmFja2VuZCIK ICAgaHVtYW5SZWFkYWJsZURlc2NyaXB0aW9uOiAiRW5hYmxlIEludGVsbGlnZW50IFRyYWNraW5n IFByZXZlbnRpb24gRGF0YWJhc2UgQmFja2VuZCIKLSAgd2ViY29yZUJpbmRpbmc6IFJ1bnRpbWVF bmFibGVkRmVhdHVyZXMKICAgY2F0ZWdvcnk6IGludGVybmFsCiAKIFNlcnZpY2VXb3JrZXJzRW5h YmxlZDoKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0NvY29hL1dlYlByb2Nl c3NQb29sQ29jb2EubW0gYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9Db2NvYS9XZWJQcm9jZXNz UG9vbENvY29hLm1tCmluZGV4IGMyMzJmYTg5YzZiZTBjNGM3NjFmNWU4MTIyZTZjYjE0ZmNkMDE2 NmEuLjM0Y2U4OGEyMzY5MTYwYmQ5YjNhYmVjYmM3ODE4OTMxZGU3ZDJmZTggMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0NvY29hL1dlYlByb2Nlc3NQb29sQ29jb2EubW0KKysr IGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQ29jb2EvV2ViUHJvY2Vzc1Bvb2xDb2NvYS5tbQpA QCAtMzk1LDcgKzM5NSwxMSBAQCB2b2lkIFdlYlByb2Nlc3NQb29sOjpwbGF0Zm9ybUluaXRpYWxp emVOZXR3b3JrUHJvY2VzcyhOZXR3b3JrUHJvY2Vzc0NyZWF0aW9uUGFyYQogICAgIHBhcmFtZXRl cnMuc3RvcmFnZUFjY2Vzc0FQSUVuYWJsZWQgPSBzdG9yYWdlQWNjZXNzQVBJRW5hYmxlZCgpOwog ICAgIHBhcmFtZXRlcnMuc3VwcHJlc3Nlc0Nvbm5lY3Rpb25UZXJtaW5hdGlvbk9uU3lzdGVtQ2hh bmdlID0gbV9jb25maWd1cmF0aW9uLT5zdXBwcmVzc2VzQ29ubmVjdGlvblRlcm1pbmF0aW9uT25T eXN0ZW1DaGFuZ2UoKTsKIAotICAgIHBhcmFtZXRlcnMuc2hvdWxkRW5hYmxlSVRQRGF0YWJhc2Ug PSBbZGVmYXVsdHMgYm9vbEZvcktleTpbTlNTdHJpbmcgc3RyaW5nV2l0aEZvcm1hdDpAIkludGVy bmFsRGVidWclQCIsIFdlYlByZWZlcmVuY2VzS2V5Ojppc0lUUERhdGFiYXNlRW5hYmxlZEtleSgp LmNyZWF0ZUNGU3RyaW5nKCkuZ2V0KCldXTsKKyAgICBOU051bWJlciAqaXNJVFBEYXRhYmFzZUVu YWJsZWRWYWx1ZSA9IFtkZWZhdWx0cyBvYmplY3RGb3JLZXk6W05TU3RyaW5nIHN0cmluZ1dpdGhG b3JtYXQ6QCJJbnRlcm5hbERlYnVnJUAiLCBXZWJQcmVmZXJlbmNlc0tleTo6aXNJVFBEYXRhYmFz ZUVuYWJsZWRLZXkoKS5jcmVhdGVDRlN0cmluZygpLmdldCgpXV07CisgICAgaWYgKCFpc0lUUERh dGFiYXNlRW5hYmxlZFZhbHVlKQorICAgICAgICBwYXJhbWV0ZXJzLnNob3VsZEVuYWJsZUlUUERh dGFiYXNlID0gbV9kZWZhdWx0UGFnZUdyb3VwLT5wcmVmZXJlbmNlcygpLmlzSVRQRGF0YWJhc2VF bmFibGVkKCk7CisgICAgZWxzZQorICAgICAgICBwYXJhbWV0ZXJzLnNob3VsZEVuYWJsZUlUUERh dGFiYXNlID0gaXNJVFBEYXRhYmFzZUVuYWJsZWRWYWx1ZS5ib29sVmFsdWU7CiAKICAgICBwYXJh bWV0ZXJzLmVuYWJsZUFkQ2xpY2tBdHRyaWJ1dGlvbkRlYnVnTW9kZSA9IFtkZWZhdWx0cyBib29s Rm9yS2V5OltOU1N0cmluZyBzdHJpbmdXaXRoRm9ybWF0OkAiRXhwZXJpbWVudGFsJUAiLCBXZWJQ cmVmZXJlbmNlc0tleTo6YWRDbGlja0F0dHJpYnV0aW9uRGVidWdNb2RlRW5hYmxlZEtleSgpLmNy ZWF0ZUNGU3RyaW5nKCkuZ2V0KCldXTsKIH0K