205739 2020-01-03 11:15:49 -0800 webgl/1.0.3/conformance/glsl/misc/shader-with-reserved-words.html is timing out on some hardware configurations 2020-03-11 17:12:14 -0700 1 1 1 Unclassified WebKit WebGL WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=205483 InRadar P2 Normal --- 198948 1 tsavell jdarpinian ap commit-queue dino ews-watchlist graouts jdarpinian kbr kondapallykalyan webkit-bot-watchers-bugzilla webkit-bug-importer oldest_to_newest 1602529 0 tsavell 2020-01-03 11:15:49 -0800 webgl/1.0.3/conformance/glsl/misc/shader-with-reserved-words.html Description: This test began failing after r253926. this may just be a rebase History: https://results.webkit.org/?suite=layout-tests&test=webgl%2F1.0.3%2Fconformance%2Fglsl%2Fmisc%2Fshader-with-reserved-words.html Diff: --- /Volumes/Data/slave/catalina-debug-tests-wk2-webgl/build/layout-test-results/webgl/1.0.3/conformance/glsl/misc/shader-with-reserved-words-expected.txt +++ /Volumes/Data/slave/catalina-debug-tests-wk2-webgl/build/layout-test-results/webgl/1.0.3/conformance/glsl/misc/shader-with-reserved-words-actual.txt @@ -1,5 +1,5 @@ -#PID UNRESPONSIVE - WebKitTestRunner (pid 96218) -FAIL: Timed out waiting for notifyDone to be called +This test runs the WebGL Test listed below in an iframe and reports PASS or FAIL. -#EOF -#EOF +Test: ../../../resources/webgl_test_files/conformance/glsl/misc/shader-with-reserved-words.html +[ PASS ] All tests passed + 1602530 1 webkit-bug-importer 2020-01-03 11:16:06 -0800 <rdar://problem/58302584> 1602926 2 ap 2020-01-05 19:33:05 -0800 This is a tricky one, but there is definitely something wrong going on here, both with and without ANGLE. This test is skipped in most configurations, and marked as a flaky timeout in the few configurations where it runs. But it also appears to be skipped on internal bots (although I don't understand how), so we don't have results from different hardware configurations. LayoutTests/TestExpectations:3823:webgl/1.0.3/conformance/glsl/misc/shader-with-reserved-words.html [ Skip ] LayoutTests/platform/mac-wk1/TestExpectations:583:webkit.org/b/170877 [ Debug ] webgl/1.0.3/conformance/glsl/misc/shader-with-reserved-words.html [ Pass Timeout ] LayoutTests/platform/mac/TestExpectations:1728:webkit.org/b/170877 [ Debug ] webgl/1.0.3/conformance/glsl/misc/shader-with-reserved-words.html [ Pass Timeout ] Anyway, this test times out on Mac minis with or without ANGLE. It passes on iMac16,2, also with or without. It presumably timed out in a different way on Dean's iMac Pro (?), making him land this "#PID UNRESPONSIVE" expectation. 1602927 3 ap 2020-01-05 19:34:17 -0800 Reusing this but to track all issues with this test. 1604466 4 jdarpinian 2020-01-08 18:34:32 -0800 I've identified a regression in shader compilation performance with ANGLE enabled, so I will fix that. After fixing the regression the performance should be the same with and without ANGLE, so if it was timing out before then it will probably still timeout. 1615452 5 389921 jdarpinian 2020-02-05 17:49:36 -0800 Created attachment 389921 Optimize disabling ANGLE_texture_rectangle 1615891 6 389921 commit-queue 2020-02-06 15:39:26 -0800 Comment on attachment 389921 Optimize disabling ANGLE_texture_rectangle Clearing flags on attachment: 389921 Committed r255990: <https://trac.webkit.org/changeset/255990> 1615892 7 commit-queue 2020-02-06 15:39:27 -0800 All reviewed patches have been landed. Closing bug. 389921 2020-02-05 17:49:36 -0800 2020-02-06 15:39:26 -0800 Optimize disabling ANGLE_texture_rectangle bug-205739-20200205174936.patch text/plain 2090 jdarpinian U3VidmVyc2lvbiBSZXZpc2lvbjogMjU1NzExCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggY2M5ZWFkZmU5ZTI4ZjQ4 OWNlNDM2OWI5ZTEzNjMwMjY1ZjVkMmQyOS4uMzc5NjFhMDIxZDFhNTJiMTQ4M2M2ZWU3ZDU5NWE2 OWJhNTIyNjY5OCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDIwLTAyLTA1ICBKYW1l cyBEYXJwaW5pYW4gIDxqZGFycGluaWFuQGNocm9taXVtLm9yZz4KKworICAgICAgICB3ZWJnbC8x LjAuMy9jb25mb3JtYW5jZS9nbHNsL21pc2Mvc2hhZGVyLXdpdGgtcmVzZXJ2ZWQtd29yZHMuaHRt bCBpcyB0aW1pbmcgb3V0IG9uIHNvbWUgaGFyZHdhcmUgY29uZmlndXJhdGlvbnMKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwNTczOQorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE9wdGltaXplIGRpc2FibGlu ZyBBTkdMRV90ZXh0dXJlX3JlY3RhbmdsZS4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNz L2FuZ2xlL0dyYXBoaWNzQ29udGV4dEdMQU5HTEUuY3BwOgorICAgICAgICAoV2ViQ29yZTo6R3Jh cGhpY3NDb250ZXh0R0xPcGVuR0w6OmNvbXBpbGVTaGFkZXIpOgorCiAyMDIwLTAyLTA0ICBBZHJp YW4gUGVyZXogZGUgQ2FzdHJvICA8YXBlcmV6QGlnYWxpYS5jb20+CiAKICAgICAgICAgTm9uLXVu aWZpZWQgYnVpbGQgZml4ZXMgZWFybHkgRmVicnVhcnkgMjAyMCBlZGl0aW9uCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9hbmdsZS9HcmFwaGljc0NvbnRleHRH TEFOR0xFLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2FuZ2xlL0dyYXBo aWNzQ29udGV4dEdMQU5HTEUuY3BwCmluZGV4IDhmOWE4MGM2NzExZDc4Y2UxN2I1NWQ1NzBiY2U0 MzMxMDdkYjJlMzIuLmY5NmZjOTViYjZkZTVlZDJjZjNkYTZlMTI5ZTFhNDMyYzcyNGM3YWQgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2FuZ2xlL0dyYXBoaWNz Q29udGV4dEdMQU5HTEUuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNz L2FuZ2xlL0dyYXBoaWNzQ29udGV4dEdMQU5HTEUuY3BwCkBAIC04MjIsMTIgKzgyMiwxMiBAQCB2 b2lkIEdyYXBoaWNzQ29udGV4dEdMT3BlbkdMOjpjb21waWxlU2hhZGVyKFBsYXRmb3JtR0xPYmpl Y3Qgc2hhZGVyKQogewogICAgIEFTU0VSVChzaGFkZXIpOwogICAgIG1ha2VDb250ZXh0Q3VycmVu dCgpOwotICAgIC8vIFdlIG5lZWQgdGhpcyBleHRlbnNpb24gdG8gc3VwcG9ydCBJT1N1cmZhY2Ug YmFja2J1ZmZlcnMsIGJ1dCB3ZQotICAgIC8vIGRvbid0IHdhbnQgaXQgZXhwb3NlZCB0byBXZWJH TCB1c2VyIHNoYWRlcnMuIFRlbXBvcmFyaWx5IGRpc2FibGUKLSAgICAvLyBpdCBkdXJpbmcgc2hh ZGVyIGNvbXBpbGF0aW9uLgotICAgIGdsOjpEaXNhYmxlRXh0ZW5zaW9uQU5HTEUoIkdMX0FOR0xF X3RleHR1cmVfcmVjdGFuZ2xlIik7CisgICAgLy8gV2UgbmVlZCB0aGUgQU5HTEVfdGV4dHVyZV9y ZWN0YW5nbGUgZXh0ZW5zaW9uIHRvIHN1cHBvcnQgSU9TdXJmYWNlCisgICAgLy8gYmFja2J1ZmZl cnMsIGJ1dCB3ZSBkb24ndCB3YW50IGl0IGV4cG9zZWQgdG8gV2ViR0wgdXNlciBzaGFkZXJzLgor ICAgIC8vIFRlbXBvcmFyaWx5IGRpc2FibGUgaXQgZHVyaW5nIHNoYWRlciBjb21waWxhdGlvbi4K KyAgICBnbDo6RGlzYWJsZShHTF9URVhUVVJFX1JFQ1RBTkdMRV9BTkdMRSk7CiAgICAgZ2w6OkNv bXBpbGVTaGFkZXIoc2hhZGVyKTsKLSAgICBnbDo6UmVxdWVzdEV4dGVuc2lvbkFOR0xFKCJHTF9B TkdMRV90ZXh0dXJlX3JlY3RhbmdsZSIpOworICAgIGdsOjpFbmFibGUoR0xfVEVYVFVSRV9SRUNU QU5HTEVfQU5HTEUpOwogfQogCiB2b2lkIEdyYXBoaWNzQ29udGV4dEdMT3BlbkdMOjpjb21waWxl U2hhZGVyRGlyZWN0KFBsYXRmb3JtR0xPYmplY3Qgc2hhZGVyKQo=