205722 2020-01-03 06:49:08 -0800 Allow multiple cmakeargs inside inside envvar 2020-01-08 06:08:17 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 pmatos pmatos clopez commit-queue webkit-bug-importer oldest_to_newest 1602408 0 pmatos 2020-01-03 06:49:08 -0800 Allow multiple cmakeargs inside inside envvar 1602410 1 pmatos 2020-01-03 06:56:36 -0800 webkit-patch upload crashed so will need to do the rest manually. 1602411 2 386679 pmatos 2020-01-03 06:58:07 -0800 Created attachment 386679 Patch 1602413 3 pmatos 2020-01-03 06:59:20 -0800 Currently it is not possible to pass multiple cmakeargs inside a BUILD_JSC_ARGS or BUILD_WEBKIT_ARGS because the split function splits without caring for quoting. Using Text::ParseWords should fix this. 1602429 4 pmatos 2020-01-03 07:44:15 -0800 To reproduce, currently this won't work: $ export BUILD_JSC_ARGS=--cmakeargs="-DENABLE_JIT=OFF -DENABLE_STATIC_JSC=ON" $ Tools/Scripts/build-jsc --release --jsc-only 1602435 5 clopez 2020-01-03 08:04:34 -0800 (In reply to Paulo Matos from comment #4) > To reproduce, currently this won't work: > $ export BUILD_JSC_ARGS=--cmakeargs="-DENABLE_JIT=OFF -DENABLE_STATIC_JSC=ON" > $ Tools/Scripts/build-jsc --release --jsc-only This should work: export BUILD_JSC_ARGS='--cmakeargs="-DENABLE_JIT=OFF" --cmakeargs="-DENABLE_STATIC_JSC=ON"' or simply export BUILD_JSC_ARGS="--cmakeargs=-DENABLE_JIT=OFF --cmakeargs=-DENABLE_STATIC_JSC=ON" Its the same format than we use for BUILD_WEBKIT_ARGS check for example this bot https://build.webkit.org/builders/GTK%20Linux%2064-bit%20Release%20Debian%20Stable%20%28Build%29/builds/28240/steps/compile-webkit/logs/stdio how it exports BUILD_WEBKIT_ARGS="--cmakeargs=-DUSE_GSTREAMER_GL=OFF --cmakeargs=-DUSE_OPENJPEG=OFF --cmakeargs=-DUSE_WPE_RENDERER=OFF" 1602436 6 386679 clopez 2020-01-03 08:04:45 -0800 Comment on attachment 386679 Patch The correct way to use this is to do something like: 1602444 7 pmatos 2020-01-03 08:26:41 -0800 (In reply to Carlos Alberto Lopez Perez from comment #5) > (In reply to Paulo Matos from comment #4) > > To reproduce, currently this won't work: > > $ export BUILD_JSC_ARGS=--cmakeargs="-DENABLE_JIT=OFF -DENABLE_STATIC_JSC=ON" > > $ Tools/Scripts/build-jsc --release --jsc-only > > This should work: > > export BUILD_JSC_ARGS='--cmakeargs="-DENABLE_JIT=OFF" > --cmakeargs="-DENABLE_STATIC_JSC=ON"' > > or simply > > export BUILD_JSC_ARGS="--cmakeargs=-DENABLE_JIT=OFF > --cmakeargs=-DENABLE_STATIC_JSC=ON" > > > Its the same format than we use for BUILD_WEBKIT_ARGS > > check for example this bot > https://build.webkit.org/builders/GTK%20Linux%2064- > bit%20Release%20Debian%20Stable%20%28Build%29/builds/28240/steps/compile- > webkit/logs/stdio how it exports > > BUILD_WEBKIT_ARGS="--cmakeargs=-DUSE_GSTREAMER_GL=OFF > --cmakeargs=-DUSE_OPENJPEG=OFF --cmakeargs=-DUSE_WPE_RENDERER=OFF" Yes - thanks, this works. 1602445 8 pmatos 2020-01-03 08:26:52 -0800 (In reply to Carlos Alberto Lopez Perez from comment #6) > Comment on attachment 386679 [details] > Patch > > The correct way to use this is to do something like: Is this comment incomplete? 1602474 9 clopez 2020-01-03 09:43:04 -0800 (In reply to Paulo Matos from comment #8) > (In reply to Carlos Alberto Lopez Perez from comment #6) > > Comment on attachment 386679 [details] > > Patch > > > > The correct way to use this is to do something like: > > Is this comment incomplete? Yes, sorry... ignore it. 1602980 10 386679 pmatos 2020-01-06 02:41:01 -0800 Comment on attachment 386679 Patch Even though we have a workaround, is there a reason not to merge this? 1603018 11 386679 clopez 2020-01-06 06:24:28 -0800 Comment on attachment 386679 Patch r=me This makes possible passing arguments containing spaces quoted. 1603028 12 386679 commit-queue 2020-01-06 07:11:38 -0800 Comment on attachment 386679 Patch Rejecting attachment 386679 from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 386679, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Logging in as commit-queue@webkit.org... Fetching: https://bugs.webkit.org/attachment.cgi?id=386679&action=edit Fetching: https://bugs.webkit.org/show_bug.cgi?id=205722&ctype=xml&excludefield=attachmentdata Processing 1 patch from 1 bug. Updating working directory Processing patch 386679 from bug 205722. Fetching: https://bugs.webkit.org/attachment.cgi?id=386679 Failed to run "['git', 'svn', 'dcommit', '--rmdir']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Committing to http://svn.webkit.org/repository/webkit/trunk ... M Tools/ChangeLog M Tools/Scripts/build-jsc M Tools/Scripts/build-webkit ERROR from SVN: A repository hook failed: Commit blocked by pre-commit hook (exit code 1) with output: The following files contain tab characters: trunk/Tools/ChangeLog Please use spaces instead to indent. If you must commit a file with tabs, use svn propset to set the "allow-tabs" property. W: d8b917e309bb2edf64e7129559e33711c1034716 and refs/remotes/origin/master differ, using rebase: :040000 040000 3dc7aab04446455aac04105d2a6a2d245ad81de7 d82a4734ada310de3a6e9d7a147a517aa3d867c9 M Tools Current branch master is up to date. ERROR: Not all changes have been committed into SVN, however the committed ones (if any) seem to be successfully integrated into the working tree. Please see the above messages for details. Failed to run "['git', 'svn', 'dcommit', '--rmdir']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Committing to http://svn.webkit.org/repository/webkit/trunk ... M Tools/ChangeLog M Tools/Scripts/build-jsc M Tools/Scripts/build-webkit ERROR from SVN: A repository hook failed: Commit blocked by pre-commit hook (exit code 1) with output: The following files contain tab characters: trunk/Tools/ChangeLog Please use spaces instead to indent. If you must commit a file with tabs, use svn propset to set the "allow-tabs" property. W: d8b917e309bb2edf64e7129559e33711c1034716 and refs/remotes/origin/master differ, using rebase: :040000 040000 3dc7aab04446455aac04105d2a6a2d245ad81de7 d82a4734ada310de3a6e9d7a147a517aa3d867c9 M Tools Current branch master is up to date. ERROR: Not all changes have been committed into SVN, however the committed ones (if any) seem to be successfully integrated into the working tree. Please see the above messages for details. Failed to run "['git', 'svn', 'dcommit', '--rmdir']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Updating OpenSource From https://git.webkit.org/git/WebKit 1e2ca3eb255..ae53adcc5bd master -> origin/master Partial-rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc ... Currently at 254050 = 1e2ca3eb255bca298d704ec2c6cabd71d28a0778 r254051 = ae53adcc5bd6144e77cbef561a9d99db002e5827 Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc First, rewinding head to replay your work on top of it... Fast-forwarded master to refs/remotes/origin/master. Full output: https://webkit-queues.webkit.org/results/13300045 1604053 13 387098 pmatos 2020-01-08 05:44:50 -0800 Created attachment 387098 Patch 1604062 14 387098 commit-queue 2020-01-08 06:07:57 -0800 Comment on attachment 387098 Patch Clearing flags on attachment: 387098 Committed r254196: <https://trac.webkit.org/changeset/254196> 1604063 15 commit-queue 2020-01-08 06:07:58 -0800 All reviewed patches have been landed. Closing bug. 1604064 16 webkit-bug-importer 2020-01-08 06:08:17 -0800 <rdar://problem/58406893> 386679 2020-01-03 06:58:07 -0800 2020-01-08 05:44:46 -0800 Patch bug-205722-20200103155804.patch text/plain 2154 pmatos U3VidmVyc2lvbiBSZXZpc2lvbjogMjUzOTkwCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZTlhMjExNDVkZDUwZWViNDlkYTA3NzZjN2FmM2Y2ZWVi MDQ4YjNjOC4uZGYzNWQwMjhkMzYzZGVmNmY0MTNlZTAzZTViMTg0YmRkYTRhMmY4YiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1 IEBACisyMDIwLTAxLTAzICBQYXVsbyBNYXRvcyAgPHBtYXRvc0BpZ2FsaWEuY29tPgorCisgICAg ICAgIEFsbG93IG11bHRpcGxlIGNtYWtlYXJncyBpbnNpZGUgaW5zaWRlIGVudnZhcgorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjA1NzIyCisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKwlBbGxvdyBzdWItYXJndW1lbnQgbGlz dHMgdG8gYmUgcGFzc2VkIGluIGEgYnVpbGQgZW52aXJvbm1lbnQgdmFyaWFibGUuCisKKyAgICAg ICAgKiBTY3JpcHRzL2J1aWxkLWpzYzoKKyAgICAgICAgKiBTY3JpcHRzL2J1aWxkLXdlYmtpdDoK KwogMjAyMC0wMS0wMiAgQWxleCBDaHJpc3RlbnNlbiAgPGFjaHJpc3RlbnNlbkB3ZWJraXQub3Jn PgogCiAgICAgICAgIEFkZCBTUEkgdG8gZGlzYWJsZSBDT1JTIG9uIHJlcXVlc3RzIHRvIFVSTHMg bWF0Y2hpbmcgYSBwYXR0ZXJuCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL2J1aWxkLWpzYyBi L1Rvb2xzL1NjcmlwdHMvYnVpbGQtanNjCmluZGV4IDBiM2QwZTNjMzE1ODExZGEwZjM4MzlkNTkz MjU0MzMxNzYxN2U5ZjkuLjZjNzM2MGJlZDEyMzk1MDQ4NDFhOWZjNGQ3OTljMDg0NDI0ODU2MzQg MTAwNzU1Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvYnVpbGQtanNjCisrKyBiL1Rvb2xzL1NjcmlwdHMv YnVpbGQtanNjCkBAIC0zNiw2ICszNiw3IEBAIHVzZSBsaWIgJEZpbmRCaW46OkJpbjsKIHVzZSB3 ZWJraXRkaXJzOwogdXNlIHdlYmtpdHBlcmw6OkZlYXR1cmVMaXN0IHF3KGdldEZlYXR1cmVPcHRp b25MaXN0KTsKIHVzZSBQT1NJWDsKK3VzZSBUZXh0OjpQYXJzZVdvcmRzOwogCiBzdWIgd3JpdGVD b25ncmF0cygpOwogCkBAIC02OSw3ICs3MCw3IEBAIGZvcmVhY2ggKEBmZWF0dXJlcykgewogfQog CiAjIEFkZGl0aW9uYWwgZW52aXJvbm1lbnQgcGFyYW1ldGVycwotcHVzaCBAQVJHViwgc3BsaXQo LyAvLCAkRU5WeydCVUlMRF9KU0NfQVJHUyd9KSBpZiAoJEVOVnsnQlVJTERfSlNDX0FSR1MnfSk7 CitwdXNoIEBBUkdWLCBwYXJzZV9saW5lKCdccysnLCAwLCAkRU5WeydCVUlMRF9KU0NfQVJHUyd9 KSBpZiAoJEVOVnsnQlVJTERfSlNDX0FSR1MnfSk7CiAKIG15ICRwcm9ncmFtTmFtZSA9IGJhc2Vu YW1lKCQwKTsKIG15ICR1c2FnZSA9IDw8RU9GOwpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy9i dWlsZC13ZWJraXQgYi9Ub29scy9TY3JpcHRzL2J1aWxkLXdlYmtpdAppbmRleCBkOTZhMDFiY2Rh YjllNDU0ZjNkZmUzYjk0ZWJkMDM4OWNkODhiZDFiLi5mYzA2NjRhNjUwNTU0NmY0MjhjNzUxNGI5 Njc1MTE5Yjc1YTYyMTQwIDEwMDc1NQotLS0gYS9Ub29scy9TY3JpcHRzL2J1aWxkLXdlYmtpdAor KysgYi9Ub29scy9TY3JpcHRzL2J1aWxkLXdlYmtpdApAQCAtNDQsNiArNDQsNyBAQCB1c2Ugd2Vi a2l0ZGlyczsKIHVzZSBMaXN0OjpVdGlsIHF3KGZpcnN0KTsKIHVzZSB3ZWJraXRwZXJsOjpGZWF0 dXJlTGlzdCBxdyhnZXRGZWF0dXJlT3B0aW9uTGlzdCk7CiB1c2UgUE9TSVg7Cit1c2UgVGV4dDo6 UGFyc2VXb3JkczsKIAogc3ViIHdyaXRlQ29uZ3JhdHMoKTsKIApAQCAtODIsNyArODMsNyBAQCBt eSAkdXNlQ0NhY2hlID0gLTE7CiBteSBAZmVhdHVyZXMgPSBnZXRGZWF0dXJlT3B0aW9uTGlzdCgp OwogCiAjIEFkZGl0aW9uYWwgZW52aXJvbm1lbnQgcGFyYW1ldGVycwotcHVzaCBAQVJHViwgc3Bs aXQoLyAvLCAkRU5WeydCVUlMRF9XRUJLSVRfQVJHUyd9KSBpZiAoJEVOVnsnQlVJTERfV0VCS0lU X0FSR1MnfSk7CitwdXNoIEBBUkdWLCBwYXJzZV9saW5lKCdccysnLCAwLCAkRU5WeydCVUlMRF9X RUJLSVRfQVJHUyd9KSBpZiAoJEVOVnsnQlVJTERfV0VCS0lUX0FSR1MnfSk7CiAKICMgSW5pdGlh bGl6ZSB2YWx1ZXMgZnJvbSBkZWZhdWx0cwogZm9yZWFjaCAoQEFSR1YpIHsK 387098 2020-01-08 05:44:50 -0800 2020-01-08 06:07:57 -0800 Patch bug-205722-20200108144446.patch text/plain 2150 pmatos U3VidmVyc2lvbiBSZXZpc2lvbjogMjU0MTEzCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggOWEyN2NmZGQyMGZjYjllNDY0NDQ1MzRlNDBhNGE2OGM1 OWVmNTg3MS4uZmM2NmIxMTY1ZjFkMTUyZDE3MzU1MjY4Y2ViOWVkNjgzNzBiNTczYyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1 IEBACisyMDIwLTAxLTA4ICBQYXVsbyBNYXRvcyAgPHBtYXRvc0BpZ2FsaWEuY29tPgorCisgICAg ICAgIEFsbG93IG11bHRpcGxlIGNtYWtlYXJncyBpbnNpZGUgaW5zaWRlIGVudnZhcgorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjA1NzIyCisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgQ2FybG9zIEFsYmVydG8gTG9wZXogUGVyZXouCisKKyAgICAgICAgQWxs b3cgc3ViLWFyZ3VtZW50IGxpc3RzIHRvIGJlIHBhc3NlZCBpbiBhIGJ1aWxkIGVudmlyb25tZW50 IHZhcmlhYmxlLgorCisgICAgICAgICogU2NyaXB0cy9idWlsZC1qc2M6CisgICAgICAgICogU2Ny aXB0cy9idWlsZC13ZWJraXQ6CisKIDIwMjAtMDEtMDYgIEpvbmF0aGFuIEJlZGFyZCAgPGpiZWRh cmRAYXBwbGUuY29tPgogCiAgICAgICAgIHJlc3VsdHMud2Via2l0Lm9yZzogVHdlYWsgcHJvY2Vz c2luZyBjb25zdGFudHMKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvYnVpbGQtanNjIGIvVG9v bHMvU2NyaXB0cy9idWlsZC1qc2MKaW5kZXggMGIzZDBlM2MzMTU4MTFkYTBmMzgzOWQ1OTMyNTQz MzE3NjE3ZTlmOS4uNmM3MzYwYmVkMTIzOTUwNDg0MWE5ZmM0ZDc5OWMwODQ0MjQ4NTYzNCAxMDA3 NTUKLS0tIGEvVG9vbHMvU2NyaXB0cy9idWlsZC1qc2MKKysrIGIvVG9vbHMvU2NyaXB0cy9idWls ZC1qc2MKQEAgLTM2LDYgKzM2LDcgQEAgdXNlIGxpYiAkRmluZEJpbjo6QmluOwogdXNlIHdlYmtp dGRpcnM7CiB1c2Ugd2Via2l0cGVybDo6RmVhdHVyZUxpc3QgcXcoZ2V0RmVhdHVyZU9wdGlvbkxp c3QpOwogdXNlIFBPU0lYOwordXNlIFRleHQ6OlBhcnNlV29yZHM7CiAKIHN1YiB3cml0ZUNvbmdy YXRzKCk7CiAKQEAgLTY5LDcgKzcwLDcgQEAgZm9yZWFjaCAoQGZlYXR1cmVzKSB7CiB9CiAKICMg QWRkaXRpb25hbCBlbnZpcm9ubWVudCBwYXJhbWV0ZXJzCi1wdXNoIEBBUkdWLCBzcGxpdCgvIC8s ICRFTlZ7J0JVSUxEX0pTQ19BUkdTJ30pIGlmICgkRU5WeydCVUlMRF9KU0NfQVJHUyd9KTsKK3B1 c2ggQEFSR1YsIHBhcnNlX2xpbmUoJ1xzKycsIDAsICRFTlZ7J0JVSUxEX0pTQ19BUkdTJ30pIGlm ICgkRU5WeydCVUlMRF9KU0NfQVJHUyd9KTsKIAogbXkgJHByb2dyYW1OYW1lID0gYmFzZW5hbWUo JDApOwogbXkgJHVzYWdlID0gPDxFT0Y7CmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL2J1aWxk LXdlYmtpdCBiL1Rvb2xzL1NjcmlwdHMvYnVpbGQtd2Via2l0CmluZGV4IGQ5NmEwMWJjZGFiOWU0 NTRmM2RmZTNiOTRlYmQwMzg5Y2Q4OGJkMWIuLmZjMDY2NGE2NTA1NTQ2ZjQyOGM3NTE0Yjk2NzUx MTliNzVhNjIxNDAgMTAwNzU1Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvYnVpbGQtd2Via2l0CisrKyBi L1Rvb2xzL1NjcmlwdHMvYnVpbGQtd2Via2l0CkBAIC00NCw2ICs0NCw3IEBAIHVzZSB3ZWJraXRk aXJzOwogdXNlIExpc3Q6OlV0aWwgcXcoZmlyc3QpOwogdXNlIHdlYmtpdHBlcmw6OkZlYXR1cmVM aXN0IHF3KGdldEZlYXR1cmVPcHRpb25MaXN0KTsKIHVzZSBQT1NJWDsKK3VzZSBUZXh0OjpQYXJz ZVdvcmRzOwogCiBzdWIgd3JpdGVDb25ncmF0cygpOwogCkBAIC04Miw3ICs4Myw3IEBAIG15ICR1 c2VDQ2FjaGUgPSAtMTsKIG15IEBmZWF0dXJlcyA9IGdldEZlYXR1cmVPcHRpb25MaXN0KCk7CiAK ICMgQWRkaXRpb25hbCBlbnZpcm9ubWVudCBwYXJhbWV0ZXJzCi1wdXNoIEBBUkdWLCBzcGxpdCgv IC8sICRFTlZ7J0JVSUxEX1dFQktJVF9BUkdTJ30pIGlmICgkRU5WeydCVUlMRF9XRUJLSVRfQVJH Uyd9KTsKK3B1c2ggQEFSR1YsIHBhcnNlX2xpbmUoJ1xzKycsIDAsICRFTlZ7J0JVSUxEX1dFQktJ VF9BUkdTJ30pIGlmICgkRU5WeydCVUlMRF9XRUJLSVRfQVJHUyd9KTsKIAogIyBJbml0aWFsaXpl IHZhbHVlcyBmcm9tIGRlZmF1bHRzCiBmb3JlYWNoIChAQVJHVikgewo=