20572 2008-08-29 19:21:53 -0700 Window doesn't get Animation/Transition events unless document is listening 2008-12-05 11:01:35 -0800 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) Mac OS X 10.5 RESOLVED FIXED P2 Normal --- 20571 1 dino dino simon.fraser oldest_to_newest 89769 0 dino 2008-08-29 19:21:53 -0700 We have code that intercepts event listener registration on the document level to make sure we don't fire unnecessary transition and animation events. However, if a listener is only on the window it means the event will never fire. 99575 1 simon.fraser 2008-11-20 18:09:09 -0800 Should the window even get animation events? Is there precedence? 101410 2 dino 2008-12-04 16:21:00 -0800 I did a little research and it seems the window should get these events. However, this is the first time one of the "noisy" events makes sense to be added to the window (others like mutation events aren't turned on). The problem is that the document doesn't register the event type when adding an event listener to the window, the way event target does. It's an easy fix. 101411 3 25756 dino 2008-12-04 16:22:07 -0800 Created attachment 25756 makes sure Window registers event types 101507 4 25756 hyatt 2008-12-05 09:53:04 -0800 Comment on attachment 25756 makes sure Window registers event types r=me 101523 5 dino 2008-12-05 11:01:35 -0800 Committed r39037 M WebCore/dom/Document.cpp M WebCore/ChangeLog M LayoutTests/ChangeLog M LayoutTests/transitions/transition-end-event-window.html 25756 2008-12-04 16:22:07 -0800 2008-12-05 09:53:04 -0800 makes sure Window registers event types events.patch text/plain 2694 dino ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCBjYWYxYjE2Li43M2MwZjRiIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMDgtMTIt MDQgIERlYW4gSmFja3NvbiAgPGRpbm9AYXBwbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorICAgICAgICAKKyAgICAgICAgTm8gbG9uZ2VyIG5lZWQgdG8gYWRk IGEgZmFrZSBsaXN0ZW5lciBvbiBhIGRvY3VtZW50CisgICAgICAgIG5vZGUgaW4gb3JkZXIgdG8g Z2V0IGV2ZW50cyBwYXNzZWQgdXAgdG8gV2luZG93LgorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjA1NzIKKworICAgICAgICAqIHRyYW5zaXRpb25zL3Ry YW5zaXRpb24tZW5kLWV2ZW50LXdpbmRvdy5odG1sOgorCiAyMDA4LTEyLTAzICBHZW9mZnJleSBH YXJlbiAgPGdnYXJlbkBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgT2xpdmVyIEh1 bnQuCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy90cmFuc2l0aW9ucy90cmFuc2l0aW9uLWVuZC1l dmVudC13aW5kb3cuaHRtbCBiL0xheW91dFRlc3RzL3RyYW5zaXRpb25zL3RyYW5zaXRpb24tZW5k LWV2ZW50LXdpbmRvdy5odG1sCmluZGV4IDQyNzUyOTIuLjJiNDJhZTcgMTAwNjQ0Ci0tLSBhL0xh eW91dFRlc3RzL3RyYW5zaXRpb25zL3RyYW5zaXRpb24tZW5kLWV2ZW50LXdpbmRvdy5odG1sCisr KyBiL0xheW91dFRlc3RzL3RyYW5zaXRpb25zL3RyYW5zaXRpb24tZW5kLWV2ZW50LXdpbmRvdy5o dG1sCkBAIC0yOCwxMCArMjgsNiBAQAogICAgIHsKICAgICAgIHZhciBib3hlcyA9IGRvY3VtZW50 LmJvZHkuZ2V0RWxlbWVudHNCeUNsYXNzTmFtZSgnYm94Jyk7CiAgICAgICBmb3IgKHZhciBpID0g MDsgaSA8IGJveGVzLmxlbmd0aDsgKytpKSB7Ci0gICAgICAgIC8vIHdlIGhhdmUgdG8gYXR0YWNo IGFuIGVtcHR5IGhhbmRsZXIgaGVyZSBvdGhlcndpc2UgdGhlIGV2ZW50IGlzbid0Ci0gICAgICAg IC8vIGZpcmVkIChXZWJDb3JlIGxvb2tzIGF0IHRoZSBkb2N1bWVudCB0byBzZWUgaWYgdGhlcmUg YXJlIGFueSBsaXN0ZW5lcnMKLSAgICAgICAgLy8gYW5kIGlnbm9yZXMgdGhlIG9uZSBvbiBXaW5k b3cpIC0gdGhpcyBzaG91bGQgYmUgZml4ZWQKLSAgICAgICAgYm94ZXNbaV0uYWRkRXZlbnRMaXN0 ZW5lcigid2Via2l0VHJhbnNpdGlvbkVuZCIsIGZ1bmN0aW9uICgpIHt9LCBmYWxzZSk7CiAgICAg ICAgIGJveGVzW2ldLnN0eWxlLmxlZnQgPSAnMjAwcHgnOwogICAgICAgfQogICAgICAgCmRpZmYg LS1naXQgYS9XZWJDb3JlL0NoYW5nZUxvZyBiL1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4IDFkN2Y3 ZmQuLjMyMDE2M2IgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1dlYkNvcmUv Q2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMDgtMTItMDQgIERlYW4gSmFja3NvbiAgPGRp bm9AYXBwbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIE1ha2Ugc3VyZSBXaW5kb3cgZXZlbnQgbGlzdGVuZXJzIGFsc28gdGVsbCB0aGUKKyAg ICAgICAgRG9jdW1lbnQgYWJvdXQgdGhlIGV2ZW50IHR5cGUsIHNvIG5vaXN5IGV2ZW50cworICAg ICAgICB3aWxsIGJlIGRpc3BhdGNoZWQgZXZlbiBpZiBub3RoaW5nIGluIHRoZSBkb2N1bWVudAor ICAgICAgICBpcyBsaXN0ZW5pbmcuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0yMDU3MgorCisgICAgICAgICogV2ViQ29yZS54Y29kZXByb2ovcHJvamVj dC5wYnhwcm9qOgorICAgICAgICAqIGRvbS9Eb2N1bWVudC5jcHA6CisgICAgICAgIChXZWJDb3Jl OjpEb2N1bWVudDo6YWRkV2luZG93RXZlbnRMaXN0ZW5lcik6CisKIDIwMDgtMTItMDQgIEVyaWMg U2VpZGVsICA8ZXJpY0B3ZWJraXQub3JnPgogCiAgICAgICAgIE5vIHJldmlldywgYnVpbGQgZml4 IG9ubHkuCmRpZmYgLS1naXQgYS9XZWJDb3JlL2RvbS9Eb2N1bWVudC5jcHAgYi9XZWJDb3JlL2Rv bS9Eb2N1bWVudC5jcHAKaW5kZXggZjcwMjkzZS4uZmY4YWQwNiAxMDA2NDQKLS0tIGEvV2ViQ29y ZS9kb20vRG9jdW1lbnQuY3BwCisrKyBiL1dlYkNvcmUvZG9tL0RvY3VtZW50LmNwcApAQCAtMjc0 OSw2ICsyNzQ5LDcgQEAgdm9pZCBEb2N1bWVudDo6YWRkV2luZG93RXZlbnRMaXN0ZW5lcihjb25z dCBBdG9taWNTdHJpbmcmIGV2ZW50VHlwZSwgUGFzc1JlZlB0cjwKICAgICAvLyBSZW1vdmUgZXhp c3RpbmcgaWRlbnRpY2FsIGxpc3RlbmVyIHNldCB3aXRoIGlkZW50aWNhbCBhcmd1bWVudHMuCiAg ICAgLy8gVGhlIERPTSAyIHNwZWMgc2F5cyB0aGF0ICJkdXBsaWNhdGUgaW5zdGFuY2VzIGFyZSBk aXNjYXJkZWQiIGluIHRoaXMgY2FzZS4KICAgICByZW1vdmVXaW5kb3dFdmVudExpc3RlbmVyKGV2 ZW50VHlwZSwgbGlzdGVuZXIuZ2V0KCksIHVzZUNhcHR1cmUpOworICAgIGFkZExpc3RlbmVyVHlw ZUlmTmVlZGVkKGV2ZW50VHlwZSk7CiAgICAgbV93aW5kb3dFdmVudExpc3RlbmVycy5hcHBlbmQo UmVnaXN0ZXJlZEV2ZW50TGlzdGVuZXI6OmNyZWF0ZShldmVudFR5cGUsIGxpc3RlbmVyLCB1c2VD YXB0dXJlKSk7CiB9CiAK