205710 2020-01-02 21:16:48 -0800 [LFC][IFC] Fix fast/parser/entities-in-html.html 2020-01-03 07:42:43 -0800 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 zalan zalan bfulgham commit-queue koivisto simon.fraser webkit-bug-importer zalan oldest_to_newest 1602332 0 zalan 2020-01-02 21:16:48 -0800 ssia 1602333 1 webkit-bug-importer 2020-01-02 21:17:16 -0800 <rdar://problem/58290731> 1602334 2 386659 zalan 2020-01-02 21:20:49 -0800 Created attachment 386659 Patch 1602385 3 386659 koivisto 2020-01-03 03:23:53 -0800 Comment on attachment 386659 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=386659&action=review > Source/WebCore/layout/inlineformatting/InlineTextItem.cpp:38 > -static inline bool isWhitespaceCharacter(char character, bool preserveNewline) > +static inline bool isWhitespaceCharacter(UChar character, bool preserveNewline) lol 1602409 4 zalan 2020-01-03 06:56:31 -0800 (In reply to Antti Koivisto from comment #3) > Comment on attachment 386659 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=386659&action=review > > > Source/WebCore/layout/inlineformatting/InlineTextItem.cpp:38 > > -static inline bool isWhitespaceCharacter(char character, bool preserveNewline) > > +static inline bool isWhitespaceCharacter(UChar character, bool preserveNewline) > > lol exactly my thoughts. 1602427 5 386659 commit-queue 2020-01-03 07:42:41 -0800 Comment on attachment 386659 Patch Clearing flags on attachment: 386659 Committed r253997: <https://trac.webkit.org/changeset/253997> 1602428 6 commit-queue 2020-01-03 07:42:43 -0800 All reviewed patches have been landed. Closing bug. 386659 2020-01-02 21:20:49 -0800 2020-01-03 07:42:41 -0800 Patch bug-205710-20200102212048.patch text/plain 1395 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMjUzOTc0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMmY2YWU5YWI4MjJjMThk OTYwZGI3YzZkMzY4YWQ3M2U2OGM5MDY2Zi4uNDY5ZTJhMDI1N2VlMjVjOGViMTQzYWUwN2ZhNTBi NjhjZDc0MjJhZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDIwLTAxLTAyICBaYWxh biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgW0xGQ11bSUZDXSBGaXggZmFz dC9wYXJzZXIvZW50aXRpZXMtaW4taHRtbC5odG1sCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDU3MTAKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzU4 MjkwNzMxPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg ICogbGF5b3V0L2lubGluZWZvcm1hdHRpbmcvSW5saW5lVGV4dEl0ZW0uY3BwOgorICAgICAgICAo V2ViQ29yZTo6TGF5b3V0Ojppc1doaXRlc3BhY2VDaGFyYWN0ZXIpOgorCiAyMDIwLTAxLTAyICBa YWxhbiBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CiAKICAgICAgICAgW0xGQ11bSUZDXSBGaXgg ZmFzdC9ydWJ5L3J1YnktanVzdGlmaWNhdGlvbi5odG1sCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS9sYXlvdXQvaW5saW5lZm9ybWF0dGluZy9JbmxpbmVUZXh0SXRlbS5jcHAgYi9Tb3VyY2Uv V2ViQ29yZS9sYXlvdXQvaW5saW5lZm9ybWF0dGluZy9JbmxpbmVUZXh0SXRlbS5jcHAKaW5kZXgg ZTAxOGI1OTEwOTg1YzYwMDRmOGRmNTQ3MzU4MTUyM2NmOTZhNDNjZS4uNjI1Njg4M2ZlMzM5NzI3 MDU1NjNiZWVjMTQwNzMzYTJlZTQ4Mzc1NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvbGF5 b3V0L2lubGluZWZvcm1hdHRpbmcvSW5saW5lVGV4dEl0ZW0uY3BwCisrKyBiL1NvdXJjZS9XZWJD b3JlL2xheW91dC9pbmxpbmVmb3JtYXR0aW5nL0lubGluZVRleHRJdGVtLmNwcApAQCAtMzUsNyAr MzUsNyBAQAogbmFtZXNwYWNlIFdlYkNvcmUgewogbmFtZXNwYWNlIExheW91dCB7CiAKLXN0YXRp YyBpbmxpbmUgYm9vbCBpc1doaXRlc3BhY2VDaGFyYWN0ZXIoY2hhciBjaGFyYWN0ZXIsIGJvb2wg cHJlc2VydmVOZXdsaW5lKQorc3RhdGljIGlubGluZSBib29sIGlzV2hpdGVzcGFjZUNoYXJhY3Rl cihVQ2hhciBjaGFyYWN0ZXIsIGJvb2wgcHJlc2VydmVOZXdsaW5lKQogewogICAgIHJldHVybiBj aGFyYWN0ZXIgPT0gJyAnIHx8IGNoYXJhY3RlciA9PSAnXHQnIHx8IChjaGFyYWN0ZXIgPT0gJ1xu JyAmJiAhcHJlc2VydmVOZXdsaW5lKTsKIH0K