205670 2019-12-31 19:59:50 -0800 Declare some classes as final. 2020-01-01 10:30:21 -0800 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 mark.lam mark.lam commit-queue ews-watchlist keith_miller msaboff saam sam tzagallo webkit-bug-importer oldest_to_newest 1602042 0 mark.lam 2019-12-31 19:59:50 -0800 There are a few "Status" classes, all of whom have static computeFor() methods. All of these classes do not have derived classes, and are independent of each others in terms of inheritance relationships. By explicitly declaring them as final, we can make it clear that a call to any unqualified computeFor() methods must be from the self class, and that external calls to any given computeFor() method qualified with a class name is defined in that class (and is not inherited). This detail may already be known to folks who are familiar with these classes. Declaring them as final helps surface this independence for readers of the code who is not already in the know. 1602045 1 386572 mark.lam 2019-12-31 20:12:27 -0800 Created attachment 386572 proposed patch. 1602077 2 386572 mark.lam 2020-01-01 09:44:25 -0800 Comment on attachment 386572 proposed patch. Thanks for the review. Landing now. 1602083 3 386572 commit-queue 2020-01-01 10:29:41 -0800 Comment on attachment 386572 proposed patch. Clearing flags on attachment: 386572 Committed r253969: <https://trac.webkit.org/changeset/253969> 1602084 4 commit-queue 2020-01-01 10:29:42 -0800 All reviewed patches have been landed. Closing bug. 1602085 5 webkit-bug-importer 2020-01-01 10:30:21 -0800 <rdar://problem/58262538> 386572 2019-12-31 20:12:27 -0800 2020-01-01 10:29:41 -0800 proposed patch. bug-205670.patch text/plain 4320 mark.lam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjUzOTY0KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI5IEBA CisyMDE5LTEyLTMxICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBE ZWNsYXJlIHNvbWUgY2xhc3NlcyBhcyBmaW5hbC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTIwNTY3MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFRoZXJlIGFyZSBhIGZldyAiU3RhdHVzIiBjbGFzc2VzLCBh bGwgb2Ygd2hvbSBoYXZlIHN0YXRpYyBjb21wdXRlRm9yKCkgbWV0aG9kcy4KKyAgICAgICAgQWxs IG9mIHRoZXNlIGNsYXNzZXMgZG8gbm90IGhhdmUgZGVyaXZlZCBjbGFzc2VzLCBhbmQgYXJlIGlu ZGVwZW5kZW50IG9mIGVhY2gKKyAgICAgICAgb3RoZXJzIGluIHRlcm1zIG9mIGluaGVyaXRhbmNl IHJlbGF0aW9uc2hpcHMuICBCeSBleHBsaWNpdGx5IGRlY2xhcmluZyB0aGVtIGFzCisgICAgICAg IGZpbmFsLCB3ZSBjYW4gbWFrZSBpdCBjbGVhciB0aGF0IGEgY2FsbCB0byBhbnkgdW5xdWFsaWZp ZWQgY29tcHV0ZUZvcigpIG1ldGhvZHMKKyAgICAgICAgd2l0aGluIG9uZSBvZiB0aGVzZSBjbGFz c2VzIG11c3QgYmUgZnJvbSB0aGUgc2VsZiBjbGFzcywgYW5kIHRoYXQgZXh0ZXJuYWwgY2FsbHMK KyAgICAgICAgdG8gYW55IGdpdmVuIGNvbXB1dGVGb3IoKSBtZXRob2QgcXVhbGlmaWVkIHdpdGgg YSBjbGFzcyBuYW1lIGlzIGRlZmluZWQgaW4gdGhhdAorICAgICAgICBjbGFzcyAoYW5kIGlzIG5v dCBpbmhlcml0ZWQgZnJvbSBhbm90aGVyIGNsYXNzKS4KKworICAgICAgICBUaGlzIGRldGFpbCBt YXkgYWxyZWFkeSBiZSBrbm93biB0byBmb2xrcyB3aG8gYXJlIGZhbWlsaWFyIHdpdGggdGhlc2Ug Y2xhc3Nlcy4KKyAgICAgICAgRGVjbGFyaW5nIHRoZW0gYXMgZmluYWwgaGVscHMgc3VyZmFjZSB0 aGlzIGluZGVwZW5kZW5jZSBmb3IgcmVhZGVycyBvZiB0aGUgY29kZQorICAgICAgICB3aG8gaXMg bm90IGFscmVhZHkgaW4gdGhlIGtub3cuCisKKyAgICAgICAgKiBieXRlY29kZS9DYWxsTGlua1N0 YXR1cy5oOgorICAgICAgICAqIGJ5dGVjb2RlL0NvbXBsZXhHZXRTdGF0dXMuaDoKKyAgICAgICAg KiBieXRlY29kZS9HZXRCeVN0YXR1cy5oOgorICAgICAgICAqIGJ5dGVjb2RlL0luQnlJZFN0YXR1 cy5oOgorICAgICAgICAqIGJ5dGVjb2RlL0luc3RhbmNlT2ZTdGF0dXMuaDoKKyAgICAgICAgKiBi eXRlY29kZS9QdXRCeUlkU3RhdHVzLmg6CisKIDIwMTktMTItMjAgIERhcmluIEFkbGVyICA8ZGFy aW5AYXBwbGUuY29tPgogCiAgICAgICAgIFRpZHkgYSBiaXQgb2YgU3RyaW5nQnVpbGRlciB1c2Fn ZQpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2J5dGVjb2RlL0NhbGxMaW5rU3RhdHVzLmgK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2J5dGVjb2RlL0NhbGxMaW5rU3Rh dHVzLmgJKHJldmlzaW9uIDI1Mzk2NCkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ieXRlY29k ZS9DYWxsTGlua1N0YXR1cy5oCSh3b3JraW5nIGNvcHkpCkBAIC00MSw3ICs0MSw3IEBAIGNsYXNz IEpTRnVuY3Rpb247CiBjbGFzcyBTdHJ1Y3R1cmU7CiBjbGFzcyBDYWxsTGlua0luZm87CiAKLWNs YXNzIENhbGxMaW5rU3RhdHVzIHsKK2NsYXNzIENhbGxMaW5rU3RhdHVzIGZpbmFsIHsKICAgICBX VEZfTUFLRV9GQVNUX0FMTE9DQVRFRDsKIHB1YmxpYzoKICAgICBDYWxsTGlua1N0YXR1cygpCklu ZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvYnl0ZWNvZGUvQ29tcGxleEdldFN0YXR1cy5oCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ieXRlY29kZS9Db21wbGV4R2V0U3Rh dHVzLmgJKHJldmlzaW9uIDI1Mzk2NCkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ieXRlY29k ZS9Db21wbGV4R2V0U3RhdHVzLmgJKHdvcmtpbmcgY29weSkKQEAgLTY3LDcgKzY3LDcgQEAgY2xh c3MgU3RydWN0dXJlQ2hhaW47CiAvLyAgICAgICAgIGJyZWFrOwogLy8gICAgIH0KIAotY2xhc3Mg Q29tcGxleEdldFN0YXR1cyB7CitjbGFzcyBDb21wbGV4R2V0U3RhdHVzIGZpbmFsIHsKIHB1Ymxp YzoKICAgICBlbnVtIEtpbmQgewogICAgICAgICBTaG91bGRTa2lwLApJbmRleDogU291cmNlL0ph dmFTY3JpcHRDb3JlL2J5dGVjb2RlL0dldEJ5U3RhdHVzLmgKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNl L0phdmFTY3JpcHRDb3JlL2J5dGVjb2RlL0dldEJ5U3RhdHVzLmgJKHJldmlzaW9uIDI1Mzk2NCkK KysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ieXRlY29kZS9HZXRCeVN0YXR1cy5oCSh3b3JraW5n IGNvcHkpCkBAIC00Myw3ICs0Myw3IEBAIGNsYXNzIEpTTW9kdWxlTmFtZXNwYWNlT2JqZWN0Owog Y2xhc3MgTW9kdWxlTmFtZXNwYWNlQWNjZXNzQ2FzZTsKIGNsYXNzIFN0cnVjdHVyZVN0dWJJbmZv OwogCi1jbGFzcyBHZXRCeVN0YXR1cyB7CitjbGFzcyBHZXRCeVN0YXR1cyBmaW5hbCB7CiAgICAg V1RGX01BS0VfRkFTVF9BTExPQ0FURUQ7CiBwdWJsaWM6CiAgICAgZW51bSBTdGF0ZSA6IHVpbnQ4 X3QgewpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2J5dGVjb2RlL0luQnlJZFN0YXR1cy5o Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ieXRlY29kZS9JbkJ5SWRTdGF0 dXMuaAkocmV2aXNpb24gMjUzOTY0KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2J5dGVjb2Rl L0luQnlJZFN0YXR1cy5oCSh3b3JraW5nIGNvcHkpCkBAIC0zOSw3ICszOSw3IEBAIGNsYXNzIEFj Y2Vzc0Nhc2U7CiBjbGFzcyBDb2RlQmxvY2s7CiBjbGFzcyBTdHJ1Y3R1cmVTdHViSW5mbzsKIAot Y2xhc3MgSW5CeUlkU3RhdHVzIHsKK2NsYXNzIEluQnlJZFN0YXR1cyBmaW5hbCB7CiAgICAgV1RG X01BS0VfRkFTVF9BTExPQ0FURUQ7CiBwdWJsaWM6CiAgICAgZW51bSBTdGF0ZSB7CkluZGV4OiBT b3VyY2UvSmF2YVNjcmlwdENvcmUvYnl0ZWNvZGUvSW5zdGFuY2VPZlN0YXR1cy5oCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ieXRlY29kZS9JbnN0YW5jZU9mU3RhdHVzLmgJ KHJldmlzaW9uIDI1Mzk2NCkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ieXRlY29kZS9JbnN0 YW5jZU9mU3RhdHVzLmgJKHdvcmtpbmcgY29weSkKQEAgLTM2LDcgKzM2LDcgQEAgY2xhc3MgQWNj ZXNzQ2FzZTsKIGNsYXNzIENvZGVCbG9jazsKIGNsYXNzIFN0cnVjdHVyZVN0dWJJbmZvOwogCi1j bGFzcyBJbnN0YW5jZU9mU3RhdHVzIHsKK2NsYXNzIEluc3RhbmNlT2ZTdGF0dXMgZmluYWwgewog ICAgIFdURl9NQUtFX0ZBU1RfQUxMT0NBVEVEOwogcHVibGljOgogICAgIGVudW0gU3RhdGUgewpJ bmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2J5dGVjb2RlL1B1dEJ5SWRTdGF0dXMuaAo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvYnl0ZWNvZGUvUHV0QnlJZFN0YXR1cy5o CShyZXZpc2lvbiAyNTM5NjQpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvYnl0ZWNvZGUvUHV0 QnlJZFN0YXR1cy5oCSh3b3JraW5nIGNvcHkpCkBAIC00Miw3ICs0Miw3IEBAIGNsYXNzIFN0cnVj dHVyZVN0dWJJbmZvOwogCiB0eXBlZGVmIEhhc2hNYXA8Q29kZU9yaWdpbiwgU3RydWN0dXJlU3R1 YkluZm8qLCBDb2RlT3JpZ2luQXBwcm94aW1hdGVIYXNoPiBTdHViSW5mb01hcDsKIAotY2xhc3Mg UHV0QnlJZFN0YXR1cyB7CitjbGFzcyBQdXRCeUlkU3RhdHVzIGZpbmFsIHsKICAgICBXVEZfTUFL RV9GQVNUX0FMTE9DQVRFRDsKIHB1YmxpYzoKICAgICBlbnVtIFN0YXRlIHsK