205669 2019-12-31 18:28:01 -0800 Reflect.construct() with a the optional newTarget parameter does not work with DOM constructors 2020-04-17 13:42:21 -0700 1 1 1 Unclassified WebKit Bindings WebKit Nightly Build Unspecified Unspecified RESOLVED DUPLICATE 202599 https://bugs.webkit.org/show_bug.cgi?id=174313 WPTImpact P2 Normal --- 1 sam webkit-unassigned ashvayka cdumez saam ysuzuki oldest_to_newest 1602032 0 386567 sam 2019-12-31 18:28:01 -0800 Created attachment 386567 sub.html Reflect.construct() with a the optional newTarget parameter does not work with DOM constructors, such as DOMParser. For example, given a script with two access to two global objects, mainWindow and childWindow: Whereas this works: var value1 = Reflect.construct(window.String, [], childWindow.String); value.constructor == childWindow.String; this does not: var value1 = Reflect.construct(window.DOMParser, [], childWindow.DOMParser); value.constructor == childWindow.DOMParser; 1602033 1 386568 sam 2019-12-31 18:31:37 -0800 Created attachment 386568 main.html 1602034 2 386569 sam 2019-12-31 18:32:19 -0800 Created attachment 386569 main.html 1602035 3 sam 2019-12-31 18:33:28 -0800 main.html demonstrates the issue. 1602036 4 sam 2019-12-31 18:50:28 -0800 For reference, DOMParser's binding constructor is generated as JSDOMParser.cpp and some relevant lines are: using JSDOMParserConstructor = JSDOMConstructor<JSDOMParser>; template<> EncodedJSValue JSC_HOST_CALL JSDOMParserConstructor::construct(JSGlobalObject* lexicalGlobalObject, CallFrame* callFrame) { VM& vm = lexicalGlobalObject->vm(); auto throwScope = DECLARE_THROW_SCOPE(vm); UNUSED_PARAM(throwScope); auto* castedThis = jsCast<JSDOMParserConstructor*>(callFrame->jsCallee()); ASSERT(castedThis); auto* context = castedThis->scriptExecutionContext(); if (UNLIKELY(!context)) return throwConstructorScriptExecutionContextUnavailableError(*lexicalGlobalObject, throwScope, "DOMParser"); ASSERT(context->isDocument()); auto& document = downcast<Document>(*context); auto object = DOMParser::create(document); return JSValue::encode(toJSNewlyCreated<IDLInterface<DOMParser>>(*lexicalGlobalObject, *castedThis->globalObject(), WTFMove(object))); } 1602040 5 sam 2019-12-31 19:44:37 -0800 My guess, though it has been a while since I did too much in here, is that we should probably be using callFrame->newTarget() in some fashion, probably in place of callFrame->jsCallee() in most places. We'll need to do a bit more digging in the WebIDL spec to figure out which document the DOMParser should be created with, though I suspect it is the document of newTarget. We can test what other browsers do by looking at document.url of a document produced by the constructed DOMParser, as it will match it's owner's url. 1602041 6 386571 sam 2019-12-31 19:57:17 -0800 Created attachment 386571 main.html Updated main.html 1602047 7 sam 2019-12-31 20:21:42 -0800 Looks like Firefox uses the document of the main window. I don't have Chrome installed at the moment to check what it does. 1602797 8 sam 2020-01-04 16:30:26 -0800 This causes failures in http://wpt.live/WebIDL/ecmascript-binding/constructors.html 1629657 9 ashvayka 2020-03-13 09:57:53 -0700 (In reply to Sam Weinig from comment #8) > This causes failures in > http://wpt.live/WebIDL/ecmascript-binding/constructors.html Most of the test cases (except for bound/proxied NewTarget values) are now fixed by https://bugs.webkit.org/show_bug.cgi?id=174313. 1642801 10 ashvayka 2020-04-17 13:42:21 -0700 (In reply to Alexey Shvayka from comment #9) > Most of the test cases (except for bound/proxied NewTarget values) are now > fixed by https://bugs.webkit.org/show_bug.cgi?id=174313. Please follow https://webkit.org/b/202599: it fixes remaining failures. *** This bug has been marked as a duplicate of bug 202599 *** 386567 2019-12-31 18:28:01 -0800 2019-12-31 18:28:01 -0800 sub.html sub.html text/html 75 sam PHNjcmlwdD4KCiAgICBwYXJlbnQuc3RhcnQod2luZG93KQogICAgCjwvc2NyaXB0PgogICAgCjxk aXY+U3ViZnJhbWU8L2Rpdj4K 386568 2019-12-31 18:31:37 -0800 2019-12-31 18:31:56 -0800 main.html main.html text/html 993 sam PHByZSBpZD0ibG9nIj48L3ByZT4KPHNjcmlwdD4KCiAgICBmdW5jdGlvbiBsb2cobXNnKQogICAg ewogICAgICAgIGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCJsb2ciKS5hcHBlbmQobXNnICsgIlxu IikKICAgIH0KCiAgICBmdW5jdGlvbiBzdGFydChjaGlsZFdpbmRvdykKICAgIHsKICAgICAgICBs b2coIlRlc3RpbmcgdmFsdWUxID0gUmVmbGVjdC5jb25zdHJ1Y3Qod2luZG93LlN0cmluZywgW10s IGNoaWxkV2luZG93LlN0cmluZykiKQogICAgICAgIHZhciB2YWx1ZTEgPSBSZWZsZWN0LmNvbnN0 cnVjdCh3aW5kb3cuU3RyaW5nLCBbXSwgY2hpbGRXaW5kb3cuU3RyaW5nKTsKICAgICAgICBpZiAo dmFsdWUxLmNvbnN0cnVjdG9yID09IGNoaWxkV2luZG93LlN0cmluZykgewogICAgICAgICAgICBs b2coIlBBU1M6IHZhbHVlMS5jb25zdHJ1Y3RvciA9PSBjaGlsZFdpbmRvdy5TdHJpbmciKQogICAg ICAgIH0gZWxzZSB7CiAgICAgICAgICAgIGxvZygiRkFJTDogdmFsdWUxLmNvbnN0cnVjdG9yICE9 IGNoaWxkV2luZG93LlN0cmluZyIpCiAgICAgICAgfQoKICAgICAgICBsb2coIlRlc3RpbmcgdmFs dWUyID0gUmVmbGVjdC5jb25zdHJ1Y3Qod2luZG93LkRPTVBhcnNlciwgW10sIGNoaWxkV2luZG93 LkRPTVBhcnNlcikiKQogICAgICAgIHZhciB2YWx1ZTIgPSBSZWZsZWN0LmNvbnN0cnVjdCh3aW5k b3cuRE9NUGFyc2VyLCBbXSwgY2hpbGRXaW5kb3cuRE9NUGFyc2VyKTsKICAgICAgICBpZiAodmFs dWUyLmNvbnN0cnVjdG9yID09IGNoaWxkV2luZG93LkRPTVBhcnNlcikgewogICAgICAgICAgICBs b2coIlBBU1M6IHZhbHVlMi5jb25zdHJ1Y3RvciA9PSBjaGlsZFdpbmRvdy5ET01QYXJzZXIiKQog ICAgICAgIH0gZWxzZSB7CiAgICAgICAgICAgIGxvZygiRkFJTDogdmFsdWUyLmNvbnN0cnVjdG9y ICE9IGNoaWxkV2luZG93LkRPTVBhcnNlciIpCiAgICAgICAgfQoKICAgIH0KCjwvc2NyaXB0Pgo8 aWZyYW1lIHNyYz0ic3ViLmh0bWwiPgoK 386569 2019-12-31 18:32:19 -0800 2019-12-31 19:57:17 -0800 main.html main.html text/html 1051 sam PHByZSBpZD0ibG9nIj48L3ByZT4KPHNjcmlwdD4KCiAgICBmdW5jdGlvbiBsb2cobXNnKQogICAg ewogICAgICAgIGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCJsb2ciKS5hcHBlbmQobXNnICsgIlxu IikKICAgIH0KCiAgICBmdW5jdGlvbiBzdGFydChjaGlsZFdpbmRvdykKICAgIHsKICAgICAgICBs b2coIlRlc3RpbmcgdmFsdWUxID0gUmVmbGVjdC5jb25zdHJ1Y3Qod2luZG93LlN0cmluZywgW10s IGNoaWxkV2luZG93LlN0cmluZykiKQogICAgICAgIHZhciB2YWx1ZTEgPSBSZWZsZWN0LmNvbnN0 cnVjdCh3aW5kb3cuU3RyaW5nLCBbXSwgY2hpbGRXaW5kb3cuU3RyaW5nKTsKICAgICAgICBpZiAo dmFsdWUxLmNvbnN0cnVjdG9yID09IGNoaWxkV2luZG93LlN0cmluZykgewogICAgICAgICAgICBs b2coIlBBU1M6IHZhbHVlMS5jb25zdHJ1Y3RvciA9PSBjaGlsZFdpbmRvdy5TdHJpbmciKQogICAg ICAgIH0gZWxzZSB7CiAgICAgICAgICAgIGxvZygiRkFJTDogdmFsdWUxLmNvbnN0cnVjdG9yICE9 IGNoaWxkV2luZG93LlN0cmluZyIpCiAgICAgICAgfQoKICAgICAgICBsb2coIlRlc3RpbmcgdmFs dWUyID0gUmVmbGVjdC5jb25zdHJ1Y3Qod2luZG93LkRPTVBhcnNlciwgW10sIGNoaWxkV2luZG93 LkRPTVBhcnNlcikiKQogICAgICAgIHZhciB2YWx1ZTIgPSBSZWZsZWN0LmNvbnN0cnVjdCh3aW5k b3cuRE9NUGFyc2VyLCBbXSwgY2hpbGRXaW5kb3cuRE9NUGFyc2VyKTsKICAgICAgICBpZiAodmFs dWUyLmNvbnN0cnVjdG9yID09IGNoaWxkV2luZG93LkRPTVBhcnNlcikgewogICAgICAgICAgICBs b2coIlBBU1M6IHZhbHVlMi5jb25zdHJ1Y3RvciA9PSBjaGlsZFdpbmRvdy5ET01QYXJzZXIiKQog ICAgICAgIH0gZWxzZSB7CiAgICAgICAgICAgIGxvZygiRkFJTDogdmFsdWUyLmNvbnN0cnVjdG9y ICE9IGNoaWxkV2luZG93LkRPTVBhcnNlciIpCiAgICAgICAgfQoKICAgIH0KCjwvc2NyaXB0Pgo8 aWZyYW1lIHNyYz0iaHR0cHM6Ly9idWctMjA1NjY5LWF0dGFjaG1lbnRzLndlYmtpdC5vcmcvYXR0 YWNobWVudC5jZ2k/aWQ9Mzg2NTY3Ij4KCg== 386571 2019-12-31 19:57:17 -0800 2019-12-31 19:57:17 -0800 main.html main.html text/html 1249 sam PHByZSBpZD0ibG9nIj48L3ByZT4KPHNjcmlwdD4KCiAgICBmdW5jdGlvbiBsb2cobXNnKQogICAg ewogICAgICAgIGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCJsb2ciKS5hcHBlbmQobXNnICsgIlxu IikKICAgIH0KCiAgICBmdW5jdGlvbiBzdGFydChjaGlsZFdpbmRvdykKICAgIHsKICAgICAgICBs b2coIlRlc3RpbmcgdmFsdWUxID0gUmVmbGVjdC5jb25zdHJ1Y3Qod2luZG93LlN0cmluZywgW10s IGNoaWxkV2luZG93LlN0cmluZykiKQogICAgICAgIHZhciB2YWx1ZTEgPSBSZWZsZWN0LmNvbnN0 cnVjdCh3aW5kb3cuU3RyaW5nLCBbXSwgY2hpbGRXaW5kb3cuU3RyaW5nKTsKICAgICAgICBpZiAo dmFsdWUxLmNvbnN0cnVjdG9yID09IGNoaWxkV2luZG93LlN0cmluZykgewogICAgICAgICAgICBs b2coIlBBU1M6IHZhbHVlMS5jb25zdHJ1Y3RvciA9PSBjaGlsZFdpbmRvdy5TdHJpbmciKTsKICAg ICAgICB9IGVsc2UgewogICAgICAgICAgICBsb2coIkZBSUw6IHZhbHVlMS5jb25zdHJ1Y3RvciAh PSBjaGlsZFdpbmRvdy5TdHJpbmciKTsKICAgICAgICB9CgogICAgICAgIGxvZygiVGVzdGluZyB2 YWx1ZTIgPSBSZWZsZWN0LmNvbnN0cnVjdCh3aW5kb3cuRE9NUGFyc2VyLCBbXSwgY2hpbGRXaW5k b3cuRE9NUGFyc2VyKSIpCiAgICAgICAgdmFyIHZhbHVlMiA9IFJlZmxlY3QuY29uc3RydWN0KHdp bmRvdy5ET01QYXJzZXIsIFtdLCBjaGlsZFdpbmRvdy5ET01QYXJzZXIpOwogICAgICAgIGlmICh2 YWx1ZTIuY29uc3RydWN0b3IgPT0gY2hpbGRXaW5kb3cuRE9NUGFyc2VyKSB7CiAgICAgICAgICAg IGxvZygiUEFTUzogdmFsdWUyLmNvbnN0cnVjdG9yID09IGNoaWxkV2luZG93LkRPTVBhcnNlciIp OwogICAgICAgICAgICB2YXIgZ2VuZXJhdGVkRG9jdW1lbnQgPSB2YWx1ZTIucGFyc2VGcm9tU3Ry aW5nKCI8ZGl2PkhlbGxvPC9kaXY+IiwgInRleHQvaHRtbCIpOwogICAgICAgICAgICBsb2coIiAg PiBBbmQgdGhlIFVSTCBhc3NvY2lhdGVkIHdpdGggZG9jdW1lbnRzIGNyZWF0ZWQgd2l0aCB0aGlz IERPTVBhcnNlciBpczogIiArIGdlbmVyYXRlZERvY3VtZW50LlVSTCk7CiAgICAgICAgfSBlbHNl IHsKICAgICAgICAgICAgbG9nKCJGQUlMOiB2YWx1ZTIuY29uc3RydWN0b3IgIT0gY2hpbGRXaW5k b3cuRE9NUGFyc2VyIik7CiAgICAgICAgfQoKICAgIH0KCjwvc2NyaXB0Pgo8aWZyYW1lIHNyYz0i aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvYXR0YWNobWVudC5jZ2k/aWQ9Mzg2NTY3Ij4KCg==