205668 2019-12-31 15:07:31 -0800 REGRESSION (r253926): webgl/1.0.3/conformance/rendering/many-draw-calls.html is much slower, times out in debug 2020-03-11 17:12:17 -0700 1 1 1 Unclassified WebKit WebGL WebKit Local Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=205483 https://bugs.webkit.org/show_bug.cgi?id=205412 InRadar P2 Normal --- 198948 1 ap jdarpinian dino ews-watchlist graouts jdarpinian kbr kondapallykalyan mark.lam mlalkaka webkit-bug-importer oldest_to_newest 1602025 0 ap 2019-12-31 15:07:31 -0800 webgl/1.0.3/conformance/rendering/many-draw-calls.html is 2-3x slower after the switch to ANGLE. It now times out nearly every time in debug, but it got much slower in release too. You can see test run time here by toggling "show test times". https://results.webkit.org/?suite=layout-tests&test=webgl%2F1.0.3%2Fconformance%2Frendering%2Fmany-draw-calls.html 1602026 1 webkit-bug-importer 2019-12-31 15:07:40 -0800 <rdar://problem/58257321> 1602027 2 ap 2019-12-31 15:08:41 -0800 Note that test history is somewhat misleading, because there was also an earlier issue on Mojave, bug 205412. The regression is super clear on Catalina. 1602028 3 kbr 2019-12-31 15:13:24 -0800 It's possible that draw call validation formerly done in WebKit and now subsumed by ANGLE simply needs to be #ifdef'd out. 1604832 4 jdarpinian 2020-01-09 13:43:06 -0800 It looks like ANGLE is being compiled with asserts even in release builds, and asserts turn on a very expensive state validation code path. I will look into changing both of these. 1604864 5 387274 jdarpinian 2020-01-09 14:36:33 -0800 Created attachment 387274 ANGLE: Disable asserts in release builds. 1604868 6 ews-watchlist 2020-01-09 14:37:19 -0800 Note that there are important steps to take when updating ANGLE. See http://trac.webkit.org/wiki/UpdatingANGLE 1604938 7 kbr 2020-01-09 17:21:49 -0800 Fantastic work James tracking this down! 1609843 8 dino 2020-01-22 16:27:58 -0800 Committed r254953: <https://trac.webkit.org/changeset/254953> 387274 2020-01-09 14:36:33 -0800 2020-01-22 14:48:16 -0800 ANGLE: Disable asserts in release builds. bug-205668-20200109143632.patch text/plain 1758 jdarpinian U3VidmVyc2lvbiBSZXZpc2lvbjogMjUzOTUzCmRpZmYgLS1naXQgYS9Tb3VyY2UvVGhpcmRQYXJ0 eS9BTkdMRS9DaGFuZ2VMb2cgYi9Tb3VyY2UvVGhpcmRQYXJ0eS9BTkdMRS9DaGFuZ2VMb2cKaW5k ZXggOWU4ZDUxZWEzNjQ0ZWYxN2QyYTNmNGIxNzc3NDVlZjVjNjQwYTRjYi4uMjY4MDc4OTNiZGMz OGIwYjUyZDcyN2I0ZjQxZjViZGNhYmQ0YjA1YiAxMDA2NDQKLS0tIGEvU291cmNlL1RoaXJkUGFy dHkvQU5HTEUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9UaGlyZFBhcnR5L0FOR0xFL0NoYW5nZUxv ZwpAQCAtMSwzICsxLDE1IEBACisyMDIwLTAxLTA5ICBKYW1lcyBEYXJwaW5pYW4gIDxqZGFycGlu aWFuQGNocm9taXVtLm9yZz4KKworICAgICAgICBSRUdSRVNTSU9OIChyMjUzOTI2KTogd2ViZ2wv MS4wLjMvY29uZm9ybWFuY2UvcmVuZGVyaW5nL21hbnktZHJhdy1jYWxscy5odG1sIGlzIG11Y2gg c2xvd2VyLCB0aW1lcyBvdXQgaW4gZGVidWcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTIwNTY2OAorCisgICAgICAgIERpc2FibGUgYXNzZXJ0cyB3aGVu IGNvbXBpbGluZyBBTkdMRSBpbiByZWxlYXNlIG1vZGUgYnkgZGVmaW5pbmcKKyAgICAgICAgTkRF QlVHLgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICog Q29uZmlndXJhdGlvbnMvQU5HTEUueGNjb25maWc6CisKIDIwMTktMTItMjUgIERlYW4gSmFja3Nv biAgPGRpbm9AYXBwbGUuY29tPgogCiAgICAgICAgIFtXZWJHTF0gRW5hYmxlIEFOR0xFIGJ5IGRl ZmF1bHQgZm9yIENvY29hIHBsYXRmb3JtcyAoZXhjZXB0IHNpbXVsYXRvcikKZGlmZiAtLWdpdCBh L1NvdXJjZS9UaGlyZFBhcnR5L0FOR0xFL0NvbmZpZ3VyYXRpb25zL0FOR0xFLnhjY29uZmlnIGIv U291cmNlL1RoaXJkUGFydHkvQU5HTEUvQ29uZmlndXJhdGlvbnMvQU5HTEUueGNjb25maWcKaW5k ZXggOTI0NzVkYzNlYmM3MzM3OWY1ZTRhMjA4YzQ3M2ZhMDc5OTRmZmJmNi4uZmFhOGQ5MmVlZGZk NTJhOTQ2ZDZmZGE1NDVkODQ5YThhMGQwMWJjNiAxMDA2NDQKLS0tIGEvU291cmNlL1RoaXJkUGFy dHkvQU5HTEUvQ29uZmlndXJhdGlvbnMvQU5HTEUueGNjb25maWcKKysrIGIvU291cmNlL1RoaXJk UGFydHkvQU5HTEUvQ29uZmlndXJhdGlvbnMvQU5HTEUueGNjb25maWcKQEAgLTM3LDcgKzM3LDkg QEAgUFVCTElDX0hFQURFUlNfRk9MREVSX1BBVEhfbWFjY2F0YWx5c3QgPSAkKFdLX0FMVEVSTkFU RV9GUkFNRVdPUktTX0RJUikvJChBTkdMRV8KIAogVVNFX0hFQURFUk1BUCA9IE5POwogCi1HQ0Nf UFJFUFJPQ0VTU09SX0RFRklOSVRJT05TID0gTElCR0xFU1YyX0lNUExFTUVOVEFUSU9OIExJQkFO R0xFX0lNUExFTUVOVEFUSU9OIEFOR0xFX0VOQUJMRV9PUEVOR0wgQU5HTEVfRU5BQkxFX0dMU0wg QU5HTEVfRU5BQkxFX0VTU0wgR0xfU0lMRU5DRV9ERVBSRUNBVElPTjsKK0RFQlVHX0RFRklORVNf ZGVidWcgPSA7CitERUJVR19ERUZJTkVTX25vcm1hbCA9IE5ERUJVRzsKK0dDQ19QUkVQUk9DRVNT T1JfREVGSU5JVElPTlMgPSAkKERFQlVHX0RFRklORVNfJChDVVJSRU5UX1ZBUklBTlQpKSBMSUJH TEVTVjJfSU1QTEVNRU5UQVRJT04gTElCQU5HTEVfSU1QTEVNRU5UQVRJT04gQU5HTEVfRU5BQkxF X09QRU5HTCBBTkdMRV9FTkFCTEVfR0xTTCBBTkdMRV9FTkFCTEVfRVNTTCBHTF9TSUxFTkNFX0RF UFJFQ0FUSU9OOwogCiBJTlNUQUxMSERSU19TQ1JJUFRfUEhBU0UgPSBZRVM7CiAK