205667 2019-12-31 14:55:02 -0800 REGRESSION (r253926): webgl/2.0.0/conformance2/buffers/get-buffer-sub-data.html is a flaky failure 2020-05-21 08:26:53 -0700 1 1 1 Unclassified WebKit WebGL WebKit Local Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=205483 InRadar P2 Normal --- 208724 1 ap kbr dino jdarpinian justin_fan kbr webkit-bug-importer oldest_to_newest 1602022 0 ap 2019-12-31 14:55:02 -0800 webgl/2.0.0/conformance2/buffers/get-buffer-sub-data.html became a flaky failure after the switch to ANGLE. https://results.webkit.org/?suite=layout-tests&test=webgl%2F2.0.0%2Fconformance2%2Fbuffers%2Fget-buffer-sub-data.html @@ -29,11 +29,11 @@ [ 26: PASS ] getError was expected value: INVALID_OPERATION : after evaluating: gl.getBufferSubData(gl.ELEMENT_ARRAY_BUFFER, 0, retArray) [ 27: FAIL ] getError expected: INVALID_VALUE. Was INVALID_OPERATION : after evaluating: gl.getBufferSubData(gl.ARRAY_BUFFER, -1, retArray) [ 28: PASS ] getError was expected value: NO_ERROR : after evaluating: gl.getBufferSubData(gl.ARRAY_BUFFER, 0, retArray) -[ 29: PASS ] areArraysEqual(retArray, [0, 0, 0, 0, 0, 0, 0, 0, 0]) is true +[ 29: FAIL ] areArraysEqual(retArray, [0, 0, 0, 0, 0, 0, 0, 0, 0]) should be true. Was false. [ 30: PASS ] getError was expected value: NO_ERROR : after evaluating: gl.getBufferSubData(gl.ARRAY_BUFFER, 0, retArray) [ 31: PASS ] areArraysEqual(retArray, floatArray) is true [ 32: PASS ] getError was expected value: NO_ERROR : after evaluating: gl.getBufferSubData(gl.ARRAY_BUFFER, 0, retArray) [ 33: PASS ] areArraysEqual(retArray, floatArray) is true [ 34: PASS ] successfullyParsed is true -[ FAIL ] 7 failures reported +[ FAIL ] 8 failures reported 1602023 1 webkit-bug-importer 2019-12-31 14:55:13 -0800 <rdar://problem/58257175> 1602580 2 kbr 2020-01-03 14:11:48 -0800 I'll investigate this locally. 1602680 3 kbr 2020-01-03 18:20:16 -0800 Can't reproduce with a built (release) WebKit inside Safari. Will try to reproduce inside the layout test runner. 1605418 4 jdarpinian 2020-01-10 17:13:09 -0800 Can't reproduce on my MacBook Pro or on a MacBookAir7,2 with Intel HD Graphics 6000 and Catalina 10.15.2. I tried running the test standalone and also with the layout test runner along with other tests. 1612299 5 justin_fan 2020-01-28 18:52:59 -0800 I have access to a Catalina mac mini 8,1 for now, but first pass (1000 repeats) hasn't revealed anything yet. 1612333 6 kbr 2020-01-28 23:04:40 -0800 (In reply to Justin Fan from comment #5) > I have access to a Catalina mac mini 8,1 for now, but first pass (1000 > repeats) hasn't revealed anything yet. Thanks for trying. Just to confirm, you're testing with the current version of ANGLE in WebKit, and with USE_ANGLE=1? If running this test in isolation doesn't repro, what about running the entire set of WebGL conformance tests within the layout tests? 1612789 7 justin_fan 2020-01-29 17:48:40 -0800 The last thing I did was run 25 iterations of a giant list of tests that last led up to the flaky failure on one of our bots, and yes, this was with USE_ANGLE=1 :( 1654758 8 kbr 2020-05-20 17:48:55 -0700 Is there any way to tell whether the [ Pass Failure ] expectation for this test can be safely removed? It's likely that the fix for Bug 208724 addressed this flakiness. 1654769 9 ap 2020-05-20 18:46:20 -0700 Indeed, the last failure was right before that fix. The expectation can be removed. 1654770 10 ap 2020-05-20 18:47:01 -0700 History on the bots: https://results.webkit.org/?suite=layout-tests&test=webgl%2F2.0.0%2Fconformance2%2Fbuffers%2Fget-buffer-sub-data.html&recent=false 1654806 11 399935 kbr 2020-05-20 23:08:39 -0700 Created attachment 399935 Patch 1654807 12 kbr 2020-05-20 23:10:06 -0700 Thanks for confirming. I wasn't sure whether the [ Pass Failure ] expectation would mask failures as passes in the bots' history. (Do they show up as warnings?) 1654924 13 399935 ap 2020-05-21 08:22:37 -0700 Comment on attachment 399935 Patch They show up as actual failures in the history, unless you check "Filter expected results" at the right. Thank you for following through on this! 1654927 14 ews-feeder 2020-05-21 08:26:52 -0700 Committed r261997: <https://trac.webkit.org/changeset/261997> All reviewed patches have been landed. Closing bug and clearing flags on attachment 399935. 399935 2020-05-20 23:08:39 -0700 2020-05-21 08:26:52 -0700 Patch bug-205667-20200520230838.patch text/plain 1594 kbr U3VidmVyc2lvbiBSZXZpc2lvbjogMjYxOTg0CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggOTQ0N2FlY2QxNzNiODE2N2M2Zjkw MmUxZjUzNGE3YTc1ZGI0NGY3Zi4uZGMyOTZlMDVmNTQ1OGNkODYyMmQ5YTI2NjEwZGFlNWQ2ODc4 N2FhZiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDIwLTA1LTIwICBLZW5uZXRoIFJ1c3NlbGwg IDxrYnJAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJFR1JFU1NJT04gKHIyNTM5MjYpOiB3ZWJn bC8yLjAuMC9jb25mb3JtYW5jZTIvYnVmZmVycy9nZXQtYnVmZmVyLXN1Yi1kYXRhLmh0bWwgaXMg YSBmbGFreSBmYWlsdXJlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0yMDU2NjcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBSZW1vdmUgZ2V0LWJ1ZmZlci1zdWItZGF0YS5odG1sIHN1cHByZXNzaW9uIHNpbmNl IGl0J3Mgbm93IHBhc3NpbmcKKyAgICAgICAgcmVsaWFibHkuCisKKyAgICAgICAgKiBUZXN0RXhw ZWN0YXRpb25zOgorCiAyMDIwLTA1LTIwICBGdWppaSBIaXJvbm9yaSAgPEhpcm9ub3JpLkZ1amlp QHNvbnkuY29tPgogCiAgICAgICAgIFtXaW5DYWlyb10gVW5yZXZpZXdlZCB0ZXN0IGdhcmRlbmlu ZwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvVGVzdEV4cGVjdGF0aW9ucyBiL0xheW91dFRlc3Rz L1Rlc3RFeHBlY3RhdGlvbnMKaW5kZXggNGEwNGY5MWE1NWNlOGUzNTIxNzNlNGIzZmZmYmFmNDM1 MDMzMzlmMS4uMDBmZWUyNDg2N2NjMmVhYWQxY2Y1NmVhMDEyYzYwZmU2ODJjNGRkMiAxMDA2NDQK LS0tIGEvTGF5b3V0VGVzdHMvVGVzdEV4cGVjdGF0aW9ucworKysgYi9MYXlvdXRUZXN0cy9UZXN0 RXhwZWN0YXRpb25zCkBAIC0zMzE3LDcgKzMzMTcsNiBAQCB3ZWJnbC8yLjAuMC9jb25mb3JtYW5j ZTIvcmVuZGVyaW5nL2NsZWFyLWZ1bmMtYnVmZmVyLXR5cGUtbWF0Y2guaHRtbCBbIFNraXAgXQog d2ViZ2wvMi4wLjAvY29uZm9ybWFuY2UyL3JlbmRlcmJ1ZmZlcnMvbXVsdGlzYW1wbGUtd2l0aC1m dWxsLXNhbXBsZS1jb3VudHMuaHRtbCBbIFBhc3MgRmFpbHVyZSBdCiB3ZWJnbC8yLjAuMC9jb25m b3JtYW5jZS9leHRlbnNpb25zL3dlYmdsLWRyYXctYnVmZmVycy5odG1sIFsgUGFzcyBGYWlsdXJl IF0KIHdlYmdsLzIuMC4wL2NvbmZvcm1hbmNlMi9idWZmZXJzL2J1ZmZlci1kYXRhLWFuZC1idWZm ZXItc3ViLWRhdGEtc3ViLXNvdXJjZS5odG1sIFsgUGFzcyBGYWlsdXJlIF0KLXdlYmdsLzIuMC4w L2NvbmZvcm1hbmNlMi9idWZmZXJzL2dldC1idWZmZXItc3ViLWRhdGEuaHRtbCBbIFBhc3MgRmFp bHVyZSBdCiAKICMgd2Via2l0Lm9yZy9iLzIwODIxMSBBZGRpdGlvbmFsIGluY29uc2l0ZW5jaWVz IGJldHdlZW4gSW50ZWwgYm90cyBhbmQgQU1EIG1hY2hpbmUKIHdlYmdsLzIuMC4wL2NvbmZvcm1h bmNlL2J1ZmZlcnMvYnVmZmVyLXVuaW5pdGlhbGl6ZWQuaHRtbCBbIFBhc3MgRmFpbHVyZSBdCg==