205661 2019-12-31 12:27:38 -0800 [LFC][IFC] Add scrollable overflow rect to Display::LineBox 2019-12-31 14:46:07 -0800 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 zalan zalan bfulgham commit-queue koivisto simon.fraser webkit-bug-importer zalan oldest_to_newest 1602002 0 zalan 2019-12-31 12:27:38 -0800 to support proper layout overflow rect 1602003 1 webkit-bug-importer 2019-12-31 12:27:59 -0800 <rdar://problem/58256282> 1602004 2 386565 zalan 2019-12-31 12:32:12 -0800 Created attachment 386565 Patch 1602005 3 386565 koivisto 2019-12-31 12:40:26 -0800 Comment on attachment 386565 Patch Happy new year r+! 1602006 4 zalan 2019-12-31 12:41:31 -0800 (In reply to Antti Koivisto from comment #3) > Comment on attachment 386565 [details] > Patch > > Happy new year r+! the best r+ 1602020 5 386565 commit-queue 2019-12-31 14:46:06 -0800 Comment on attachment 386565 Patch Clearing flags on attachment: 386565 Committed r253962: <https://trac.webkit.org/changeset/253962> 1602021 6 commit-queue 2019-12-31 14:46:07 -0800 All reviewed patches have been landed. Closing bug. 386565 2019-12-31 12:32:12 -0800 2019-12-31 14:46:06 -0800 Patch bug-205661-20191231123211.patch text/plain 7078 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMjUzOTU4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNDg3YjQ4ODU1OTk4MWJl OTFhYzQzYjBmYWMxZGFjNjhmZDMwMTJlMi4uYWI1YTNmYzE1YzEyOWE4MWRiOGIyMzViOWYyY2M4 NDI3ZjVmYzExZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI1IEBACisyMDE5LTEyLTMxICBaYWxh biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgW0xGQ11bSUZDXSBBZGQgc2Ny b2xsYWJsZSBvdmVyZmxvdyByZWN0IHRvIERpc3BsYXk6OkxpbmVCb3gKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwNTY2MQorICAgICAgICA8cmRhcjov L3Byb2JsZW0vNTgyNTYyODI+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgQ29tcHV0ZSBsYXlvdXQgb3ZlcmZsb3cgcmVjdCB3aGlsZSBjbG9zaW5nIHRo ZSBsaW5lIGFuZCBhZGp1c3RpbmcgdGhlIHJ1c3QgdmVydGljYWxseS4KKworICAgICAgICAqIGxh eW91dC9kaXNwbGF5dHJlZS9EaXNwbGF5SW5saW5lUmVjdC5oOgorICAgICAgICAoV2ViQ29yZTo6 RGlzcGxheTo6SW5saW5lUmVjdDo6c2V0Qm90dG9tKToKKyAgICAgICAgKFdlYkNvcmU6OkRpc3Bs YXk6OklubGluZVJlY3Q6OmV4cGFuZFZlcnRpY2FsbHlUb0NvbnRhaW4pOgorICAgICAgICAqIGxh eW91dC9kaXNwbGF5dHJlZS9EaXNwbGF5TGluZUJveC5oOgorICAgICAgICAoV2ViQ29yZTo6RGlz cGxheTo6TGluZUJveDo6c2Nyb2xsYWJsZU92ZXJmbG93UmVjdCBjb25zdCk6CisgICAgICAgIChX ZWJDb3JlOjpEaXNwbGF5OjpMaW5lQm94Ojpsb2dpY2FsVG9wTGVmdCBjb25zdCk6CisgICAgICAg IChXZWJDb3JlOjpEaXNwbGF5OjpMaW5lQm94OjpzZXRTY3JvbGxhYmxlT3ZlcmZsb3dSZWN0KToK KyAgICAgICAgKiBsYXlvdXQvaW5saW5lZm9ybWF0dGluZy9JbmxpbmVMaW5lQnVpbGRlci5jcHA6 CisgICAgICAgIChXZWJDb3JlOjpMYXlvdXQ6OkxpbmVCdWlsZGVyOjphbGlnbkNvbnRlbnRWZXJ0 aWNhbGx5KToKKyAgICAgICAgKiBsYXlvdXQvaW50ZWdyYXRpb24vTGF5b3V0SW50ZWdyYXRpb25M aW5lTGF5b3V0LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkxheW91dEludGVncmF0aW9uOjpMaW5l TGF5b3V0Ojpjb2xsZWN0T3ZlcmZsb3cpOgorCiAyMDE5LTEyLTMxICBaYWxhbiBCdWp0YXMgIDx6 YWxhbkBhcHBsZS5jb20+CiAKICAgICAgICAgW0xGQ11bSUZDXShSZWdyZXNzaW9uIHIyNTM5MDkp IEZpeCBmYXN0L3RleHQvc2ltcGxlLWxpbmUtd2l0aC1ici5odG1sCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViQ29yZS9sYXlvdXQvZGlzcGxheXRyZWUvRGlzcGxheUlubGluZVJlY3QuaCBiL1NvdXJj ZS9XZWJDb3JlL2xheW91dC9kaXNwbGF5dHJlZS9EaXNwbGF5SW5saW5lUmVjdC5oCmluZGV4IDg4 ZmY4YWQxMTY4ZWI3ZDQ3MGRiZjYxNGM3MzM3ZmRhYWEwNGU0ZDYuLjZkNTNjNmUxMGQ0NzRkZDgx Mzc2OGRkNjQ5N2RkMGYxYmNjZTkzODcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2xheW91 dC9kaXNwbGF5dHJlZS9EaXNwbGF5SW5saW5lUmVjdC5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL2xh eW91dC9kaXNwbGF5dHJlZS9EaXNwbGF5SW5saW5lUmVjdC5oCkBAIC01MCw2ICs1MCw3IEBAIHB1 YmxpYzoKICAgICBJbmxpbmVMYXlvdXRTaXplIHNpemUoKSBjb25zdDsKIAogICAgIHZvaWQgc2V0 VG9wKElubGluZUxheW91dFVuaXQpOworICAgIHZvaWQgc2V0Qm90dG9tKElubGluZUxheW91dFVu aXQpOwogICAgIHZvaWQgc2V0TGVmdChJbmxpbmVMYXlvdXRVbml0KTsKICAgICB2b2lkIHNldFRv cExlZnQoY29uc3QgSW5saW5lTGF5b3V0UG9pbnQmKTsKICAgICB2b2lkIHNldFdpZHRoKElubGlu ZUxheW91dFVuaXQpOwpAQCAtNjEsNiArNjIsNyBAQCBwdWJsaWM6CiAgICAgdm9pZCBleHBhbmQo T3B0aW9uYWw8SW5saW5lTGF5b3V0VW5pdD4sIE9wdGlvbmFsPElubGluZUxheW91dFVuaXQ+KTsK ICAgICB2b2lkIGV4cGFuZEhvcml6b250YWxseShJbmxpbmVMYXlvdXRVbml0IGRlbHRhKSB7IGV4 cGFuZChkZWx0YSwgeyB9KTsgfQogICAgIHZvaWQgZXhwYW5kVmVydGljYWxseShJbmxpbmVMYXlv dXRVbml0IGRlbHRhKSB7IGV4cGFuZCh7IH0sIGRlbHRhKTsgfQorICAgIHZvaWQgZXhwYW5kVmVy dGljYWxseVRvQ29udGFpbihjb25zdCBJbmxpbmVSZWN0Jik7CiAKICAgICBvcGVyYXRvciBJbmxp bmVMYXlvdXRSZWN0KCkgY29uc3Q7CiAKQEAgLTE4Nyw2ICsxODksMTUgQEAgaW5saW5lIHZvaWQg SW5saW5lUmVjdDo6c2V0VG9wKElubGluZUxheW91dFVuaXQgdG9wKQogICAgIG1fcmVjdC5zZXRZ KHRvcCk7CiB9CiAKK2lubGluZSB2b2lkIElubGluZVJlY3Q6OnNldEJvdHRvbShJbmxpbmVMYXlv dXRVbml0IGJvdHRvbSkKK3sKKyNpZiAhQVNTRVJUX0RJU0FCTEVECisgICAgbV9oYXNWYWxpZFRv cCA9IHRydWU7CisgICAgbV9oYXNWYWxpZEhlaWdodCA9IHRydWU7CisjZW5kaWYKKyAgICBtX3Jl Y3Quc2hpZnRNYXhZRWRnZVRvKGJvdHRvbSk7Cit9CisKIGlubGluZSB2b2lkIElubGluZVJlY3Q6 OnNldExlZnQoSW5saW5lTGF5b3V0VW5pdCBsZWZ0KQogewogI2lmICFBU1NFUlRfRElTQUJMRUQK QEAgLTIzMCw2ICsyNDEsMTQgQEAgaW5saW5lIHZvaWQgSW5saW5lUmVjdDo6ZXhwYW5kKE9wdGlv bmFsPElubGluZUxheW91dFVuaXQ+IHdpZHRoLCBPcHRpb25hbDxJbmxpbmUKICAgICBtX3JlY3Qu ZXhwYW5kKHdpZHRoLnZhbHVlT3IoMCksIGhlaWdodC52YWx1ZU9yKDApKTsKIH0KIAoraW5saW5l IHZvaWQgSW5saW5lUmVjdDo6ZXhwYW5kVmVydGljYWxseVRvQ29udGFpbihjb25zdCBJbmxpbmVS ZWN0JiBvdGhlcikKK3sKKyAgICBhdXRvIGNvbnRhaW5Ub3AgPSBzdGQ6Om1pbih0b3AoKSwgb3Ro ZXIudG9wKCkpOworICAgIGF1dG8gY29udGFpbkJvdHRvbSA9IHN0ZDo6bWF4KGJvdHRvbSgpLCBv dGhlci5ib3R0b20oKSk7CisgICAgc2V0VG9wKGNvbnRhaW5Ub3ApOworICAgIHNldEJvdHRvbShj b250YWluQm90dG9tKTsKK30KKwogaW5saW5lIElubGluZVJlY3Q6Om9wZXJhdG9yIElubGluZUxh eW91dFJlY3QoKSBjb25zdAogewogICAgIEFTU0VSVChoYXNWYWxpZEdlb21ldHJ5KCkpOyAKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2xheW91dC9kaXNwbGF5dHJlZS9EaXNwbGF5TGluZUJv eC5oIGIvU291cmNlL1dlYkNvcmUvbGF5b3V0L2Rpc3BsYXl0cmVlL0Rpc3BsYXlMaW5lQm94LmgK aW5kZXggZjVjODYyYjE4YzQ3Y2I2NjU1OTQ2NTI2NmIzZGJiYzZiNDBhMzE3My4uZDNlYzUzYTY4 ZmJhZmE5YjhlODE2ZTJkNmU5NjliYzNjYzZkNDU1ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNv cmUvbGF5b3V0L2Rpc3BsYXl0cmVlL0Rpc3BsYXlMaW5lQm94LmgKKysrIGIvU291cmNlL1dlYkNv cmUvbGF5b3V0L2Rpc3BsYXl0cmVlL0Rpc3BsYXlMaW5lQm94LmgKQEAgLTYyLDkgKzYyLDkgQEAg cHVibGljOgogICAgIExpbmVCb3goKSA9IGRlZmF1bHQ7CiAKICAgICBjb25zdCBJbmxpbmVSZWN0 JiBsb2dpY2FsUmVjdCgpIGNvbnN0IHsgcmV0dXJuIG1fcmVjdDsgfQorICAgIGNvbnN0IElubGlu ZVJlY3QmIHNjcm9sbGFibGVPdmVyZmxvd1JlY3QoKSBjb25zdCB7IHJldHVybiBtX3Njcm9sbGFi bGVPdmVyZmxvd1JlY3Q7IH0KIAogICAgIElubGluZUxheW91dFBvaW50IGxvZ2ljYWxUb3BMZWZ0 KCkgY29uc3QgeyByZXR1cm4gbV9yZWN0LnRvcExlZnQoKTsgfQotCiAgICAgSW5saW5lTGF5b3V0 VW5pdCBsb2dpY2FsTGVmdCgpIGNvbnN0IHsgcmV0dXJuIG1fcmVjdC5sZWZ0KCk7IH0KICAgICBJ bmxpbmVMYXlvdXRVbml0IGxvZ2ljYWxSaWdodCgpIGNvbnN0IHsgcmV0dXJuIG1fcmVjdC5yaWdo dCgpOyB9CiAgICAgSW5saW5lTGF5b3V0VW5pdCBsb2dpY2FsVG9wKCkgY29uc3QgeyByZXR1cm4g bV9yZWN0LnRvcCgpOyB9CkBAIC0xMDMsNiArMTAzLDggQEAgcHVibGljOgogICAgIHZvaWQgc2V0 TG9naWNhbEhlaWdodElmR3JlYXRlcihJbmxpbmVMYXlvdXRVbml0KTsKICAgICB2b2lkIHNldExv Z2ljYWxXaWR0aChJbmxpbmVMYXlvdXRVbml0IGxvZ2ljYWxXaWR0aCkgeyBtX3JlY3Quc2V0V2lk dGgobG9naWNhbFdpZHRoKTsgfQogCisgICAgdm9pZCBzZXRTY3JvbGxhYmxlT3ZlcmZsb3dSZWN0 KGNvbnN0IElubGluZVJlY3QmIHJlY3QpIHsgbV9zY3JvbGxhYmxlT3ZlcmZsb3dSZWN0ID0gcmVj dDsgfQorCiAgICAgdm9pZCBtb3ZlSG9yaXpvbnRhbGx5KElubGluZUxheW91dFVuaXQgZGVsdGEp IHsgbV9yZWN0Lm1vdmVIb3Jpem9udGFsbHkoZGVsdGEpOyB9CiAKICAgICB2b2lkIGV4cGFuZEhv cml6b250YWxseShJbmxpbmVMYXlvdXRVbml0IGRlbHRhKSB7IG1fcmVjdC5leHBhbmRIb3Jpem9u dGFsbHkoZGVsdGEpOyB9CkBAIC0xMjcsNiArMTI5LDcgQEAgcHJpdmF0ZToKICAgICBib29sIG1f aGFzVmFsaWRCYXNlbGluZU9mZnNldCB7IGZhbHNlIH07CiAjZW5kaWYKICAgICBJbmxpbmVSZWN0 IG1fcmVjdDsKKyAgICBJbmxpbmVSZWN0IG1fc2Nyb2xsYWJsZU92ZXJmbG93UmVjdDsKICAgICBC YXNlbGluZSBtX2Jhc2VsaW5lOwogICAgIElubGluZUxheW91dFVuaXQgbV9iYXNlbGluZU9mZnNl dDsKICAgICBib29sIG1faXNDb25zaWRlcmVkRW1wdHkgeyB0cnVlIH07CmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViQ29yZS9sYXlvdXQvaW5saW5lZm9ybWF0dGluZy9JbmxpbmVMaW5lQnVpbGRlci5j cHAgYi9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQvaW5saW5lZm9ybWF0dGluZy9JbmxpbmVMaW5lQnVp bGRlci5jcHAKaW5kZXggNjNjMjg4NmUxNjM0NDdmZWVkZDQ3NDA1NjdhMmQ0MjBmZmIzZWZmMC4u NDhlNTIzOGRmNzQ4ZTZhNDFhMzAxMmU3OWZkOGIxY2Y1YzNmZmYwMiAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvbGF5b3V0L2lubGluZWZvcm1hdHRpbmcvSW5saW5lTGluZUJ1aWxkZXIuY3Bw CisrKyBiL1NvdXJjZS9XZWJDb3JlL2xheW91dC9pbmxpbmVmb3JtYXR0aW5nL0lubGluZUxpbmVC dWlsZGVyLmNwcApAQCAtMzIyLDYgKzMyMiw3IEBAIHNpemVfdCBMaW5lQnVpbGRlcjo6cmV2ZXJ0 KGNvbnN0IElubGluZUl0ZW0mIHJldmVydFRvKQogdm9pZCBMaW5lQnVpbGRlcjo6YWxpZ25Db250 ZW50VmVydGljYWxseShSdW5MaXN0JiBydW5MaXN0KQogewogICAgIEFTU0VSVCghbV9pc0ludHJp bnNpY1NpemluZyk7CisgICAgYXV0byBzY3JvbGxhYmxlT3ZlcmZsb3dSZWN0ID0gbV9saW5lQm94 LmxvZ2ljYWxSZWN0KCk7CiAgICAgZm9yIChhdXRvJiBydW4gOiBydW5MaXN0KSB7CiAgICAgICAg IElubGluZUxheW91dFVuaXQgbG9naWNhbFRvcCA9IDA7CiAgICAgICAgIGF1dG8mIGxheW91dEJv eCA9IHJ1bi5sYXlvdXRCb3goKTsKQEAgLTM2OCwxMCArMzY5LDEzIEBAIHZvaWQgTGluZUJ1aWxk ZXI6OmFsaWduQ29udGVudFZlcnRpY2FsbHkoUnVuTGlzdCYgcnVuTGlzdCkKICAgICAgICAgICAg IGJyZWFrOwogICAgICAgICB9CiAgICAgICAgIHJ1bi5hZGp1c3RMb2dpY2FsVG9wKGxvZ2ljYWxU b3ApOworICAgICAgICAvLyBBZGp1c3Qgc2Nyb2xsYWJsZSBvdmVyZmxvdyBpZiB0aGUgcnVuIG92 ZXJmbG93cyB0aGUgbGluZS4KKyAgICAgICAgc2Nyb2xsYWJsZU92ZXJmbG93UmVjdC5leHBhbmRW ZXJ0aWNhbGx5VG9Db250YWluKHJ1bi5sb2dpY2FsUmVjdCgpKTsKICAgICAgICAgLy8gQ29udmVy dCBydW5zIGZyb20gcmVsYXRpdmUgdG8gdGhlIGxpbmUgdG9wL2xlZnQgdG8gdGhlIGZvcm1hdHRp bmcgcm9vdCdzIGJvcmRlciBib3ggdG9wL2xlZnQuCiAgICAgICAgIHJ1bi5tb3ZlVmVydGljYWxs eSh0aGlzLT5sb2dpY2FsVG9wKCkpOwogICAgICAgICBydW4ubW92ZUhvcml6b250YWxseSh0aGlz LT5sb2dpY2FsTGVmdCgpKTsKICAgICB9CisgICAgbV9saW5lQm94LnNldFNjcm9sbGFibGVPdmVy Zmxvd1JlY3Qoc2Nyb2xsYWJsZU92ZXJmbG93UmVjdCk7CiB9CiAKIHZvaWQgTGluZUJ1aWxkZXI6 Omp1c3RpZnlSdW5zKFJ1bkxpc3QmIHJ1bkxpc3QpIGNvbnN0CmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViQ29yZS9sYXlvdXQvaW50ZWdyYXRpb24vTGF5b3V0SW50ZWdyYXRpb25MaW5lTGF5b3V0LmNw cCBiL1NvdXJjZS9XZWJDb3JlL2xheW91dC9pbnRlZ3JhdGlvbi9MYXlvdXRJbnRlZ3JhdGlvbkxp bmVMYXlvdXQuY3BwCmluZGV4IDJmNmMwNjE5ODIzMWZiYTkyNWM3ZGVhZjI1NmI3MzViM2RhOGQz NjMuLmYyZTQ5ODRjOGY2Mjg5MWI0YTgzYWQxNzdkYmQ3OGQwNDQ1MjUzM2EgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJDb3JlL2xheW91dC9pbnRlZ3JhdGlvbi9MYXlvdXRJbnRlZ3JhdGlvbkxpbmVM YXlvdXQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2xheW91dC9pbnRlZ3JhdGlvbi9MYXlvdXRJ bnRlZ3JhdGlvbkxpbmVMYXlvdXQuY3BwCkBAIC0xNTgsNyArMTU4LDcgQEAgdm9pZCBMaW5lTGF5 b3V0Ojpjb2xsZWN0T3ZlcmZsb3coUmVuZGVyQmxvY2tGbG93JiBmbG93KQogICAgIGF1dG8gdmll d3BvcnRTaXplID0gbV9mbG93LmZyYW1lKCkudmlldygpLT5zaXplKCk7CiAKICAgICBmb3IgKGF1 dG8mIGxpbmVCb3ggOiBkaXNwbGF5SW5saW5lQ29udGVudCgpLT5saW5lQm94ZXMpIHsKLSAgICAg ICAgYXV0byBsaW5lUmVjdCA9IExheW91dDo6dG9MYXlvdXRSZWN0KGxpbmVCb3gubG9naWNhbFJl Y3QoKSk7CisgICAgICAgIGF1dG8gbGluZVJlY3QgPSBMYXlvdXQ6OnRvTGF5b3V0UmVjdChsaW5l Qm94LnNjcm9sbGFibGVPdmVyZmxvd1JlY3QoKSk7CiAgICAgICAgIGF1dG8gdmlzdWFsT3ZlcmZs b3dSZWN0ID0gTGF5b3V0UmVjdCB7IGNvbXB1dGVWaXN1YWxPdmVyZmxvdyhmbG93LnN0eWxlKCks IGxpbmVSZWN0LCB2aWV3cG9ydFNpemUpIH07CiAgICAgICAgIGZsb3cuYWRkTGF5b3V0T3ZlcmZs b3cobGluZVJlY3QpOwogICAgICAgICBmbG93LmFkZFZpc3VhbE92ZXJmbG93KHZpc3VhbE92ZXJm bG93UmVjdCk7Cg==