205648 2019-12-30 11:45:10 -0800 REGRESSION(r253939): [GTK] Broke build with !USE(WPE_RENDERER) 2020-01-08 07:12:21 -0800 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 205604 1 clopez webkit-unassigned bugs-noreply commit-queue dino dpino ews-watchlist graouts kondapallykalyan sam oldest_to_newest 1601901 0 clopez 2019-12-30 11:45:10 -0800 r253939 broke the build in the Debian stable bot: https://build.webkit.org/builders/GTK%20Linux%2064-bit%20Release%20Debian%20Stable%20%28Build%29/builds/28184 This bot checks that WebKit its buildable with the libraries shipped by the distribution. libwpe is still not shipped by Debian stable, so it builds with --cmakeargs=-DUSE_WPE_RENDERER=OFF The build error from gcc is a bit cryptic, so I tried to build it locally with clang instead of gcc and I can see this: In file included from ../../Source/WebKit/UIProcess/gtk/WaylandCompositor.cpp:46: In file included from DerivedSources/ForwardingHeaders/WebCore/Extensions3DOpenGL.h:28: In file included from DerivedSources/ForwardingHeaders/WebCore/Extensions3DOpenGLCommon.h:31: In file included from DerivedSources/ForwardingHeaders/WebCore/GraphicsContext3D.h:31: DerivedSources/ForwardingHeaders/WebCore/GraphicsContext3DBase.h:734:9: error: expected identifier None, ^ /usr/include/X11/X.h:115:30: note: expanded from macro 'None' #define None 0L /* universal null resource or null atom */ It seems there is a conflict because of using the word "None", which a X11 header defines to 0L. This X11 header is included when !USE(WPE_RENDERER) from In file included from Source/WebKit/UIProcess/gtk/WaylandCompositor.cpp:32: In file included from /usr/include/EGL/egl.h:39: In file included from /usr/include/EGL/eglplatform.h:124: In file included from /usr/include/X11/Xlib.h:44: 1603015 1 386838 dpino 2020-01-06 05:59:31 -0800 Created attachment 386838 Patch 1603696 2 386838 commit-queue 2020-01-07 11:50:46 -0800 Comment on attachment 386838 Patch Rejecting attachment 386838 from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'apply-attachment', '--no-update', '--non-interactive', 386838, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Logging in as commit-queue@webkit.org... Fetching: https://bugs.webkit.org/attachment.cgi?id=386838&action=edit Fetching: https://bugs.webkit.org/show_bug.cgi?id=205648&ctype=xml&excludefield=attachmentdata Processing 1 patch from 1 bug. Processing patch 386838 from bug 205648. Fetching: https://bugs.webkit.org/attachment.cgi?id=386838 Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Carlos Alberto Lopez Perez']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Parsed 2 diffs from patch file(s). patching file Source/WebCore/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. can't find file to patch at input line 5 Perhaps you used the wrong -p or --strip option? The text leading up to this was: -------------------------- |Index: Source/WebCore/platform/graphics/GraphicsContext3DBase.h |index 2e03805c218c7987049cdd80a6f070cca1813978..67bd154df1ec6a00807efbb2614d024f08f3be50 100644 |--- Source/WebCore/platform/graphics/GraphicsContext3DBase.h (revision 0) |+++ Source/WebCore/platform/graphics/GraphicsContext3DBase.h (working copy) -------------------------- No file to patch. Skipping patch. 1 out of 1 hunk ignored Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Carlos Alberto Lopez Perez']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: https://webkit-queues.webkit.org/results/13300762 1603953 3 387074 dpino 2020-01-07 22:05:48 -0800 Created attachment 387074 Patch 1604065 4 387074 commit-queue 2020-01-08 06:10:14 -0800 Comment on attachment 387074 Patch Clearing flags on attachment: 387074 Committed r254198: <https://trac.webkit.org/changeset/254198> 1604066 5 commit-queue 2020-01-08 06:10:15 -0800 All reviewed patches have been landed. Closing bug. 386838 2020-01-06 05:59:31 -0800 2020-01-07 22:05:41 -0800 Patch bug-205648-20200106145929.patch text/plain 1152 dpino U3VidmVyc2lvbiBSZXZpc2lvbjogMjU0MDQ5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNzVmZThhZjQ3ZmYzYTQ0 NTI1YmFkNjA1OGFhYzk5NjM3NjIxMDVmYi4uNGQxMTU1MmZiZTQ2ZGFjZTNkMDM4OTBkZmUwMzkx ZGNjMzNjZWU4NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDIwLTAxLTA2ICBEaWVn byBQaW5vIEdhcmNpYSAgPGRwaW5vQGlnYWxpYS5jb20+CisKKyAgICAgICAgUkVHUkVTU0lPTihy MjUzOTM5KTogW0dUS10gQnJva2UgYnVpbGQgd2l0aCAhVVNFKFdQRV9SRU5ERVJFUikKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwNTY0OAorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogcGxhdGZvcm0vZ3Jh cGhpY3MvR3JhcGhpY3NDb250ZXh0M0RCYXNlLmg6CisKIDIwMjAtMDEtMDUgIEVyaWMgQ2FybHNv biAgPGVyaWMuY2FybHNvbkBhcHBsZS5jb20+CiAKICAgICAgICAgW01lZGlhIGluIEdQVSBwcm9j ZXNzXSBBZGQgcmVtb3RlIE1JTUUgdHlwZSBjYWNoZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vZ3JhcGhpY3MvR3JhcGhpY3NDb250ZXh0M0RCYXNlLmggYi9Tb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9ncmFwaGljcy9HcmFwaGljc0NvbnRleHQzREJhc2UuaAppbmRleCAyZTAz ODA1YzIxOGM3OTg3MDQ5Y2RkODBhNmYwNzBjY2ExODEzOTc4Li42N2JkMTU0ZGYxZWM2YTAwODA3 ZWZiYjI2MTRkMDI0ZjA4ZjNiZTUwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9ncmFwaGljcy9HcmFwaGljc0NvbnRleHQzREJhc2UuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9ncmFwaGljcy9HcmFwaGljc0NvbnRleHQzREJhc2UuaApAQCAtNzM4LDcgKzczOCw3 IEBAIHB1YmxpYzoKICAgICAgICAgSW1hZ2UsCiAgICAgICAgIENhbnZhcywKICAgICAgICAgVmlk ZW8sCi0gICAgICAgIE5vbmUsCisgICAgICAgIERPTVNvdXJjZU5vbmUsCiAgICAgfTsKIAogI2lm IFVTRShBTkdMRSkK 387074 2020-01-07 22:05:48 -0800 2020-01-08 07:12:21 -0800 Patch bug-205648-20200108070546.patch text/plain 1272 dpino U3VidmVyc2lvbiBSZXZpc2lvbjogMjU0MTUzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNWIwZjY4Y2FjNWQ0OGQ4 YWQ4NDJiZThmZTQ2NGNlZDk5MWQxYmUyZi4uYmQzZmJmMDVhYTU1M2NkYWRkNjExYzFhMzIyZDcx OGQ1NmExMDM0ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDIwLTAxLTA3ICBEaWVn byBQaW5vIEdhcmNpYSAgPGRwaW5vQGlnYWxpYS5jb20+CisKKyAgICAgICAgUkVHUkVTU0lPTihy MjUzOTM5KTogW0dUS10gQnJva2UgYnVpbGQgd2l0aCAhVVNFKFdQRV9SRU5ERVJFUikgCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDU2NDgKKworICAg ICAgICBSZXZpZXdlZCBieSBDYXJsb3MgQWxiZXJ0byBMb3BleiBQZXJlei4KKworICAgICAgICAq IHBsYXRmb3JtL2dyYXBoaWNzL0dyYXBoaWNzQ29udGV4dEdMLmg6IFJlbmFtZSBlbnVtIE5vbmUg dG8KKyAgICAgICAgRE9NU291cmNlTm9uZSB0byBhdm9pZCBuYW1lIGNvbGxpc3Npb24uCisKIDIw MjAtMDEtMDcgIERhbmllbCBCYXRlcyAgPGRhYmF0ZXNAYXBwbGUuY29tPgogCiAgICAgICAgIEZp cnN0IGNoYXJhY3RlciBpbiBlYWNoIHdvcmQtd3JhcHBlZCBsaW5lIGhhcyBpbmNvcnJlY3QgY2hh cmFjdGVyIHJlY3Qgd2hlbiByZXF1ZXN0ZWQgcmFuZ2Ugc3BhbnMgbXVsdGlwbGUgbGluZXMKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0dyYXBoaWNzQ29udGV4 dEdMLmggYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9HcmFwaGljc0NvbnRleHRH TC5oCmluZGV4IDkxNWM0MDQ0NzgyYWQyZGE2MDAyOGRhNjU5NTFiN2JmZGY1MzA2NTAuLjBmMWRh ZDlmZjg4NThhNDdlY2U1NWJmYWE0MGY5NDBjNTNmZTE2NTIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0dyYXBoaWNzQ29udGV4dEdMLmgKKysrIGIvU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvR3JhcGhpY3NDb250ZXh0R0wuaApAQCAtNzM4LDcg KzczOCw3IEBAIHB1YmxpYzoKICAgICAgICAgSW1hZ2UsCiAgICAgICAgIENhbnZhcywKICAgICAg ICAgVmlkZW8sCi0gICAgICAgIE5vbmUsCisgICAgICAgIERPTVNvdXJjZU5vbmUsCiAgICAgfTsK IAogI2lmIFVTRShBTkdMRSkK