205635 2019-12-29 20:52:07 -0800 XMLSerializer doesn't correctly encode entities in <style> element 2020-01-02 18:54:31 -0800 1 1 1 Unclassified WebKit XML Safari Technology Preview Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 xidorn-webkit cdumez achristensen ap cdumez commit-queue ews-watchlist ggaren mifenton rniwa webkit-bug-importer youennf oldest_to_newest 1601813 0 386505 xidorn-webkit 2019-12-29 20:52:07 -0800 Created attachment 386505 testcase Please see the testcase, in Safari, it shows: > <style xmlns="http://www.w3.org/1999/xhtml">/* & */</style> while in both Firefox and Chrome it shows: > <style xmlns="http://www.w3.org/1999/xhtml">/* &amp; */</style> The testcase basically just invokes XMLSerializer's serializeToString to serialize the following element: > <style>/* & */</style> and the output from Safari is not a valid XML. 1602254 1 386635 cdumez 2020-01-02 15:11:12 -0800 Created attachment 386635 Patch 1602310 2 386635 commit-queue 2020-01-02 18:53:05 -0800 Comment on attachment 386635 Patch Clearing flags on attachment: 386635 Committed r253988: <https://trac.webkit.org/changeset/253988> 1602311 3 commit-queue 2020-01-02 18:53:06 -0800 All reviewed patches have been landed. Closing bug. 1602313 4 webkit-bug-importer 2020-01-02 18:54:31 -0800 <rdar://problem/58289242> 386505 2019-12-29 20:52:07 -0800 2019-12-29 20:52:07 -0800 testcase xml-entity.html text/html 228 xidorn-webkit PCFET0NUWVBFIGh0bWw+CjxzdHlsZT4vKiAmICovPC9zdHlsZT4KPHByZT48L3ByZT4KPHNjcmlw dD4KICBsZXQgc3R5bGUgPSBkb2N1bWVudC5xdWVyeVNlbGVjdG9yKCdzdHlsZScpOwogIGxldCBw cmUgPSBkb2N1bWVudC5xdWVyeVNlbGVjdG9yKCdwcmUnKTsKICBwcmUudGV4dENvbnRlbnQgPSAo bmV3IFhNTFNlcmlhbGl6ZXIoKSkuc2VyaWFsaXplVG9TdHJpbmcoc3R5bGUpOwo8L3NjcmlwdD4K 386635 2020-01-02 15:11:12 -0800 2020-01-02 18:53:05 -0800 Patch bug-205635-20200102151111.patch text/plain 4232 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjUzOTc0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggY2E1NzU2NmNhNmYzNjMw ZjMzZmE1YzVlY2YwYmQwNTI2ODdhZTdhYi4uNjdiNDc2ZGQzNGRlMTdjM2QwNGVmMjZjODlkMDU5 NDY4M2QyOTk4ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDIwLTAxLTAyICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgWE1MU2VyaWFsaXplciBkb2Vz bid0IGNvcnJlY3RseSBlbmNvZGUgZW50aXRpZXMgaW4gPHN0eWxlPiBlbGVtZW50CisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDU2MzUKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBcyBwZXIgWzFdLCB3aGVu IGRvaW5nIGFuIFhNTCBzZXJpYWxpemF0aW9uIG9mIHRleHQsIHdlIHNob3VsZCBlc2NhcGUgJzwn LCAnPicgYW5kICcmJywgZXZlbgorICAgICAgICBpZiB0aGUgdGV4dCBpcyBpbnNpZGUgYSA8c3R5 bGU+IGVsZW1lbnQuIFRoZSA8c3R5bGU+IGVsZW1lbnQgZXhjZXB0aW9uIGlzIGZvciBIVE1MIHNl cmlhbGl6YXRpb24gWzJdLgorCisgICAgICAgIFsxXSBodHRwczovL3czYy5naXRodWIuaW8vRE9N LVBhcnNpbmcvI3htbC1zZXJpYWxpemluZy1hLXRleHQtbm9kZQorICAgICAgICBbMl0gaHR0cHM6 Ly9odG1sLnNwZWMud2hhdHdnLm9yZy8jc2VyaWFsaXNpbmctaHRtbC1mcmFnbWVudHMKKworICAg ICAgICBUZXN0OiBmYXN0L2RvbS94bWxzZXJpYWxpemVyLWFtcGVyc2FuZC1pbi1zdHlsZS5odG1s CisKKyAgICAgICAgKiBlZGl0aW5nL01hcmt1cEFjY3VtdWxhdG9yLmNwcDoKKyAgICAgICAgKFdl YkNvcmU6Ok1hcmt1cEFjY3VtdWxhdG9yOjplbnRpdHlNYXNrRm9yVGV4dCBjb25zdCk6CisKIDIw MjAtMDEtMDEgIEpvb25naHVuIFBhcmsgIDxqaDcxOC5wYXJrQHNhbXN1bmcuY29tPgogCiAgICAg ICAgIFVucmV2aWV3ZWQuIFJlbW92ZSB0aGUgYnVpbGQgd2FybmluZyBiZWxvdyBzaW5jZSByMjUz OTM5LgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvZWRpdGluZy9NYXJrdXBBY2N1bXVsYXRv ci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9lZGl0aW5nL01hcmt1cEFjY3VtdWxhdG9yLmNwcAppbmRl eCBlY2M0YjRjNDkxY2FkNjY5NDJiYzRiZGRjNzZiMTk1NDllOTE3ZDcyLi5iNGVkYTM4NDgzN2Nh NmM5ZDBhYjI3ZGQ4OWQ4NDc1MDg0NWYwYmExIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9l ZGl0aW5nL01hcmt1cEFjY3VtdWxhdG9yLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9lZGl0aW5n L01hcmt1cEFjY3VtdWxhdG9yLmNwcApAQCAtMzgwLDcgKzM4MCw3IEBAIHZvaWQgTWFya3VwQWNj dW11bGF0b3I6OmFwcGVuZE5hbWVzcGFjZShTdHJpbmdCdWlsZGVyJiByZXN1bHQsIGNvbnN0IEF0 b21TdHJpbmcmCiAKIEVudGl0eU1hc2sgTWFya3VwQWNjdW11bGF0b3I6OmVudGl0eU1hc2tGb3JU ZXh0KGNvbnN0IFRleHQmIHRleHQpIGNvbnN0CiB7Ci0gICAgaWYgKCF0ZXh0LmRvY3VtZW50KCku aXNIVE1MRG9jdW1lbnQoKSkKKyAgICBpZiAoIXRleHQuZG9jdW1lbnQoKS5pc0hUTUxEb2N1bWVu dCgpIHx8IGluWE1MRnJhZ21lbnRTZXJpYWxpemF0aW9uKCkpCiAgICAgICAgIHJldHVybiBFbnRp dHlNYXNrSW5QQ0RBVEE7CiAKICAgICBjb25zdCBRdWFsaWZpZWROYW1lKiBwYXJlbnROYW1lID0g bnVsbHB0cjsKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwppbmRleCAyYjAwYmRlYTFiZGJkYWY4M2U3ZmYxN2VmOGViMjYwOGIzMDdkYTk4 Li5mYTFhYTI0ZjliYjk1OTNhODJkNTVkZjBhNWZhZDIyNjhmNDlmOGI5IDEwMDY0NAotLS0gYS9M YXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMg KzEsMTUgQEAKKzIwMjAtMDEtMDIgIENocmlzIER1bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KKwor ICAgICAgICBYTUxTZXJpYWxpemVyIGRvZXNuJ3QgY29ycmVjdGx5IGVuY29kZSBlbnRpdGllcyBp biA8c3R5bGU+IGVsZW1lbnQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTIwNTYzNQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIEFkZCBsYXlvdXQgdGVzdCBjb3ZlcmFnZS4KKworICAgICAgICAqIGZhc3QvZG9t L3htbHNlcmlhbGl6ZXItYW1wZXJzYW5kLWluLXN0eWxlLWV4cGVjdGVkLnR4dDogQWRkZWQuCisg ICAgICAgICogZmFzdC9kb20veG1sc2VyaWFsaXplci1hbXBlcnNhbmQtaW4tc3R5bGUuaHRtbDog QWRkZWQuCisKIDIwMjAtMDEtMDEgIHlvdWVubiBmYWJsZXQgIDx5b3Vlbm5AYXBwbGUuY29tPgog CiAgICAgICAgIEltcGxlbWVudCB0cmFuc2NlaXZlciBzZXRDb2RlY1ByZWZlcmVuY2VzCmRpZmYg LS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L2RvbS94bWxzZXJpYWxpemVyLWFtcGVyc2FuZC1pbi1z dHlsZS1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9mYXN0L2RvbS94bWxzZXJpYWxpemVyLWFt cGVyc2FuZC1pbi1zdHlsZS1leHBlY3RlZC50eHQKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXgg MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uNjY5NDNiYzE0ZTI3MWU0 MmFkMGY0MTlhZWRmMjI2YmJhOTY2M2EyOQotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3Rz L2Zhc3QvZG9tL3htbHNlcmlhbGl6ZXItYW1wZXJzYW5kLWluLXN0eWxlLWV4cGVjdGVkLnR4dApA QCAtMCwwICsxLDExIEBACitUZXN0cyBYTUwgc2VyaWFsaXphdGlvbiBvZiBhbXBlcnNhbmQgaW4g YSBzdHlsZSBlbGVtZW50LgorCitPbiBzdWNjZXNzLCB5b3Ugd2lsbCBzZWUgYSBzZXJpZXMgb2Yg IlBBU1MiIG1lc3NhZ2VzLCBmb2xsb3dlZCBieSAiVEVTVCBDT01QTEVURSIuCisKKworVGVzdCBj YXNlOiAvKiAmIDwgPiAiw4LCoCAqLworUEFTUyByZXN1bHQgaXMgIjxzdHlsZSB4bWxucz1cImh0 dHA6Ly93d3cudzMub3JnLzE5OTkveGh0bWxcIj4vKiAmYW1wOyAmbHQ7ICZndDsgXCLDgsKgICov PC9zdHlsZT4iCitQQVNTIHN1Y2Nlc3NmdWxseVBhcnNlZCBpcyB0cnVlCisKK1RFU1QgQ09NUExF VEUKKwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9kb20veG1sc2VyaWFsaXplci1hbXBl cnNhbmQtaW4tc3R5bGUuaHRtbCBiL0xheW91dFRlc3RzL2Zhc3QvZG9tL3htbHNlcmlhbGl6ZXIt YW1wZXJzYW5kLWluLXN0eWxlLmh0bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uZTUxMzk5ZWE1ZTYzZGI2OWZmYWQ1 OTc5NGVhOGQ5ZmJiNmEwNTc4YQotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2Zhc3Qv ZG9tL3htbHNlcmlhbGl6ZXItYW1wZXJzYW5kLWluLXN0eWxlLmh0bWwKQEAgLTAsMCArMSwyMyBA QAorPCFET0NUWVBFIGh0bWw+Cis8aHRtbD4KKzxoZWFkPgorPHN0eWxlPjwvc3R5bGU+Cis8L2hl YWQ+Cis8Ym9keT4KKzxzY3JpcHQgc3JjPSIuLi8uLi9yZXNvdXJjZXMvanMtdGVzdC5qcyI+PC9z Y3JpcHQ+Cis8c2NyaXB0PgorZGVzY3JpcHRpb24oIlRlc3RzIFhNTCBzZXJpYWxpemF0aW9uIG9m IGFtcGVyc2FuZCBpbiBhIHN0eWxlIGVsZW1lbnQuIik7CitzdHlsZSA9IGRvY3VtZW50LnF1ZXJ5 U2VsZWN0b3IoJ3N0eWxlJyk7CisKK2Z1bmN0aW9uIHRlc3RYTUxTZXJpYWxpemF0aW9uKGlucHV0 LCBleHBlY3RlZCkKK3sKKyAgICBkZWJ1ZygiVGVzdCBjYXNlOiAiICsgaW5wdXQpOworICAgIHN0 eWxlLmlubmVyVGV4dCA9IGlucHV0OworICAgIHJlc3VsdCA9IChuZXcgWE1MU2VyaWFsaXplcigp KS5zZXJpYWxpemVUb1N0cmluZyhzdHlsZSk7CisgICAgc2hvdWxkQmVFcXVhbFRvU3RyaW5nKCJy ZXN1bHQiLCAiIiArIGV4cGVjdGVkKTsKK30KKwordGVzdFhNTFNlcmlhbGl6YXRpb24oIi8qICYg PCA+IFwiwqAgKi8iLCAiPHN0eWxlIHhtbG5zPVwiaHR0cDovL3d3dy53My5vcmcvMTk5OS94aHRt bFwiPi8qICZhbXA7ICZsdDsgJmd0OyBcIsKgICovPC9zdHlsZT4iKTsKKzwvc2NyaXB0PgorPC9i b2R5PgorPC9odG1sPgo=