205570 2019-12-23 15:36:20 -0800 REGRESSION(r218839): Web Inspector: Color picker: pressing Esc should hide color picker 2020-01-06 10:24:36 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 nvasilyev nvasilyev bburg commit-queue inspector-bugzilla-changes webkit-bug-importer oldest_to_newest 1601317 0 nvasilyev 2019-12-23 15:36:20 -0800 There's relevant code in Popover.js but it doesn't work: handleEvent(event) { switch (event.type) { ... case "keypress": if (event.keyCode === WI.KeyboardShortcut.Key.Escape.keyCode) this.dismiss(); 1601318 1 webkit-bug-importer 2019-12-23 15:36:35 -0800 <rdar://problem/58169820> 1601427 2 nvasilyev 2019-12-24 17:21:26 -0800 Regressed in r218839 as `keyboardShortcutDisabled` getter was removed: https://github.com/WebKit/webkit/commit/9870d084e62af3e5a9240390f46c7a61a4ce40a0#diff-a644aa8b89b6359edd1f27853c18a8faL106 1601429 3 386395 nvasilyev 2019-12-24 17:35:01 -0800 Created attachment 386395 Patch 1602687 4 386395 nvasilyev 2020-01-03 18:39:30 -0800 Comment on attachment 386395 Patch This only works every other time. 1602688 5 386741 nvasilyev 2020-01-03 18:41:01 -0800 Created attachment 386741 Patch 1603082 6 386741 bburg 2020-01-06 09:21:47 -0800 Comment on attachment 386741 Patch r=me, good catch. 1603113 7 386741 commit-queue 2020-01-06 10:24:34 -0800 Comment on attachment 386741 Patch Clearing flags on attachment: 386741 Committed r254061: <https://trac.webkit.org/changeset/254061> 1603114 8 commit-queue 2020-01-06 10:24:36 -0800 All reviewed patches have been landed. Closing bug. 386395 2019-12-24 17:35:01 -0800 2020-01-03 18:41:01 -0800 Patch patch.txt text/plain 1518 nvasilyev ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IGY3NzdiNjIzZDU3Li4zYmVkZDk2YWUzYiAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTktMTItMjQgIE5pa2l0 YSBWYXNpbHlldiAgPG52YXNpbHlldkBhcHBsZS5jb20+CisKKyAgICAgICAgUkVHUkVTU0lPTihy MjE4ODM5KTogV2ViIEluc3BlY3RvcjogQ29sb3IgcGlja2VyOiBwcmVzc2luZyBFc2Mgc2hvdWxk IGhpZGUgY29sb3IgcGlja2VyCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0yMDU1NzAKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzU4MTY5ODIwPgorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogVXNlckludGVy ZmFjZS9WaWV3cy9RdWlja0NvbnNvbGUuanM6CisgICAgICAgIChXSS5RdWlja0NvbnNvbGUucHJv dG90eXBlLnNldCBrZXlib2FyZFNob3J0Y3V0RGlzYWJsZWQpOgorICAgICAgICBSZXN0b3JlIGtl eWJvYXJkU2hvcnRjdXREaXNhYmxlZCBzZXR0ZXIsIHdoaWNoIHdhcyByZW1vdmVkIGluIHIyMTg4 Mzkgd2l0aG91dCBhbnkgZXhwbGFuYXRpb24uCisKIDIwMTktMTItMjAgIE5pa2l0YSBWYXNpbHll diAgPG52YXNpbHlldkBhcHBsZS5jb20+CiAKICAgICAgICAgV2ViIEluc3BlY3RvcjogR3JhZGll bnQgZWRpdG9yOiBvcGFjaXR5IHNsaWRlciBpcyB0b28gY2xvc2UgdG8gdGhlIHJpZ2h0IGVkZ2Ug b2YgdGhlIHBvcG92ZXIKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50 ZXJmYWNlL1ZpZXdzL1F1aWNrQ29uc29sZS5qcyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2Vy SW50ZXJmYWNlL1ZpZXdzL1F1aWNrQ29uc29sZS5qcwppbmRleCA2OWYzMDVlNWM5MC4uOTFkMjI2 NjlhNDYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1Zp ZXdzL1F1aWNrQ29uc29sZS5qcworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVy ZmFjZS9WaWV3cy9RdWlja0NvbnNvbGUuanMKQEAgLTEwMSw2ICsxMDEsMTEgQEAgV0kuUXVpY2tD b25zb2xlID0gY2xhc3MgUXVpY2tDb25zb2xlIGV4dGVuZHMgV0kuVmlldwogICAgICAgICByZXR1 cm4gdGhpcy5fbmF2aWdhdGlvbkJhcjsKICAgICB9CiAKKyAgICBzZXQga2V5Ym9hcmRTaG9ydGN1 dERpc2FibGVkKGRpc2FibGVkKQorICAgIHsKKyAgICAgICAgdGhpcy5fdG9nZ2xlT3JGb2N1c0tl eWJvYXJkU2hvcnRjdXQuZGlzYWJsZWQgPSBkaXNhYmxlZDsKKyAgICB9CisKICAgICBjbG9zZWQo KQogICAgIHsKICAgICAgICAgV0kuc2V0dGluZ3MuY29uc29sZVNhdmVkUmVzdWx0QWxpYXMucmVt b3ZlRXZlbnRMaXN0ZW5lcihudWxsLCBudWxsLCB0aGlzKTsK 386741 2020-01-03 18:41:01 -0800 2020-01-06 10:24:34 -0800 Patch patch.txt text/plain 2387 nvasilyev ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IGQwMGQwNTFhOWU0Li5kYzI1MTFlOWJiNyAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMjAtMDEtMDMgIE5pa2l0 YSBWYXNpbHlldiAgPG52YXNpbHlldkBhcHBsZS5jb20+CisKKyAgICAgICAgUkVHUkVTU0lPTihy MjE4ODM5KTogV2ViIEluc3BlY3RvcjogQ29sb3IgcGlja2VyOiBwcmVzc2luZyBFc2Mgc2hvdWxk IGhpZGUgY29sb3IgcGlja2VyCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0yMDU1NzAKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzU4MTY5ODIwPgorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogVXNlckludGVy ZmFjZS9WaWV3cy9RdWlja0NvbnNvbGUuanM6CisgICAgICAgIChXSS5RdWlja0NvbnNvbGUucHJv dG90eXBlLnNldCBrZXlib2FyZFNob3J0Y3V0RGlzYWJsZWQpOgorICAgICAgICAoV0kuUXVpY2tD b25zb2xlLnByb3RvdHlwZS5fdG9nZ2xlT3JGb2N1cyk6CisgICAgICAgIFJlc3RvcmUga2V5Ym9h cmRTaG9ydGN1dERpc2FibGVkIHNldHRlciwgd2hpY2ggd2FzIHJlbW92ZWQgaW4gcjIxODgzOSB3 aXRob3V0IGFueSBleHBsYW5hdGlvbi4KKwogMjAxOS0xMi0yMCAgTmlraXRhIFZhc2lseWV2ICA8 bnZhc2lseWV2QGFwcGxlLmNvbT4KIAogICAgICAgICBXZWIgSW5zcGVjdG9yOiBHcmFkaWVudCBl ZGl0b3I6IG9wYWNpdHkgc2xpZGVyIGlzIHRvbyBjbG9zZSB0byB0aGUgcmlnaHQgZWRnZSBvZiB0 aGUgcG9wb3ZlcgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZh Y2UvVmlld3MvUXVpY2tDb25zb2xlLmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRl cmZhY2UvVmlld3MvUXVpY2tDb25zb2xlLmpzCmluZGV4IDY5ZjMwNWU1YzkwLi5mYzlhODhiZGU0 ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3Mv UXVpY2tDb25zb2xlLmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNl L1ZpZXdzL1F1aWNrQ29uc29sZS5qcwpAQCAtMzEsNiArMzEsNyBAQCBXSS5RdWlja0NvbnNvbGUg PSBjbGFzcyBRdWlja0NvbnNvbGUgZXh0ZW5kcyBXSS5WaWV3CiAKICAgICAgICAgdGhpcy5fdG9n Z2xlT3JGb2N1c0tleWJvYXJkU2hvcnRjdXQgPSBuZXcgV0kuS2V5Ym9hcmRTaG9ydGN1dChudWxs LCBXSS5LZXlib2FyZFNob3J0Y3V0LktleS5Fc2NhcGUsIHRoaXMuX3RvZ2dsZU9yRm9jdXMuYmlu ZCh0aGlzKSk7CiAgICAgICAgIHRoaXMuX3RvZ2dsZU9yRm9jdXNLZXlib2FyZFNob3J0Y3V0Lmlt cGxpY2l0bHlQcmV2ZW50c0RlZmF1bHQgPSBmYWxzZTsKKyAgICAgICAgdGhpcy5fa2V5Ym9hcmRT aG9ydGN1dERpc2FibGVkID0gZmFsc2U7CiAKICAgICAgICAgdGhpcy5fYXV0b21hdGljRXhlY3V0 aW9uQ29udGV4dFBhdGhDb21wb25lbnQgPSB0aGlzLl9jcmVhdGVFeGVjdXRpb25Db250ZXh0UGF0 aENvbXBvbmVudChudWxsLCBXSS5VSVN0cmluZygiQXV0byIpKTsKICAgICAgICAgdGhpcy5fdXBk YXRlQXV0b21hdGljRXhlY3V0aW9uQ29udGV4dFBhdGhDb21wb25lbnRUb29sdGlwKCk7CkBAIC0x MDEsNiArMTAyLDExIEBAIFdJLlF1aWNrQ29uc29sZSA9IGNsYXNzIFF1aWNrQ29uc29sZSBleHRl bmRzIFdJLlZpZXcKICAgICAgICAgcmV0dXJuIHRoaXMuX25hdmlnYXRpb25CYXI7CiAgICAgfQog CisgICAgc2V0IGtleWJvYXJkU2hvcnRjdXREaXNhYmxlZChkaXNhYmxlZCkKKyAgICB7CisgICAg ICAgIHRoaXMuX2tleWJvYXJkU2hvcnRjdXREaXNhYmxlZCA9IGRpc2FibGVkOworICAgIH0KKwog ICAgIGNsb3NlZCgpCiAgICAgewogICAgICAgICBXSS5zZXR0aW5ncy5jb25zb2xlU2F2ZWRSZXN1 bHRBbGlhcy5yZW1vdmVFdmVudExpc3RlbmVyKG51bGwsIG51bGwsIHRoaXMpOwpAQCAtNDQ2LDYg KzQ1Miw5IEBAIFdJLlF1aWNrQ29uc29sZSA9IGNsYXNzIFF1aWNrQ29uc29sZSBleHRlbmRzIFdJ LlZpZXcKIAogICAgIF90b2dnbGVPckZvY3VzKGV2ZW50KQogICAgIHsKKyAgICAgICAgaWYgKHRo aXMuX2tleWJvYXJkU2hvcnRjdXREaXNhYmxlZCkKKyAgICAgICAgICAgIHJldHVybjsKKwogICAg ICAgICBpZiAodGhpcy5wcm9tcHQuZm9jdXNlZCkgewogICAgICAgICAgICAgV0kudG9nZ2xlU3Bs aXRDb25zb2xlKCk7CiAgICAgICAgICAgICBldmVudC5wcmV2ZW50RGVmYXVsdCgpOwo=