<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>205564</bug_id>
          
          <creation_ts>2019-12-23 12:01:28 -0800</creation_ts>
          <short_desc>Provide pid to crashing service worker process and GPU process</short_desc>
          <delta_ts>2020-01-05 02:20:43 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Service Workers</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="youenn fablet">youennf</reporter>
          <assigned_to name="youenn fablet">youennf</assigned_to>
          <cc>achristensen</cc>
    
    <cc>commit-queue</cc>
    
    <cc>darin</cc>
    
    <cc>dino</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1601276</commentid>
    <comment_count>0</comment_count>
    <who name="youenn fablet">youennf</who>
    <bug_when>2019-12-23 12:01:28 -0800</bug_when>
    <thetext>Provide pid to crashing service worker process and GPU process</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1601284</commentid>
    <comment_count>1</comment_count>
      <attachid>386348</attachid>
    <who name="youenn fablet">youennf</who>
    <bug_when>2019-12-23 12:20:35 -0800</bug_when>
    <thetext>Created attachment 386348
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1601559</commentid>
    <comment_count>2</comment_count>
      <attachid>386348</attachid>
    <who name="Darin Adler">darin</who>
    <bug_when>2019-12-26 20:41:37 -0800</bug_when>
    <thetext>Comment on attachment 386348
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=386348&amp;action=review

&gt; Source/WebKit/ChangeLog:8
&gt; +        No change of behavior, we provide pids to the WKContext callbacks.

Why are we doing this to the C API rather than the Objective-C/Swift API?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1601586</commentid>
    <comment_count>3</comment_count>
    <who name="youenn fablet">youennf</who>
    <bug_when>2019-12-27 01:24:03 -0800</bug_when>
    <thetext>(In reply to Darin Adler from comment #2)
&gt; Comment on attachment 386348 [details]
&gt; Patch
&gt; 
&gt; View in context:
&gt; https://bugs.webkit.org/attachment.cgi?id=386348&amp;action=review
&gt; 
&gt; &gt; Source/WebKit/ChangeLog:8
&gt; &gt; +        No change of behavior, we provide pids to the WKContext callbacks.
&gt; 
&gt; Why are we doing this to the C API rather than the Objective-C/Swift API?

We could do both but the only use case is to allow better WebKitTestRunner error reporting and the API in use is the cross platform C API.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1602175</commentid>
    <comment_count>4</comment_count>
      <attachid>386348</attachid>
    <who name="Alex Christensen">achristensen</who>
    <bug_when>2020-01-02 10:57:04 -0800</bug_when>
    <thetext>Comment on attachment 386348
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=386348&amp;action=review

&gt; Source/WebKit/UIProcess/API/C/WKContext.h:60
&gt;  typedef void (*WKContextChildProcessDidCrashCallback)(WKContextRef context, const void *clientInfo);
&gt;  typedef WKContextChildProcessDidCrashCallback WKContextNetworkProcessDidCrashCallback;

Are these still needed.

&gt; Source/WebKit/UIProcess/API/C/WKContext.h:116
&gt; -    WKContextChildProcessDidCrashCallback                               serviceWorkerProcessDidCrash;
&gt; -    WKContextChildProcessDidCrashCallback                               gpuProcessDidCrash;
&gt; +    WKContextChildProcessWithPIDDidCrashCallback                        serviceWorkerProcessDidCrash;
&gt; +    WKContextChildProcessWithPIDDidCrashCallback                        gpuProcessDidCrash;

This is not a binary-compatible change.  Do we have any clients using these except WebKitTestRunner?  If so, we will need to add WKContextClientV4</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1602369</commentid>
    <comment_count>5</comment_count>
      <attachid>386348</attachid>
    <who name="youenn fablet">youennf</who>
    <bug_when>2020-01-03 01:39:00 -0800</bug_when>
    <thetext>Comment on attachment 386348
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=386348&amp;action=review

&gt;&gt; Source/WebKit/UIProcess/API/C/WKContext.h:60
&gt;&gt;  typedef WKContextChildProcessDidCrashCallback WKContextNetworkProcessDidCrashCallback;
&gt; 
&gt; Are these still needed.

Yes, WKContextNetworkProcessDidCrashCallback is still in use.

&gt;&gt; Source/WebKit/UIProcess/API/C/WKContext.h:116
&gt;&gt; +    WKContextChildProcessWithPIDDidCrashCallback                        gpuProcessDidCrash;
&gt; 
&gt; This is not a binary-compatible change.  Do we have any clients using these except WebKitTestRunner?  If so, we will need to add WKContextClientV4

serviceWorkerProcessDidCrash and gpuProcessDidCrash have been recently added mid December 2019 and at that time, the version was incremented.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1602491</commentid>
    <comment_count>6</comment_count>
      <attachid>386348</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2020-01-03 10:05:02 -0800</bug_when>
    <thetext>Comment on attachment 386348
Patch

Clearing flags on attachment: 386348

Committed r254006: &lt;https://trac.webkit.org/changeset/254006&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1602492</commentid>
    <comment_count>7</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2020-01-03 10:05:04 -0800</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1602494</commentid>
    <comment_count>8</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2020-01-03 10:06:20 -0800</bug_when>
    <thetext>&lt;rdar://problem/58300321&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1602531</commentid>
    <comment_count>9</comment_count>
      <attachid>386348</attachid>
    <who name="Alex Christensen">achristensen</who>
    <bug_when>2020-01-03 11:22:33 -0800</bug_when>
    <thetext>Comment on attachment 386348
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=386348&amp;action=review

&gt; Source/WebKit/UIProcess/API/C/WKContext.h:62
&gt; +using WKContextChildProcessWithPIDDidCrashCallback = void (*)(WKContextRef, WKProcessID, const void *clientInfo);

As pointed out by Keith Rollin, this line needs to be as follows because this is a C API:

typedef void (*WKContextChildProcessWithPIDDidCrashCallback)(WKContextRef context, WKProcessID processID, const void *clientInfo);</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1602570</commentid>
    <comment_count>10</comment_count>
    <who name="Dean Jackson">dino</who>
    <bug_when>2020-01-03 13:54:21 -0800</bug_when>
    <thetext>Fixed in r254012</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1602834</commentid>
    <comment_count>11</comment_count>
    <who name="youenn fablet">youennf</who>
    <bug_when>2020-01-05 02:20:43 -0800</bug_when>
    <thetext>(In reply to Dean Jackson from comment #10)
&gt; Fixed in r254012

Thanks!</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>386348</attachid>
            <date>2019-12-23 12:20:35 -0800</date>
            <delta_ts>2020-01-03 10:05:02 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-205564-20191223212033.patch</filename>
            <type>text/plain</type>
            <size>12274</size>
            <attacher name="youenn fablet">youennf</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjUzODgzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No
YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDk3MDEyNTJhOGM5YmQ0ZmJj
NjU1NTg1YTBkNmRhOTI3NzVkOWMyZmUuLmQ5MDU3YTZjZjk3ZDE4NjhjM2RiMTA2YWM4ZjBmMDcw
NzRhOTM3NWQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj
ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjUgQEAKKzIwMTktMTItMjMgIHlvdWVubiBm
YWJsZXQgIDx5b3Vlbm5AYXBwbGUuY29tPgorCisgICAgICAgIFByb3ZpZGUgcGlkIHRvIGNyYXNo
aW5nIHNlcnZpY2Ugd29ya2VyIHByb2Nlc3MgYW5kIEdQVSBwcm9jZXNzCisgICAgICAgIGh0dHBz
Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDU1NjQKKworICAgICAgICBSZXZp
ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBObyBjaGFuZ2Ugb2YgYmVoYXZpb3Is
IHdlIHByb3ZpZGUgcGlkcyB0byB0aGUgV0tDb250ZXh0IGNhbGxiYWNrcy4KKworICAgICAgICAq
IFVJUHJvY2Vzcy9BUEkvQy9XS0NvbnRleHQuaDoKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL0Mv
V0tDb250ZXh0UHJpdmF0ZS5oOgorICAgICAgICAqIFVJUHJvY2Vzcy9HUFUvR1BVUHJvY2Vzc1By
b3h5LmNwcDoKKyAgICAgICAgKFdlYktpdDo6R1BVUHJvY2Vzc1Byb3h5OjpncHVQcm9jZXNzQ3Jh
c2hlZCk6CisgICAgICAgICogVUlQcm9jZXNzL1dlYkNvbnRleHRDbGllbnQuY3BwOgorICAgICAg
ICAoV2ViS2l0OjpXZWJDb250ZXh0Q2xpZW50OjpzZXJ2aWNlV29ya2VyUHJvY2Vzc0RpZENyYXNo
KToKKyAgICAgICAgKFdlYktpdDo6V2ViQ29udGV4dENsaWVudDo6Z3B1UHJvY2Vzc0RpZENyYXNo
KToKKyAgICAgICAgKiBVSVByb2Nlc3MvV2ViQ29udGV4dENsaWVudC5oOgorICAgICAgICAqIFVJ
UHJvY2Vzcy9XZWJQcm9jZXNzUG9vbC5jcHA6CisgICAgICAgIChXZWJLaXQ6OldlYlByb2Nlc3NQ
b29sOjpzZXJ2aWNlV29ya2VyUHJvY2Vzc0NyYXNoZWQpOgorICAgICAgICAoV2ViS2l0OjpXZWJQ
cm9jZXNzUG9vbDo6Z3B1UHJvY2Vzc0NyYXNoZWQpOgorICAgICAgICAqIFVJUHJvY2Vzcy9XZWJQ
cm9jZXNzUG9vbC5oOgorCiAyMDE5LTEyLTIzICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNnYXJj
aWFAaWdhbGlhLmNvbT4KIAogICAgICAgICBXZWJEcml2ZXI6IGZpeCBoYW5kbGluZyBvZiBzZXNz
aW9uIHRpbWVvdXRzIGZvciB2YWx1ZXMgaGlnaGVyIHRoYW4gTUFYX0lOVApkaWZmIC0tZ2l0IGEv
U291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL0MvV0tDb250ZXh0LmggYi9Tb3VyY2UvV2ViS2l0
L1VJUHJvY2Vzcy9BUEkvQy9XS0NvbnRleHQuaAppbmRleCAzZWFhMzU2NTQ3OWJmZWQ5OWRkNDlh
NmQ1MzU5ZDYyZjQxYTdkZmRlLi5mOTJmY2ViYTQzMzRjOTdlNzIyYTUxOTUzYTNhYWNhMDE5ODNj
M2RmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvQy9XS0NvbnRleHQu
aAorKysgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvQy9XS0NvbnRleHQuaApAQCAtMzMs
NiArMzMsMTMgQEAKICNpbmNsdWRlIDxXZWJLaXQvV0tDb250ZXh0SW5qZWN0ZWRCdW5kbGVDbGll
bnQuaD4KICNpbmNsdWRlIDxXZWJLaXQvV0tEZXByZWNhdGVkLmg+CiAKKyNpZiBkZWZpbmVkKFdJ
TjMyKSB8fCBkZWZpbmVkKF9XSU4zMikKK3R5cGVkZWYgaW50IFdLUHJvY2Vzc0lEOworI2Vsc2UK
KyNpbmNsdWRlIDx1bmlzdGQuaD4KK3R5cGVkZWYgcGlkX3QgV0tQcm9jZXNzSUQ7CisjZW5kaWYK
KwogI2lmZGVmIF9fY3BsdXNwbHVzCiBleHRlcm4gIkMiIHsKICNlbmRpZgpAQCAtNTIsNiArNTks
OCBAQCB0eXBlZGVmIFdLRGF0YVJlZiAoKldLQ29udGV4dENvcHlXZWJDcnlwdG9NYXN0ZXJLZXlD
YWxsYmFjaykoV0tDb250ZXh0UmVmIGNvbnRleAogdHlwZWRlZiB2b2lkICgqV0tDb250ZXh0Q2hp
bGRQcm9jZXNzRGlkQ3Jhc2hDYWxsYmFjaykoV0tDb250ZXh0UmVmIGNvbnRleHQsIGNvbnN0IHZv
aWQgKmNsaWVudEluZm8pOwogdHlwZWRlZiBXS0NvbnRleHRDaGlsZFByb2Nlc3NEaWRDcmFzaENh
bGxiYWNrIFdLQ29udGV4dE5ldHdvcmtQcm9jZXNzRGlkQ3Jhc2hDYWxsYmFjazsKIAordXNpbmcg
V0tDb250ZXh0Q2hpbGRQcm9jZXNzV2l0aFBJRERpZENyYXNoQ2FsbGJhY2sgPSB2b2lkICgqKShX
S0NvbnRleHRSZWYsIFdLUHJvY2Vzc0lELCBjb25zdCB2b2lkICpjbGllbnRJbmZvKTsKKwogdHlw
ZWRlZiBzdHJ1Y3QgV0tDb250ZXh0Q2xpZW50QmFzZSB7CiAgICAgaW50ICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB2ZXJzaW9u
OwogICAgIGNvbnN0IHZvaWQgKiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgY2xpZW50SW5mbzsKQEAgLTEwMyw4ICsxMTIsOCBAQCB0eXBlZGVm
IHN0cnVjdCBXS0NvbnRleHRDbGllbnRWMyB7CiAgICAgdm9pZCAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAoKmNvcHlXZWJDcnlw
dG9NYXN0ZXJLZXlfdW5hdmFpbGFibGUpKHZvaWQpOwogCiAgICAgLy8gVmVyc2lvbjIuCi0gICAg
V0tDb250ZXh0Q2hpbGRQcm9jZXNzRGlkQ3Jhc2hDYWxsYmFjayAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICBzZXJ2aWNlV29ya2VyUHJvY2Vzc0RpZENyYXNoOwotICAgIFdLQ29udGV4dENo
aWxkUHJvY2Vzc0RpZENyYXNoQ2FsbGJhY2sgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
Z3B1UHJvY2Vzc0RpZENyYXNoOworICAgIFdLQ29udGV4dENoaWxkUHJvY2Vzc1dpdGhQSUREaWRD
cmFzaENhbGxiYWNrICAgICAgICAgICAgICAgICAgICAgICAgc2VydmljZVdvcmtlclByb2Nlc3NE
aWRDcmFzaDsKKyAgICBXS0NvbnRleHRDaGlsZFByb2Nlc3NXaXRoUElERGlkQ3Jhc2hDYWxsYmFj
ayAgICAgICAgICAgICAgICAgICAgICAgIGdwdVByb2Nlc3NEaWRDcmFzaDsKIH0gV0tDb250ZXh0
Q2xpZW50VjM7CiAKIC8vIEZJWE1FOiBSZW1vdmUgdGhlc2Ugb25jZSBzdXBwb3J0IGZvciBNYXZl
cmlja3MgaGFzIGJlZW4gZHJvcHBlZC4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvVUlQcm9j
ZXNzL0FQSS9DL1dLQ29udGV4dFByaXZhdGUuaCBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQ
SS9DL1dLQ29udGV4dFByaXZhdGUuaAppbmRleCA3OTAzMThlMGQ4NWQ0M2Y5MDhlMWUyYWZjYmZh
YmYxYzU3NjYzZWVjLi5lNzc2Yjc0Yzk1NGZjZWM3NTExMDA4NDRjNjhmZGY2NTQ4ODkwZjkyIDEw
MDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvQy9XS0NvbnRleHRQcml2YXRl
LmgKKysrIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL0MvV0tDb250ZXh0UHJpdmF0ZS5o
CkBAIC0yOSwxMyArMjksNiBAQAogI2luY2x1ZGUgPFdlYktpdC9XS0Jhc2UuaD4KICNpbmNsdWRl
IDxXZWJLaXQvV0tDb250ZXh0Lmg+CiAKLSNpZiBkZWZpbmVkKFdJTjMyKSB8fCBkZWZpbmVkKF9X
SU4zMikKLXR5cGVkZWYgaW50IFdLUHJvY2Vzc0lEOwotI2Vsc2UKLSNpbmNsdWRlIDx1bmlzdGQu
aD4KLXR5cGVkZWYgcGlkX3QgV0tQcm9jZXNzSUQ7Ci0jZW5kaWYKLQogI2lmZGVmIF9fY3BsdXNw
bHVzCiBleHRlcm4gIkMiIHsKICNlbmRpZgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9VSVBy
b2Nlc3MvR1BVL0dQVVByb2Nlc3NQcm94eS5jcHAgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9H
UFUvR1BVUHJvY2Vzc1Byb3h5LmNwcAppbmRleCBlMzJlMWMwOGQ3NGEzMzkyNmQ3ZDBkMTBiYjE2
NmI5ZDZiNmI4Mzk4Li5iMmJiYmMyMWM3NWQyYzQ5ZWNhNjM1N2E5Y2MyNWQ2Y2Y2YjhjODRkIDEw
MDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9HUFUvR1BVUHJvY2Vzc1Byb3h5LmNw
cAorKysgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9HUFUvR1BVUHJvY2Vzc1Byb3h5LmNwcApA
QCAtMTM5LDcgKzEzOSw3IEBAIHZvaWQgR1BVUHJvY2Vzc1Byb3h5OjpvcGVuR1BVUHJvY2Vzc0Nv
bm5lY3Rpb24oQ29ubmVjdGlvblJlcXVlc3RJZGVudGlmaWVyIGNvbm5lCiB2b2lkIEdQVVByb2Nl
c3NQcm94eTo6Z3B1UHJvY2Vzc0NyYXNoZWQoKQogewogICAgIGZvciAoYXV0byYgcHJvY2Vzc1Bv
b2wgOiBXZWJQcm9jZXNzUG9vbDo6YWxsUHJvY2Vzc1Bvb2xzKCkpCi0gICAgICAgIHByb2Nlc3NQ
b29sLT5ncHVQcm9jZXNzQ3Jhc2hlZCgpOworICAgICAgICBwcm9jZXNzUG9vbC0+Z3B1UHJvY2Vz
c0NyYXNoZWQocHJvY2Vzc0lkZW50aWZpZXIoKSk7CiB9CiAKIHZvaWQgR1BVUHJvY2Vzc1Byb3h5
OjpkaWRDbG9zZShJUEM6OkNvbm5lY3Rpb24mKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9V
SVByb2Nlc3MvV2ViQ29udGV4dENsaWVudC5jcHAgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9X
ZWJDb250ZXh0Q2xpZW50LmNwcAppbmRleCBkYjViZWVkYWJjZWM2MWYzNjRiOGY4NmI1YjllZTUw
M2IyNWJkY2JmLi5hMjUyOGMyYzBlMGQ3ZTEzMDk4NjE2YjMxNTA4ODY2ZWY5ODQ3NjEzIDEwMDY0
NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9XZWJDb250ZXh0Q2xpZW50LmNwcAorKysg
Yi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9XZWJDb250ZXh0Q2xpZW50LmNwcApAQCAtNDYsMjAg
KzQ2LDIwIEBAIHZvaWQgV2ViQ29udGV4dENsaWVudDo6bmV0d29ya1Byb2Nlc3NEaWRDcmFzaChX
ZWJQcm9jZXNzUG9vbCogcHJvY2Vzc1Bvb2wpCiAgICAgbV9jbGllbnQubmV0d29ya1Byb2Nlc3NE
aWRDcmFzaCh0b0FQSShwcm9jZXNzUG9vbCksIG1fY2xpZW50LmJhc2UuY2xpZW50SW5mbyk7CiB9
CiAKLXZvaWQgV2ViQ29udGV4dENsaWVudDo6c2VydmljZVdvcmtlclByb2Nlc3NEaWRDcmFzaChX
ZWJQcm9jZXNzUG9vbCogcHJvY2Vzc1Bvb2wpCit2b2lkIFdlYkNvbnRleHRDbGllbnQ6OnNlcnZp
Y2VXb3JrZXJQcm9jZXNzRGlkQ3Jhc2goV2ViUHJvY2Vzc1Bvb2wqIHByb2Nlc3NQb29sLCBQcm9j
ZXNzSUQgcHJvY2Vzc0lEKQogewogICAgIGlmICghbV9jbGllbnQuc2VydmljZVdvcmtlclByb2Nl
c3NEaWRDcmFzaCkKICAgICAgICAgcmV0dXJuOwogCi0gICAgbV9jbGllbnQuc2VydmljZVdvcmtl
clByb2Nlc3NEaWRDcmFzaCh0b0FQSShwcm9jZXNzUG9vbCksIG1fY2xpZW50LmJhc2UuY2xpZW50
SW5mbyk7CisgICAgbV9jbGllbnQuc2VydmljZVdvcmtlclByb2Nlc3NEaWRDcmFzaCh0b0FQSShw
cm9jZXNzUG9vbCksIHByb2Nlc3NJRCwgbV9jbGllbnQuYmFzZS5jbGllbnRJbmZvKTsKIH0KIAot
dm9pZCBXZWJDb250ZXh0Q2xpZW50OjpncHVQcm9jZXNzRGlkQ3Jhc2goV2ViUHJvY2Vzc1Bvb2wq
IHByb2Nlc3NQb29sKQordm9pZCBXZWJDb250ZXh0Q2xpZW50OjpncHVQcm9jZXNzRGlkQ3Jhc2go
V2ViUHJvY2Vzc1Bvb2wqIHByb2Nlc3NQb29sLCBQcm9jZXNzSUQgcHJvY2Vzc0lEKQogewogICAg
IGlmICghbV9jbGllbnQuZ3B1UHJvY2Vzc0RpZENyYXNoKQogICAgICAgICByZXR1cm47CiAKLSAg
ICBtX2NsaWVudC5ncHVQcm9jZXNzRGlkQ3Jhc2godG9BUEkocHJvY2Vzc1Bvb2wpLCBtX2NsaWVu
dC5iYXNlLmNsaWVudEluZm8pOworICAgIG1fY2xpZW50LmdwdVByb2Nlc3NEaWRDcmFzaCh0b0FQ
SShwcm9jZXNzUG9vbCksIHByb2Nlc3NJRCwgbV9jbGllbnQuYmFzZS5jbGllbnRJbmZvKTsKIH0K
IAogfSAvLyBuYW1lc3BhY2UgV2ViS2l0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1VJUHJv
Y2Vzcy9XZWJDb250ZXh0Q2xpZW50LmggYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9XZWJDb250
ZXh0Q2xpZW50LmgKaW5kZXggZDkxODE2YzM5YTliODE0ODRiM2I2MzVlMTEwNzdlYjY5MDNiNjBj
OC4uNzRjYmY2NzI0MzM3NjFiMGE4YzIwZmExZGMzNjE5ZDQ1YTkyYWVmZSAxMDA2NDQKLS0tIGEv
U291cmNlL1dlYktpdC9VSVByb2Nlc3MvV2ViQ29udGV4dENsaWVudC5oCisrKyBiL1NvdXJjZS9X
ZWJLaXQvVUlQcm9jZXNzL1dlYkNvbnRleHRDbGllbnQuaApAQCAtNDUsOCArNDUsOCBAQCBjbGFz
cyBXZWJDb250ZXh0Q2xpZW50IDogcHVibGljIEFQSTo6Q2xpZW50PFdLQ29udGV4dENsaWVudEJh
c2U+IHsKIHB1YmxpYzoKICAgICB2b2lkIHBsdWdJbkF1dG9TdGFydE9yaWdpbkhhc2hlc0NoYW5n
ZWQoV2ViUHJvY2Vzc1Bvb2wqKTsKICAgICB2b2lkIG5ldHdvcmtQcm9jZXNzRGlkQ3Jhc2goV2Vi
UHJvY2Vzc1Bvb2wqKTsKLSAgICB2b2lkIHNlcnZpY2VXb3JrZXJQcm9jZXNzRGlkQ3Jhc2goV2Vi
UHJvY2Vzc1Bvb2wqKTsKLSAgICB2b2lkIGdwdVByb2Nlc3NEaWRDcmFzaChXZWJQcm9jZXNzUG9v
bCopOworICAgIHZvaWQgc2VydmljZVdvcmtlclByb2Nlc3NEaWRDcmFzaChXZWJQcm9jZXNzUG9v
bCosIFByb2Nlc3NJRCk7CisgICAgdm9pZCBncHVQcm9jZXNzRGlkQ3Jhc2goV2ViUHJvY2Vzc1Bv
b2wqLCBQcm9jZXNzSUQpOwogfTsKIAogfSAvLyBuYW1lc3BhY2UgV2ViS2l0CmRpZmYgLS1naXQg
YS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9XZWJQcm9jZXNzUG9vbC5jcHAgYi9Tb3VyY2UvV2Vi
S2l0L1VJUHJvY2Vzcy9XZWJQcm9jZXNzUG9vbC5jcHAKaW5kZXggODUwMTUyYWUyMDkyMjI4ZmZh
NTFjZWU5MGEzODFkMjY5ZWRiNDc4OC4uY2NhZDVjYjFjZTRjNDg4MTNkMTk2ODBmNDViZjk3NDFl
ZmQxNjIxYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvV2ViUHJvY2Vzc1Bv
b2wuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL1dlYlByb2Nlc3NQb29sLmNwcApA
QCAtNjk5LDcgKzY5OSw3IEBAIHZvaWQgV2ViUHJvY2Vzc1Bvb2w6Om5ldHdvcmtQcm9jZXNzQ3Jh
c2hlZChOZXR3b3JrUHJvY2Vzc1Byb3h5JiBuZXR3b3JrUHJvY2Vzc1ByCiB2b2lkIFdlYlByb2Nl
c3NQb29sOjpzZXJ2aWNlV29ya2VyUHJvY2Vzc0NyYXNoZWQoV2ViUHJvY2Vzc1Byb3h5JiBwcm94
eSkKIHsKICNpZiBFTkFCTEUoU0VSVklDRV9XT1JLRVIpCi0gICAgbV9jbGllbnQuc2VydmljZVdv
cmtlclByb2Nlc3NEaWRDcmFzaCh0aGlzKTsKKyAgICBtX2NsaWVudC5zZXJ2aWNlV29ya2VyUHJv
Y2Vzc0RpZENyYXNoKHRoaXMsIHByb3h5LnByb2Nlc3NJZGVudGlmaWVyKCkpOwogI2VuZGlmCiB9
CiAKQEAgLTcxMiw5ICs3MTIsOSBAQCB2b2lkIFdlYlByb2Nlc3NQb29sOjpnZXROZXR3b3JrUHJv
Y2Vzc0Nvbm5lY3Rpb24oV2ViUHJvY2Vzc1Byb3h5JiB3ZWJQcm9jZXNzUHJveAogfQogCiAjaWYg
RU5BQkxFKEdQVV9QUk9DRVNTKQotdm9pZCBXZWJQcm9jZXNzUG9vbDo6Z3B1UHJvY2Vzc0NyYXNo
ZWQoKQordm9pZCBXZWJQcm9jZXNzUG9vbDo6Z3B1UHJvY2Vzc0NyYXNoZWQoUHJvY2Vzc0lEIGlk
ZW50aWZpZXIpCiB7Ci0gICAgbV9jbGllbnQuZ3B1UHJvY2Vzc0RpZENyYXNoKHRoaXMpOworICAg
IG1fY2xpZW50LmdwdVByb2Nlc3NEaWRDcmFzaCh0aGlzLCBpZGVudGlmaWVyKTsKICAgICB0ZXJt
aW5hdGVBbGxXZWJDb250ZW50UHJvY2Vzc2VzKCk7CiB9CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9X
ZWJLaXQvVUlQcm9jZXNzL1dlYlByb2Nlc3NQb29sLmggYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vz
cy9XZWJQcm9jZXNzUG9vbC5oCmluZGV4IDBjOTUwYTJlZDg3NjY4MDM2ZjNiZWFlOTgzN2ZiOGQx
ZDAwNTIxNTIuLmI3Yzk1NWE1ZjNlYmU1ODA1YWQ3MDk1YmMwNjg3OGUxMjhkMTE1NjggMTAwNjQ0
Ci0tLSBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL1dlYlByb2Nlc3NQb29sLmgKKysrIGIvU291
cmNlL1dlYktpdC9VSVByb2Nlc3MvV2ViUHJvY2Vzc1Bvb2wuaApAQCAtMzg0LDcgKzM4NCw3IEBA
IHB1YmxpYzoKICAgICB2b2lkIHNldFBsdWdJbkF1dG9TdGFydE9yaWdpbnNGaWx0ZXJpbmdPdXRF
bnRyaWVzQWRkZWRBZnRlclRpbWUoQVBJOjpEaWN0aW9uYXJ5JiwgV2FsbFRpbWUpOwogCiAjaWYg
RU5BQkxFKEdQVV9QUk9DRVNTKQotICAgIHZvaWQgZ3B1UHJvY2Vzc0NyYXNoZWQoKTsKKyAgICB2
b2lkIGdwdVByb2Nlc3NDcmFzaGVkKFByb2Nlc3NJRCk7CiAgICAgdm9pZCBnZXRHUFVQcm9jZXNz
Q29ubmVjdGlvbihXZWJQcm9jZXNzUHJveHkmLCBNZXNzYWdlczo6V2ViUHJvY2Vzc1Byb3h5OjpH
ZXRHUFVQcm9jZXNzQ29ubmVjdGlvbkRlbGF5ZWRSZXBseSYmKTsKICNlbmRpZgogCmRpZmYgLS1n
aXQgYS9Ub29scy9DaGFuZ2VMb2cgYi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggYTA4ZTEzYTRhZWZi
MGE1YzdhY2I0Y2Q4ZDcwOTA0ZThhN2I3ZWFhMy4uNTdmNWM5ZWM1ZTM0ZDY2ZjVmMWZmZTMxMTU3
ZTc3N2RjODdjODNmNSAxMDA2NDQKLS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0No
YW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE5LTEyLTIzICB5b3Vlbm4gZmFibGV0ICA8eW91
ZW5uQGFwcGxlLmNvbT4KKworICAgICAgICBQcm92aWRlIHBpZCB0byBjcmFzaGluZyBzZXJ2aWNl
IHdvcmtlciBwcm9jZXNzIGFuZCBHUFUgcHJvY2VzcworICAgICAgICBodHRwczovL2J1Z3Mud2Vi
a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjA1NTY0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C
T0RZIChPT1BTISkuCisKKyAgICAgICAgRXhwb3NpbmcgdGhlIHBpZCBhbGxvd3MgV2ViS2l0VGVz
dFJ1bm5lciB0byBwcm92aWRlIGJldHRlciBpbmZvcm1hdGlvbi4KKworICAgICAgICAqIFdlYktp
dFRlc3RSdW5uZXIvVGVzdENvbnRyb2xsZXIuY3BwOgorICAgICAgICAoV1RSOjpUZXN0Q29udHJv
bGxlcjo6c2VydmljZVdvcmtlclByb2Nlc3NEaWRDcmFzaCk6CisgICAgICAgIChXVFI6OlRlc3RD
b250cm9sbGVyOjpncHVQcm9jZXNzRGlkQ3Jhc2gpOgorICAgICAgICAqIFdlYktpdFRlc3RSdW5u
ZXIvVGVzdENvbnRyb2xsZXIuaDoKKwogMjAxOS0xMi0yMyAgQ2FybG9zIEdhcmNpYSBDYW1wb3Mg
IDxjZ2FyY2lhQGlnYWxpYS5jb20+CiAKICAgICAgICAgW0dUS10gSW5wdXRNZXRob2QgQVBJIHVu
aXQgdGVzdHMgZG9uJ3Qgd29yayB1bmRlciBYMTEKZGlmZiAtLWdpdCBhL1Rvb2xzL1dlYktpdFRl
c3RSdW5uZXIvVGVzdENvbnRyb2xsZXIuY3BwIGIvVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9UZXN0
Q29udHJvbGxlci5jcHAKaW5kZXggYTFlMmZmOTZmYmQyMmI4Yzg5YTg2NmFlMmFkMzJhMzQ5N2Vk
YWU1Yy4uOTk3OWM5MGZmZjc3YmQwODE4NTFiZmNhZGVlODQ5MThlMzkwN2VhMCAxMDA2NDQKLS0t
IGEvVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9UZXN0Q29udHJvbGxlci5jcHAKKysrIGIvVG9vbHMv
V2ViS2l0VGVzdFJ1bm5lci9UZXN0Q29udHJvbGxlci5jcHAKQEAgLTE4MjgsMTQgKzE4MjgsMTQg
QEAgdm9pZCBUZXN0Q29udHJvbGxlcjo6bmV0d29ya1Byb2Nlc3NEaWRDcmFzaChXS0NvbnRleHRS
ZWYgY29udGV4dCwgY29uc3Qgdm9pZCAqY2wKICAgICBzdGF0aWNfY2FzdDxUZXN0Q29udHJvbGxl
cio+KGNvbnN0X2Nhc3Q8dm9pZCo+KGNsaWVudEluZm8pKS0+bmV0d29ya1Byb2Nlc3NEaWRDcmFz
aCgpOwogfQogCi12b2lkIFRlc3RDb250cm9sbGVyOjpzZXJ2aWNlV29ya2VyUHJvY2Vzc0RpZENy
YXNoKFdLQ29udGV4dFJlZiBjb250ZXh0LCBjb25zdCB2b2lkICpjbGllbnRJbmZvKQordm9pZCBU
ZXN0Q29udHJvbGxlcjo6c2VydmljZVdvcmtlclByb2Nlc3NEaWRDcmFzaChXS0NvbnRleHRSZWYg
Y29udGV4dCwgV0tQcm9jZXNzSUQgcHJvY2Vzc0lELCBjb25zdCB2b2lkICpjbGllbnRJbmZvKQog
ewotICAgIHN0YXRpY19jYXN0PFRlc3RDb250cm9sbGVyKj4oY29uc3RfY2FzdDx2b2lkKj4oY2xp
ZW50SW5mbykpLT5zZXJ2aWNlV29ya2VyUHJvY2Vzc0RpZENyYXNoKCk7CisgICAgc3RhdGljX2Nh
c3Q8VGVzdENvbnRyb2xsZXIqPihjb25zdF9jYXN0PHZvaWQqPihjbGllbnRJbmZvKSktPnNlcnZp
Y2VXb3JrZXJQcm9jZXNzRGlkQ3Jhc2gocHJvY2Vzc0lEKTsKIH0KIAotdm9pZCBUZXN0Q29udHJv
bGxlcjo6Z3B1UHJvY2Vzc0RpZENyYXNoKFdLQ29udGV4dFJlZiBjb250ZXh0LCBjb25zdCB2b2lk
ICpjbGllbnRJbmZvKQordm9pZCBUZXN0Q29udHJvbGxlcjo6Z3B1UHJvY2Vzc0RpZENyYXNoKFdL
Q29udGV4dFJlZiBjb250ZXh0LCBXS1Byb2Nlc3NJRCBwcm9jZXNzSUQsIGNvbnN0IHZvaWQgKmNs
aWVudEluZm8pCiB7Ci0gICAgc3RhdGljX2Nhc3Q8VGVzdENvbnRyb2xsZXIqPihjb25zdF9jYXN0
PHZvaWQqPihjbGllbnRJbmZvKSktPmdwdVByb2Nlc3NEaWRDcmFzaCgpOworICAgIHN0YXRpY19j
YXN0PFRlc3RDb250cm9sbGVyKj4oY29uc3RfY2FzdDx2b2lkKj4oY2xpZW50SW5mbykpLT5ncHVQ
cm9jZXNzRGlkQ3Jhc2gocHJvY2Vzc0lEKTsKIH0KIAogdm9pZCBUZXN0Q29udHJvbGxlcjo6ZGlk
UmVjZWl2ZUtleURvd25NZXNzYWdlRnJvbUluamVjdGVkQnVuZGxlKFdLRGljdGlvbmFyeVJlZiBt
ZXNzYWdlQm9keURpY3Rpb25hcnksIGJvb2wgc3luY2hyb25vdXMpCkBAIC0yMTk3LDE2ICsyMTk3
LDE2IEBAIHZvaWQgVGVzdENvbnRyb2xsZXI6Om5ldHdvcmtQcm9jZXNzRGlkQ3Jhc2goKQogICAg
IGV4aXQoMSk7CiB9CiAKLXZvaWQgVGVzdENvbnRyb2xsZXI6OnNlcnZpY2VXb3JrZXJQcm9jZXNz
RGlkQ3Jhc2goKQordm9pZCBUZXN0Q29udHJvbGxlcjo6c2VydmljZVdvcmtlclByb2Nlc3NEaWRD
cmFzaChXS1Byb2Nlc3NJRCBwcm9jZXNzSUQpCiB7Ci0gICAgZnByaW50ZihzdGRlcnIsICIjQ1JB
U0hFRCAtIFNlcnZpY2VXb3JrZXJQcm9jZXNzXG4iKTsKKyAgICBmcHJpbnRmKHN0ZGVyciwgIiND
UkFTSEVEIC0gU2VydmljZVdvcmtlclByb2Nlc3MgKHBpZCAlbGQpXG4iLCBzdGF0aWNfY2FzdDxs
b25nPihwcm9jZXNzSUQpKTsKICAgICBpZiAobV9zaG91bGRFeGl0V2hlbldlYlByb2Nlc3NDcmFz
aGVzKQogICAgICAgICBleGl0KDEpOwogfQogCi12b2lkIFRlc3RDb250cm9sbGVyOjpncHVQcm9j
ZXNzRGlkQ3Jhc2goKQordm9pZCBUZXN0Q29udHJvbGxlcjo6Z3B1UHJvY2Vzc0RpZENyYXNoKFdL
UHJvY2Vzc0lEIHByb2Nlc3NJRCkKIHsKLSAgICBmcHJpbnRmKHN0ZGVyciwgIiNDUkFTSEVEIC0g
R1BVUHJvY2Vzc1xuIik7CisgICAgZnByaW50ZihzdGRlcnIsICIjQ1JBU0hFRCAtIEdQVVByb2Nl
c3MgKHBpZCAlbGQpXG4iLCBzdGF0aWNfY2FzdDxsb25nPihwcm9jZXNzSUQpKTsKICAgICBpZiAo
bV9zaG91bGRFeGl0V2hlbldlYlByb2Nlc3NDcmFzaGVzKQogICAgICAgICBleGl0KDEpOwogfQpk
aWZmIC0tZ2l0IGEvVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9UZXN0Q29udHJvbGxlci5oIGIvVG9v
bHMvV2ViS2l0VGVzdFJ1bm5lci9UZXN0Q29udHJvbGxlci5oCmluZGV4IDQwOWM3ZmE5ZmQyMGVi
NGM3NDgxZDRkYTkxZjMwZDg5ZTAzMWJmMzguLmZiNWEzZDU1ZDUwOWRjOGY3ODk4ZTcwODRmZTYz
ODM5OWFlOThjOTUgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIvVGVzdENvbnRy
b2xsZXIuaAorKysgYi9Ub29scy9XZWJLaXRUZXN0UnVubmVyL1Rlc3RDb250cm9sbGVyLmgKQEAg
LTQwNywxMCArNDA3LDEwIEBAIHByaXZhdGU6CiAgICAgLy8gV0tDb250ZXh0Q2xpZW50CiAgICAg
c3RhdGljIHZvaWQgbmV0d29ya1Byb2Nlc3NEaWRDcmFzaChXS0NvbnRleHRSZWYsIGNvbnN0IHZv
aWQqKTsKICAgICB2b2lkIG5ldHdvcmtQcm9jZXNzRGlkQ3Jhc2goKTsKLSAgICBzdGF0aWMgdm9p
ZCBzZXJ2aWNlV29ya2VyUHJvY2Vzc0RpZENyYXNoKFdLQ29udGV4dFJlZiwgY29uc3Qgdm9pZCop
OwotICAgIHZvaWQgc2VydmljZVdvcmtlclByb2Nlc3NEaWRDcmFzaCgpOwotICAgIHN0YXRpYyB2
b2lkIGdwdVByb2Nlc3NEaWRDcmFzaChXS0NvbnRleHRSZWYsIGNvbnN0IHZvaWQqKTsKLSAgICB2
b2lkIGdwdVByb2Nlc3NEaWRDcmFzaCgpOworICAgIHN0YXRpYyB2b2lkIHNlcnZpY2VXb3JrZXJQ
cm9jZXNzRGlkQ3Jhc2goV0tDb250ZXh0UmVmLCBXS1Byb2Nlc3NJRCwgY29uc3Qgdm9pZCopOwor
ICAgIHZvaWQgc2VydmljZVdvcmtlclByb2Nlc3NEaWRDcmFzaChXS1Byb2Nlc3NJRCk7CisgICAg
c3RhdGljIHZvaWQgZ3B1UHJvY2Vzc0RpZENyYXNoKFdLQ29udGV4dFJlZiwgV0tQcm9jZXNzSUQs
IGNvbnN0IHZvaWQqKTsKKyAgICB2b2lkIGdwdVByb2Nlc3NEaWRDcmFzaChXS1Byb2Nlc3NJRCk7
CiAKICAgICAvLyBXS1BhZ2VOYXZpZ2F0aW9uQ2xpZW50CiAgICAgc3RhdGljIHZvaWQgZGlkQ29t
bWl0TmF2aWdhdGlvbihXS1BhZ2VSZWYsIFdLTmF2aWdhdGlvblJlZiwgV0tUeXBlUmVmIHVzZXJE
YXRhLCBjb25zdCB2b2lkKik7Cg==
</data>

          </attachment>
      

    </bug>

</bugzilla>