205558 2019-12-23 07:10:22 -0800 [GTK] Make ondemand hardware acceleration policy never leave AC mode 2020-01-02 01:05:02 -0800 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED Gtk P2 Normal --- 1 cgarcia webkit-unassigned berto bugs-noreply cmarcelo ews-watchlist gustavo gyuyoung.kim luiz magomez noam ryuan.choi sergio svillar zan zeno oldest_to_newest 1601242 0 cgarcia 2019-12-23 07:10:22 -0800 We still enter AC mode on demand but we never leave it for the same drawing area. This avoids scrolling performance problems with some websites that start small accelerated animation while scrolling (like WebKit bugzilla review tool), due to constant enter/leave AC mode. 1601244 1 386342 cgarcia 2019-12-23 07:16:08 -0800 Created attachment 386342 Patch 1601245 2 ews-watchlist 2019-12-23 07:16:50 -0800 Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API 1601270 3 386342 svillar 2019-12-23 10:46:34 -0800 Comment on attachment 386342 Patch I'm fine with the change. I'd like to hear from Zan or Miguel though, as they might have a different opinion on the matter. 1602134 4 zan 2020-01-01 23:52:18 -0800 It makes sense. 1602143 5 cgarcia 2020-01-02 01:05:02 -0800 Committed r253974: <https://trac.webkit.org/changeset/253974> 386342 2019-12-23 07:16:08 -0800 2019-12-23 10:46:34 -0800 Patch wk2-ac-ondemand-no-leave.diff text/plain 3228 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9DaGFu Z2VMb2cKaW5kZXggMDBkNjMwZGFjOTAuLjNkNjU3NmZmOGJmIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0L0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0L0NoYW5nZUxvZwpAQCAtMSwzICsx LDE5IEBACisyMDE5LTEyLTIzICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNnYXJjaWFAaWdhbGlh LmNvbT4KKworICAgICAgICBbR1RLXSBNYWtlIG9uZGVtYW5kIGhhcmR3YXJlIGFjY2VsZXJhdGlv biBwb2xpY3kgbmV2ZXIgbGVhdmUgQUMgbW9kZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjA1NTU4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgV2Ugc3RpbGwgZW50ZXIgQUMgbW9kZSBvbiBkZW1hbmQgYnV0 IHdlIG5ldmVyIGxlYXZlIGl0IGZvciB0aGUgc2FtZSBkcmF3aW5nIGFyZWEuIFRoaXMgYXZvaWRz IHNjcm9sbGluZworICAgICAgICBwZXJmb3JtYW5jZSBwcm9ibGVtcyB3aXRoIHNvbWUgd2Vic2l0 ZXMgdGhhdCBzdGFydCBzbWFsbCBhY2NlbGVyYXRlZCBhbmltYXRpb24gd2hpbGUgc2Nyb2xsaW5n IChsaWtlIFdlYktpdAorICAgICAgICBidWd6aWxsYSByZXZpZXcgdG9vbCksIGR1ZSB0byBjb25z dGFudCBlbnRlci9sZWF2ZSBBQyBtb2RlLgorCisgICAgICAgICogVUlQcm9jZXNzL0FQSS9nbGli L1dlYktpdFNldHRpbmdzLmNwcDoKKyAgICAgICAgKHdlYmtpdF9zZXR0aW5nc19jbGFzc19pbml0 KTogVXBkYXRlIEFQSSBkb2N1bWVudGF0aW9uLgorICAgICAgICAqIFdlYlByb2Nlc3MvV2ViUGFn ZS9Db29yZGluYXRlZEdyYXBoaWNzL0RyYXdpbmdBcmVhQ29vcmRpbmF0ZWRHcmFwaGljcy5jcHA6 CisgICAgICAgIChXZWJLaXQ6OkRyYXdpbmdBcmVhQ29vcmRpbmF0ZWRHcmFwaGljczo6ZW50ZXJB Y2NlbGVyYXRlZENvbXBvc2l0aW5nTW9kZSk6IEZvcmNlIEFDIG1vZGUgdGhlIGZpcnN0IHRpbWUg d2UgZW50ZXIgaXQuCisKIDIwMTktMTItMDYgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNp YUBpZ2FsaWEuY29tPgogCiAgICAgICAgIFdlYkRyaXZlcjogc2V2ZXJhbCB3M2MgY29sbGVjdGlv bnMgdGVzdHMgYWRkZWQgaW4gcjIzMDk1MyBhcmUgZmFpbGluZwpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYktpdC9VSVByb2Nlc3MvQVBJL2dsaWIvV2ViS2l0U2V0dGluZ3MuY3BwIGIvU291cmNlL1dl YktpdC9VSVByb2Nlc3MvQVBJL2dsaWIvV2ViS2l0U2V0dGluZ3MuY3BwCmluZGV4IGU1NzAxNmIz NWMxLi44ZDBhMTYyY2MyNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJ L2dsaWIvV2ViS2l0U2V0dGluZ3MuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQ SS9nbGliL1dlYktpdFNldHRpbmdzLmNwcApAQCAtMTQ0MSw4ICsxNDQxLDggQEAgc3RhdGljIHZv aWQgd2Via2l0X3NldHRpbmdzX2NsYXNzX2luaXQoV2ViS2l0U2V0dGluZ3NDbGFzcyoga2xhc3Mp CiAgICAgICoKICAgICAgKiBUaGUgI1dlYktpdEhhcmR3YXJlQWNjZWxlcmF0aW9uUG9saWN5IHRv IGRlY2lkZSBob3cgdG8gZW5hYmxlIGFuZCBkaXNhYmxlCiAgICAgICogaGFyZHdhcmUgYWNjZWxl cmF0aW9uLiBUaGUgZGVmYXVsdCB2YWx1ZSAlV0VCS0lUX0hBUkRXQVJFX0FDQ0VMRVJBVElPTl9Q T0xJQ1lfT05fREVNQU5ECi0gICAgICogZW5hYmxlcyB0aGUgaGFyZHdhcmUgYWNjZWxlcmF0aW9u IHdoZW4gdGhlIHdlYiBjb250ZW50cyByZXF1ZXN0IGl0LCBkaXNhYmxpbmcgaXQgYWdhaW4KLSAg ICAgKiB3aGVuIG5vIGxvbmdlciBuZWVkZWQuIEl0J3MgcG9zc2libGUgdG8gZW5mb3JjZSBoYXJk d2FyZSBhY2NlbGVyYXRpb24gdG8gYmUgYWx3YXlzIGVuYWJsZWQKKyAgICAgKiBlbmFibGVzIHRo ZSBoYXJkd2FyZSBhY2NlbGVyYXRpb24gd2hlbiB0aGUgd2ViIGNvbnRlbnRzIHJlcXVlc3QgaXQu CisgICAgICogSXQncyBwb3NzaWJsZSB0byBlbmZvcmNlIGhhcmR3YXJlIGFjY2VsZXJhdGlvbiB0 byBiZSBhbHdheXMgZW5hYmxlZAogICAgICAqIGJ5IHVzaW5nICVXRUJLSVRfSEFSRFdBUkVfQUND RUxFUkFUSU9OX1BPTElDWV9BTFdBWVMuIEFuZCBpdCdzIGFsc28gcG9zc2libGUgdG8gZGlzYWJs ZSBpdAogICAgICAqIGNvbXBsZXRlbHkgdXNpbmcgJVdFQktJVF9IQVJEV0FSRV9BQ0NFTEVSQVRJ T05fUE9MSUNZX05FVkVSLiBOb3RlIHRoYXQgZGlzYWJsaW5nIGhhcmR3YXJlCiAgICAgICogYWNj ZWxlcmF0aW9uIG1pZ2h0IGNhdXNlIHNvbWUgd2Vic2l0ZXMgdG8gbm90IHJlbmRlciBjb3JyZWN0 bHkgb3IgY29uc3VtZSBtb3JlIENQVS4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvV2ViUHJv Y2Vzcy9XZWJQYWdlL0Nvb3JkaW5hdGVkR3JhcGhpY3MvRHJhd2luZ0FyZWFDb29yZGluYXRlZEdy YXBoaWNzLmNwcCBiL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9XZWJQYWdlL0Nvb3JkaW5hdGVk R3JhcGhpY3MvRHJhd2luZ0FyZWFDb29yZGluYXRlZEdyYXBoaWNzLmNwcAppbmRleCA2ODc4MGY4 Yjg2Mi4uZmJkZjI1NGVjNDIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9X ZWJQYWdlL0Nvb3JkaW5hdGVkR3JhcGhpY3MvRHJhd2luZ0FyZWFDb29yZGluYXRlZEdyYXBoaWNz LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvV2ViUGFnZS9Db29yZGluYXRlZEdy YXBoaWNzL0RyYXdpbmdBcmVhQ29vcmRpbmF0ZWRHcmFwaGljcy5jcHAKQEAgLTU1Nyw2ICs1NTcs MTIgQEAgdm9pZCBEcmF3aW5nQXJlYUNvb3JkaW5hdGVkR3JhcGhpY3M6OnJlc3VtZVBhaW50aW5n KCkKIAogdm9pZCBEcmF3aW5nQXJlYUNvb3JkaW5hdGVkR3JhcGhpY3M6OmVudGVyQWNjZWxlcmF0 ZWRDb21wb3NpdGluZ01vZGUoR3JhcGhpY3NMYXllciogZ3JhcGhpY3NMYXllcikKIHsKKyNpZiBQ TEFURk9STShHVEspCisgICAgaWYgKCFtX2Fsd2F5c1VzZUNvbXBvc2l0aW5nKSB7CisgICAgICAg IG1fd2ViUGFnZS5jb3JlUGFnZSgpLT5zZXR0aW5ncygpLnNldEZvcmNlQ29tcG9zaXRpbmdNb2Rl KHRydWUpOworICAgICAgICBtX2Fsd2F5c1VzZUNvbXBvc2l0aW5nID0gdHJ1ZTsKKyAgICB9Cisj ZW5kaWYKICAgICBtX2Rpc2NhcmRQcmV2aW91c0xheWVyVHJlZUhvc3RUaW1lci5zdG9wKCk7CiAK ICAgICBtX2V4aXRDb21wb3NpdGluZ1RpbWVyLnN0b3AoKTsK