205540 2019-12-21 04:18:54 -0800 Move Vector HashTraits to HashTraits.h to fix GCC build 2019-12-21 09:19:20 -0800 1 1 1 Unclassified WebKit Web Template Framework WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 205392 1 koivisto webkit-unassigned benjamin cdumez cmarcelo commit-queue dbates ews-watchlist webkit-bug-importer zalan oldest_to_newest 1601082 0 koivisto 2019-12-21 04:18:54 -0800 GCC is stricter than LLVM with partial specializations Error: partial specialization of €˜struct WTF::HashTraits<WTF::Vector<U, otherCapacity, WTF::CrashOnOverflow, 16> > after instantiation of €˜struct WTF::HashTraits<WTF::Vector<WTF::String> > 1601083 1 386295 koivisto 2019-12-21 04:28:09 -0800 Created attachment 386295 patch 1601090 2 386295 commit-queue 2019-12-21 09:18:40 -0800 Comment on attachment 386295 patch Clearing flags on attachment: 386295 Committed r253864: <https://trac.webkit.org/changeset/253864> 1601091 3 commit-queue 2019-12-21 09:18:41 -0800 All reviewed patches have been landed. Closing bug. 1601092 4 webkit-bug-importer 2019-12-21 09:19:20 -0800 <rdar://problem/58137077> 386295 2019-12-21 04:28:09 -0800 2019-12-21 09:18:40 -0800 patch vector-hash-fix.patch text/plain 4299 koivisto ZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nIGIvU291cmNlL1dURi9DaGFuZ2VMb2cK aW5kZXggOWMwMDU5YTcyODcuLjAyNjNjNzZkYjQzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV1RGL0No YW5nZUxvZworKysgYi9Tb3VyY2UvV1RGL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE5 LTEyLTIxICBBbnR0aSBLb2l2aXN0byAgPGFudHRpQGFwcGxlLmNvbT4KKworICAgICAgICBNb3Zl IFZlY3RvciBIYXNoVHJhaXRzIHRvIEhhc2hUcmFpdHMuaCB0byBmaXggR0NDIGJ1aWxkCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDU1NDAKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBHQ0MgaXMgc3RyaWN0 ZXIgdGhhbiBMTFZNIHdpdGggcGFydGlhbCBzcGVjaWFsaXphdGlvbnMKKworICAgICAgICBFcnJv cjogcGFydGlhbCBzcGVjaWFsaXphdGlvbiBvZiBzdHJ1Y3QgV1RGOjpIYXNoVHJhaXRzPFdURjo6 VmVjdG9yPFUsIG90aGVyQ2FwYWNpdHksIFdURjo6Q3Jhc2hPbk92ZXJmbG93LCAxNj4gPgorICAg ICAgICBhZnRlciBpbnN0YW50aWF0aW9uIG9mIHN0cnVjdCBXVEY6Okhhc2hUcmFpdHM8V1RGOjpW ZWN0b3I8V1RGOjpTdHJpbmc+ID4KKworICAgICAgICAqIHd0Zi9IYXNoVHJhaXRzLmg6CisgICAg ICAgICogd3RmL1ZlY3Rvckhhc2guaDoKKwogMjAxOS0xMi0xOSAgQW50dGkgS29pdmlzdG8gIDxh bnR0aUBhcHBsZS5jb20+CiAKICAgICAgICAgQWxsb3cgVmVjdG9ycyBhcyBoYXNoIGtleXMKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XVEYvd3RmL0hhc2hUcmFpdHMuaCBiL1NvdXJjZS9XVEYvd3RmL0hh c2hUcmFpdHMuaAppbmRleCBjYzhlNzk4YTZlNy4uNTUyZDRiNmZlYjIgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XVEYvd3RmL0hhc2hUcmFpdHMuaAorKysgYi9Tb3VyY2UvV1RGL3d0Zi9IYXNoVHJhaXRz LmgKQEAgLTM2MSw2ICszNjEsMTQgQEAgc3RydWN0IE51bGxhYmxlSGFzaFRyYWl0cyA6IHB1Ymxp YyBIYXNoVHJhaXRzPFQ+IHsKICAgICBzdGF0aWMgVCBlbXB0eVZhbHVlKCkgeyByZXR1cm4gcmVp bnRlcnByZXRfY2FzdDxUPigxKTsgfQogfTsKIAordGVtcGxhdGU8dHlwZW5hbWUgVCwgc2l6ZV90 IGlubGluZUNhcGFjaXR5Pgorc3RydWN0IEhhc2hUcmFpdHM8VmVjdG9yPFQsIGlubGluZUNhcGFj aXR5Pj4gOiBHZW5lcmljSGFzaFRyYWl0czxWZWN0b3I8VCwgaW5saW5lQ2FwYWNpdHk+PiB7Cisg ICAgc3RhdGljIGNvbnN0ZXhwciBib29sIGVtcHR5VmFsdWVJc1plcm8gPSAhaW5saW5lQ2FwYWNp dHk7CisKKyAgICBzdGF0aWMgdm9pZCBjb25zdHJ1Y3REZWxldGVkVmFsdWUoVmVjdG9yPFQsIGlu bGluZUNhcGFjaXR5PiYgc2xvdCkgeyBuZXcgKE5vdE51bGwsIHN0ZDo6YWRkcmVzc29mKHNsb3Qp KSBWZWN0b3I8VCwgaW5saW5lQ2FwYWNpdHk+KFdURjo6SGFzaFRhYmxlRGVsZXRlZFZhbHVlKTsg fQorICAgIHN0YXRpYyBib29sIGlzRGVsZXRlZFZhbHVlKGNvbnN0IFZlY3RvcjxULCBpbmxpbmVD YXBhY2l0eT4mIHZhbHVlKSB7IHJldHVybiB2YWx1ZS5pc0hhc2hUYWJsZURlbGV0ZWRWYWx1ZSgp OyB9Cit9OworCiAvLyBVc2VmdWwgZm9yIGNsYXNzZXMgdGhhdCB3YW50IGNvbXBsZXRlIGNvbnRy b2wgb3ZlciB3aGF0IGlzIGVtcHR5IGFuZCB3aGF0IGlzIGRlbGV0ZWQsCiAvLyBhbmQgaG93IHRv IGNvbnN0cnVjdCBib3RoLgogdGVtcGxhdGU8dHlwZW5hbWUgVD4KZGlmZiAtLWdpdCBhL1NvdXJj ZS9XVEYvd3RmL1ZlY3Rvckhhc2guaCBiL1NvdXJjZS9XVEYvd3RmL1ZlY3Rvckhhc2guaAppbmRl eCAyYjU0MzQ0ZjJhMC4uZmJiYzllYTQwNGMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvd3RmL1Zl Y3Rvckhhc2guaAorKysgYi9Tb3VyY2UvV1RGL3d0Zi9WZWN0b3JIYXNoLmgKQEAgLTQ3LDE0ICs0 Nyw2IEBAIHN0cnVjdCBWZWN0b3JIYXNoIHsKICAgICBzdGF0aWMgY29uc3RleHByIGJvb2wgc2Fm ZVRvQ29tcGFyZVRvRW1wdHlPckRlbGV0ZWQgPSB0cnVlOwogfTsKIAotdGVtcGxhdGU8dHlwZW5h bWUgVCwgc2l6ZV90IGlubGluZUNhcGFjaXR5Pgotc3RydWN0IEhhc2hUcmFpdHM8VmVjdG9yPFQs IGlubGluZUNhcGFjaXR5Pj4gOiBHZW5lcmljSGFzaFRyYWl0czxWZWN0b3I8VCwgaW5saW5lQ2Fw YWNpdHk+PiB7Ci0gICAgc3RhdGljIGNvbnN0ZXhwciBib29sIGVtcHR5VmFsdWVJc1plcm8gPSAh aW5saW5lQ2FwYWNpdHk7Ci0KLSAgICBzdGF0aWMgdm9pZCBjb25zdHJ1Y3REZWxldGVkVmFsdWUo VmVjdG9yPFQsIGlubGluZUNhcGFjaXR5PiYgc2xvdCkgeyBuZXcgKE5vdE51bGwsIHN0ZDo6YWRk cmVzc29mKHNsb3QpKSBWZWN0b3I8VCwgaW5saW5lQ2FwYWNpdHk+KFdURjo6SGFzaFRhYmxlRGVs ZXRlZFZhbHVlKTsgfQotICAgIHN0YXRpYyBib29sIGlzRGVsZXRlZFZhbHVlKGNvbnN0IFZlY3Rv cjxULCBpbmxpbmVDYXBhY2l0eT4mIHZhbHVlKSB7IHJldHVybiB2YWx1ZS5pc0hhc2hUYWJsZURl bGV0ZWRWYWx1ZSgpOyB9Ci19OwotCiB0ZW1wbGF0ZTx0eXBlbmFtZSBULCBzaXplX3QgaW5saW5l Q2FwYWNpdHk+CiBzdHJ1Y3QgRGVmYXVsdEhhc2g8VmVjdG9yPFQsIGlubGluZUNhcGFjaXR5Pj4g ewogICAgIHVzaW5nIEhhc2ggPSBWZWN0b3JIYXNoPFQsIGlubGluZUNhcGFjaXR5PjsKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxv ZwppbmRleCAzMzg0ZWIzMWZiOC4uN2U1NmM1MTZlOWEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD b3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwx NyBAQAorMjAxOS0xMi0yMSAgQW50dGkgS29pdmlzdG8gIDxhbnR0aUBhcHBsZS5jb20+CisKKyAg ICAgICAgTW92ZSBWZWN0b3IgSGFzaFRyYWl0cyB0byBIYXNoVHJhaXRzLmggdG8gZml4IEdDQyBi dWlsZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjA1 NTQwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBj b250ZW50ZXh0ZW5zaW9ucy9ERkFNaW5pbWl6ZXIuY3BwOgorCisgICAgICAgIEFjdGlvbktleSBI YXNoVHJhaXQgY2xhaW1zIHRoYXQgZW1wdHlWYWx1ZUlzWmVyby4gTm93IHdpdGggVmVjdG9yIEhh c2hUcmFpdCBoYXZpbmcgZW1wdHlWYWx1ZUlzWmVybyB0b28KKyAgICAgICAgSGFzaE1hcDxBY3Rp b25LZXksIFZlY3Rvcjw+PiBzdGFydGVkIHRha2luZyB0aGUgb3B0aW1pemVkIHBhdGguCisKKyAg ICAgICAgSG93ZXZlciBBY3Rpb25LZXkgZW1wdHkgdmFsdWUgd2Fzbid0IGFjdHVhbGx5IHplcm8g YmVjYXVzZSBFbXB0eSBlbnVtIHZhbHVlIHdhc24ndCAwLgorCiAyMDE5LTEyLTE5ICBBbGFuIEJ1 anRhcyAgPHphbGFuQGFwcGxlLmNvbT4KIAogICAgICAgICBVbnJldmlld2VkLCByb2xsaW5nIG91 dCByMjUzNzExLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvY29udGVudGV4dGVuc2lvbnMv REZBTWluaW1pemVyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2NvbnRlbnRleHRlbnNpb25zL0RGQU1p bmltaXplci5jcHAKaW5kZXggNDQwOGU4NGJmMjcuLmYyMmU4ZDVlYTNjIDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViQ29yZS9jb250ZW50ZXh0ZW5zaW9ucy9ERkFNaW5pbWl6ZXIuY3BwCisrKyBiL1Nv dXJjZS9XZWJDb3JlL2NvbnRlbnRleHRlbnNpb25zL0RGQU1pbmltaXplci5jcHAKQEAgLTQwOSwx NyArNDA5LDE3IEBAIHN0cnVjdCBBY3Rpb25LZXkgewogICAgIGJvb2wgaXNFbXB0eVZhbHVlKCkg Y29uc3QgeyByZXR1cm4gc3RhdGUgPT0gRW1wdHk7IH0KICAgICBib29sIGlzRGVsZXRlZFZhbHVl KCkgY29uc3QgeyByZXR1cm4gc3RhdGUgPT0gRGVsZXRlZDsgfQogCi0gICAgdW5zaWduZWQgaGFz aDsKKyAgICB1bnNpZ25lZCBoYXNoIHsgMCB9OwogICAgIAotICAgIGNvbnN0IERGQSogZGZhOwot ICAgIHVpbnQzMl90IGFjdGlvbnNTdGFydDsKLSAgICB1aW50MTZfdCBhY3Rpb25zTGVuZ3RoOwor ICAgIGNvbnN0IERGQSogZGZhIHsgbnVsbHB0ciB9OworICAgIHVpbnQzMl90IGFjdGlvbnNTdGFy dCB7IDAgfTsKKyAgICB1aW50MTZfdCBhY3Rpb25zTGVuZ3RoIHsgMCB9OwogICAgIAogICAgIGVu dW0gewotICAgICAgICBWYWxpZCwKICAgICAgICAgRW1wdHksCisgICAgICAgIFZhbGlkLAogICAg ICAgICBEZWxldGVkCi0gICAgfSBzdGF0ZTsKKyAgICB9IHN0YXRlIHsgRW1wdHkgfTsKIH07CiAK IHN0cnVjdCBBY3Rpb25LZXlIYXNoIHsK