205516 2019-12-20 13:28:45 -0800 [Bindings] Add @@toStringTag to our iterator prototype object 2020-04-25 05:36:44 -0700 1 1 1 Unclassified WebKit Bindings WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=211020 https://heycam.github.io/webidl/#es-iterator-prototype-object InRadar P2 Normal --- 1 cdumez cdumez cdumez commit-queue darin ggaren rniwa sam webkit-bug-importer youennf oldest_to_newest 1600900 0 cdumez 2019-12-20 13:28:45 -0800 Add @@ toStringTag to our iterator prototype object, as per: - https://heycam.github.io/webidl/#es-iterator-prototype-object 1600901 1 386245 cdumez 2019-12-20 13:30:46 -0800 Created attachment 386245 Patch 1600908 2 386245 darin 2019-12-20 13:48:14 -0800 Comment on attachment 386245 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=386245&action=review > Source/WebCore/bindings/js/JSDOMIterator.h:267 > + putDirectWithoutTransition(vm, vm.propertyNames->toStringTagSymbol, jsString(vm, info()->className), PropertyAttribute::DontEnum | PropertyAttribute::ReadOnly); I guess this is the same pattern that prototypes in the JavaScript runtime follow, so I guess it’s appropriately efficient. Do we want to expose the actual values from className? No need to be indirect or hide that as an implementation detail? 1600912 3 cdumez 2019-12-20 13:52:09 -0800 (In reply to Darin Adler from comment #2) > Comment on attachment 386245 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=386245&action=review > > > Source/WebCore/bindings/js/JSDOMIterator.h:267 > > + putDirectWithoutTransition(vm, vm.propertyNames->toStringTagSymbol, jsString(vm, info()->className), PropertyAttribute::DontEnum | PropertyAttribute::ReadOnly); > > I guess this is the same pattern that prototypes in the JavaScript runtime > follow, so I guess it’s appropriately efficient. > > Do we want to expose the actual values from className? No need to be > indirect or hide that as an implementation detail? Using info()->className here is important to pass the tests. info()->className looks like "URLSearchParams Iterator" and is set in our generated bindings. The spec says: """ The class string of an iterator prototype object for a given interface is the result of concatenating the identifier of the interface and the string " Iterator". """ 1600916 4 386249 cdumez 2019-12-20 14:00:14 -0800 Created attachment 386249 Patch 1600944 5 386249 darin 2019-12-20 14:39:50 -0800 Comment on attachment 386249 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=386249&action=review > Source/WebCore/bindings/js/JSDOMIterator.h:268 > + putDirectWithoutTransition(vm, vm.propertyNames->toStringTagSymbol, jsString(vm, info()->className), PropertyAttribute::DontEnum | PropertyAttribute::ReadOnly); JSC::PropertyAttribute perhaps? 1600946 6 386259 cdumez 2019-12-20 14:42:12 -0800 Created attachment 386259 Patch 1600959 7 386259 darin 2019-12-20 14:54:30 -0800 Comment on attachment 386259 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=386259&action=review > Source/WebCore/bindings/js/JSDOMIterator.h:268 > + putDirectWithoutTransition(vm, vm.propertyNames->toStringTagSymbol, jsString(vm, info()->className), JSC::PropertyAttribute::DontEnum | JSC::PropertyAttribute::ReadOnly); Might also have to be JSC::jsString -- not really sure. 1601026 8 386259 commit-queue 2019-12-20 17:04:35 -0800 Comment on attachment 386259 Patch Clearing flags on attachment: 386259 Committed r253855: <https://trac.webkit.org/changeset/253855> 1601027 9 commit-queue 2019-12-20 17:04:37 -0800 All reviewed patches have been landed. Closing bug. 1601028 10 webkit-bug-importer 2019-12-20 17:05:30 -0800 <rdar://problem/58129948> 1601115 11 386259 darin 2019-12-21 17:11:21 -0800 Comment on attachment 386259 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=386259&action=review >> Source/WebCore/bindings/js/JSDOMIterator.h:268 >> + putDirectWithoutTransition(vm, vm.propertyNames->toStringTagSymbol, jsString(vm, info()->className), JSC::PropertyAttribute::DontEnum | JSC::PropertyAttribute::ReadOnly); > > Might also have to be JSC::jsString -- not really sure. I figured out why it does not. The type of the first argument is JSC::VM&, and so argument-dependent lookup kicks in to search the JSC namespace for the function name. 1601116 12 darin 2019-12-21 17:17:59 -0800 (In reply to Chris Dumez from comment #3) > (In reply to Darin Adler from comment #2) > > > Source/WebCore/bindings/js/JSDOMIterator.h:267 > > > + putDirectWithoutTransition(vm, vm.propertyNames->toStringTagSymbol, jsString(vm, info()->className), PropertyAttribute::DontEnum | PropertyAttribute::ReadOnly); > > > > I guess this is the same pattern that prototypes in the JavaScript runtime > > follow, so I guess it’s appropriately efficient. > > > > Do we want to expose the actual values from className? No need to be > > indirect or hide that as an implementation detail? > > Using info()->className here is important to pass the tests. > info()->className looks like "URLSearchParams Iterator" and is set in our > generated bindings. > > The spec says: > """ > The class string of an iterator prototype object for a given interface is > the result of concatenating the identifier of the interface and the string " > Iterator". > """ Yes, I understand we need that name. What I wondered is whether it was OK to require that it be exactly equal to the className value from the info structure. The four examples I found that have a className that is different from the toStringTagSymbol value are: AsyncGeneratorFunctionPrototype: className="AsyncGenerator", toStringTag="AsyncGeneratorFunction" JSDataViewPrototype: className="DataViewPrototype", toStringTag="DataView" JSModuleNamespaceObject: className="ModuleNamespaceObject", toStringTag="Module" JSPromisePrototype: className="PromisePrototype", toStringTag="Promise" I was just wondering why this happens sometimes and why it shouldn't happen here. Maybe all four of those are just bugs. 386245 2019-12-20 13:30:46 -0800 2019-12-20 14:00:13 -0800 Patch bug-205516-20191220133045.patch text/plain 4430 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjUzODM5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYjc5Yjg1N2Q1ZjAyNDI0 MTcxMzgzMTAwYWUwMTk0M2IxMmRlYzdiYy4uY2EwNzBkOWI2YWJkZTNkZTU0NmQwMDA3Zjk1M2E3 MmU0NWRjOTM4MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE5LTEyLTIwICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgW0JpbmRpbmdzXSBBZGQgQEB0 b1N0cmluZ1RhZyB0byBvdXIgaXRlcmF0b3IgcHJvdG90eXBlIG9iamVjdAorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjA1NTE2CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkIEBAIHRvU3RyaW5nVGFnIHRv IG91ciBpdGVyYXRvciBwcm90b3R5cGUgb2JqZWN0LCBhcyBwZXI6CisgICAgICAgIC0gaHR0cHM6 Ly9oZXljYW0uZ2l0aHViLmlvL3dlYmlkbC8jZXMtaXRlcmF0b3ItcHJvdG90eXBlLW9iamVjdAor CisgICAgICAgIE5vIG5ldyB0ZXN0cywgcmViYXNlbGluZWQgZXhpc3RpbmcgdGVzdHMuCisKKyAg ICAgICAgKiBiaW5kaW5ncy9qcy9KU0RPTUl0ZXJhdG9yLmg6CisgICAgICAgIChXZWJDb3JlOjpJ dGVyYXRvclRyYWl0cz46OmZpbmlzaENyZWF0aW9uKToKKwogMjAxOS0xMi0yMCAgeW91ZW5uIGZh YmxldCAgPHlvdWVubkBhcHBsZS5jb20+CiAKICAgICAgICAgU1dTZXJ2ZXIgY2FuIGJlIGNyZWF0 ZWQgd2l0aG91dCBhbnkgcGF0aCB0byBzdG9yZSByZWdpc3RyYXRpb25zIGluIG5vbiBlcGhlbWVy YWwgc2Vzc2lvbnMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2pzL0pTRE9N SXRlcmF0b3IuaCBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2pzL0pTRE9NSXRlcmF0b3IuaApp bmRleCAzNjc5ZmIyMGIwYmZmNzk0YzkxOTc0MDRhYmM2OWRkYjdkMWMyMDhiLi5kNWRiYzhlNzAw NDk5NGY3MzI4YmNlNzYwNzMyMWQzYTdjODNkM2QxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9iaW5kaW5ncy9qcy9KU0RPTUl0ZXJhdG9yLmgKKysrIGIvU291cmNlL1dlYkNvcmUvYmluZGlu Z3MvanMvSlNET01JdGVyYXRvci5oCkBAIC0yNjQsNiArMjY0LDcgQEAgdm9pZCBKU0RPTUl0ZXJh dG9yUHJvdG90eXBlPEpTV3JhcHBlciwgSXRlcmF0b3JUcmFpdHM+OjpmaW5pc2hDcmVhdGlvbihK U0M6OlZNJgogICAgIEJhc2U6OmZpbmlzaENyZWF0aW9uKHZtKTsKICAgICBBU1NFUlQoaW5oZXJp dHModm0sIGluZm8oKSkpOwogCisgICAgcHV0RGlyZWN0V2l0aG91dFRyYW5zaXRpb24odm0sIHZt LnByb3BlcnR5TmFtZXMtPnRvU3RyaW5nVGFnU3ltYm9sLCBqc1N0cmluZyh2bSwgaW5mbygpLT5j bGFzc05hbWUpLCBQcm9wZXJ0eUF0dHJpYnV0ZTo6RG9udEVudW0gfCBQcm9wZXJ0eUF0dHJpYnV0 ZTo6UmVhZE9ubHkpOwogICAgIEpTQ19OQVRJVkVfSU5UUklOU0lDX0ZVTkNUSU9OX1dJVEhPVVRf VFJBTlNJVElPTih2bS5wcm9wZXJ0eU5hbWVzLT5uZXh0LCBuZXh0LCAwLCAwLCBKU0M6Ok5vSW50 cmluc2ljKTsKIH0KIApkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvaW1wb3J0ZWQvdzNjL0NoYW5n ZUxvZyBiL0xheW91dFRlc3RzL2ltcG9ydGVkL3czYy9DaGFuZ2VMb2cKaW5kZXggYzRjMDcxMWVm YjVlNGRlM2EzMjRkZGY2Mjc3Zjg0MDEwZWZkZGIwZi4uN2ZkMTE1MmM2M2NlZjZiZGRmZmQ3ZDU1 NTI2OTAxMDFjNDkwMmNlMyAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvaW1wb3J0ZWQvdzNjL0No YW5nZUxvZworKysgYi9MYXlvdXRUZXN0cy9pbXBvcnRlZC93M2MvQ2hhbmdlTG9nCkBAIC0xLDMg KzEsMTUgQEAKKzIwMTktMTItMjAgIENocmlzIER1bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KKwor ICAgICAgICBbQmluZGluZ3NdIEFkZCBAQHRvU3RyaW5nVGFnIHRvIG91ciBpdGVyYXRvciBwcm90 b3R5cGUgb2JqZWN0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0yMDU1MTYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBSZWJhc2VsaW5lIFdQVCB0ZXN0cyB0aGF0IGFyZSBub3cgcGFzc2luZy4KKworICAgICAg ICAqIHdlYi1wbGF0Zm9ybS10ZXN0cy9XZWJJREwvZWNtYXNjcmlwdC1iaW5kaW5nL2RlZmF1bHQt aXRlcmF0b3Itb2JqZWN0LWV4cGVjdGVkLnR4dDoKKyAgICAgICAgKiB3ZWItcGxhdGZvcm0tdGVz dHMvV2ViSURML2VjbWFzY3JpcHQtYmluZGluZy9pdGVyYXRvci1wcm90b3R5cGUtb2JqZWN0LWV4 cGVjdGVkLnR4dDoKKwogMjAxOS0xMi0yMCAgVHJ1aXR0IFNhdmVsbCAgPHRzYXZlbGxAYXBwbGUu Y29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQsIHJvbGxpbmcgb3V0IHIyNTM4MzEuCmRpZmYgLS1n aXQgYS9MYXlvdXRUZXN0cy9pbXBvcnRlZC93M2Mvd2ViLXBsYXRmb3JtLXRlc3RzL1dlYklETC9l Y21hc2NyaXB0LWJpbmRpbmcvZGVmYXVsdC1pdGVyYXRvci1vYmplY3QtZXhwZWN0ZWQudHh0IGIv TGF5b3V0VGVzdHMvaW1wb3J0ZWQvdzNjL3dlYi1wbGF0Zm9ybS10ZXN0cy9XZWJJREwvZWNtYXNj cmlwdC1iaW5kaW5nL2RlZmF1bHQtaXRlcmF0b3Itb2JqZWN0LWV4cGVjdGVkLnR4dAppbmRleCBm MTNkM2JlMGVlMDI3NjhmMzEyM2YwNmQ2NzUwNWY2MWNlNjYxNDQxLi4zNWQ5ZTY2NzJiOTcyMTU5 NTgxOTE4ZWJkY2UyYjE5MGM2ZWYyOThiIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9pbXBvcnRl ZC93M2Mvd2ViLXBsYXRmb3JtLXRlc3RzL1dlYklETC9lY21hc2NyaXB0LWJpbmRpbmcvZGVmYXVs dC1pdGVyYXRvci1vYmplY3QtZXhwZWN0ZWQudHh0CisrKyBiL0xheW91dFRlc3RzL2ltcG9ydGVk L3czYy93ZWItcGxhdGZvcm0tdGVzdHMvV2ViSURML2VjbWFzY3JpcHQtYmluZGluZy9kZWZhdWx0 LWl0ZXJhdG9yLW9iamVjdC1leHBlY3RlZC50eHQKQEAgLTEsNSArMSw1IEBACiAKIFBBU1MgRGVm YXVsdCBpdGVyYXRvciBvYmplY3RzIGZvciBhbiBpbnRlcmZhY2UgaGF2ZSB0aGUgc2FtZSBwcm90 b3R5cGUgCiBQQVNTIE9iamVjdC5wcm90b3R5cGUudG9TdHJpbmcgcmV0dXJucyBjb3JyZWN0IHZh bHVlIAotRkFJTCBAQHRvU3RyaW5nVGFnIGhhcyBjb3JyZWN0IHZhbHVlIGZyb20gcHJvdG90eXBl IGFzc2VydF9lcXVhbHM6IGV4cGVjdGVkIChzdHJpbmcpICJVUkxTZWFyY2hQYXJhbXMgSXRlcmF0 b3IiIGJ1dCBnb3QgKHVuZGVmaW5lZCkgdW5kZWZpbmVkCitQQVNTIEBAdG9TdHJpbmdUYWcgaGFz IGNvcnJlY3QgdmFsdWUgZnJvbSBwcm90b3R5cGUgCiAKZGlmZiAtLWdpdCBhL0xheW91dFRlc3Rz L2ltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMvV2ViSURML2VjbWFzY3JpcHQtYmluZGlu Zy9pdGVyYXRvci1wcm90b3R5cGUtb2JqZWN0LWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL2lt cG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMvV2ViSURML2VjbWFzY3JpcHQtYmluZGluZy9p dGVyYXRvci1wcm90b3R5cGUtb2JqZWN0LWV4cGVjdGVkLnR4dAppbmRleCA3ZjMyMWZiZmMyOWU1 MzhkYzRkMDBmYjhmMjBkMDBmMjljZDFjM2M1Li4zY2UwMjM2NzRmYWMzNjg3Yjc1MzQyNDc3NWU2 OTAwOGU1M2UxNTI1IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9pbXBvcnRlZC93M2Mvd2ViLXBs YXRmb3JtLXRlc3RzL1dlYklETC9lY21hc2NyaXB0LWJpbmRpbmcvaXRlcmF0b3ItcHJvdG90eXBl LW9iamVjdC1leHBlY3RlZC50eHQKKysrIGIvTGF5b3V0VGVzdHMvaW1wb3J0ZWQvdzNjL3dlYi1w bGF0Zm9ybS10ZXN0cy9XZWJJREwvZWNtYXNjcmlwdC1iaW5kaW5nL2l0ZXJhdG9yLXByb3RvdHlw ZS1vYmplY3QtZXhwZWN0ZWQudHh0CkBAIC0zLDYgKzMsNiBAQCBQQVNTIEhhcyAlSXRlcmF0b3JQ cm90b3R5cGUlIGFzIHByb3RvdHlwZQogUEFTUyBuZXh0KCkgZXhpc3RzIGFuZCBpcyB3cml0YWJs ZSwgZW51bWVyYWJsZSwgYW5kIGNvbmZpZ3VyYWJsZSAKIFBBU1MgbmV4dCgpIHRocm93cyBUeXBl RXJyb3Igd2hlbiBjYWxsZWQgb24gaW5lbGlnaWJsZSByZWNlaXZlciAKIFBBU1MgT2JqZWN0LnBy b3RvdHlwZS50b1N0cmluZyByZXR1cm5zIGNvcnJlY3QgdmFsdWUgCi1GQUlMIEBAdG9TdHJpbmdU YWcgaGFzIGNvcnJlY3QgdmFsdWUgdW5kZWZpbmVkIGlzIG5vdCBhbiBvYmplY3QgKGV2YWx1YXRp bmcgJ09iamVjdC5nZXRPd25Qcm9wZXJ0eURlc2NyaXB0b3IoaXRlcmF0b3JQcm90bywgU3ltYm9s LnRvU3RyaW5nVGFnKS52YWx1ZScpCitQQVNTIEBAdG9TdHJpbmdUYWcgaGFzIGNvcnJlY3QgdmFs dWUgCiBQQVNTIElzIHNwZWNpZmljIHRvIGFuIGludGVyZmFjZSAKIAo= 386249 2019-12-20 14:00:14 -0800 2019-12-20 14:42:10 -0800 Patch bug-205516-20191220140014.patch text/plain 4607 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjUzODM5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYjc5Yjg1N2Q1ZjAyNDI0 MTcxMzgzMTAwYWUwMTk0M2IxMmRlYzdiYy4uY2Q0NjExMjE3ZTg5YWE2NzA0NmJmOTg5NGE2Njc3 ZjJiY2NmODA4ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE5LTEyLTIwICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgW0JpbmRpbmdzXSBBZGQgQEB0 b1N0cmluZ1RhZyB0byBvdXIgaXRlcmF0b3IgcHJvdG90eXBlIG9iamVjdAorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjA1NTE2CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgRGFyaW4gQWRsZXIuCisKKyAgICAgICAgQWRkIEBAIHRvU3RyaW5nVGFnIHRvIG91 ciBpdGVyYXRvciBwcm90b3R5cGUgb2JqZWN0LCBhcyBwZXI6CisgICAgICAgIC0gaHR0cHM6Ly9o ZXljYW0uZ2l0aHViLmlvL3dlYmlkbC8jZXMtaXRlcmF0b3ItcHJvdG90eXBlLW9iamVjdAorCisg ICAgICAgIE5vIG5ldyB0ZXN0cywgcmViYXNlbGluZWQgZXhpc3RpbmcgdGVzdHMuCisKKyAgICAg ICAgKiBiaW5kaW5ncy9qcy9KU0RPTUl0ZXJhdG9yLmg6CisgICAgICAgIChXZWJDb3JlOjpJdGVy YXRvclRyYWl0cz46OmZpbmlzaENyZWF0aW9uKToKKwogMjAxOS0xMi0yMCAgeW91ZW5uIGZhYmxl dCAgPHlvdWVubkBhcHBsZS5jb20+CiAKICAgICAgICAgU1dTZXJ2ZXIgY2FuIGJlIGNyZWF0ZWQg d2l0aG91dCBhbnkgcGF0aCB0byBzdG9yZSByZWdpc3RyYXRpb25zIGluIG5vbiBlcGhlbWVyYWwg c2Vzc2lvbnMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2pzL0pTRE9NSXRl cmF0b3IuaCBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2pzL0pTRE9NSXRlcmF0b3IuaAppbmRl eCAzNjc5ZmIyMGIwYmZmNzk0YzkxOTc0MDRhYmM2OWRkYjdkMWMyMDhiLi4wNjMxMDM5NTNlZWRl ZmM2ZThkOWVjYTY4Yjk5NWZkYmU0MDM3M2NhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9i aW5kaW5ncy9qcy9KU0RPTUl0ZXJhdG9yLmgKKysrIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mv anMvSlNET01JdGVyYXRvci5oCkBAIC0yOCw2ICsyOCw3IEBACiAKICNpbmNsdWRlICJKU0RPTUNv bnZlcnQuaCIKICNpbmNsdWRlIDxKYXZhU2NyaXB0Q29yZS9JdGVyYXRvclByb3RvdHlwZS5oPgor I2luY2x1ZGUgPEphdmFTY3JpcHRDb3JlL1Byb3BlcnR5U2xvdC5oPgogI2luY2x1ZGUgPHR5cGVf dHJhaXRzPgogCiBuYW1lc3BhY2UgV2ViQ29yZSB7CkBAIC0yNjQsNiArMjY1LDcgQEAgdm9pZCBK U0RPTUl0ZXJhdG9yUHJvdG90eXBlPEpTV3JhcHBlciwgSXRlcmF0b3JUcmFpdHM+OjpmaW5pc2hD cmVhdGlvbihKU0M6OlZNJgogICAgIEJhc2U6OmZpbmlzaENyZWF0aW9uKHZtKTsKICAgICBBU1NF UlQoaW5oZXJpdHModm0sIGluZm8oKSkpOwogCisgICAgcHV0RGlyZWN0V2l0aG91dFRyYW5zaXRp b24odm0sIHZtLnByb3BlcnR5TmFtZXMtPnRvU3RyaW5nVGFnU3ltYm9sLCBqc1N0cmluZyh2bSwg aW5mbygpLT5jbGFzc05hbWUpLCBQcm9wZXJ0eUF0dHJpYnV0ZTo6RG9udEVudW0gfCBQcm9wZXJ0 eUF0dHJpYnV0ZTo6UmVhZE9ubHkpOwogICAgIEpTQ19OQVRJVkVfSU5UUklOU0lDX0ZVTkNUSU9O X1dJVEhPVVRfVFJBTlNJVElPTih2bS5wcm9wZXJ0eU5hbWVzLT5uZXh0LCBuZXh0LCAwLCAwLCBK U0M6Ok5vSW50cmluc2ljKTsKIH0KIApkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvaW1wb3J0ZWQv dzNjL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL2ltcG9ydGVkL3czYy9DaGFuZ2VMb2cKaW5kZXgg YzRjMDcxMWVmYjVlNGRlM2EzMjRkZGY2Mjc3Zjg0MDEwZWZkZGIwZi4uNGYwZWJiMzM3Njc3YWM5 YWVjMGU2NDZjMmU3Njk5YjA2M2EyZGQwOCAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvaW1wb3J0 ZWQvdzNjL0NoYW5nZUxvZworKysgYi9MYXlvdXRUZXN0cy9pbXBvcnRlZC93M2MvQ2hhbmdlTG9n CkBAIC0xLDMgKzEsMTUgQEAKKzIwMTktMTItMjAgIENocmlzIER1bWV6ICA8Y2R1bWV6QGFwcGxl LmNvbT4KKworICAgICAgICBbQmluZGluZ3NdIEFkZCBAQHRvU3RyaW5nVGFnIHRvIG91ciBpdGVy YXRvciBwcm90b3R5cGUgb2JqZWN0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0yMDU1MTYKKworICAgICAgICBSZXZpZXdlZCBieSBEYXJpbiBBZGxlci4K KworICAgICAgICBSZWJhc2VsaW5lIFdQVCB0ZXN0cyB0aGF0IGFyZSBub3cgcGFzc2luZy4KKwor ICAgICAgICAqIHdlYi1wbGF0Zm9ybS10ZXN0cy9XZWJJREwvZWNtYXNjcmlwdC1iaW5kaW5nL2Rl ZmF1bHQtaXRlcmF0b3Itb2JqZWN0LWV4cGVjdGVkLnR4dDoKKyAgICAgICAgKiB3ZWItcGxhdGZv cm0tdGVzdHMvV2ViSURML2VjbWFzY3JpcHQtYmluZGluZy9pdGVyYXRvci1wcm90b3R5cGUtb2Jq ZWN0LWV4cGVjdGVkLnR4dDoKKwogMjAxOS0xMi0yMCAgVHJ1aXR0IFNhdmVsbCAgPHRzYXZlbGxA YXBwbGUuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQsIHJvbGxpbmcgb3V0IHIyNTM4MzEuCmRp ZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9pbXBvcnRlZC93M2Mvd2ViLXBsYXRmb3JtLXRlc3RzL1dl YklETC9lY21hc2NyaXB0LWJpbmRpbmcvZGVmYXVsdC1pdGVyYXRvci1vYmplY3QtZXhwZWN0ZWQu dHh0IGIvTGF5b3V0VGVzdHMvaW1wb3J0ZWQvdzNjL3dlYi1wbGF0Zm9ybS10ZXN0cy9XZWJJREwv ZWNtYXNjcmlwdC1iaW5kaW5nL2RlZmF1bHQtaXRlcmF0b3Itb2JqZWN0LWV4cGVjdGVkLnR4dApp bmRleCBmMTNkM2JlMGVlMDI3NjhmMzEyM2YwNmQ2NzUwNWY2MWNlNjYxNDQxLi4zNWQ5ZTY2NzJi OTcyMTU5NTgxOTE4ZWJkY2UyYjE5MGM2ZWYyOThiIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9p bXBvcnRlZC93M2Mvd2ViLXBsYXRmb3JtLXRlc3RzL1dlYklETC9lY21hc2NyaXB0LWJpbmRpbmcv ZGVmYXVsdC1pdGVyYXRvci1vYmplY3QtZXhwZWN0ZWQudHh0CisrKyBiL0xheW91dFRlc3RzL2lt cG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMvV2ViSURML2VjbWFzY3JpcHQtYmluZGluZy9k ZWZhdWx0LWl0ZXJhdG9yLW9iamVjdC1leHBlY3RlZC50eHQKQEAgLTEsNSArMSw1IEBACiAKIFBB U1MgRGVmYXVsdCBpdGVyYXRvciBvYmplY3RzIGZvciBhbiBpbnRlcmZhY2UgaGF2ZSB0aGUgc2Ft ZSBwcm90b3R5cGUgCiBQQVNTIE9iamVjdC5wcm90b3R5cGUudG9TdHJpbmcgcmV0dXJucyBjb3Jy ZWN0IHZhbHVlIAotRkFJTCBAQHRvU3RyaW5nVGFnIGhhcyBjb3JyZWN0IHZhbHVlIGZyb20gcHJv dG90eXBlIGFzc2VydF9lcXVhbHM6IGV4cGVjdGVkIChzdHJpbmcpICJVUkxTZWFyY2hQYXJhbXMg SXRlcmF0b3IiIGJ1dCBnb3QgKHVuZGVmaW5lZCkgdW5kZWZpbmVkCitQQVNTIEBAdG9TdHJpbmdU YWcgaGFzIGNvcnJlY3QgdmFsdWUgZnJvbSBwcm90b3R5cGUgCiAKZGlmZiAtLWdpdCBhL0xheW91 dFRlc3RzL2ltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMvV2ViSURML2VjbWFzY3JpcHQt YmluZGluZy9pdGVyYXRvci1wcm90b3R5cGUtb2JqZWN0LWV4cGVjdGVkLnR4dCBiL0xheW91dFRl c3RzL2ltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMvV2ViSURML2VjbWFzY3JpcHQtYmlu ZGluZy9pdGVyYXRvci1wcm90b3R5cGUtb2JqZWN0LWV4cGVjdGVkLnR4dAppbmRleCA3ZjMyMWZi ZmMyOWU1MzhkYzRkMDBmYjhmMjBkMDBmMjljZDFjM2M1Li4zY2UwMjM2NzRmYWMzNjg3Yjc1MzQy NDc3NWU2OTAwOGU1M2UxNTI1IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9pbXBvcnRlZC93M2Mv d2ViLXBsYXRmb3JtLXRlc3RzL1dlYklETC9lY21hc2NyaXB0LWJpbmRpbmcvaXRlcmF0b3ItcHJv dG90eXBlLW9iamVjdC1leHBlY3RlZC50eHQKKysrIGIvTGF5b3V0VGVzdHMvaW1wb3J0ZWQvdzNj L3dlYi1wbGF0Zm9ybS10ZXN0cy9XZWJJREwvZWNtYXNjcmlwdC1iaW5kaW5nL2l0ZXJhdG9yLXBy b3RvdHlwZS1vYmplY3QtZXhwZWN0ZWQudHh0CkBAIC0zLDYgKzMsNiBAQCBQQVNTIEhhcyAlSXRl cmF0b3JQcm90b3R5cGUlIGFzIHByb3RvdHlwZQogUEFTUyBuZXh0KCkgZXhpc3RzIGFuZCBpcyB3 cml0YWJsZSwgZW51bWVyYWJsZSwgYW5kIGNvbmZpZ3VyYWJsZSAKIFBBU1MgbmV4dCgpIHRocm93 cyBUeXBlRXJyb3Igd2hlbiBjYWxsZWQgb24gaW5lbGlnaWJsZSByZWNlaXZlciAKIFBBU1MgT2Jq ZWN0LnByb3RvdHlwZS50b1N0cmluZyByZXR1cm5zIGNvcnJlY3QgdmFsdWUgCi1GQUlMIEBAdG9T dHJpbmdUYWcgaGFzIGNvcnJlY3QgdmFsdWUgdW5kZWZpbmVkIGlzIG5vdCBhbiBvYmplY3QgKGV2 YWx1YXRpbmcgJ09iamVjdC5nZXRPd25Qcm9wZXJ0eURlc2NyaXB0b3IoaXRlcmF0b3JQcm90bywg U3ltYm9sLnRvU3RyaW5nVGFnKS52YWx1ZScpCitQQVNTIEBAdG9TdHJpbmdUYWcgaGFzIGNvcnJl Y3QgdmFsdWUgCiBQQVNTIElzIHNwZWNpZmljIHRvIGFuIGludGVyZmFjZSAKIAo= 386259 2019-12-20 14:42:12 -0800 2019-12-20 17:04:35 -0800 Patch bug-205516-20191220144211.patch text/plain 4561 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjUzODQ1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNWE5NGYzYzIzNTEzYmMw NmJhN2Q1N2UyYzBhNTRjZjBlNjhhODBiYi4uMGE4MTI2ZjFmOTNkNjBjOGI5ZGZkOTU2ZTUyMGI5 MTMzNTE4NmJjNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE5LTEyLTIwICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgW0JpbmRpbmdzXSBBZGQgQEB0 b1N0cmluZ1RhZyB0byBvdXIgaXRlcmF0b3IgcHJvdG90eXBlIG9iamVjdAorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjA1NTE2CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgRGFyaW4gQWRsZXIuCisKKyAgICAgICAgQWRkIEBAIHRvU3RyaW5nVGFnIHRvIG91 ciBpdGVyYXRvciBwcm90b3R5cGUgb2JqZWN0LCBhcyBwZXI6CisgICAgICAgIC0gaHR0cHM6Ly9o ZXljYW0uZ2l0aHViLmlvL3dlYmlkbC8jZXMtaXRlcmF0b3ItcHJvdG90eXBlLW9iamVjdAorCisg ICAgICAgIE5vIG5ldyB0ZXN0cywgcmViYXNlbGluZWQgZXhpc3RpbmcgdGVzdHMuCisKKyAgICAg ICAgKiBiaW5kaW5ncy9qcy9KU0RPTUl0ZXJhdG9yLmg6CisgICAgICAgIChXZWJDb3JlOjpJdGVy YXRvclRyYWl0cz46OmZpbmlzaENyZWF0aW9uKToKKwogMjAxOS0xMi0yMCAgVHJ1aXR0IFNhdmVs bCAgPHRzYXZlbGxAYXBwbGUuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQsIHJvbGxpbmcgb3V0 IHIyNTM4MjAuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9qcy9KU0RPTUl0 ZXJhdG9yLmggYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9qcy9KU0RPTUl0ZXJhdG9yLmgKaW5k ZXggMzY3OWZiMjBiMGJmZjc5NGM5MTk3NDA0YWJjNjlkZGI3ZDFjMjA4Yi4uMTE4NmJiOTdiZmM2 MGY3ZTE5YzBiM2I4ODU2Nzg4OWM3ZmMwMDYzMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUv YmluZGluZ3MvanMvSlNET01JdGVyYXRvci5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdz L2pzL0pTRE9NSXRlcmF0b3IuaApAQCAtMjgsNiArMjgsNyBAQAogCiAjaW5jbHVkZSAiSlNET01D b252ZXJ0LmgiCiAjaW5jbHVkZSA8SmF2YVNjcmlwdENvcmUvSXRlcmF0b3JQcm90b3R5cGUuaD4K KyNpbmNsdWRlIDxKYXZhU2NyaXB0Q29yZS9Qcm9wZXJ0eVNsb3QuaD4KICNpbmNsdWRlIDx0eXBl X3RyYWl0cz4KIAogbmFtZXNwYWNlIFdlYkNvcmUgewpAQCAtMjY0LDYgKzI2NSw3IEBAIHZvaWQg SlNET01JdGVyYXRvclByb3RvdHlwZTxKU1dyYXBwZXIsIEl0ZXJhdG9yVHJhaXRzPjo6ZmluaXNo Q3JlYXRpb24oSlNDOjpWTSYKICAgICBCYXNlOjpmaW5pc2hDcmVhdGlvbih2bSk7CiAgICAgQVNT RVJUKGluaGVyaXRzKHZtLCBpbmZvKCkpKTsKIAorICAgIHB1dERpcmVjdFdpdGhvdXRUcmFuc2l0 aW9uKHZtLCB2bS5wcm9wZXJ0eU5hbWVzLT50b1N0cmluZ1RhZ1N5bWJvbCwganNTdHJpbmcodm0s IGluZm8oKS0+Y2xhc3NOYW1lKSwgSlNDOjpQcm9wZXJ0eUF0dHJpYnV0ZTo6RG9udEVudW0gfCBK U0M6OlByb3BlcnR5QXR0cmlidXRlOjpSZWFkT25seSk7CiAgICAgSlNDX05BVElWRV9JTlRSSU5T SUNfRlVOQ1RJT05fV0lUSE9VVF9UUkFOU0lUSU9OKHZtLnByb3BlcnR5TmFtZXMtPm5leHQsIG5l eHQsIDAsIDAsIEpTQzo6Tm9JbnRyaW5zaWMpOwogfQogCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0 cy9pbXBvcnRlZC93M2MvQ2hhbmdlTG9nIGIvTGF5b3V0VGVzdHMvaW1wb3J0ZWQvdzNjL0NoYW5n ZUxvZwppbmRleCBjNGMwNzExZWZiNWU0ZGUzYTMyNGRkZjYyNzdmODQwMTBlZmRkYjBmLi40ZjBl YmIzMzc2NzdhYzlhZWMwZTY0NmMyZTc2OTliMDYzYTJkZDA4IDEwMDY0NAotLS0gYS9MYXlvdXRU ZXN0cy9pbXBvcnRlZC93M2MvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3RzL2ltcG9ydGVkL3cz Yy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxOS0xMi0yMCAgQ2hyaXMgRHVtZXogIDxj ZHVtZXpAYXBwbGUuY29tPgorCisgICAgICAgIFtCaW5kaW5nc10gQWRkIEBAdG9TdHJpbmdUYWcg dG8gb3VyIGl0ZXJhdG9yIHByb3RvdHlwZSBvYmplY3QKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwNTUxNgorCisgICAgICAgIFJldmlld2VkIGJ5IERh cmluIEFkbGVyLgorCisgICAgICAgIFJlYmFzZWxpbmUgV1BUIHRlc3RzIHRoYXQgYXJlIG5vdyBw YXNzaW5nLgorCisgICAgICAgICogd2ViLXBsYXRmb3JtLXRlc3RzL1dlYklETC9lY21hc2NyaXB0 LWJpbmRpbmcvZGVmYXVsdC1pdGVyYXRvci1vYmplY3QtZXhwZWN0ZWQudHh0OgorICAgICAgICAq IHdlYi1wbGF0Zm9ybS10ZXN0cy9XZWJJREwvZWNtYXNjcmlwdC1iaW5kaW5nL2l0ZXJhdG9yLXBy b3RvdHlwZS1vYmplY3QtZXhwZWN0ZWQudHh0OgorCiAyMDE5LTEyLTIwICBUcnVpdHQgU2F2ZWxs ICA8dHNhdmVsbEBhcHBsZS5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZCwgcm9sbGluZyBvdXQg cjI1MzgzMS4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2ltcG9ydGVkL3czYy93ZWItcGxhdGZv cm0tdGVzdHMvV2ViSURML2VjbWFzY3JpcHQtYmluZGluZy9kZWZhdWx0LWl0ZXJhdG9yLW9iamVj dC1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9pbXBvcnRlZC93M2Mvd2ViLXBsYXRmb3JtLXRl c3RzL1dlYklETC9lY21hc2NyaXB0LWJpbmRpbmcvZGVmYXVsdC1pdGVyYXRvci1vYmplY3QtZXhw ZWN0ZWQudHh0CmluZGV4IGYxM2QzYmUwZWUwMjc2OGYzMTIzZjA2ZDY3NTA1ZjYxY2U2NjE0NDEu LjM1ZDllNjY3MmI5NzIxNTk1ODE5MThlYmRjZTJiMTkwYzZlZjI5OGIgMTAwNjQ0Ci0tLSBhL0xh eW91dFRlc3RzL2ltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMvV2ViSURML2VjbWFzY3Jp cHQtYmluZGluZy9kZWZhdWx0LWl0ZXJhdG9yLW9iamVjdC1leHBlY3RlZC50eHQKKysrIGIvTGF5 b3V0VGVzdHMvaW1wb3J0ZWQvdzNjL3dlYi1wbGF0Zm9ybS10ZXN0cy9XZWJJREwvZWNtYXNjcmlw dC1iaW5kaW5nL2RlZmF1bHQtaXRlcmF0b3Itb2JqZWN0LWV4cGVjdGVkLnR4dApAQCAtMSw1ICsx LDUgQEAKIAogUEFTUyBEZWZhdWx0IGl0ZXJhdG9yIG9iamVjdHMgZm9yIGFuIGludGVyZmFjZSBo YXZlIHRoZSBzYW1lIHByb3RvdHlwZSAKIFBBU1MgT2JqZWN0LnByb3RvdHlwZS50b1N0cmluZyBy ZXR1cm5zIGNvcnJlY3QgdmFsdWUgCi1GQUlMIEBAdG9TdHJpbmdUYWcgaGFzIGNvcnJlY3QgdmFs dWUgZnJvbSBwcm90b3R5cGUgYXNzZXJ0X2VxdWFsczogZXhwZWN0ZWQgKHN0cmluZykgIlVSTFNl YXJjaFBhcmFtcyBJdGVyYXRvciIgYnV0IGdvdCAodW5kZWZpbmVkKSB1bmRlZmluZWQKK1BBU1Mg QEB0b1N0cmluZ1RhZyBoYXMgY29ycmVjdCB2YWx1ZSBmcm9tIHByb3RvdHlwZSAKIApkaWZmIC0t Z2l0IGEvTGF5b3V0VGVzdHMvaW1wb3J0ZWQvdzNjL3dlYi1wbGF0Zm9ybS10ZXN0cy9XZWJJREwv ZWNtYXNjcmlwdC1iaW5kaW5nL2l0ZXJhdG9yLXByb3RvdHlwZS1vYmplY3QtZXhwZWN0ZWQudHh0 IGIvTGF5b3V0VGVzdHMvaW1wb3J0ZWQvdzNjL3dlYi1wbGF0Zm9ybS10ZXN0cy9XZWJJREwvZWNt YXNjcmlwdC1iaW5kaW5nL2l0ZXJhdG9yLXByb3RvdHlwZS1vYmplY3QtZXhwZWN0ZWQudHh0Cmlu ZGV4IDdmMzIxZmJmYzI5ZTUzOGRjNGQwMGZiOGYyMGQwMGYyOWNkMWMzYzUuLjNjZTAyMzY3NGZh YzM2ODdiNzUzNDI0Nzc1ZTY5MDA4ZTUzZTE1MjUgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2lt cG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMvV2ViSURML2VjbWFzY3JpcHQtYmluZGluZy9p dGVyYXRvci1wcm90b3R5cGUtb2JqZWN0LWV4cGVjdGVkLnR4dAorKysgYi9MYXlvdXRUZXN0cy9p bXBvcnRlZC93M2Mvd2ViLXBsYXRmb3JtLXRlc3RzL1dlYklETC9lY21hc2NyaXB0LWJpbmRpbmcv aXRlcmF0b3ItcHJvdG90eXBlLW9iamVjdC1leHBlY3RlZC50eHQKQEAgLTMsNiArMyw2IEBAIFBB U1MgSGFzICVJdGVyYXRvclByb3RvdHlwZSUgYXMgcHJvdG90eXBlCiBQQVNTIG5leHQoKSBleGlz dHMgYW5kIGlzIHdyaXRhYmxlLCBlbnVtZXJhYmxlLCBhbmQgY29uZmlndXJhYmxlIAogUEFTUyBu ZXh0KCkgdGhyb3dzIFR5cGVFcnJvciB3aGVuIGNhbGxlZCBvbiBpbmVsaWdpYmxlIHJlY2VpdmVy IAogUEFTUyBPYmplY3QucHJvdG90eXBlLnRvU3RyaW5nIHJldHVybnMgY29ycmVjdCB2YWx1ZSAK LUZBSUwgQEB0b1N0cmluZ1RhZyBoYXMgY29ycmVjdCB2YWx1ZSB1bmRlZmluZWQgaXMgbm90IGFu IG9iamVjdCAoZXZhbHVhdGluZyAnT2JqZWN0LmdldE93blByb3BlcnR5RGVzY3JpcHRvcihpdGVy YXRvclByb3RvLCBTeW1ib2wudG9TdHJpbmdUYWcpLnZhbHVlJykKK1BBU1MgQEB0b1N0cmluZ1Rh ZyBoYXMgY29ycmVjdCB2YWx1ZSAKIFBBU1MgSXMgc3BlY2lmaWMgdG8gYW4gaW50ZXJmYWNlIAog Cg==