205513 2019-12-20 11:56:15 -0800 lldbwebkittester: Strip CLANG_DEBUG_INFORMATION_LEVEL option while building 2019-12-20 14:31:30 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 jbedard jbedard ap commit-queue dbates ews-watchlist slewis tsavell webkit-bug-importer oldest_to_newest 1600854 0 jbedard 2019-12-20 11:56:15 -0800 When built with CLANG_DEBUG_INFORMATION_LEVEL=line-tables-only, our lldb tests don't work. We should disable these tests on release queues. 1600870 1 jbedard 2019-12-20 12:37:25 -0800 Talking with Alexey, we're going to the opposite: we're going to fix release binaries so they can run lldb tests instead. 1600886 2 386242 jbedard 2019-12-20 12:58:46 -0800 Created attachment 386242 Patch 1600903 3 386242 ap 2019-12-20 13:37:13 -0800 Comment on attachment 386242 Patch Worth explaining this in a comment. We are lucky that fixing “make” builds is not necessary at the moment. 1600905 4 386246 jbedard 2019-12-20 13:46:52 -0800 Created attachment 386246 Patch for landing 1600932 5 386246 commit-queue 2019-12-20 14:30:40 -0800 Comment on attachment 386246 Patch for landing Clearing flags on attachment: 386246 Committed r253845: <https://trac.webkit.org/changeset/253845> 1600933 6 commit-queue 2019-12-20 14:30:42 -0800 All reviewed patches have been landed. Closing bug. 1600936 7 webkit-bug-importer 2019-12-20 14:31:30 -0800 <rdar://problem/58125695> 386242 2019-12-20 12:58:46 -0800 2019-12-20 13:46:50 -0800 Patch bug-205513-20191220125846.patch text/plain 1412 jbedard SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI1MzgzOSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDEzIEBACisyMDE5LTEyLTIwICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNv bT4KKworICAgICAgICBsbGRid2Via2l0dGVzdGVyOiBTdHJpcCBDTEFOR19ERUJVR19JTkZPUk1B VElPTl9MRVZFTCBvcHRpb24gd2hpbGUgYnVpbGRpbmcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwNTUxMworCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgICogU2NyaXB0cy93ZWJraXRkaXJzLnBtOgorICAgICAg ICAoYnVpbGRYQ29kZVByb2plY3QpOiBTdHJpcCBDTEFOR19ERUJVR19JTkZPUk1BVElPTl9MRVZF TCBmcm9tIGxsZGJXZWJLaXRUZXN0ZXIuCisKIDIwMTktMTItMjAgIEppZXdlbiBUYW4gIDxqaWV3 ZW5fdGFuQGFwcGxlLmNvbT4KIAogICAgICAgICBbV2ViQXV0aG5dIEltcGxlbWVudCBjb2RlcnMg Zm9yIENUQVAgQ2xpZW50UElOIHJlcXVlc3RzIGFuZCByZXNwb25zZXMKSW5kZXg6IFRvb2xzL1Nj cmlwdHMvd2Via2l0ZGlycy5wbQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9TY3JpcHRzL3dlYmtpdGRp cnMucG0JKHJldmlzaW9uIDI1MzgxNikKKysrIFRvb2xzL1NjcmlwdHMvd2Via2l0ZGlycy5wbQko d29ya2luZyBjb3B5KQpAQCAtMTkwNiw2ICsxOTA2LDE2IEBAIHN1YiBidWlsZFhDb2RlUHJvamVj dCgkJEApCiAgICAgfQogCiAgICAgY2hvbXAoJEVOVntEU1lNVVRJTF9OVU1fVEhSRUFEU30gPSBg c3lzY3RsIC1uIGh3LmFjdGl2ZWNwdWApOworICAgIGlmICgkcHJvamVjdCBlcSAibGxkYldlYktp dFRlc3RlciIpIHsKKyAgICAgICAgbXkgJGluZGV4ID0gMDsKKyAgICAgICAgd2hpbGUgKCRpbmRl eCA8IHNjYWxhcihAZXh0cmFPcHRpb25zKSkgeworICAgICAgICAgICAgaWYgKCRleHRyYU9wdGlv bnNbJGluZGV4XSA9fiAvQ0xBTkdfREVCVUdfSU5GT1JNQVRJT05fTEVWRUw9LykgeworICAgICAg ICAgICAgICAgIHNwbGljZSBAZXh0cmFPcHRpb25zLCAkaW5kZXgsIDE7CisgICAgICAgICAgICB9 IGVsc2UgeworICAgICAgICAgICAgICAgICRpbmRleCArPSAxOworICAgICAgICAgICAgfQorICAg ICAgICB9CisgICAgfQogICAgIHJldHVybiBzeXN0ZW0gInhjb2RlYnVpbGQiLCAiLXByb2plY3Qi LCAiJHByb2plY3QueGNvZGVwcm9qIiwgQGV4dHJhT3B0aW9uczsKIH0KIAo= 386246 2019-12-20 13:46:52 -0800 2019-12-20 14:30:40 -0800 Patch for landing bug-205513-20191220134651.patch text/plain 1543 jbedard SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI1MzgzOSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDEzIEBACisyMDE5LTEyLTIwICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNv bT4KKworICAgICAgICBsbGRid2Via2l0dGVzdGVyOiBTdHJpcCBDTEFOR19ERUJVR19JTkZPUk1B VElPTl9MRVZFTCBvcHRpb24gd2hpbGUgYnVpbGRpbmcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwNTUxMworCisgICAgICAgIFJldmlld2VkIGJ5IEFs ZXhleSBQcm9za3VyeWFrb3YuCisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdGRpcnMucG06Cisg ICAgICAgIChidWlsZFhDb2RlUHJvamVjdCk6IFN0cmlwIENMQU5HX0RFQlVHX0lORk9STUFUSU9O X0xFVkVMIGZyb20gbGxkYldlYktpdFRlc3Rlci4KKwogMjAxOS0xMi0yMCAgSmlld2VuIFRhbiAg PGppZXdlbl90YW5AYXBwbGUuY29tPgogCiAgICAgICAgIFtXZWJBdXRobl0gSW1wbGVtZW50IGNv ZGVycyBmb3IgQ1RBUCBDbGllbnRQSU4gcmVxdWVzdHMgYW5kIHJlc3BvbnNlcwpJbmRleDogVG9v bHMvU2NyaXB0cy93ZWJraXRkaXJzLnBtCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL1NjcmlwdHMvd2Vi a2l0ZGlycy5wbQkocmV2aXNpb24gMjUzODE2KQorKysgVG9vbHMvU2NyaXB0cy93ZWJraXRkaXJz LnBtCSh3b3JraW5nIGNvcHkpCkBAIC0xOTA2LDYgKzE5MDYsMTggQEAgc3ViIGJ1aWxkWENvZGVQ cm9qZWN0KCQkQCkKICAgICB9CiAKICAgICBjaG9tcCgkRU5We0RTWU1VVElMX05VTV9USFJFQURT fSA9IGBzeXNjdGwgLW4gaHcuYWN0aXZlY3B1YCk7CisKKyAgICAjIGxsZGJXZWJLaXRUZXN0ZXIg d29uJ3Qgd29yayB3aXRoIHRoZSB3cm9uZyBDTEFOR19ERUJVR19JTkZPUk1BVElPTl9MRVZFTCwg c28gYWx3YXlzIHVzZSB0aGUgZGVmYXVsdCBmb3IgdGhhdCBwcm9qZWN0CisgICAgaWYgKCRwcm9q ZWN0IGVxICJsbGRiV2ViS2l0VGVzdGVyIikgeworICAgICAgICBteSAkaW5kZXggPSAwOworICAg ICAgICB3aGlsZSAoJGluZGV4IDwgc2NhbGFyKEBleHRyYU9wdGlvbnMpKSB7CisgICAgICAgICAg ICBpZiAoJGV4dHJhT3B0aW9uc1skaW5kZXhdID1+IC9DTEFOR19ERUJVR19JTkZPUk1BVElPTl9M RVZFTD0vKSB7CisgICAgICAgICAgICAgICAgc3BsaWNlIEBleHRyYU9wdGlvbnMsICRpbmRleCwg MTsKKyAgICAgICAgICAgIH0gZWxzZSB7CisgICAgICAgICAgICAgICAgJGluZGV4ICs9IDE7Cisg ICAgICAgICAgICB9CisgICAgICAgIH0KKyAgICB9CiAgICAgcmV0dXJuIHN5c3RlbSAieGNvZGVi dWlsZCIsICItcHJvamVjdCIsICIkcHJvamVjdC54Y29kZXByb2oiLCBAZXh0cmFPcHRpb25zOwog fQogCg==