205473 2019-12-19 14:11:08 -0800 REGRESSION: [ Mac wk2 ] http/tests/inspector/target/provisional-load-cancels-previous-load.html is a flaky failure 2020-01-06 20:42:43 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 tsavell yurys bburg commit-queue webkit-bot-watchers-bugzilla webkit-bug-importer yurys oldest_to_newest 1600496 0 tsavell 2019-12-19 14:11:08 -0800 http/tests/inspector/target/provisional-load-cancels-previous-load.html This test is a flaky failure on Mac wk2 sense around r253723 History: https://results.webkit.org/?suite=layout-tests&test=http%2Ftests%2Finspector%2Ftarget%2Fprovisional-load-cancels-previous-load.html Diff: --- /Volumes/Data/slave/catalina-release-tests-wk2/build/layout-test-results/http/tests/inspector/target/provisional-load-cancels-previous-load-expected.txt +++ /Volumes/Data/slave/catalina-release-tests-wk2/build/layout-test-results/http/tests/inspector/target/provisional-load-cancels-previous-load-actual.txt @@ -1,17 +1,2 @@ +ALERT: PASS: Should receive DidCommitProvisionalTarget event 0 => 2. Test that two consequtive cross domain navigation requests will result in two provisional targets being created, first of which is later destroyed and the second is committed. - - -== Running test suite: Target.PSON --- Running test case: ProvisionalPagePaused -Current target is 0. -PASS: Should receive TargetAdded event for target 1. -PASS: Target 1 should be provisional. -PASS: Target 1 should be paused on start. -PASS: Should receive TargetRemoved event for target 1 -PASS: Should receive TargetAdded event for target 2. -PASS: Target 2 should be provisional. -PASS: Target 2 should be paused on start. -PASS: Should receive TargetRemoved event for target 0 -PASS: Should receive DidCommitProvisionalTarget event 0 => 2. -PASS: Should have seen 3 different targets. - 1600526 1 tsavell 2019-12-19 15:13:00 -0800 I can reproduce this failure by running the test in iterations 1600531 2 webkit-bug-importer 2019-12-19 15:23:33 -0800 <rdar://problem/58093690> 1600808 3 ap 2019-12-20 11:01:22 -0800 This test was added on 2019-12-04, was green for a week, then saw various infrequent failures, and became super flaky on 2019-12-18. Perhaps https://trac.webkit.org/r253718 ? But there may be multiple causes for the flakiness. 1602249 4 386634 yurys 2020-01-02 14:43:12 -0800 Created attachment 386634 Patch 1603177 5 386634 bburg 2020-01-06 11:35:59 -0800 Comment on attachment 386634 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=386634&action=review r=me with some comments > Source/WebInspectorUI/ChangeLog:8 > + May want to clarify that the flaky failure is due to a problem with the test itself, not the code under test. > Source/WebInspectorUI/ChangeLog:12 > + can be overriden in the tests. Nit: overridden > Source/WebInspectorUI/UserInterface/Test/FrontendTestHarness.js:130 > + deferOutputUntilTestPageIsReloaded() Are there other cases where we think this will be needed? > LayoutTests/http/tests/inspector/target/provisional-load-cancels-previous-load.html:23 > + WI.Target.prototype._resumeIfPaused = () => {} It is kind of weird to monkey patch like this, but I suppose it's just for a test. Nit: need trailing semicolon. 1603419 6 386634 yurys 2020-01-06 19:55:06 -0800 Comment on attachment 386634 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=386634&action=review >> Source/WebInspectorUI/ChangeLog:8 >> + > > May want to clarify that the flaky failure is due to a problem with the test itself, not the code under test. Done. >> Source/WebInspectorUI/ChangeLog:12 >> + can be overriden in the tests. > > Nit: overridden Done. >> Source/WebInspectorUI/UserInterface/Test/FrontendTestHarness.js:130 >> + deferOutputUntilTestPageIsReloaded() > > Are there other cases where we think this will be needed? Yes, other navigation tests that need to log during navigation will need to suspend the output as well. >> LayoutTests/http/tests/inspector/target/provisional-load-cancels-previous-load.html:23 >> + WI.Target.prototype._resumeIfPaused = () => {} > > It is kind of weird to monkey patch like this, but I suppose it's just for a test. > > Nit: need trailing semicolon. Yes, this is just for the testing purposes, we always want to resume in normal flow. Added semicolon. 1603420 7 386926 yurys 2020-01-06 19:55:56 -0800 Created attachment 386926 Patch for landing 1603430 8 386926 commit-queue 2020-01-06 20:42:41 -0800 Comment on attachment 386926 Patch for landing Clearing flags on attachment: 386926 Committed r254111: <https://trac.webkit.org/changeset/254111> 1603431 9 commit-queue 2020-01-06 20:42:43 -0800 All reviewed patches have been landed. Closing bug. 386634 2020-01-02 14:43:12 -0800 2020-01-06 19:55:55 -0800 Patch bug-205473-20200102144311.patch text/plain 5175 yurys U3VidmVyc2lvbiBSZXZpc2lvbjogMjUzNzkxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCBl MjA1Y2E3MzE1NTNjYzI4N2M5NjAxMzE3N2EzNmZhNzFhNjlmMjUxLi41NzhlMWE4Y2E0N2QzMzE4 MjhkYmEyNTg3ZDdjOTUwODU1OGRhZjkwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyMCBAQAorMjAyMC0wMS0wMiAgWXVyeSBTZW1pa2hhdHNreSAgPHl1cnlzQGNocm9taXVt Lm9yZz4KKworICAgICAgICBSRUdSRVNTSU9OOiBbIE1hYyB3azIgXSBodHRwL3Rlc3RzL2luc3Bl Y3Rvci90YXJnZXQvcHJvdmlzaW9uYWwtbG9hZC1jYW5jZWxzLXByZXZpb3VzLWxvYWQuaHRtbCBp cyBhIGZsYWt5IGZhaWx1cmUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTIwNTQ3MworICAgICAgICA8cmRhcjovL3Byb2JsZW0vNTgwOTM2OTA+CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBVc2VySW50ZXJm YWNlL1Byb3RvY29sL1RhcmdldC5qczoKKyAgICAgICAgKFdJLlRhcmdldC5wcm90b3R5cGUuaW5p dGlhbGl6ZSk6CisgICAgICAgIChXSS5UYXJnZXQucHJvdG90eXBlLl9yZXN1bWVJZlBhdXNlZCk6 IGV4dHJhY3RlZCByZXN1bWUgbG9naWMgaW4gYSBtZXRob2QgdGhhdAorICAgICAgICBjYW4gYmUg b3ZlcnJpZGVuIGluIHRoZSB0ZXN0cy4KKworICAgICAgICAqIFVzZXJJbnRlcmZhY2UvVGVzdC9G cm9udGVuZFRlc3RIYXJuZXNzLmpzOgorICAgICAgICAoRnJvbnRlbmRUZXN0SGFybmVzcy5wcm90 b3R5cGUuZGVmZXJPdXRwdXRVbnRpbFRlc3RQYWdlSXNSZWxvYWRlZCk6IGFsbG93IHRvIHBhdXNl CisgICAgICAgIG91dHB1dCB3aGVuIG5hdmlnYXRpb24gaXMgc3RhcnRlZCB2aWEgcHJvdG9jb2wg Y29tbWFuZHMgcmF0aGVyIHRoYW4gdGhlIHRlc3QgaGFybmVzcy4KKwogMjAxOS0xMi0xOSAgRGV2 aW4gUm91c3NvICA8ZHJvdXNzb0BhcHBsZS5jb20+CiAKICAgICAgICAgV2ViIEluc3BlY3Rvcjog QXVkaXQ6IGV4aXRpbmcgZWRpdCBtb2RlIHdpdGggdGhlIHNhbWUgc2VsZWN0aW9uIGFzIGJlZm9y ZSBlbnRlcmluZyBlZGl0IG1vZGUgZG9lc24ndCByZXNlbGVjdApkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvUHJvdG9jb2wvVGFyZ2V0LmpzIGIvU291cmNl L1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvUHJvdG9jb2wvVGFyZ2V0LmpzCmluZGV4IGNh Mzg1ZmUyOGIxYmVmYmE4NGM0NjljODc1ODkyMWQ3ZmZiMGEzNDEuLmMyNmExOWE4ODVlYTg5MTRh ZDRmYmQ4N2RjYmM0ZjM3NzcwYjU5NmEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JV SS9Vc2VySW50ZXJmYWNlL1Byb3RvY29sL1RhcmdldC5qcworKysgYi9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvVXNlckludGVyZmFjZS9Qcm90b2NvbC9UYXJnZXQuanMKQEAgLTEwMCw2ICsxMDAsMTEg QEAgV0kuVGFyZ2V0ID0gY2xhc3MgVGFyZ2V0IGV4dGVuZHMgV0kuT2JqZWN0CiAgICAgICAgICAg ICAgICAgdGhpcy5JbnNwZWN0b3JBZ2VudC5pbml0aWFsaXplZCgpOwogICAgICAgICB9KTsKIAor ICAgICAgICB0aGlzLl9yZXN1bWVJZlBhdXNlZCgpOworICAgIH0KKworICAgIF9yZXN1bWVJZlBh dXNlZCgpCisgICAgewogICAgICAgICBpZiAodGhpcy5faXNQYXVzZWQpIHsKICAgICAgICAgICAg IGNvbnNvbGUuYXNzZXJ0KHRoaXMuX3BhcmVudFRhcmdldC5oYXNDb21tYW5kKCJUYXJnZXQucmVz dW1lIikpOwogICAgICAgICAgICAgdGhpcy5fcGFyZW50VGFyZ2V0LlRhcmdldEFnZW50LnJlc3Vt ZSh0aGlzLl9pZGVudGlmaWVyLCAoZXJyb3IpID0+IHsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJ bnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1Rlc3QvRnJvbnRlbmRUZXN0SGFybmVzcy5qcyBiL1Nv dXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1Rlc3QvRnJvbnRlbmRUZXN0SGFybmVz cy5qcwppbmRleCAzYWNjMzMwNzBmYjdmNWNlNDdmZTA0OGQyNGM2YjEwOTc5MjgxMTRkLi5lNjhj OTdmNmEyMzE4ZTg2YzA2MDMyOWY3NGVjNDZlYmI4ODE0NzJhIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9UZXN0L0Zyb250ZW5kVGVzdEhhcm5lc3MuanMK KysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVGVzdC9Gcm9udGVuZFRl c3RIYXJuZXNzLmpzCkBAIC0xMjcsNiArMTI3LDEyIEBAIEZyb250ZW5kVGVzdEhhcm5lc3MgPSBj bGFzcyBGcm9udGVuZFRlc3RIYXJuZXNzIGV4dGVuZHMgVGVzdEhhcm5lc3MKICAgICAgICAgfQog ICAgIH0KIAorICAgIGRlZmVyT3V0cHV0VW50aWxUZXN0UGFnZUlzUmVsb2FkZWQoKQorICAgIHsK KyAgICAgICAgY29uc29sZS5hc3NlcnQoIXRoaXMuX3Rlc3RQYWdlSXNSZWxvYWRpbmcpOworICAg ICAgICB0aGlzLl90ZXN0UGFnZUlzUmVsb2FkaW5nID0gdHJ1ZTsKKyAgICB9CisKICAgICB0ZXN0 UGFnZURpZExvYWQoKQogICAgIHsKICAgICAgICAgaWYgKHRoaXMuZHVtcEFjdGl2aXR5VG9TeXN0 ZW1Db25zb2xlKQpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nIGIvTGF5b3V0VGVz dHMvQ2hhbmdlTG9nCmluZGV4IDFlYjM1YmNlNzdhMDIxNzQyNmExMDExN2MzYjkyZTk4MWIyNThl MGYuLmFlYWNmYTQ2YjMzNWNlODMwMTJjNGYzNTVjZGRhYzhiZjgzOWUzZWQgMTAwNjQ0Ci0tLSBh L0xheW91dFRlc3RzL0NoYW5nZUxvZworKysgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNiBAQAorMjAyMC0wMS0wMiAgWXVyeSBTZW1pa2hhdHNreSAgPHl1cnlzQGNocm9taXVt Lm9yZz4KKworICAgICAgICBSRUdSRVNTSU9OOiBbIE1hYyB3azIgXSBodHRwL3Rlc3RzL2luc3Bl Y3Rvci90YXJnZXQvcHJvdmlzaW9uYWwtbG9hZC1jYW5jZWxzLXByZXZpb3VzLWxvYWQuaHRtbCBp cyBhIGZsYWt5IGZhaWx1cmUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTIwNTQ3MworICAgICAgICA8cmRhcjovL3Byb2JsZW0vNTgwOTM2OTA+CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgS2VlcCBwcm92aXNp b25hbCBwYWdlIHBhdXNlZCB1bnRpbCBzZWNvbmQgbmF2aWdhdGlvbiByZXBsYWNlcyBpdCBhbmQg YWxzbworICAgICAgICBkZWZlciBvdXRwdXQgdW50aWwgdGVzdCBwYWdlIGlzIGZ1bGx5IGluaXRp YWxpemVkIGFmdGVyIG5hdmlnYXRpb24uCisKKyAgICAgICAgKiBodHRwL3Rlc3RzL2luc3BlY3Rv ci90YXJnZXQvcHJvdmlzaW9uYWwtbG9hZC1jYW5jZWxzLXByZXZpb3VzLWxvYWQuaHRtbDoKKwog MjAxOS0xMi0xOSAgQ2hyaXMgRHVtZXogIDxjZHVtZXpAYXBwbGUuY29tPgogCiAgICAgICAgIFJl c3luYyB3ZWItcGxhdGZvcm0tdGVzdHMvaHRtbCB0ZXN0cyBmcm9tIHVwc3RyZWFtCmRpZmYgLS1n aXQgYS9MYXlvdXRUZXN0cy9odHRwL3Rlc3RzL2luc3BlY3Rvci90YXJnZXQvcHJvdmlzaW9uYWwt bG9hZC1jYW5jZWxzLXByZXZpb3VzLWxvYWQuaHRtbCBiL0xheW91dFRlc3RzL2h0dHAvdGVzdHMv aW5zcGVjdG9yL3RhcmdldC9wcm92aXNpb25hbC1sb2FkLWNhbmNlbHMtcHJldmlvdXMtbG9hZC5o dG1sCmluZGV4IDI2NjI2MjIwZTRmNGY5ZjQ0YTFiMTFmNWNkYzE2YTIyNTMyZmNhNjAuLjUyNzE2 NTI5YWI3ZmI2YzYyZGEyODYwYzFjNjgwZjZkMzI4OTdlMzkgMTAwNjQ0Ci0tLSBhL0xheW91dFRl c3RzL2h0dHAvdGVzdHMvaW5zcGVjdG9yL3RhcmdldC9wcm92aXNpb25hbC1sb2FkLWNhbmNlbHMt cHJldmlvdXMtbG9hZC5odG1sCisrKyBiL0xheW91dFRlc3RzL2h0dHAvdGVzdHMvaW5zcGVjdG9y L3RhcmdldC9wcm92aXNpb25hbC1sb2FkLWNhbmNlbHMtcHJldmlvdXMtbG9hZC5odG1sCkBAIC0x OCw2ICsxOCwxMCBAQCBmdW5jdGlvbiB0ZXN0KCkKICAgICAgICAgICAgIGNvbnN0IHVybCA9ICJo dHRwOi8vbG9jYWxob3N0OjgwMDAvaW5zcGVjdG9yL3RhcmdldC9wcm92aXNpb25hbC1sb2FkLWNh bmNlbHMtcHJldmlvdXMtbG9hZC5odG1sIjsKICAgICAgICAgICAgIGxldCBuYXZpZ2F0ZWRUd2lj ZSA9IGZhbHNlOwogCisgICAgICAgICAgICBsZXQgb3JpZ2luYWxSZXN1bWVJZlBhdXNlZCA9IFdJ LlRhcmdldC5wcm90b3R5cGUuX3Jlc3VtZUlmUGF1c2VkOworICAgICAgICAgICAgLy8gS2VlcCBm aXJzdCBwcm92aXNpb25hbCBuYXZpZ2F0aW9uIHBhdXNlZC4KKyAgICAgICAgICAgIFdJLlRhcmdl dC5wcm90b3R5cGUuX3Jlc3VtZUlmUGF1c2VkID0gKCkgPT4ge30KKwogICAgICAgICAgICAgV0ku dGFyZ2V0TWFuYWdlci5hZGRFdmVudExpc3RlbmVyKFdJLlRhcmdldE1hbmFnZXIuRXZlbnQuVGFy Z2V0QWRkZWQsIChldmVudCkgPT4gewogICAgICAgICAgICAgICAgIGxldCB0YXJnZXQgPSBldmVu dC5kYXRhLnRhcmdldDsKICAgICAgICAgICAgICAgICBsZXQgdGFyZ2V0SWQgPSB0YXJnZXRJZE1h cC5nZXQodGFyZ2V0LmlkZW50aWZpZXIpOwpAQCAtMjYsNiArMzAsOSBAQCBmdW5jdGlvbiB0ZXN0 KCkKICAgICAgICAgICAgICAgICBJbnNwZWN0b3JUZXN0LmV4cGVjdFRydWUodGFyZ2V0LmlzUGF1 c2VkLCBgVGFyZ2V0ICR7dGFyZ2V0SWR9IHNob3VsZCBiZSBwYXVzZWQgb24gc3RhcnQuYCk7CiAg ICAgICAgICAgICAgICAgaWYgKCFuYXZpZ2F0ZWRUd2ljZSkgewogICAgICAgICAgICAgICAgICAg ICBuYXZpZ2F0ZWRUd2ljZSA9IHRydWU7CisgICAgICAgICAgICAgICAgICAgIFdJLlRhcmdldC5w cm90b3R5cGUuX3Jlc3VtZUlmUGF1c2VkID0gb3JpZ2luYWxSZXN1bWVJZlBhdXNlZDsKKworICAg ICAgICAgICAgICAgICAgICBJbnNwZWN0b3JUZXN0LmRlZmVyT3V0cHV0VW50aWxUZXN0UGFnZUlz UmVsb2FkZWQoKTsKIAogICAgICAgICAgICAgICAgICAgICAvLyBTZW5kIHR3byBjb25zZXF1dGl2 ZSBuYXZpZ2F0aW9uIHJlcXVlc3RzLiBUaGUgbGF0dGVyIHdpbGwgY2FuY2VsIHByb3Zpc2lvbmFs CiAgICAgICAgICAgICAgICAgICAgIC8vIGxvYWQgb2YgdGhlIGZvcm1lci4K 386926 2020-01-06 19:55:56 -0800 2020-01-06 20:42:41 -0800 Patch for landing bug-205473-20200106195555.patch text/plain 5443 yurys U3VidmVyc2lvbiBSZXZpc2lvbjogMjUzNzkxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCBl MjA1Y2E3MzE1NTNjYzI4N2M5NjAxMzE3N2EzNmZhNzFhNjlmMjUxLi5mNmM4OTE5MzY2NjY4ZTRl NjI5ZWZkZTA3ZWI0OTBhMDE2MzNjZWVjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyNCBAQAorMjAyMC0wMS0wMiAgWXVyeSBTZW1pa2hhdHNreSAgPHl1cnlzQGNocm9taXVt Lm9yZz4KKworICAgICAgICBSRUdSRVNTSU9OOiBbIE1hYyB3azIgXSBodHRwL3Rlc3RzL2luc3Bl Y3Rvci90YXJnZXQvcHJvdmlzaW9uYWwtbG9hZC1jYW5jZWxzLXByZXZpb3VzLWxvYWQuaHRtbCBp cyBhIGZsYWt5IGZhaWx1cmUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTIwNTQ3MworICAgICAgICA8cmRhcjovL3Byb2JsZW0vNTgwOTM2OTA+CisKKyAg ICAgICAgVGhlIGZhaWx1cmUgd2FzIGR1ZSB0byBhdHRlbXB0cyB0byBhZGQgb3V0cHV0IHRvIHRo ZSB0ZXN0IHBhZ2Ugd2hpY2ggY291bGQgYmUgbm90IGZ1bGx5CisgICAgICAgIGxvYWRlZCBhZnRl ciBuYXZpZ2F0aW9uLiBUbyBtYWtlIGl0IGRldGVybWluaXN0aWMgaXQgaXMgbm93IHBvc3NpYmxl IHRvIGtlZXAgcHJvdmlzaW9uYWwKKyAgICAgICAgbmF2aWdhdGlvbiBwYXVzZWQgYW5kIHRvIGRl ZmVyIG91dHB1dCB1bnRpbCB0aGUgdGVzdCBwYWdlIGlzIHJlYWR5LgorCisgICAgICAgIFJldmll d2VkIGJ5IEJyaWFuIEJ1cmcuCisKKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL1Byb3RvY29sL1Rh cmdldC5qczoKKyAgICAgICAgKFdJLlRhcmdldC5wcm90b3R5cGUuaW5pdGlhbGl6ZSk6CisgICAg ICAgIChXSS5UYXJnZXQucHJvdG90eXBlLl9yZXN1bWVJZlBhdXNlZCk6IGV4dHJhY3RlZCByZXN1 bWUgbG9naWMgaW4gYSBtZXRob2QgdGhhdAorICAgICAgICBjYW4gYmUgb3ZlcnJpZGRlbiBpbiB0 aGUgdGVzdHMuCisKKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL1Rlc3QvRnJvbnRlbmRUZXN0SGFy bmVzcy5qczoKKyAgICAgICAgKEZyb250ZW5kVGVzdEhhcm5lc3MucHJvdG90eXBlLmRlZmVyT3V0 cHV0VW50aWxUZXN0UGFnZUlzUmVsb2FkZWQpOiBhbGxvdyB0byBwYXVzZQorICAgICAgICBvdXRw dXQgd2hlbiBuYXZpZ2F0aW9uIGlzIHN0YXJ0ZWQgdmlhIHByb3RvY29sIGNvbW1hbmRzIHJhdGhl ciB0aGFuIHRoZSB0ZXN0IGhhcm5lc3MuCisKIDIwMTktMTItMTkgIERldmluIFJvdXNzbyAgPGRy b3Vzc29AYXBwbGUuY29tPgogCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IEF1ZGl0OiBleGl0aW5n IGVkaXQgbW9kZSB3aXRoIHRoZSBzYW1lIHNlbGVjdGlvbiBhcyBiZWZvcmUgZW50ZXJpbmcgZWRp dCBtb2RlIGRvZXNuJ3QgcmVzZWxlY3QKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JV SS9Vc2VySW50ZXJmYWNlL1Byb3RvY29sL1RhcmdldC5qcyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JV SS9Vc2VySW50ZXJmYWNlL1Byb3RvY29sL1RhcmdldC5qcwppbmRleCBjYTM4NWZlMjhiMWJlZmJh ODRjNDY5Yzg3NTg5MjFkN2ZmYjBhMzQxLi5jMjZhMTlhODg1ZWE4OTE0YWQ0ZmJkODdkY2JjNGYz Nzc3MGI1OTZhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFj ZS9Qcm90b2NvbC9UYXJnZXQuanMKKysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRl cmZhY2UvUHJvdG9jb2wvVGFyZ2V0LmpzCkBAIC0xMDAsNiArMTAwLDExIEBAIFdJLlRhcmdldCA9 IGNsYXNzIFRhcmdldCBleHRlbmRzIFdJLk9iamVjdAogICAgICAgICAgICAgICAgIHRoaXMuSW5z cGVjdG9yQWdlbnQuaW5pdGlhbGl6ZWQoKTsKICAgICAgICAgfSk7CiAKKyAgICAgICAgdGhpcy5f cmVzdW1lSWZQYXVzZWQoKTsKKyAgICB9CisKKyAgICBfcmVzdW1lSWZQYXVzZWQoKQorICAgIHsK ICAgICAgICAgaWYgKHRoaXMuX2lzUGF1c2VkKSB7CiAgICAgICAgICAgICBjb25zb2xlLmFzc2Vy dCh0aGlzLl9wYXJlbnRUYXJnZXQuaGFzQ29tbWFuZCgiVGFyZ2V0LnJlc3VtZSIpKTsKICAgICAg ICAgICAgIHRoaXMuX3BhcmVudFRhcmdldC5UYXJnZXRBZ2VudC5yZXN1bWUodGhpcy5faWRlbnRp ZmllciwgKGVycm9yKSA9PiB7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNl ckludGVyZmFjZS9UZXN0L0Zyb250ZW5kVGVzdEhhcm5lc3MuanMgYi9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvVXNlckludGVyZmFjZS9UZXN0L0Zyb250ZW5kVGVzdEhhcm5lc3MuanMKaW5kZXggM2Fj YzMzMDcwZmI3ZjVjZTQ3ZmUwNDhkMjRjNmIxMDk3OTI4MTE0ZC4uZTY4Yzk3ZjZhMjMxOGU4NmMw NjAzMjlmNzRlYzQ2ZWJiODgxNDcyYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJ L1VzZXJJbnRlcmZhY2UvVGVzdC9Gcm9udGVuZFRlc3RIYXJuZXNzLmpzCisrKyBiL1NvdXJjZS9X ZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1Rlc3QvRnJvbnRlbmRUZXN0SGFybmVzcy5qcwpA QCAtMTI3LDYgKzEyNywxMiBAQCBGcm9udGVuZFRlc3RIYXJuZXNzID0gY2xhc3MgRnJvbnRlbmRU ZXN0SGFybmVzcyBleHRlbmRzIFRlc3RIYXJuZXNzCiAgICAgICAgIH0KICAgICB9CiAKKyAgICBk ZWZlck91dHB1dFVudGlsVGVzdFBhZ2VJc1JlbG9hZGVkKCkKKyAgICB7CisgICAgICAgIGNvbnNv bGUuYXNzZXJ0KCF0aGlzLl90ZXN0UGFnZUlzUmVsb2FkaW5nKTsKKyAgICAgICAgdGhpcy5fdGVz dFBhZ2VJc1JlbG9hZGluZyA9IHRydWU7CisgICAgfQorCiAgICAgdGVzdFBhZ2VEaWRMb2FkKCkK ICAgICB7CiAgICAgICAgIGlmICh0aGlzLmR1bXBBY3Rpdml0eVRvU3lzdGVtQ29uc29sZSkKZGlm ZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwpp bmRleCAxZWIzNWJjZTc3YTAyMTc0MjZhMTAxMTdjM2I5MmU5ODFiMjU4ZTBmLi5iNmJiMTg0MzIz MDQ3YTRkMDM4ZDU4Y2ZlYTQ2ODE1OGRiOGNhNmY2IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9D aGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIw MjAtMDEtMDIgIFl1cnkgU2VtaWtoYXRza3kgIDx5dXJ5c0BjaHJvbWl1bS5vcmc+CisKKyAgICAg ICAgUkVHUkVTU0lPTjogWyBNYWMgd2syIF0gaHR0cC90ZXN0cy9pbnNwZWN0b3IvdGFyZ2V0L3By b3Zpc2lvbmFsLWxvYWQtY2FuY2Vscy1wcmV2aW91cy1sb2FkLmh0bWwgaXMgYSBmbGFreSBmYWls dXJlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDU0 NzMKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzU4MDkzNjkwPgorCisgICAgICAgIFJldmlld2Vk IGJ5IEJyaWFuIEJ1cmcuCisKKyAgICAgICAgS2VlcCBwcm92aXNpb25hbCBwYWdlIHBhdXNlZCB1 bnRpbCBzZWNvbmQgbmF2aWdhdGlvbiByZXBsYWNlcyBpdCBhbmQgYWxzbworICAgICAgICBkZWZl ciBvdXRwdXQgdW50aWwgdGVzdCBwYWdlIGlzIGZ1bGx5IGluaXRpYWxpemVkIGFmdGVyIG5hdmln YXRpb24uCisKKyAgICAgICAgKiBodHRwL3Rlc3RzL2luc3BlY3Rvci90YXJnZXQvcHJvdmlzaW9u YWwtbG9hZC1jYW5jZWxzLXByZXZpb3VzLWxvYWQuaHRtbDoKKwogMjAxOS0xMi0xOSAgQ2hyaXMg RHVtZXogIDxjZHVtZXpAYXBwbGUuY29tPgogCiAgICAgICAgIFJlc3luYyB3ZWItcGxhdGZvcm0t dGVzdHMvaHRtbCB0ZXN0cyBmcm9tIHVwc3RyZWFtCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9o dHRwL3Rlc3RzL2luc3BlY3Rvci90YXJnZXQvcHJvdmlzaW9uYWwtbG9hZC1jYW5jZWxzLXByZXZp b3VzLWxvYWQuaHRtbCBiL0xheW91dFRlc3RzL2h0dHAvdGVzdHMvaW5zcGVjdG9yL3RhcmdldC9w cm92aXNpb25hbC1sb2FkLWNhbmNlbHMtcHJldmlvdXMtbG9hZC5odG1sCmluZGV4IDI2NjI2MjIw ZTRmNGY5ZjQ0YTFiMTFmNWNkYzE2YTIyNTMyZmNhNjAuLjM3NzJiNDUxZjE0NGUzZjdkNjNiMmVk OWNlZjU3N2JjZTU1NzVjMGQgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2h0dHAvdGVzdHMvaW5z cGVjdG9yL3RhcmdldC9wcm92aXNpb25hbC1sb2FkLWNhbmNlbHMtcHJldmlvdXMtbG9hZC5odG1s CisrKyBiL0xheW91dFRlc3RzL2h0dHAvdGVzdHMvaW5zcGVjdG9yL3RhcmdldC9wcm92aXNpb25h bC1sb2FkLWNhbmNlbHMtcHJldmlvdXMtbG9hZC5odG1sCkBAIC0xOCw2ICsxOCwxMCBAQCBmdW5j dGlvbiB0ZXN0KCkKICAgICAgICAgICAgIGNvbnN0IHVybCA9ICJodHRwOi8vbG9jYWxob3N0Ojgw MDAvaW5zcGVjdG9yL3RhcmdldC9wcm92aXNpb25hbC1sb2FkLWNhbmNlbHMtcHJldmlvdXMtbG9h ZC5odG1sIjsKICAgICAgICAgICAgIGxldCBuYXZpZ2F0ZWRUd2ljZSA9IGZhbHNlOwogCisgICAg ICAgICAgICBsZXQgb3JpZ2luYWxSZXN1bWVJZlBhdXNlZCA9IFdJLlRhcmdldC5wcm90b3R5cGUu X3Jlc3VtZUlmUGF1c2VkOworICAgICAgICAgICAgLy8gS2VlcCBmaXJzdCBwcm92aXNpb25hbCBu YXZpZ2F0aW9uIHBhdXNlZC4KKyAgICAgICAgICAgIFdJLlRhcmdldC5wcm90b3R5cGUuX3Jlc3Vt ZUlmUGF1c2VkID0gKCkgPT4ge307CisKICAgICAgICAgICAgIFdJLnRhcmdldE1hbmFnZXIuYWRk RXZlbnRMaXN0ZW5lcihXSS5UYXJnZXRNYW5hZ2VyLkV2ZW50LlRhcmdldEFkZGVkLCAoZXZlbnQp ID0+IHsKICAgICAgICAgICAgICAgICBsZXQgdGFyZ2V0ID0gZXZlbnQuZGF0YS50YXJnZXQ7CiAg ICAgICAgICAgICAgICAgbGV0IHRhcmdldElkID0gdGFyZ2V0SWRNYXAuZ2V0KHRhcmdldC5pZGVu dGlmaWVyKTsKQEAgLTI2LDYgKzMwLDkgQEAgZnVuY3Rpb24gdGVzdCgpCiAgICAgICAgICAgICAg ICAgSW5zcGVjdG9yVGVzdC5leHBlY3RUcnVlKHRhcmdldC5pc1BhdXNlZCwgYFRhcmdldCAke3Rh cmdldElkfSBzaG91bGQgYmUgcGF1c2VkIG9uIHN0YXJ0LmApOwogICAgICAgICAgICAgICAgIGlm ICghbmF2aWdhdGVkVHdpY2UpIHsKICAgICAgICAgICAgICAgICAgICAgbmF2aWdhdGVkVHdpY2Ug PSB0cnVlOworICAgICAgICAgICAgICAgICAgICBXSS5UYXJnZXQucHJvdG90eXBlLl9yZXN1bWVJ ZlBhdXNlZCA9IG9yaWdpbmFsUmVzdW1lSWZQYXVzZWQ7CisKKyAgICAgICAgICAgICAgICAgICAg SW5zcGVjdG9yVGVzdC5kZWZlck91dHB1dFVudGlsVGVzdFBhZ2VJc1JlbG9hZGVkKCk7CiAKICAg ICAgICAgICAgICAgICAgICAgLy8gU2VuZCB0d28gY29uc2VxdXRpdmUgbmF2aWdhdGlvbiByZXF1 ZXN0cy4gVGhlIGxhdHRlciB3aWxsIGNhbmNlbCBwcm92aXNpb25hbAogICAgICAgICAgICAgICAg ICAgICAvLyBsb2FkIG9mIHRoZSBmb3JtZXIuCg==