205471 2019-12-19 13:54:17 -0800 Use a WeakHashSet for WKProcessAssertionBackgroundTaskManager._assertionsNeedingBackgroundTask 2019-12-19 15:51:19 -0800 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 cdumez cdumez achristensen beidson commit-queue ggaren rniwa webkit-bug-importer oldest_to_newest 1600485 0 cdumez 2019-12-19 13:54:17 -0800 Use a WeakHashSet for WKProcessAssertionBackgroundTaskManager._assertionsNeedingBackgroundTask, instead of a HashSet of raw pointers, for extra safety. 1600486 1 386140 cdumez 2019-12-19 13:55:13 -0800 Created attachment 386140 Patch 1600540 2 386140 commit-queue 2019-12-19 15:50:01 -0800 Comment on attachment 386140 Patch Clearing flags on attachment: 386140 Committed r253794: <https://trac.webkit.org/changeset/253794> 1600541 3 commit-queue 2019-12-19 15:50:02 -0800 All reviewed patches have been landed. Closing bug. 1600542 4 webkit-bug-importer 2019-12-19 15:51:19 -0800 <rdar://problem/58094829> 386140 2019-12-19 13:55:13 -0800 2019-12-19 15:50:01 -0800 Patch bug-205471-20191219135512.patch text/plain 3923 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjUzNzgzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGQzYjE4NTBhMzE4NDdhZjFk NzViZWRmNTViMmIzNGRlYTRmMmI5MTUuLmQ4ODc0YWFlZTVkNDYzYWUwNWI3ZWViNzdlN2QxZTEz YTA4ZWY0YjEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMTktMTItMTkgIENocmlzIER1 bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KKworICAgICAgICBVc2UgYSBXZWFrSGFzaFNldCBmb3Ig V0tQcm9jZXNzQXNzZXJ0aW9uQmFja2dyb3VuZFRhc2tNYW5hZ2VyLl9hc3NlcnRpb25zTmVlZGlu Z0JhY2tncm91bmRUYXNrCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0yMDU0NzEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBVc2UgYSBXZWFrSGFzaFNldCBmb3IgV0tQcm9jZXNzQXNzZXJ0aW9uQmFja2dyb3Vu ZFRhc2tNYW5hZ2VyLl9hc3NlcnRpb25zTmVlZGluZ0JhY2tncm91bmRUYXNrLCBpbnN0ZWFkCisg ICAgICAgIG9mIGEgSGFzaFNldCBvZiByYXcgcG9pbnRlcnMsIGZvciBleHRyYSBzYWZldHkuCisK KyAgICAgICAgKiBVSVByb2Nlc3MvaW9zL1Byb2Nlc3NBc3NlcnRpb25JT1MubW06CisgICAgICAg ICgtW1dLUHJvY2Vzc0Fzc2VydGlvbkJhY2tncm91bmRUYXNrTWFuYWdlciByZW1vdmVBc3NlcnRp b25OZWVkaW5nQmFja2dyb3VuZFRhc2s6XSk6CisgICAgICAgICgtW1dLUHJvY2Vzc0Fzc2VydGlv bkJhY2tncm91bmRUYXNrTWFuYWdlciBfbm90aWZ5QXNzZXJ0aW9uc09mSW1taW5lbnRTdXNwZW5z aW9uXSk6CisgICAgICAgICgtW1dLUHJvY2Vzc0Fzc2VydGlvbkJhY2tncm91bmRUYXNrTWFuYWdl ciBfdXBkYXRlQmFja2dyb3VuZFRhc2tdKToKKwogMjAxOS0xMi0xOSAgQWxleCBDaHJpc3RlbnNl biAgPGFjaHJpc3RlbnNlbkB3ZWJraXQub3JnPgogCiAgICAgICAgIERlcHJlY2F0ZSBfV0tSZW1v dGVPYmplY3RJbnRlcmZhY2UgbWV0aG9kcyB3aXRob3V0IG9mUmVwbHk6CmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9pb3MvUHJvY2Vzc0Fzc2VydGlvbklPUy5tbSBiL1NvdXJj ZS9XZWJLaXQvVUlQcm9jZXNzL2lvcy9Qcm9jZXNzQXNzZXJ0aW9uSU9TLm1tCmluZGV4IDE5NGJi NzA1ZTg4N2NiYmZlZmQ0NmE4ZGYzZmM1NTNmNDg1OTRiYmUuLjMxYzEwOTczM2EwMjYwYTdmMzEx YzU4MTk4OGIxNzdjYjg4NTljOGQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNz L2lvcy9Qcm9jZXNzQXNzZXJ0aW9uSU9TLm1tCisrKyBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNz L2lvcy9Qcm9jZXNzQXNzZXJ0aW9uSU9TLm1tCkBAIC0zNSw2ICszNSw3IEBACiAjaW1wb3J0IDx3 dGYvSGFzaE1hcC5oPgogI2ltcG9ydCA8d3RmL1J1bkxvb3AuaD4KICNpbXBvcnQgPHd0Zi9WZWN0 b3IuaD4KKyNpbXBvcnQgPHd0Zi9XZWFrSGFzaFNldC5oPgogCiB1c2luZyBXZWJLaXQ6OlByb2Nl c3NBbmRVSUFzc2VydGlvbjsKIApAQCAtNTUsNyArNTYsNyBAQCBAZW5kCiBAaW1wbGVtZW50YXRp b24gV0tQcm9jZXNzQXNzZXJ0aW9uQmFja2dyb3VuZFRhc2tNYW5hZ2VyCiB7CiAgICAgVUlCYWNr Z3JvdW5kVGFza0lkZW50aWZpZXIgX2JhY2tncm91bmRUYXNrOwotICAgIEhhc2hTZXQ8UHJvY2Vz c0FuZFVJQXNzZXJ0aW9uKj4gX2Fzc2VydGlvbnNOZWVkaW5nQmFja2dyb3VuZFRhc2s7CisgICAg V2Vha0hhc2hTZXQ8UHJvY2Vzc0FuZFVJQXNzZXJ0aW9uPiBfYXNzZXJ0aW9uc05lZWRpbmdCYWNr Z3JvdW5kVGFzazsKICAgICBCT09MIF9hcHBsaWNhdGlvbklzQmFja2dyb3VuZGVkOwogICAgIGRp c3BhdGNoX2Jsb2NrX3QgX3BlbmRpbmdUYXNrUmVsZWFzZVRhc2s7CiB9CkBAIC0xMDQsNyArMTA1 LDcgQEAgLSAodm9pZClhZGRBc3NlcnRpb25OZWVkaW5nQmFja2dyb3VuZFRhc2s6KFByb2Nlc3NB bmRVSUFzc2VydGlvbiYpYXNzZXJ0aW9uCiAKIC0gKHZvaWQpcmVtb3ZlQXNzZXJ0aW9uTmVlZGlu Z0JhY2tncm91bmRUYXNrOihQcm9jZXNzQW5kVUlBc3NlcnRpb24mKWFzc2VydGlvbgogewotICAg IF9hc3NlcnRpb25zTmVlZGluZ0JhY2tncm91bmRUYXNrLnJlbW92ZSgmYXNzZXJ0aW9uKTsKKyAg ICBfYXNzZXJ0aW9uc05lZWRpbmdCYWNrZ3JvdW5kVGFzay5yZW1vdmUoYXNzZXJ0aW9uKTsKICAg ICBbc2VsZiBfdXBkYXRlQmFja2dyb3VuZFRhc2tdOwogfQogCkBAIC0xMTIsOSArMTEzLDkgQEAg LSAodm9pZClfbm90aWZ5QXNzZXJ0aW9uc09mSW1taW5lbnRTdXNwZW5zaW9uCiB7CiAgICAgQVNT RVJUKFJ1bkxvb3A6OmlzTWFpbigpKTsKIAotICAgIFZlY3RvcjxXZWFrUHRyPFByb2Nlc3NBbmRV SUFzc2VydGlvbj4+IGFzc2VydGlvbnNOZWVkaW5nQmFja2dyb3VuZFRhc2sgPSBXVEY6Om1hcChf YXNzZXJ0aW9uc05lZWRpbmdCYWNrZ3JvdW5kVGFzaywgW10oYXV0byogYXNzZXJ0aW9uKSB7Ci0g ICAgICAgIHJldHVybiBtYWtlV2Vha1B0cigqYXNzZXJ0aW9uKTsKLSAgICB9KTsKKyAgICBWZWN0 b3I8V2Vha1B0cjxQcm9jZXNzQW5kVUlBc3NlcnRpb24+PiBhc3NlcnRpb25zTmVlZGluZ0JhY2tn cm91bmRUYXNrOworICAgIGZvciAoYXV0byYgYXNzZXJ0aW9uIDogX2Fzc2VydGlvbnNOZWVkaW5n QmFja2dyb3VuZFRhc2spCisgICAgICAgIGFzc2VydGlvbnNOZWVkaW5nQmFja2dyb3VuZFRhc2su YXBwZW5kKG1ha2VXZWFrUHRyKGFzc2VydGlvbikpOwogCiAgICAgLy8gTm90ZSB0aGF0IHdlIGRv bid0IGV4cGVjdCBjbGllbnRzIHRvIHJlZ2lzdGVyIG5ldyBhc3NlcnRpb25zIHdoZW4gZ2V0dGlu ZyBub3RpZmllZCB0aGF0IHRoZSBVSSBhc3NlcnRpb24gd2lsbCBleHBpcmUgaW1taW5lbnRseS4K ICAgICAvLyBJZiBjbGllbnRzIHdlcmUgdG8gZG8gc28sIHRoZW4gdGhvc2UgbmV3IGFzc2VydGlv bnMgd291bGQgbm90IGdldCBub3RpZmllZCBvZiB0aGUgaW1taW5lbnQgc3VzcGVuc2lvbi4KQEAg LTE1NSw3ICsxNTYsNyBAQCAtICh2b2lkKV9jYW5jZWxQZW5kaW5nUmVsZWFzZVRhc2sKIAogLSAo dm9pZClfdXBkYXRlQmFja2dyb3VuZFRhc2sKIHsKLSAgICBpZiAoIV9hc3NlcnRpb25zTmVlZGlu Z0JhY2tncm91bmRUYXNrLmlzRW1wdHkoKSAmJiBfYmFja2dyb3VuZFRhc2sgPT0gVUlCYWNrZ3Jv dW5kVGFza0ludmFsaWQpIHsKKyAgICBpZiAoIV9hc3NlcnRpb25zTmVlZGluZ0JhY2tncm91bmRU YXNrLmNvbXB1dGVzRW1wdHkoKSAmJiBfYmFja2dyb3VuZFRhc2sgPT0gVUlCYWNrZ3JvdW5kVGFz a0ludmFsaWQpIHsKICAgICAgICAgaWYgKF9hcHBsaWNhdGlvbklzQmFja2dyb3VuZGVkKSB7CiAg ICAgICAgICAgICBSRUxFQVNFX0xPR19FUlJPUihQcm9jZXNzU3VzcGVuc2lvbiwgIiVwIC0gV0tQ cm9jZXNzQXNzZXJ0aW9uQmFja2dyb3VuZFRhc2tNYW5hZ2VyOiBJZ25vcmVkIHJlcXVlc3QgdG8g c3RhcnQgYSBuZXcgYmFja2dyb3VuZCB0YXNrIGJlY2F1c2UgdGhlIGFwcGxpY2F0aW9uIGlzIGFs cmVhZHkgaW4gdGhlIGJhY2tncm91bmQiLCBzZWxmKTsKICAgICAgICAgICAgIHJldHVybjsKQEAg LTE4NSw3ICsxODYsNyBAQCAtICh2b2lkKV91cGRhdGVCYWNrZ3JvdW5kVGFzawogCiAgICAgICAg ICAgICBbc2VsZiBfc2NoZWR1bGVSZWxlYXNlVGFza107CiAgICAgICAgIH1dOwotICAgIH0gZWxz ZSBpZiAoX2Fzc2VydGlvbnNOZWVkaW5nQmFja2dyb3VuZFRhc2suaXNFbXB0eSgpKQorICAgIH0g ZWxzZSBpZiAoX2Fzc2VydGlvbnNOZWVkaW5nQmFja2dyb3VuZFRhc2suY29tcHV0ZXNFbXB0eSgp KQogICAgICAgICBbc2VsZiBfcmVsZWFzZUJhY2tncm91bmRUYXNrXTsKIH0KIAo=