205463 2019-12-19 11:41:55 -0800 Log telemetry for IOUserClient lookups 2019-12-19 16:04:06 -0800 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 bfulgham bfulgham bfulgham ggaren pvollan webkit-bug-importer oldest_to_newest 1600401 0 bfulgham 2019-12-19 11:41:55 -0800 We should use telemetry to make sure that every instance of an IOKit class we allow in our sandbox is actually needed by something for valid purposes. Ideally, we would move as many of these out of the WebContent process as possible. This telemetry will be a good first step in seeing if there is any low-hanging fruit. 1600402 1 bfulgham 2019-12-19 11:42:10 -0800 <rdar://problem/57987372> 1600405 2 386127 bfulgham 2019-12-19 11:44:59 -0800 Created attachment 386127 Patch 1600436 3 386127 pvollan 2019-12-19 12:30:57 -0800 Comment on attachment 386127 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=386127&action=review R=me. > Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:451 > (iokit-user-client-class "AppleJPEGDriverUserClient") > (iokit-user-client-class "IOSurfaceAcceleratorClient") No telemetry for these? > Source/WebKit/WebProcess/com.apple.WebProcess.sb.in:564 > (iokit-user-client-class "AppleMultitouchDeviceUserClient") > (iokit-user-client-class "AppleUpstreamUserClient") Ditto. 1600471 4 386127 bfulgham 2019-12-19 13:24:05 -0800 Comment on attachment 386127 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=386127&action=review >> Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:451 >> (iokit-user-client-class "IOSurfaceAcceleratorClient") > > No telemetry for these? I think we expect to be using these, so telemetry won't be that useful (everyone will always have these). But if we move these features to the GPU Process we should add telemetry, too, and consider removing them. >> Source/WebKit/WebProcess/com.apple.WebProcess.sb.in:564 >> (iokit-user-client-class "AppleUpstreamUserClient") > > Ditto. Actually, I'm not sure if we use these. I'll add them. 1600549 5 bfulgham 2019-12-19 16:04:06 -0800 Committed r253798: <https://trac.webkit.org/changeset/253798> 386127 2019-12-19 11:44:59 -0800 2019-12-19 12:30:57 -0800 Patch bug-205463-20191219114458.patch text/plain 6479 bfulgham U3VidmVyc2lvbiBSZXZpc2lvbjogMjUzNzY3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDEzYzUxMTQ0Y2EyMzEzMjlj OTU0NmIyODU1NmI2YjY2YjgzZDVkNGIuLmJiMTE3ZmE3MmMxZTJiOThlZjU4Njk3M2YyMTMzMmQ1 OGVjMGJmMGMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAgQEAKKzIwMTktMTItMTkgIEJyZW50IEZ1 bGdoYW0gIDxiZnVsZ2hhbUBhcHBsZS5jb20+CisKKyAgICAgICAgTG9nIHRlbGVtZXRyeSBmb3Ig SU9Vc2VyQ2xpZW50IGxvb2t1cHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTIwNTQ2MworICAgICAgICA8cmRhcjovL3Byb2JsZW0vNTc5ODczNzI+CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhpcyBwYXRj aCBhZGRzIHNvbWUgdGVsZW1ldHJ5IGZvciBJT0tpdCBjbGFzc2VzLgorCisgICAgICAgIE5vIG5l dyB0ZXN0cy4gTm8gY2hhbmdlIGluIGJlaGF2aW9yLgorCisgICAgICAgICogTmV0d29ya1Byb2Nl c3MvbWFjL2NvbS5hcHBsZS5XZWJLaXQuTmV0d29ya1Byb2Nlc3Muc2IuaW46CisgICAgICAgICog UmVzb3VyY2VzL1NhbmRib3hQcm9maWxlcy9pb3MvY29tLmFwcGxlLldlYktpdC5OZXR3b3JraW5n LnNiOgorICAgICAgICAqIFJlc291cmNlcy9TYW5kYm94UHJvZmlsZXMvaW9zL2NvbS5hcHBsZS5X ZWJLaXQuV2ViQ29udGVudC5zYjoKKyAgICAgICAgKiBXZWJQcm9jZXNzL2NvbS5hcHBsZS5XZWJQ cm9jZXNzLnNiLmluOgorCiAyMDE5LTEyLTE5ICB5b3Vlbm4gZmFibGV0ICA8eW91ZW5uQGFwcGxl LmNvbT4KIAogICAgICAgICBDYWNoZVN0b3JhZ2VFbmdpbmUgc2hvdWxkIG5vdCBjbGVhciBjYWNo ZXMgbWVtb3J5IHJlcHJlc2VudGF0aW9uIGZvciBlcGhlbWVyYWwgc2Vzc2lvbnMKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJLaXQvTmV0d29ya1Byb2Nlc3MvbWFjL2NvbS5hcHBsZS5XZWJLaXQuTmV0 d29ya1Byb2Nlc3Muc2IuaW4gYi9Tb3VyY2UvV2ViS2l0L05ldHdvcmtQcm9jZXNzL21hYy9jb20u YXBwbGUuV2ViS2l0Lk5ldHdvcmtQcm9jZXNzLnNiLmluCmluZGV4IDQyZWUyOTQ2MTg4NDVjNzNj Y2QxMDQwOWMyYzI0NDQ1Zjk0NGFlOGMuLmI4OTNjZTQ0MGFmMzA2Y2QxZmZkYTY1NzIzZmExYzQz ODEzN2FlYjQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvTmV0d29ya1Byb2Nlc3MvbWFjL2Nv bS5hcHBsZS5XZWJLaXQuTmV0d29ya1Byb2Nlc3Muc2IuaW4KKysrIGIvU291cmNlL1dlYktpdC9O ZXR3b3JrUHJvY2Vzcy9tYWMvY29tLmFwcGxlLldlYktpdC5OZXR3b3JrUHJvY2Vzcy5zYi5pbgpA QCAtMTMzLDYgKzEzMyw5IEBACiAKIDs7IElPS2l0IHVzZXIgY2xpZW50cwogKGFsbG93IGlva2l0 LW9wZW4KKyNpZiBfX01BQ19PU19YX1ZFUlNJT05fTUlOX1JFUVVJUkVEID49IDEwMTUwMAorICAg ICh3aXRoIHJlcG9ydCkgKHdpdGggdGVsZW1ldHJ5KQorI2VuZGlmCiAgICAgKGlva2l0LXVzZXIt Y2xpZW50LWNsYXNzICJSb290RG9tYWluVXNlckNsaWVudCIpKQogCiA7OyBjb29raWVkLgpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYktpdC9SZXNvdXJjZXMvU2FuZGJveFByb2ZpbGVzL2lvcy9jb20u YXBwbGUuV2ViS2l0Lk5ldHdvcmtpbmcuc2IgYi9Tb3VyY2UvV2ViS2l0L1Jlc291cmNlcy9TYW5k Ym94UHJvZmlsZXMvaW9zL2NvbS5hcHBsZS5XZWJLaXQuTmV0d29ya2luZy5zYgppbmRleCBiNmQx YjE4NWE0YjM5YzI3NGNjNjFiNzQ4N2Y4YmZjZDIxOGQ0M2M5Li45OWEyM2QwZDBmYTgyM2QyZGE0 ZDc5OGY0MDJmZjJkZjkwMDg5OWUxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1Jlc291cmNl cy9TYW5kYm94UHJvZmlsZXMvaW9zL2NvbS5hcHBsZS5XZWJLaXQuTmV0d29ya2luZy5zYgorKysg Yi9Tb3VyY2UvV2ViS2l0L1Jlc291cmNlcy9TYW5kYm94UHJvZmlsZXMvaW9zL2NvbS5hcHBsZS5X ZWJLaXQuTmV0d29ya2luZy5zYgpAQCAtNTUsNyArNTUsNyBAQAogOzsgZW5vdWdoIGFjY2VzcyB0 byBtYWtlIGl0IHBvc3NpYmxlLgogCiA7OyBJT0tpdCB1c2VyIGNsaWVudHMKLShhbGxvdyBpb2tp dC1vcGVuCisoYWxsb3cgaW9raXQtb3BlbiAod2l0aCByZXBvcnQpICh3aXRoIHRlbGVtZXRyeSkK ICAgICAgICAoaW9raXQtdXNlci1jbGllbnQtY2xhc3MgIlJvb3REb21haW5Vc2VyQ2xpZW50Iikp CiAKIDs7IFZhcmlvdXMgc2VydmljZXMgcmVxdWlyZWQgYnkgQ0ZOZXR3b3JrIGFuZCBvdGhlciBm cmFtZXdvcmtzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1Jlc291cmNlcy9TYW5kYm94UHJv ZmlsZXMvaW9zL2NvbS5hcHBsZS5XZWJLaXQuV2ViQ29udGVudC5zYiBiL1NvdXJjZS9XZWJLaXQv UmVzb3VyY2VzL1NhbmRib3hQcm9maWxlcy9pb3MvY29tLmFwcGxlLldlYktpdC5XZWJDb250ZW50 LnNiCmluZGV4IDY5MzdiNGE5ZDZlNjBlZGY1YjliZGQzMThjYjJiYTM0NDdjYzIxY2MuLmI0YTk2 MWU0YTE5OTgyNzdhNGE3MmMzNzFjMzhhOTFiNjBiNGE3YTcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJLaXQvUmVzb3VyY2VzL1NhbmRib3hQcm9maWxlcy9pb3MvY29tLmFwcGxlLldlYktpdC5XZWJD b250ZW50LnNiCisrKyBiL1NvdXJjZS9XZWJLaXQvUmVzb3VyY2VzL1NhbmRib3hQcm9maWxlcy9p b3MvY29tLmFwcGxlLldlYktpdC5XZWJDb250ZW50LnNiCkBAIC04Nyw3ICs4Nyw3IEBACiAgICAg KGFsbG93IHVzZXItcHJlZmVyZW5jZS1yZWFkIHVzZXItcHJlZmVyZW5jZS13cml0ZSAoYXBwbHkg cHJlZmVyZW5jZS1kb21haW4gZG9tYWlucykpKQogCiAoZGVmaW5lLW9uY2UgKGZyYW1lYnVmZmVy LWFjY2VzcykKLSAgICAoYWxsb3cgaW9raXQtb3BlbgorICAgIChhbGxvdyBpb2tpdC1vcGVuICh3 aXRoIHJlcG9ydCkgKHdpdGggdGVsZW1ldHJ5KQogICAgICAgICAgICAoaW9raXQtdXNlci1jbGll bnQtY2xhc3MgIklPTW9iaWxlRnJhbWVidWZmZXJVc2VyQ2xpZW50IikpCiAgICAgKG1vYmlsZS1w cmVmZXJlbmNlcy1yZWFkICJjb20uYXBwbGUuaW9raXQuSU9Nb2JpbGVHcmFwaGljc0ZhbWlseSIp KQogCkBAIC0xMDgsNyArMTA4LDcgQEAKICAgICAgICAgKG1vYmlsZS1wcmVmZXJlbmNlcy1yZWFk ICJjb20uYXBwbGUuTW9iaWxlQXNzZXQiKSkpCiAKIChkZWZpbmUtb25jZSAobW9iaWxlLWtleWJh Zy1hY2Nlc3MpCi0gICAgIChhbGxvdyBpb2tpdC1vcGVuCisgICAgIChhbGxvdyBpb2tpdC1vcGVu ICh3aXRoIHJlcG9ydCkgKHdpdGggdGVsZW1ldHJ5KQogICAgICAgICAgICAgKGlva2l0LXVzZXIt Y2xpZW50LWNsYXNzICJBcHBsZUtleVN0b3JlVXNlckNsaWVudCIpKSkKIAogKGRlZmluZS1vbmNl IChsb2NhdGlvbi1zZXJ2aWNlcykKQEAgLTQxMiw3ICs0MTIsNyBAQAogICAgICAgICAgICAgKGlv a2l0LXByb3BlcnR5ICJneXJvLWludGVycnVwdC1jYWxpYnJhdGlvbiIpKSkKICAgICAod2l0aC1m aWx0ZXIKICAgICAgICAgKGlva2l0LXJlZ2lzdHJ5LWVudHJ5LWNsYXNzICJJT0hJREV2ZW50U2Vy dmljZUZhc3RQYXRoVXNlckNsaWVudCIpCi0gICAgICAgIChhbGxvdyBpb2tpdC1vcGVuKQorICAg ICAgICAoYWxsb3cgaW9raXQtb3BlbiAod2l0aCByZXBvcnQpICh3aXRoIHRlbGVtZXRyeSkpCiAg ICAgICAgIChhbGxvdyBpb2tpdC1nZXQtcHJvcGVydGllcyBpb2tpdC1zZXQtcHJvcGVydGllcwog ICAgICAgICAgICAgKGlva2l0LXByb3BlcnR5ICJpbnRlcnZhbCIKICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAibW9kZSIKQEAgLTQ0OSw3ICs0NDksOCBAQAogICAgIChhbGxvdyBpb2tpdC1v cGVuCiAgICAgICAgIChpb2tpdC11c2VyLWNsaWVudC1jbGFzcyAiQXBwbGVKUEVHRHJpdmVyVXNl ckNsaWVudCIpCiAgICAgICAgIChpb2tpdC11c2VyLWNsaWVudC1jbGFzcyAiSU9TdXJmYWNlQWNj ZWxlcmF0b3JDbGllbnQiKQotICAgICAgICAoaW9raXQtdXNlci1jbGllbnQtY2xhc3MgIklPU3Vy ZmFjZVNlbmRSaWdodCIpCisgICAgICAgIChpb2tpdC11c2VyLWNsaWVudC1jbGFzcyAiSU9TdXJm YWNlU2VuZFJpZ2h0IikpCisgICAgKGFsbG93IGlva2l0LW9wZW4gKHdpdGggcmVwb3J0KSAod2l0 aCB0ZWxlbWV0cnkpCiAgICAgICAgIDs7IFJlcXVpcmVzIGJ5IFVJVmlldyAtPiBVSVRleHRNYWdu aWZpZXJSZW5kZXJlciAtPiBVSVdpbmRvdwogICAgICAgICAoaW9raXQtdXNlci1jbGllbnQtY2xh c3MgIklPU3VyZmFjZVJvb3RVc2VyQ2xpZW50IikpCiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJL aXQvV2ViUHJvY2Vzcy9jb20uYXBwbGUuV2ViUHJvY2Vzcy5zYi5pbiBiL1NvdXJjZS9XZWJLaXQv V2ViUHJvY2Vzcy9jb20uYXBwbGUuV2ViUHJvY2Vzcy5zYi5pbgppbmRleCAzN2VjNDgxOGI3YThk MzVkZWRjMTIxZjNkNjBiNzQ3OGVkZWMyOTVhLi4yYzU4NzY3YmZhNDc2YjMwMDc2ZjFkZDY0NzBm NmEwNWQxMWMxNzZjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvY29tLmFw cGxlLldlYlByb2Nlc3Muc2IuaW4KKysrIGIvU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL2NvbS5h cHBsZS5XZWJQcm9jZXNzLnNiLmluCkBAIC0xMTYsOSArMTE2LDE1IEBACiAgICAgICAgIChpb2tp dC1yZWdpc3RyeS1lbnRyeS1jbGFzcyAiSU9TdXJmYWNlU2VuZFJpZ2h0IikpCiAgICAgOzsgQ29y ZVZpZGVvIENWQ0dEaXNwbGF5TGluawogICAgIChhbGxvdyBpb2tpdC1vcGVuCisjaWYgX19NQUNf T1NfWF9WRVJTSU9OX01JTl9SRVFVSVJFRCA+PSAxMDE1MDAKKyAgICAgICAgKHdpdGggcmVwb3J0 KSAod2l0aCB0ZWxlbWV0cnkpCisjZW5kaWYKICAgICAgICAgKGlva2l0LXJlZ2lzdHJ5LWVudHJ5 LWNsYXNzICJJT0ZyYW1lYnVmZmVyU2hhcmVkVXNlckNsaWVudCIpKQogICAgIDs7IEguMjY0IEFj Y2VsZXJhdGlvbgogICAgIChhbGxvdyBpb2tpdC1vcGVuCisjaWYgX19NQUNfT1NfWF9WRVJTSU9O X01JTl9SRVFVSVJFRCA+PSAxMDE1MDAKKyAgICAgICAgKHdpdGggcmVwb3J0KSAod2l0aCB0ZWxl bWV0cnkpCisjZW5kaWYKICAgICAgICAgKGlva2l0LXJlZ2lzdHJ5LWVudHJ5LWNsYXNzICJBcHBs ZUludGVsTUVVc2VyQ2xpZW50IikKICAgICAgICAgKGlva2l0LXJlZ2lzdHJ5LWVudHJ5LWNsYXNz ICJBcHBsZVNOQkZCVXNlckNsaWVudCIpKQogICAgIDs7IFF1YXJ0ekNvcmUKQEAgLTU1NiwxMiAr NTYyLDE4IEBACiAoYWxsb3cgaW9raXQtb3BlbgogICAgIChpb2tpdC11c2VyLWNsaWVudC1jbGFz cyAiQXBwbGVNdWx0aXRvdWNoRGV2aWNlVXNlckNsaWVudCIpCiAgICAgKGlva2l0LXVzZXItY2xp ZW50LWNsYXNzICJBcHBsZVVwc3RyZWFtVXNlckNsaWVudCIpCi0gICAgKGlva2l0LXVzZXItY2xp ZW50LWNsYXNzICJJT0hJRFBhcmFtVXNlckNsaWVudCIpCi0gICAgKGlva2l0LXVzZXItY2xpZW50 LWNsYXNzICJSb290RG9tYWluVXNlckNsaWVudCIpCispCisoYWxsb3cgaW9raXQtb3BlbgorI2lm IF9fTUFDX09TX1hfVkVSU0lPTl9NSU5fUkVRVUlSRUQgPj0gMTAxNTAwCisgICAgKHdpdGggcmVw b3J0KSAod2l0aCB0ZWxlbWV0cnkpCisjZW5kaWYKICAgICAoaW9raXQtdXNlci1jbGllbnQtY2xh c3MgIklPQXVkaW9Db250cm9sVXNlckNsaWVudCIpCiAgICAgKGlva2l0LXVzZXItY2xpZW50LWNs YXNzICJJT0F1ZGlvRW5naW5lVXNlckNsaWVudCIpCisgICAgKGlva2l0LXVzZXItY2xpZW50LWNs YXNzICJJT0hJRFBhcmFtVXNlckNsaWVudCIpCisgICAgKGlva2l0LXVzZXItY2xpZW50LWNsYXNz ICJSb290RG9tYWluVXNlckNsaWVudCIpCiAgICAgOzsgRm9sbG93aW5nIGlzIG5lZWRlZCBkdWUg dG8gPHJkYXI6Ly9wcm9ibGVtLzEwNDI3NDUxPiAmJiA8cmRhcjovL3Byb2JsZW0vMTA4MDg4MTc+ Ci0gICAgKGlva2l0LXVzZXItY2xpZW50LWNsYXNzICJBdWRpb0FVVUMiKSkKKyAgICAoaW9raXQt dXNlci1jbGllbnQtY2xhc3MgIkF1ZGlvQVVVQyIpCispCiAKIDs7IGNvb2tpZWQuCiA7OyBGSVhN RTogVXBkYXRlIGZvciA8cmRhcjovL3Byb2JsZW0vMTM2NDI4NTI+LgpAQCAtODI3LDYgKzgzOSw5 IEBACiAgICAgICAgIDs7IFF1aWNrVGltZUlJRENEaWdpdGl6ZXIgYXNzaXN0YW50CiAgICAgICAg IChnbG9iYWwtbmFtZSAiY29tLmFwcGxlLklJRENBc3Npc3RhbnQiKSkKICAgICAoYWxsb3cgaW9r aXQtb3BlbgorI2lmIF9fTUFDX09TX1hfVkVSU0lPTl9NSU5fUkVRVUlSRUQgPj0gMTAxNTAwCisg ICAgICAgICh3aXRoIHJlcG9ydCkgKHdpdGggdGVsZW1ldHJ5KQorI2VuZGlmCiAgICAgICAgIDs7 IFF1aWNrVGltZVVTQlZEQ0RpZ2l0aXplcgogICAgICAgICAoaW9raXQtdXNlci1jbGllbnQtY2xh c3MgIklPVVNCRGV2aWNlVXNlckNsaWVudFYyIikKICAgICAgICAgKGlva2l0LXVzZXItY2xpZW50 LWNsYXNzICJJT1VTQkludGVyZmFjZVVzZXJDbGllbnRWMiIpKQo=