205458 2019-12-19 09:34:23 -0800 REGRESSION: [ iOS ] imported/w3c/web-platform-tests/dom/events/Event-dispatch-on-disabled-elements.html is failing 2020-01-27 12:36:27 -0800 1 1 1 Unclassified WebKit DOM WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=206759 InRadar P2 Normal --- 1 tsavell graouts commit-queue dbates ddkilzer graouts thorton webkit-bot-watchers-bugzilla webkit-bug-importer wenson_hsieh oldest_to_newest 1600322 0 tsavell 2019-12-19 09:34:23 -0800 imported/w3c/web-platform-tests/dom/events/Event-dispatch-on-disabled-elements.html This test is failing constantly on iOS and has been very flakey. This was last modified in https://trac.webkit.org/changeset/253728/webkit This is currently slowing down EWS History: https://results.webkit.org/?suite=layout-tests&test=imported%2Fw3c%2Fweb-platform-tests%2Fdom%2Fevents%2FEvent-dispatch-on-disabled-elements.html 1600323 1 webkit-bug-importer 2019-12-19 09:34:50 -0800 <rdar://problem/58081704> 1600739 2 graouts 2019-12-20 08:45:08 -0800 Right… so: it was failing constantly but I think this was addressed in r253746. This was based on results from EWS that somehow don't reproduce now, odd. I'll look into this shortly. 1602071 3 graouts 2020-01-01 08:47:50 -0800 The failing test, "Real clicks on disabled elements must not dispatch events.", runs the same steps for five types of elements: "button", "fieldset", "input", "select" and "textarea", in that order. If we run the steps for each element type individually, it passes. If we run "button", "fieldset", "input" and then either "select" or "textarea", it passes. However, if we try to run both of those, it fails. Logging shows that we do not enter -[WKContentViewInteraction _singleTapRecognized:] after the "click" event to "select" has been delivered. My guess is that even though the "select" element has been removed, UIKit still delivers the immediate next tap to it and the WKContentView doesn't see it and fails to deliver the next tap to the Web content. 1602072 4 graouts 2020-01-01 08:57:53 -0800 Adding this before continuing to the next element type fixes the issue: await new Promise(resolve => setTimeout(resolve, 1000)); We need to figure out why continuing the loop synchronously after the call to remove() fails. 1602075 5 dbates 2020-01-01 09:28:01 -0800 Only considering what you wrote (I haven't looked at the test): my guess is that UIKit does **not** delivering the tap because the kit is animating a view and this is the default kit behavior. It's fixable. 1602078 6 graouts 2020-01-01 09:51:02 -0800 So [_inputPeripheral beginEditing] is called in -[WKContentViewInteraction _elementDidFocus:userIsInteracting:blurPreviousNode:activityStateChanges:userObject:] for the <select> element after we attempt to click on the <textarea> in the next loop iteration. 1602122 7 wenson_hsieh 2020-01-01 19:58:23 -0800 (In reply to Daniel Bates from comment #5) > Only considering what you wrote (I haven't looked at the test): my guess is > that UIKit does **not** delivering the tap because the kit is animating a > view and this is the default kit behavior. It's fixable. Dan's hunch is correct. WKScrollView is eating the subsequent touches after bringing up the input view, because it has active animations (i.e. the implementation of -[UIView hitTest:withEvent:]). This happens because we're trying to zoom/scroll to reveal the focused element. To test this, I commented out the implementation of -[WKContentView _zoomToRevealFocusedElement], and saw that the flakiness did not reproduce. 1602128 8 wenson_hsieh 2020-01-01 20:35:54 -0800 A couple of potential ways to fix this: 1. Wait for animations on WKScrollView to finish before proceeding with a single tap in UIScriptControllerIOS::singleTapAtPointWithModifiers, like so: + NSDate *timeoutDate = [NSDate dateWithTimeIntervalSinceNow:someReasonableTimeoutDate]; + while (webView().scrollView.layer.animationKeys.count) { + [[NSRunLoop currentRunLoop] runMode:NSDefaultRunLoopMode beforeDate:timeoutDate]; + if ([timeoutDate compare:NSDate.date] == NSOrderedAscending) + break; + } or, 2. Force animations to finish before proceeding with a single tap in UIScriptControllerIOS::singleTapAtPointWithModifiers, like so: + [webView().scrollView _removeAllAnimations:NO]; 1603023 9 386841 graouts 2020-01-06 06:46:12 -0800 Created attachment 386841 Patch 1603261 10 386841 commit-queue 2020-01-06 14:04:42 -0800 Comment on attachment 386841 Patch Clearing flags on attachment: 386841 Committed r254082: <https://trac.webkit.org/changeset/254082> 1603262 11 commit-queue 2020-01-06 14:04:44 -0800 All reviewed patches have been landed. Closing bug. 1611521 12 ddkilzer 2020-01-27 12:36:27 -0800 This fixed iPhone Simulator test failures, but not iPad Simulator test failures, which are tracked by: Bug 206759: REGRESSION: [ iOS ] imported/w3c/web-platform-tests/dom/events/Event-dispatch-on-disabled-elements.html is flaky failing <https://bugs.webkit.org/show_bug.cgi?id=206759> 386841 2020-01-06 06:46:12 -0800 2020-01-06 14:04:42 -0800 Patch bug-205458-20200106154610.patch text/plain 4805 graouts U3VidmVyc2lvbiBSZXZpc2lvbjogMjU0MDQ4CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggN2M1NzlkZDUzZGFlMDI1YzRhMDIwYjE2YmMwZDgzNjFj ZDJiNmZiMC4uYmY5OTIxOTliMDk2NDUyOWQ3MTllMDE2MzFlMmFmMjcwM2ZjZmYwMyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIz IEBACisyMDIwLTAxLTA2ICBBbnRvaW5lIFF1aW50ICA8Z3Jhb3V0c0BhcHBsZS5jb20+CisKKyAg ICAgICAgUkVHUkVTU0lPTjogWyBpT1MgXSBpbXBvcnRlZC93M2Mvd2ViLXBsYXRmb3JtLXRlc3Rz L2RvbS9ldmVudHMvRXZlbnQtZGlzcGF0Y2gtb24tZGlzYWJsZWQtZWxlbWVudHMuaHRtbCBpcyBm YWlsaW5nCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0y MDU0NTgKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzU4MDgxNzA0PgorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoZSBsYXN0IHN1Yi10ZXN0IGluIGlt cG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMvZG9tL2V2ZW50cy9FdmVudC1kaXNwYXRjaC1v bi1kaXNhYmxlZC1lbGVtZW50cy5odG1sIGNoZWNrcyBvbiB0aGUKKyAgICAgICAgYWJpbGl0eSB0 byBhY3RpdmF0ZSB2YXJpb3VzIGZvcm0gY29udHJvbHMgYWZ0ZXIgZGlzYWJsaW5nIGFuZCByZS1l bmFibGluZyB0aGVtLiBUd28gb2YgdGhvc2UgZm9ybSBjb250cm9scywgPHNlbGVjdD4KKyAgICAg ICAgYW5kIDx0ZXh0YXJlYT4sIHdvdWxkIHRyaWdnZXIgYW5pbWF0aW9ucyBvZiB0aGUgd2ViIHZp ZXcncyBVSVNjcm9sbFZpZXcgY2F1c2luZyB0b3VjaGVzIHRvIGJlIGNvbnN1bWVkIGJ5IFVJS2l0 IGFuZAorICAgICAgICBuZXZlciBzZWVuIGJ5IHRoZSBXS0NvbnRlbnRWaWV3LCBhbmQgYXMgc3Vj aCB0aGUgZXhwZWN0ZWQgImNsaWNrIiBldmVudHMgd291bGQgbm90IGJlIHJlY2VpdmVkLiBJdCB3 b3VsZCBoYXZlIGJlZW4KKyAgICAgICAgcG9zc2libGUgdG8gbW9kaWZ5IHRoZSB0ZXN0IHRvIHdh aXQgb24gYW55IHBvdGVudGlhbCBwYWdlIHNjcm9sbCB0byBjb21wbGV0ZSBiZWZvcmUgZGlzcGF0 Y2hpbmcgdGFwcywgYnV0IHNpbmNlIHRoaXMKKyAgICAgICAgaXMgYSBXUFQgdGVzdCwgd2UgY2Fu bm90IG1vZGlmeSBpdC4gSW5zdGVhZCwgd2UgbWFrZSBhIGNoYW5nZSB0byB0aGUgZnVuY3Rpb24g Y2FsbGVkIGJ5IHVpU2NyaXB0Q29udHJvbGxlci5zaW5nbGVUYXBBdFBvaW50KCkKKyAgICAgICAg dG8gaW50ZXJydXB0IGFueSBwZW5kaW5nIFVJU2Nyb2xsVmlldyBhbmltYXRpb24gd2hlbiBhIHRh cCBpcyBiZWluZyB0cmlnZ2VyZWQgb24gdGhlIHdlYiB2aWV3LiBDcmVkaXQgdG8gV2Vuc29uIEhz aWVoCisgICAgICAgIGZvciBzdWdnZXN0aW5nIHRoaXMgc2ltcGxlIGFuZCBlZmZlY3RpdmUgYXBw cm9hY2guCisKKyAgICAgICAgKiBXZWJLaXRUZXN0UnVubmVyL2lvcy9VSVNjcmlwdENvbnRyb2xs ZXJJT1MubW06CisgICAgICAgIChXVFI6OlVJU2NyaXB0Q29udHJvbGxlcklPUzo6c2luZ2xlVGFw QXRQb2ludFdpdGhNb2RpZmllcnMpOgorCiAyMDIwLTAxLTA1ICBTYW0gV2VpbmlnICA8d2Vpbmln QGFwcGxlLmNvbT4KIAogICAgICAgICBGdXJ0aGVyIHNpbXBsaWZ5IFN0cmluZ0J1aWxkZXIgdXNh Z2UgYnkgc3RhbmRhcmRpemluZyBoZXggZm9ybWF0aW5nIHRvIGEgc2luZ2xlIGhleCgpIGZ1bmN0 aW9uCmRpZmYgLS1naXQgYS9Ub29scy9XZWJLaXRUZXN0UnVubmVyL2lvcy9VSVNjcmlwdENvbnRy b2xsZXJJT1MubW0gYi9Ub29scy9XZWJLaXRUZXN0UnVubmVyL2lvcy9VSVNjcmlwdENvbnRyb2xs ZXJJT1MubW0KaW5kZXggZDdjZGNlNzRjYTllMTRhZTMxYjIyOTEzYTkwMGY3Y2IyNWRiYTRhYi4u OWJhMzMwMzA3MWZiMjg4ZGIyOTZmODUzMWFhYjZlNGYyMzcyOTIxNSAxMDA2NDQKLS0tIGEvVG9v bHMvV2ViS2l0VGVzdFJ1bm5lci9pb3MvVUlTY3JpcHRDb250cm9sbGVySU9TLm1tCisrKyBiL1Rv b2xzL1dlYktpdFRlc3RSdW5uZXIvaW9zL1VJU2NyaXB0Q29udHJvbGxlcklPUy5tbQpAQCAtMjg2 LDYgKzI4Niw5IEBAIHZvaWQgVUlTY3JpcHRDb250cm9sbGVySU9TOjpzaW5nbGVUYXBBdFBvaW50 V2l0aE1vZGlmaWVycyhsb25nIHgsIGxvbmcgeSwgSlNWYWx1CiAKIHZvaWQgVUlTY3JpcHRDb250 cm9sbGVySU9TOjpzaW5nbGVUYXBBdFBvaW50V2l0aE1vZGlmaWVycyhXZWJDb3JlOjpGbG9hdFBv aW50IGxvY2F0aW9uLCBWZWN0b3I8U3RyaW5nPiYmIG1vZGlmaWVyRmxhZ3MsIEJsb2NrUHRyPHZv aWQoKT4mJiBibG9jaykKIHsKKyAgICAvLyBBbmltYXRpb25zIG9uIHRoZSBzY3JvbGwgdmlldyBj b3VsZCBiZSBpbiBwcm9ncmVzcyB0byByZXZlYWwgYSBmb3JtIGNvbnRyb2wgd2hpY2ggbWF5IGlu dGVyZmVyZSB3aXRoIGhpdCB0ZXN0aW5nIChzZWUgd2tiLnVnLzIwNTQ1OCkuCisgICAgW3dlYlZp ZXcoKS5zY3JvbGxWaWV3IF9yZW1vdmVBbGxBbmltYXRpb25zOk5PXTsKKwogICAgIHdhaXRGb3JT aW5nbGVUYXBUb1Jlc2V0KCk7CiAKICAgICBmb3IgKGF1dG8mIG1vZGlmaWVyRmxhZyA6IG1vZGlm aWVyRmxhZ3MpCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cgYi9MYXlvdXRUZXN0 cy9DaGFuZ2VMb2cKaW5kZXggOGYzNmM4MzBlZDIyY2RjOTY1ZjliMThlYTgzMTFiYzM0ZDBmYjk3 YS4uNGY0MDVhNzhkODE3MWNkOTZkMzA0M2ZkYjk4M2Y4NDYxMjU5NzA0ZSAxMDA2NDQKLS0tIGEv TGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwpAQCAtMSwz ICsxLDE1IEBACisyMDIwLTAxLTA2ICBBbnRvaW5lIFF1aW50ICA8Z3Jhb3V0c0BhcHBsZS5jb20+ CisKKyAgICAgICAgUkVHUkVTU0lPTjogWyBpT1MgXSBpbXBvcnRlZC93M2Mvd2ViLXBsYXRmb3Jt LXRlc3RzL2RvbS9ldmVudHMvRXZlbnQtZGlzcGF0Y2gtb24tZGlzYWJsZWQtZWxlbWVudHMuaHRt bCBpcyBmYWlsaW5nCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0yMDU0NTgKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzU4MDgxNzA0PgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFJlbW92ZSB0aGUgcGxhdGZv cm0tc3BlY2lmaWMgZXhwZWN0YXRpb24gc2luY2UgdGhpcyB0ZXN0IG5vdyBwYXNzZXMgcmVsaWFi bHkgb24gaU9TIGFzIHdlbGwuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9pb3MvaW1wb3J0ZWQvdzNj L3dlYi1wbGF0Zm9ybS10ZXN0cy9kb20vZXZlbnRzL0V2ZW50LWRpc3BhdGNoLW9uLWRpc2FibGVk LWVsZW1lbnRzLWV4cGVjdGVkLnR4dDogUmVtb3ZlZC4KKwogMjAyMC0wMS0wNSAgWmFsYW4gQnVq dGFzICA8emFsYW5AYXBwbGUuY29tPgogCiAgICAgICAgIFtTTExdIEdlbmVyYXRlIHJ1bnMgZm9y IHByZXNlcnZlZCBuZXcgbGluZXMKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3BsYXRmb3JtL2lv cy9pbXBvcnRlZC93M2Mvd2ViLXBsYXRmb3JtLXRlc3RzL2RvbS9ldmVudHMvRXZlbnQtZGlzcGF0 Y2gtb24tZGlzYWJsZWQtZWxlbWVudHMtZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvcGxhdGZv cm0vaW9zL2ltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMvZG9tL2V2ZW50cy9FdmVudC1k aXNwYXRjaC1vbi1kaXNhYmxlZC1lbGVtZW50cy1leHBlY3RlZC50eHQKZGVsZXRlZCBmaWxlIG1v ZGUgMTAwNjQ0CmluZGV4IGM0ODJiYzAyMDFmYmUwMGVkYTFjMjk5OTM0NjE1YmQ1NDQwNWVhMDMu LjAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAKLS0tIGEvTGF5b3V0VGVz dHMvcGxhdGZvcm0vaW9zL2ltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMvZG9tL2V2ZW50 cy9FdmVudC1kaXNwYXRjaC1vbi1kaXNhYmxlZC1lbGVtZW50cy1leHBlY3RlZC50eHQKKysrIC9k ZXYvbnVsbApAQCAtMSwxMiArMCwwIEBACi0gCi0KLVBBU1MgQ2FuIGRpc3BhdGNoIHVudHJ1c3Rl ZCAnY2xpY2snIEV2ZW50cyBhdCBkaXNhYmxlZCBIVE1MIGVsZW1lbnRzLiAKLVBBU1MgQ2FuIGRp c3BhdGNoIHVudHJ1c3RlZCBFdmVudHMgYXQgZGlzYWJsZWQgSFRNTCBlbGVtZW50cy4gCi1QQVNT IENhbiBkaXNwYXRjaCBDdXN0b21FdmVudHMgYXQgZGlzYWJsZWQgSFRNTCBlbGVtZW50cy4gCi1Q QVNTIENhbGxpbmcgY2xpY2soKSBvbiBkaXNhYmxlZCBlbGVtZW50cyBtdXN0IG5vdCBkaXNwYXRj aCBldmVudHMuIAotUEFTUyBDU1MgVHJhbnNpdGlvbnMgdHJhbnNpdGlvbnJ1biwgdHJhbnNpdGlv bnN0YXJ0LCB0cmFuc2l0aW9uZW5kIGV2ZW50cyBmaXJlIG9uIGRpc2FibGVkIGZvcm0gZWxlbWVu dHMgCi1QQVNTIENTUyBUcmFuc2l0aW9ucyB0cmFuc2l0aW9uY2FuY2VsIGV2ZW50IGZpcmVzIG9u IGRpc2FibGVkIGZvcm0gZWxlbWVudHMgCi1QQVNTIENTUyBBbmltYXRpb24gYW5pbWF0aW9uc3Rh cnQsIGFuaW1hdGlvbml0ZXJhdGlvbiwgYW5pbWF0aW9uZW5kIGZpcmUgb24gZGlzYWJsZWQgZm9y bSBlbGVtZW50cyAKLVBBU1MgQ1NTIEFuaW1hdGlvbidzIGFuaW1hdGlvbmNhbmNlbCBldmVudCBm aXJlcyBvbiBkaXNhYmxlZCBmb3JtIGVsZW1lbnRzIAotRkFJTCBSZWFsIGNsaWNrcyBvbiBkaXNh YmxlZCBlbGVtZW50cyBtdXN0IG5vdCBkaXNwYXRjaCBldmVudHMuIGFzc2VydF90cnVlOiBIVE1M U2VsZWN0RWxlbWVudCBpcyBlbmFibGVkLCBzbyBvbmNsaWNrIG11c3QgZmlyZS4gZXhwZWN0ZWQg dHJ1ZSBnb3QgZmFsc2UKLQo=