205453 2019-12-19 08:12:35 -0800 pal/FileSizeFormatter.h declares fileSizeDescription in the top-level namespace 2019-12-19 10:04:12 -0800 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED DoNotImportToRadar P2 Normal --- 1 wenson_hsieh wenson_hsieh bdakin cdumez commit-queue esprehn+autocc ews-watchlist gyuyoung.kim megan_gardner thorton webkit-bug-importer oldest_to_newest 1600275 0 wenson_hsieh 2019-12-19 08:12:35 -0800 It should be under the PAL namespace instead. 1600280 1 386105 wenson_hsieh 2019-12-19 08:18:06 -0800 Created attachment 386105 Patch 1600343 2 386105 commit-queue 2019-12-19 10:04:10 -0800 Comment on attachment 386105 Patch Clearing flags on attachment: 386105 Committed r253762: <https://trac.webkit.org/changeset/253762> 1600345 3 commit-queue 2019-12-19 10:04:12 -0800 All reviewed patches have been landed. Closing bug. 386105 2019-12-19 08:18:06 -0800 2019-12-19 10:04:10 -0800 Patch bug-205453-20191219081805.patch text/plain 4654 wenson_hsieh U3VidmVyc2lvbiBSZXZpc2lvbjogMjUzNzIyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMzA4Y2E3ZjMxMjVhMGEz YWQ5NTk1OGFmMWE5Zjg5ZTM5NzhmZGYyNC4uMTdiNDEyZGQ0YWFjOTcxNjczMDI2ZWRiOTI4MzRj NWVjNDcyYjRiYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE5LTEyLTE5ICBXZW5z b24gSHNpZWggIDx3ZW5zb25faHNpZWhAYXBwbGUuY29tPgorCisgICAgICAgIHBhbC9GaWxlU2l6 ZUZvcm1hdHRlci5oIGRlY2xhcmVzIGZpbGVTaXplRGVzY3JpcHRpb24gaW4gdGhlIHRvcC1sZXZl bCBuYW1lc3BhY2UKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTIwNTQ1MworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIENoYW5nZSBmaWxlU2l6ZURlc2NyaXB0aW9uIHRvIFBBTDo6ZmlsZVNpemVEZXNjcmlwdGlv bi4gTm8gY2hhbmdlIGluIGJlaGF2aW9yLgorCisgICAgICAgICogaHRtbC9IVE1MQXR0YWNobWVu dEVsZW1lbnQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6SFRNTEF0dGFjaG1lbnRFbGVtZW50Ojpz ZXRGaWxlKToKKyAgICAgICAgKFdlYkNvcmU6OkhUTUxBdHRhY2htZW50RWxlbWVudDo6dXBkYXRl QXR0cmlidXRlcyk6CisKIDIwMTktMTItMTggIEVyaWMgQ2FybHNvbiAgPGVyaWMuY2FybHNvbkBh cHBsZS5jb20+CiAKICAgICAgICAgUmVtb3ZlIG1vcmUgdW51c2VkIE1lZGlhUGxheWVyIG1ldGhv ZHMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL1BBTC9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi Q29yZS9QQUwvQ2hhbmdlTG9nCmluZGV4IDExYTg4MDM2ZmUxNmZjMWRiYTcyNmU0N2FiOTlkODE0 MGYyODAwNzEuLmZiODMzMmM0NzI4MGQxMjFkNGMyMmEzM2Y4YjhhODViYjBlY2RjNjggMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL1BBTC9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUv UEFML0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE5LTEyLTE5ICBXZW5zb24gSHNpZWgg IDx3ZW5zb25faHNpZWhAYXBwbGUuY29tPgorCisgICAgICAgIHBhbC9GaWxlU2l6ZUZvcm1hdHRl ci5oIGRlY2xhcmVzIGZpbGVTaXplRGVzY3JpcHRpb24gaW4gdGhlIHRvcC1sZXZlbCBuYW1lc3Bh Y2UKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwNTQ1 MworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE1vdmUg ZmlsZVNpemVEZXNjcmlwdGlvbiB0byB0aGUgUEFMIG5hbWVzcGFjZS4KKworICAgICAgICAqIHBh bC9GaWxlU2l6ZUZvcm1hdHRlci5jcHA6CisgICAgICAgIChmaWxlU2l6ZURlc2NyaXB0aW9uKTog RGVsZXRlZC4KKyAgICAgICAgKiBwYWwvRmlsZVNpemVGb3JtYXR0ZXIuaDoKKyAgICAgICAgKiBw YWwvY29jb2EvRmlsZVNpemVGb3JtYXR0ZXJDb2NvYS5tbToKKyAgICAgICAgKGZpbGVTaXplRGVz Y3JpcHRpb24pOiBEZWxldGVkLgorCiAyMDE5LTEyLTE4ICBCZW4gTmhhbSAgPG5oYW1AYXBwbGUu Y29tPgogCiAgICAgICAgIEFkZCBuZXR3b3JrIGxvYWRpbmcgc2lnbnBvc3RzCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViQ29yZS9QQUwvcGFsL0ZpbGVTaXplRm9ybWF0dGVyLmNwcCBiL1NvdXJjZS9X ZWJDb3JlL1BBTC9wYWwvRmlsZVNpemVGb3JtYXR0ZXIuY3BwCmluZGV4IGExODYxNWQyN2MxODAy ZDRkMjc3MmEwYjUxMjNiYzk2MDU1NTVjOGIuLjM5NGI2YmM1MTM2M2E5MzgyZTA2NGJhODZjMjY1 YWNhMTkwMmU3MDIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL1BBTC9wYWwvRmlsZVNpemVG b3JtYXR0ZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL1BBTC9wYWwvRmlsZVNpemVGb3JtYXR0 ZXIuY3BwCkBAIC0yOCw2ICsyOCw4IEBACiAKICNpbmNsdWRlIDx3dGYvdGV4dC9TdHJpbmdDb25j YXRlbmF0ZU51bWJlcnMuaD4KIAorbmFtZXNwYWNlIFBBTCB7CisKICNpZiAhUExBVEZPUk0oQ09D T0EpCiAKIFN0cmluZyBmaWxlU2l6ZURlc2NyaXB0aW9uKHVpbnQ2NF90IHNpemUpCkBAIC00NCwz ICs0Niw1IEBAIFN0cmluZyBmaWxlU2l6ZURlc2NyaXB0aW9uKHVpbnQ2NF90IHNpemUpCiB9CiAK ICNlbmRpZgorCit9IC8vIG5hbWVzcGFjZSBQQUwKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3Jl L1BBTC9wYWwvRmlsZVNpemVGb3JtYXR0ZXIuaCBiL1NvdXJjZS9XZWJDb3JlL1BBTC9wYWwvRmls ZVNpemVGb3JtYXR0ZXIuaAppbmRleCAyYWVhMTI3OTc2YzMzOTNhOTA0OTIyNDYyNTFlY2QwMGY3 NWIxOGVkLi5iYmJiY2VmZmI0NzlhZjViZWFhNGVmZTZiYTIwYjUxZjFmNzBkMjFkIDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViQ29yZS9QQUwvcGFsL0ZpbGVTaXplRm9ybWF0dGVyLmgKKysrIGIvU291 cmNlL1dlYkNvcmUvUEFML3BhbC9GaWxlU2l6ZUZvcm1hdHRlci5oCkBAIC0yNyw0ICsyNyw4IEBA CiAKICNpbmNsdWRlIDx3dGYvdGV4dC9XVEZTdHJpbmcuaD4KIAorbmFtZXNwYWNlIFBBTCB7CisK IFBBTF9FWFBPUlQgU3RyaW5nIGZpbGVTaXplRGVzY3JpcHRpb24odWludDY0X3QpOworCit9IC8v IG5hbWVzcGFjZSBQQUwKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL1BBTC9wYWwvY29jb2Ev RmlsZVNpemVGb3JtYXR0ZXJDb2NvYS5tbSBiL1NvdXJjZS9XZWJDb3JlL1BBTC9wYWwvY29jb2Ev RmlsZVNpemVGb3JtYXR0ZXJDb2NvYS5tbQppbmRleCA0NzA5NWJhZjU0MGNlNjlkMGQ2MTk0ZWE5 YTVhN2EyZjkwYjZiYmFlLi44YzM4NjI3Y2ExOTE4NWRkZmY1NTYxMTU3NDYwYzgzZjc2NTNhYzQ0 IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9QQUwvcGFsL2NvY29hL0ZpbGVTaXplRm9ybWF0 dGVyQ29jb2EubW0KKysrIGIvU291cmNlL1dlYkNvcmUvUEFML3BhbC9jb2NvYS9GaWxlU2l6ZUZv cm1hdHRlckNvY29hLm1tCkBAIC0yOCw3ICsyOCwxMSBAQAogCiAjaW1wb3J0ICJOU0ZpbGVTaXpl Rm9ybWF0dGVyU1BJLmgiCiAKK25hbWVzcGFjZSBQQUwgeworCiBTdHJpbmcgZmlsZVNpemVEZXNj cmlwdGlvbih1aW50NjRfdCBzaXplKQogewogICAgIHJldHVybiBOU0xvY2FsaXplZEZpbGVTaXpl RGVzY3JpcHRpb24oc2l6ZSwgMCwgMCk7CiB9CisKK30gLy8gbmFtZXNwYWNlIFBBTApkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MQXR0YWNobWVudEVsZW1lbnQuY3BwIGIvU291 cmNlL1dlYkNvcmUvaHRtbC9IVE1MQXR0YWNobWVudEVsZW1lbnQuY3BwCmluZGV4IGZjZmE3ODRh MDVjZDUwNTViMThlMzZkYjU4OThiZTcwYWRmNzI2MTEuLmJkYWQ5YTAwNTQyOGYxNDdhODE1ZWNl MDNlN2MzOWEwN2I4OWEyZDUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTEF0 dGFjaG1lbnRFbGVtZW50LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxBdHRhY2ht ZW50RWxlbWVudC5jcHAKQEAgLTExNiw3ICsxMTYsNyBAQCB2b2lkIEhUTUxBdHRhY2htZW50RWxl bWVudDo6c2V0RmlsZShSZWZQdHI8RmlsZT4mJiBmaWxlLCBVcGRhdGVEaXNwbGF5QXR0cmlidXRl cwogICAgIGlmICh1cGRhdGVBdHRyaWJ1dGVzID09IFVwZGF0ZURpc3BsYXlBdHRyaWJ1dGVzOjpZ ZXMpIHsKICAgICAgICAgaWYgKG1fZmlsZSkgewogICAgICAgICAgICAgc2V0QXR0cmlidXRlV2l0 aG91dFN5bmNocm9uaXphdGlvbihIVE1MTmFtZXM6OnRpdGxlQXR0ciwgbV9maWxlLT5uYW1lKCkp OwotICAgICAgICAgICAgc2V0QXR0cmlidXRlV2l0aG91dFN5bmNocm9uaXphdGlvbihIVE1MTmFt ZXM6OnN1YnRpdGxlQXR0ciwgZmlsZVNpemVEZXNjcmlwdGlvbihtX2ZpbGUtPnNpemUoKSkpOwor ICAgICAgICAgICAgc2V0QXR0cmlidXRlV2l0aG91dFN5bmNocm9uaXphdGlvbihIVE1MTmFtZXM6 OnN1YnRpdGxlQXR0ciwgUEFMOjpmaWxlU2l6ZURlc2NyaXB0aW9uKG1fZmlsZS0+c2l6ZSgpKSk7 CiAgICAgICAgICAgICBzZXRBdHRyaWJ1dGVXaXRob3V0U3luY2hyb25pemF0aW9uKEhUTUxOYW1l czo6dHlwZUF0dHIsIG1fZmlsZS0+dHlwZSgpKTsKICAgICAgICAgfSBlbHNlIHsKICAgICAgICAg ICAgIHJlbW92ZUF0dHJpYnV0ZShIVE1MTmFtZXM6OnRpdGxlQXR0cik7CkBAIC0yMTgsNyArMjE4 LDcgQEAgdm9pZCBIVE1MQXR0YWNobWVudEVsZW1lbnQ6OnVwZGF0ZUF0dHJpYnV0ZXMoT3B0aW9u YWw8dWludDY0X3Q+JiYgbmV3RmlsZVNpemUsIGMKICAgICAgICAgcmVtb3ZlQXR0cmlidXRlKEhU TUxOYW1lczo6dHlwZUF0dHIpOwogCiAgICAgaWYgKG5ld0ZpbGVTaXplKQotICAgICAgICBzZXRB dHRyaWJ1dGVXaXRob3V0U3luY2hyb25pemF0aW9uKEhUTUxOYW1lczo6c3VidGl0bGVBdHRyLCBm aWxlU2l6ZURlc2NyaXB0aW9uKCpuZXdGaWxlU2l6ZSkpOworICAgICAgICBzZXRBdHRyaWJ1dGVX aXRob3V0U3luY2hyb25pemF0aW9uKEhUTUxOYW1lczo6c3VidGl0bGVBdHRyLCBQQUw6OmZpbGVT aXplRGVzY3JpcHRpb24oKm5ld0ZpbGVTaXplKSk7CiAgICAgZWxzZQogICAgICAgICByZW1vdmVB dHRyaWJ1dGUoSFRNTE5hbWVzOjpzdWJ0aXRsZUF0dHIpOwogCg==