205429 2019-12-18 17:54:37 -0800 macCatalyst: Cursor should update when the platform deems it necessary 2019-12-18 18:21:53 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 thorton thorton webkit-bug-importer wenson_hsieh oldest_to_newest 1600085 0 thorton 2019-12-18 17:54:37 -0800 macCatalyst: Cursor should update when the platform deems it necessary 1600086 1 386044 thorton 2019-12-18 17:55:13 -0800 Created attachment 386044 Patch 1600087 2 thorton 2019-12-18 17:55:15 -0800 <rdar://problem/57983076> 1600088 3 386044 wenson_hsieh 2019-12-18 17:57:13 -0800 Comment on attachment 386044 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=386044&action=review > Source/WebKit/Shared/ios/InteractionInformationAtPosition.h:87 > + float caretHeight; Nit - maybe give this an initial value? > Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm:2766 > + if (Frame* frame = hitTestResult.innerNodeFrame()) { > + if (FrameView *frameView = frame->view()) { Nit - auto*? 1600097 4 thorton 2019-12-18 18:21:53 -0800 https://trac.webkit.org/changeset/253731/webkit 386044 2019-12-18 17:55:13 -0800 2019-12-18 17:57:13 -0800 Patch bug-205429-20191218175512.patch text/plain 6014 thorton U3VidmVyc2lvbiBSZXZpc2lvbjogMjUzNjM5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMDc1MTBjNDU0NjUwOGM3 YWMzODExNWVlYzEwMWZlMDAxOWJiNmM4ZC4uZTkyNTgzMjFlZjI0ZjA4YmQ4YTVjZjg2MTY2N2U1 NzJiNTg3Zjg5MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDE5LTEyLTE4ICBUaW0g SG9ydG9uICA8dGltb3RoeV9ob3J0b25AYXBwbGUuY29tPgorCisgICAgICAgIG1hY0NhdGFseXN0 OiBDdXJzb3Igc2hvdWxkIHVwZGF0ZSB3aGVuIHRoZSBwbGF0Zm9ybSBkZWVtcyBpdCBuZWNlc3Nh cnkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwNTQy OQorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNTc5ODMwNzY+CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBwYWdlL0V2ZW50SGFuZGxlci5oOgorICAg ICAgICBFeHBvc2Ugc2VsZWN0Q3Vyc29yIGZvciBXZWJLaXQncyB1c2UuCisKIDIwMTktMTItMTcg IFRpbSBIb3J0b24gIDx0aW1vdGh5X2hvcnRvbkBhcHBsZS5jb20+CiAKICAgICAgICAgbWFjQ2F0 YWx5c3Q6IEN1cnNvciBzaG91bGQgdXBkYXRlIG9uIG1vdXNlIG1vdmVtZW50IGFuZCBzdHlsZSBj aGFuZ2UKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktp dC9DaGFuZ2VMb2cKaW5kZXggNjZlNmRkNWEwYjhmYTY0OGVjMzY3ZWNmNzE1OTM1NDc1MGRjNWRm Zi4uNmM4MzU0ZThjMGNiZmM2MjljMDhiOTg4NDA0NWJhZjBmYWQyZjUwMyAxMDA2NDQKLS0tIGEv U291cmNlL1dlYktpdC9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9DaGFuZ2VMb2cKQEAg LTEsMyArMSwyMSBAQAorMjAxOS0xMi0xOCAgVGltIEhvcnRvbiAgPHRpbW90aHlfaG9ydG9uQGFw cGxlLmNvbT4KKworICAgICAgICBtYWNDYXRhbHlzdDogQ3Vyc29yIHNob3VsZCB1cGRhdGUgd2hl biB0aGUgcGxhdGZvcm0gZGVlbXMgaXQgbmVjZXNzYXJ5CisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDU0MjkKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVt LzU3OTgzMDc2PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgICogU2hhcmVkL2lvcy9JbnRlcmFjdGlvbkluZm9ybWF0aW9uQXRQb3NpdGlvbi5oOgorICAg ICAgICAqIFNoYXJlZC9pb3MvSW50ZXJhY3Rpb25JbmZvcm1hdGlvbkF0UG9zaXRpb24ubW06Cisg ICAgICAgIChXZWJLaXQ6OkludGVyYWN0aW9uSW5mb3JtYXRpb25BdFBvc2l0aW9uOjplbmNvZGUg Y29uc3QpOgorICAgICAgICAoV2ViS2l0OjpJbnRlcmFjdGlvbkluZm9ybWF0aW9uQXRQb3NpdGlv bjo6ZGVjb2RlKToKKyAgICAgICAgKiBXZWJQcm9jZXNzL1dlYlBhZ2UvaW9zL1dlYlBhZ2VJT1Mu bW06CisgICAgICAgIChXZWJLaXQ6OldlYlBhZ2U6OnBvc2l0aW9uSW5mb3JtYXRpb24pOgorICAg ICAgICBFeHBvc2UgdGhlIGN1cnJlbnQgY3Vyc29yIGFuZCBjYXJldCBzaXplIG9uIHBvc2l0aW9u IGluZm9ybWF0aW9uIHNvCisgICAgICAgIHRoYXQgbWFjQ2F0YWx5c3QgVUlLaXQgY2FuIHJldHJp ZXZlIGl0IG91dC1vZi1iYW5kIChpbiBhZGRpdGlvbiB0bworICAgICAgICBzZXR0aW5nIGl0IHdo ZW4gd2UgZG8gYSBoaXQtdGVzdCwgbGlrZSBpbiByMjUzNjM2LgorCiAyMDE5LTEyLTE3ICB5b3Vl bm4gZmFibGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4KIAogICAgICAgICBXZWJLaXRUZXN0UnVubmVy IHNob3VsZCByZXBvcnQgR1BVIHByb2Nlc3MgY3Jhc2hlcwpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YkNvcmUvcGFnZS9FdmVudEhhbmRsZXIuaCBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRXZlbnRIYW5k bGVyLmgKaW5kZXggZGNiZjIyMjg4MTQ3MTNmMTYzM2U0NmI3OTAwYmZlNTBlMjcyNTc1ZC4uYzZk YzViZmIwZGUxNzBiNmI0OWM2MTQ4OTk3YzVlODEwZDRhMjZiNCAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkNvcmUvcGFnZS9FdmVudEhhbmRsZXIuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL0V2 ZW50SGFuZGxlci5oCkBAIC0zNDEsNiArMzQxLDggQEAgcHVibGljOgogICAgIFdFQkNPUkVfRVhQ T1JUIHZvaWQgY2FuY2VsU2VsZWN0aW9uQXV0b3Njcm9sbCgpOwogI2VuZGlmCiAKKyAgICBXRUJD T1JFX0VYUE9SVCBPcHRpb25hbDxDdXJzb3I+IHNlbGVjdEN1cnNvcihjb25zdCBIaXRUZXN0UmVz dWx0JiwgYm9vbCBzaGlmdEtleSk7CisKIHByaXZhdGU6CiAjaWYgRU5BQkxFKERSQUdfU1VQUE9S VCkKICAgICBzdGF0aWMgRHJhZ1N0YXRlJiBkcmFnU3RhdGUoKTsKQEAgLTM3MSw3ICszNzMsNiBA QCBwcml2YXRlOgogCiAgICAgYm9vbCBpbnRlcm5hbEtleUV2ZW50KGNvbnN0IFBsYXRmb3JtS2V5 Ym9hcmRFdmVudCYpOwogCi0gICAgT3B0aW9uYWw8Q3Vyc29yPiBzZWxlY3RDdXJzb3IoY29uc3Qg SGl0VGVzdFJlc3VsdCYsIGJvb2wgc2hpZnRLZXkpOwogICAgIHZvaWQgdXBkYXRlQ3Vyc29yKEZy YW1lVmlldyYsIGNvbnN0IEhpdFRlc3RSZXN1bHQmLCBib29sIHNoaWZ0S2V5KTsKIAogICAgIHZv aWQgaG92ZXJUaW1lckZpcmVkKCk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1NoYXJlZC9p b3MvSW50ZXJhY3Rpb25JbmZvcm1hdGlvbkF0UG9zaXRpb24uaCBiL1NvdXJjZS9XZWJLaXQvU2hh cmVkL2lvcy9JbnRlcmFjdGlvbkluZm9ybWF0aW9uQXRQb3NpdGlvbi5oCmluZGV4IDVkZTU4ZDk2 YzRiNmZjOWIzMmY0MWE5ZjFhNGRlMmU2NTYwODdmOTYuLjQ4YmQ1ZDk1ZDBjYjEwZDFhODcwNDRk N2EyODE0NDk1MDc1MzRhNzUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvU2hhcmVkL2lvcy9J bnRlcmFjdGlvbkluZm9ybWF0aW9uQXRQb3NpdGlvbi5oCisrKyBiL1NvdXJjZS9XZWJLaXQvU2hh cmVkL2lvcy9JbnRlcmFjdGlvbkluZm9ybWF0aW9uQXRQb3NpdGlvbi5oCkBAIC0zMCw2ICszMCw3 IEBACiAjaW5jbHVkZSAiQXJndW1lbnRDb2RlcnMuaCIKICNpbmNsdWRlICJJbnRlcmFjdGlvbklu Zm9ybWF0aW9uUmVxdWVzdC5oIgogI2luY2x1ZGUgIlNoYXJlYWJsZUJpdG1hcC5oIgorI2luY2x1 ZGUgPFdlYkNvcmUvQ3Vyc29yLmg+CiAjaW5jbHVkZSA8V2ViQ29yZS9FbGVtZW50Q29udGV4dC5o PgogI2luY2x1ZGUgPFdlYkNvcmUvSW50UG9pbnQuaD4KICNpbmNsdWRlIDxXZWJDb3JlL1Njcm9s bFR5cGVzLmg+CkBAIC04Myw2ICs4NCwxMCBAQCBzdHJ1Y3QgSW50ZXJhY3Rpb25JbmZvcm1hdGlv bkF0UG9zaXRpb24gewogICAgIFN0cmluZyB0ZXh0QmVmb3JlOwogICAgIFN0cmluZyB0ZXh0QWZ0 ZXI7CiAKKyAgICBmbG9hdCBjYXJldEhlaWdodDsKKworICAgIE9wdGlvbmFsPFdlYkNvcmU6OkN1 cnNvcj4gY3Vyc29yOworCiAgICAgV2ViQ29yZTo6VGV4dEluZGljYXRvckRhdGEgbGlua0luZGlj YXRvcjsKICNpZiBFTkFCTEUoREFUQV9ERVRFQ1RJT04pCiAgICAgU3RyaW5nIGRhdGFEZXRlY3Rv cklkZW50aWZpZXI7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1NoYXJlZC9pb3MvSW50ZXJh Y3Rpb25JbmZvcm1hdGlvbkF0UG9zaXRpb24ubW0gYi9Tb3VyY2UvV2ViS2l0L1NoYXJlZC9pb3Mv SW50ZXJhY3Rpb25JbmZvcm1hdGlvbkF0UG9zaXRpb24ubW0KaW5kZXggYmM3MmQxZjBmOTI3NWJi MzE5NjZkZDI3N2U4OTYzMTBlNTFjYzk3Ny4uYjI4MTQyZGJlNzM2NjRiYjA2ZjRjMzU0MWY5ZTlk MTBiZGZjYTkzNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9TaGFyZWQvaW9zL0ludGVyYWN0 aW9uSW5mb3JtYXRpb25BdFBvc2l0aW9uLm1tCisrKyBiL1NvdXJjZS9XZWJLaXQvU2hhcmVkL2lv cy9JbnRlcmFjdGlvbkluZm9ybWF0aW9uQXRQb3NpdGlvbi5tbQpAQCAtNjgsNiArNjgsOCBAQCB2 b2lkIEludGVyYWN0aW9uSW5mb3JtYXRpb25BdFBvc2l0aW9uOjplbmNvZGUoSVBDOjpFbmNvZGVy JiBlbmNvZGVyKSBjb25zdAogI2VuZGlmCiAgICAgZW5jb2RlciA8PCB0ZXh0QmVmb3JlOwogICAg IGVuY29kZXIgPDwgdGV4dEFmdGVyOworICAgIGVuY29kZXIgPDwgY2FyZXRIZWlnaHQ7CisgICAg ZW5jb2RlciA8PCBjdXJzb3I7CiAgICAgZW5jb2RlciA8PCBsaW5rSW5kaWNhdG9yOwogCiAgICAg U2hhcmVhYmxlQml0bWFwOjpIYW5kbGUgaGFuZGxlOwpAQCAtMTU4LDYgKzE2MCwxMiBAQCBib29s IEludGVyYWN0aW9uSW5mb3JtYXRpb25BdFBvc2l0aW9uOjpkZWNvZGUoSVBDOjpEZWNvZGVyJiBk ZWNvZGVyLCBJbnRlcmFjdGlvbgogICAgIAogICAgIGlmICghZGVjb2Rlci5kZWNvZGUocmVzdWx0 LnRleHRBZnRlcikpCiAgICAgICAgIHJldHVybiBmYWxzZTsKKworICAgIGlmICghZGVjb2Rlci5k ZWNvZGUocmVzdWx0LmNhcmV0SGVpZ2h0KSkKKyAgICAgICAgcmV0dXJuIGZhbHNlOworCisgICAg aWYgKCFkZWNvZGVyLmRlY29kZShyZXN1bHQuY3Vyc29yKSkKKyAgICAgICAgcmV0dXJuIGZhbHNl OwogICAgIAogICAgIE9wdGlvbmFsPFdlYkNvcmU6OlRleHRJbmRpY2F0b3JEYXRhPiBsaW5rSW5k aWNhdG9yOwogICAgIGRlY29kZXIgPj4gbGlua0luZGljYXRvcjsKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJLaXQvV2ViUHJvY2Vzcy9XZWJQYWdlL2lvcy9XZWJQYWdlSU9TLm1tIGIvU291cmNlL1dl YktpdC9XZWJQcm9jZXNzL1dlYlBhZ2UvaW9zL1dlYlBhZ2VJT1MubW0KaW5kZXggNGJkMDBhNWZk Mzg1MWQ3MzUyMTQzMDYxYzUwZTY1YzRjNmI0MWNmNS4uYjE4NDc2ZWUwOGZjODQ2M2Q4MDVkZDFk MmVhZmFmMTIzYzlmMGM3ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL1dl YlBhZ2UvaW9zL1dlYlBhZ2VJT1MubW0KKysrIGIvU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL1dl YlBhZ2UvaW9zL1dlYlBhZ2VJT1MubW0KQEAgLTI3NTksNiArMjc1OSwxNiBAQCBJbnRlcmFjdGlv bkluZm9ybWF0aW9uQXRQb3NpdGlvbiBXZWJQYWdlOjpwb3NpdGlvbkluZm9ybWF0aW9uKGNvbnN0 IEludGVyYWN0aW9uSQogICAgIGluZm8uYWRqdXN0ZWRQb2ludEZvck5vZGVSZXNwb25kaW5nVG9D bGlja0V2ZW50cyA9IGFkanVzdGVkUG9pbnQ7CiAgICAgaW5mby5ub2RlQXRQb3NpdGlvbkhhc0Rv dWJsZUNsaWNrSGFuZGxlciA9IG1fcGFnZS0+bWFpbkZyYW1lKCkubm9kZVJlc3BvbmRpbmdUb0Rv dWJsZUNsaWNrRXZlbnQocmVxdWVzdC5wb2ludCwgYWRqdXN0ZWRQb2ludCk7CiAKKyAgICBhdXRv JiBldmVudEhhbmRsZXIgPSBtX3BhZ2UtPm1haW5GcmFtZSgpLmV2ZW50SGFuZGxlcigpOworICAg IEhpdFRlc3RSZXN1bHQgaGl0VGVzdFJlc3VsdCA9IGV2ZW50SGFuZGxlci5oaXRUZXN0UmVzdWx0 QXRQb2ludChyZXF1ZXN0LnBvaW50LCBIaXRUZXN0UmVxdWVzdDo6UmVhZE9ubHkgfCBIaXRUZXN0 UmVxdWVzdDo6QWxsb3dGcmFtZVNjcm9sbGJhcnMpOworICAgIGluZm8uY3Vyc29yID0gZXZlbnRI YW5kbGVyLnNlbGVjdEN1cnNvcihoaXRUZXN0UmVzdWx0LCBmYWxzZSk7CisgICAgaWYgKEZyYW1l KiBmcmFtZSA9IGhpdFRlc3RSZXN1bHQuaW5uZXJOb2RlRnJhbWUoKSkgeworICAgICAgICBpZiAo RnJhbWVWaWV3ICpmcmFtZVZpZXcgPSBmcmFtZS0+dmlldygpKSB7CisgICAgICAgICAgICBWaXNp YmxlUG9zaXRpb24gcG9zaXRpb24gPSBmcmFtZS0+dmlzaWJsZVBvc2l0aW9uRm9yUG9pbnQocmVx dWVzdC5wb2ludCk7CisgICAgICAgICAgICBpbmZvLmNhcmV0SGVpZ2h0ID0gZnJhbWVWaWV3LT5j b250ZW50c1RvUm9vdFZpZXcocG9zaXRpb24uYWJzb2x1dGVDYXJldEJvdW5kcygpKS5oZWlnaHQo KTsKKyAgICAgICAgfQorICAgIH0KKwogI2lmIEVOQUJMRShEQVRBX0lOVEVSQUNUSU9OKQogICAg IGluZm8uaGFzU2VsZWN0aW9uQXRQb3NpdGlvbiA9IG1fcGFnZS0+aGFzU2VsZWN0aW9uQXRQb3Np dGlvbihhZGp1c3RlZFBvaW50KTsKICNlbmRpZgo=