205419 2019-12-18 15:07:20 -0800 IPC::Connection::sendMessage() should use CRASH_WITH_INFO() 2020-07-23 17:12:47 -0700 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 214713 1 ddkilzer ddkilzer cdumez commit-queue ggaren mark.lam webkit-bug-importer oldest_to_newest 1600021 0 ddkilzer 2019-12-18 15:07:20 -0800 IPC::Connection::sendMessage() should use CRASH_WITH_INFO() to encode kern_return_t error code and hash of message name. <rdar://problem/58058661> 1600025 1 386014 ddkilzer 2019-12-18 15:11:31 -0800 Created attachment 386014 Patch v1 1600029 2 386018 ddkilzer 2019-12-18 15:25:12 -0800 Created attachment 386018 Patch v2 1600042 3 386018 mark.lam 2019-12-18 15:49:47 -0800 Comment on attachment 386018 Patch v2 View in context: https://bugs.webkit.org/attachment.cgi?id=386018&action=review > Source/WebKit/Platform/IPC/cocoa/ConnectionCocoa.mm:277 > + WebKit::setCrashReportApplicationSpecificInformation((__bridge CFStringRef)[NSString stringWithFormat:@"Unhandled error code %x, message '%s'", kr, messageName.data()]); nit: Might as well log messageName.hash() as well. 1604148 4 387113 ddkilzer 2020-01-08 10:35:50 -0800 Created attachment 387113 Patch for landing 1604149 5 386018 ddkilzer 2020-01-08 10:36:48 -0800 Comment on attachment 386018 Patch v2 View in context: https://bugs.webkit.org/attachment.cgi?id=386018&action=review >> Source/WebKit/Platform/IPC/cocoa/ConnectionCocoa.mm:277 >> + WebKit::setCrashReportApplicationSpecificInformation((__bridge CFStringRef)[NSString stringWithFormat:@"Unhandled error code %x, message '%s'", kr, messageName.data()]); > > nit: Might as well log messageName.hash() as well. Done. Thanks! 1604175 6 387113 commit-queue 2020-01-08 11:26:11 -0800 Comment on attachment 387113 Patch for landing Clearing flags on attachment: 387113 Committed r254208: <https://trac.webkit.org/changeset/254208> 1604176 7 commit-queue 2020-01-08 11:26:13 -0800 All reviewed patches have been landed. Closing bug. 386014 2019-12-18 15:11:31 -0800 2019-12-18 15:25:11 -0800 Patch v1 bug-205419-20191218151131.patch text/plain 2069 ddkilzer U3VidmVyc2lvbiBSZXZpc2lvbjogMjUzNzIyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGJhOGI3Njc2NzQ5MTkzMjU0 MmUyYTcwMGQyYWY5ZDZiNjkwMGU0YWUuLjk2ODNjOTc5NTkxZTI4NDQ5NjMxOGUyMmQ1ZDc2Yzk0 ODk1ZDlhZGUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTktMTItMTggIERhdmlkIEtp bHplciAgPGRka2lsemVyQGFwcGxlLmNvbT4KKworICAgICAgICBJUEM6OkNvbm5lY3Rpb246OnNl bmRNZXNzYWdlKCkgc2hvdWxkIHVzZSBDUkFTSF9XSVRIX0lORk8oKQorICAgICAgICA8aHR0cHM6 Ly93ZWJraXQub3JnL2IvMjA1NDE5PgorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNTgwNTg2NjE+ CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBQbGF0 Zm9ybS9JUEMvY29jb2EvQ29ubmVjdGlvbkNvY29hLm1tOgorICAgICAgICAoSVBDOjpDb25uZWN0 aW9uOjpzZW5kTWVzc2FnZSk6CisgICAgICAgIC0gU3dpdGNoIGZyb20gQ1JBU0goKSB0byBDUkFT SF9XSVRIX0lORk8oKS4KKwogMjAxOS0xMi0xOCAgRGF2aWQgS2lsemVyICA8ZGRraWx6ZXJAYXBw bGUuY29tPgogCiAgICAgICAgIFtDb2NvYV0gR1BVIHByb2Nlc3Mgc2hvdWxkIGxvZyBJUEMgbWVz c2FnZSBuYW1lIGJlZm9yZSBjcmFzaGluZyBmcm9tIGludmFsaWQgV2ViQ29udGVudCBtZXNzYWdl CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1BsYXRmb3JtL0lQQy9jb2NvYS9Db25uZWN0aW9u Q29jb2EubW0gYi9Tb3VyY2UvV2ViS2l0L1BsYXRmb3JtL0lQQy9jb2NvYS9Db25uZWN0aW9uQ29j b2EubW0KaW5kZXggMjM5MTI5MDU3MDRlMjk1MzhmMjFlYTZkMWRlMjc4YWNkMGRjM2UwNi4uOTg2 MmUzM2VmMTNiM2NkNTcyZTU5NzU1YTNmOGViYWE1MGNkZjViYiAxMDA2NDQKLS0tIGEvU291cmNl L1dlYktpdC9QbGF0Zm9ybS9JUEMvY29jb2EvQ29ubmVjdGlvbkNvY29hLm1tCisrKyBiL1NvdXJj ZS9XZWJLaXQvUGxhdGZvcm0vSVBDL2NvY29hL0Nvbm5lY3Rpb25Db2NvYS5tbQpAQCAtMzksNiAr MzksNyBAQAogI2ltcG9ydCA8d3RmL01hY2hTZW5kUmlnaHQuaD4KICNpbXBvcnQgPHd0Zi9SdW5M b29wLmg+CiAjaW1wb3J0IDx3dGYvc3BpL2Rhcndpbi9YUENTUEkuaD4KKyNpbXBvcnQgPHd0Zi90 ZXh0L1N0cmluZ0NvbmNhdGVuYXRlLmg+CiAKICNpZiBQTEFURk9STShJT1NfRkFNSUxZKQogI2lt cG9ydCAiUHJvY2Vzc0Fzc2VydGlvbi5oIgpAQCAtMjcyLDggKzI3Myw5IEBAIGJvb2wgQ29ubmVj dGlvbjo6c2VuZE1lc3NhZ2Uoc3RkOjp1bmlxdWVfcHRyPE1hY2hNZXNzYWdlPiBtZXNzYWdlKQog ICAgICAgICByZXR1cm4gZmFsc2U7CiAKICAgICBkZWZhdWx0OgotICAgICAgICBXZWJLaXQ6OnNl dENyYXNoUmVwb3J0QXBwbGljYXRpb25TcGVjaWZpY0luZm9ybWF0aW9uKChfX2JyaWRnZSBDRlN0 cmluZ1JlZilbTlNTdHJpbmcgc3RyaW5nV2l0aEZvcm1hdDpAIlVuaGFuZGxlZCBlcnJvciBjb2Rl ICV4LCBtZXNzYWdlICclczo6JXMnIiwga3IsIG1lc3NhZ2UtPm1lc3NhZ2VSZWNlaXZlck5hbWUo KS5kYXRhKCksIG1lc3NhZ2UtPm1lc3NhZ2VOYW1lKCkuZGF0YSgpXSk7Ci0gICAgICAgIENSQVNI KCk7CisgICAgICAgIENTdHJpbmcgbWVzc2FnZSA9IG1ha2VTdHJpbmcobWVzc2FnZS0+bWVzc2Fn ZVJlY2VpdmVyTmFtZSgpLmRhdGEoKSwgIjo6IiwgbWVzc2FnZS0+bWVzc2FnZU5hbWUoKS5kYXRh KCkpLnV0ZjgoKTsKKyAgICAgICAgV2ViS2l0OjpzZXRDcmFzaFJlcG9ydEFwcGxpY2F0aW9uU3Bl Y2lmaWNJbmZvcm1hdGlvbigoX19icmlkZ2UgQ0ZTdHJpbmdSZWYpW05TU3RyaW5nIHN0cmluZ1dp dGhGb3JtYXQ6QCJVbmhhbmRsZWQgZXJyb3IgY29kZSAleCwgbWVzc2FnZSAnJXMnIiwga3IsIG1l c3NhZ2UuZGF0YSgpXSk7CisgICAgICAgIENSQVNIX1dJVEhfSU5GTyhrciwgbWVzc2FnZS5oYXNo KCkpOwogICAgIH0KIH0KIAo= 386018 2019-12-18 15:25:12 -0800 2020-01-08 10:35:48 -0800 Patch v2 bug-205419-20191218152512.patch text/plain 2081 ddkilzer U3VidmVyc2lvbiBSZXZpc2lvbjogMjUzNzIyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGJhOGI3Njc2NzQ5MTkzMjU0 MmUyYTcwMGQyYWY5ZDZiNjkwMGU0YWUuLjk2ODNjOTc5NTkxZTI4NDQ5NjMxOGUyMmQ1ZDc2Yzk0 ODk1ZDlhZGUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTktMTItMTggIERhdmlkIEtp bHplciAgPGRka2lsemVyQGFwcGxlLmNvbT4KKworICAgICAgICBJUEM6OkNvbm5lY3Rpb246OnNl bmRNZXNzYWdlKCkgc2hvdWxkIHVzZSBDUkFTSF9XSVRIX0lORk8oKQorICAgICAgICA8aHR0cHM6 Ly93ZWJraXQub3JnL2IvMjA1NDE5PgorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNTgwNTg2NjE+ CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBQbGF0 Zm9ybS9JUEMvY29jb2EvQ29ubmVjdGlvbkNvY29hLm1tOgorICAgICAgICAoSVBDOjpDb25uZWN0 aW9uOjpzZW5kTWVzc2FnZSk6CisgICAgICAgIC0gU3dpdGNoIGZyb20gQ1JBU0goKSB0byBDUkFT SF9XSVRIX0lORk8oKS4KKwogMjAxOS0xMi0xOCAgRGF2aWQgS2lsemVyICA8ZGRraWx6ZXJAYXBw bGUuY29tPgogCiAgICAgICAgIFtDb2NvYV0gR1BVIHByb2Nlc3Mgc2hvdWxkIGxvZyBJUEMgbWVz c2FnZSBuYW1lIGJlZm9yZSBjcmFzaGluZyBmcm9tIGludmFsaWQgV2ViQ29udGVudCBtZXNzYWdl CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1BsYXRmb3JtL0lQQy9jb2NvYS9Db25uZWN0aW9u Q29jb2EubW0gYi9Tb3VyY2UvV2ViS2l0L1BsYXRmb3JtL0lQQy9jb2NvYS9Db25uZWN0aW9uQ29j b2EubW0KaW5kZXggMjM5MTI5MDU3MDRlMjk1MzhmMjFlYTZkMWRlMjc4YWNkMGRjM2UwNi4uMjY5 YTA5OTFiM2QxNGExYjY4M2MwYTZkMDBlMmVhZDE4MTY0YWIxYiAxMDA2NDQKLS0tIGEvU291cmNl L1dlYktpdC9QbGF0Zm9ybS9JUEMvY29jb2EvQ29ubmVjdGlvbkNvY29hLm1tCisrKyBiL1NvdXJj ZS9XZWJLaXQvUGxhdGZvcm0vSVBDL2NvY29hL0Nvbm5lY3Rpb25Db2NvYS5tbQpAQCAtMzksNiAr MzksNyBAQAogI2ltcG9ydCA8d3RmL01hY2hTZW5kUmlnaHQuaD4KICNpbXBvcnQgPHd0Zi9SdW5M b29wLmg+CiAjaW1wb3J0IDx3dGYvc3BpL2Rhcndpbi9YUENTUEkuaD4KKyNpbXBvcnQgPHd0Zi90 ZXh0L1N0cmluZ0NvbmNhdGVuYXRlLmg+CiAKICNpZiBQTEFURk9STShJT1NfRkFNSUxZKQogI2lt cG9ydCAiUHJvY2Vzc0Fzc2VydGlvbi5oIgpAQCAtMjcyLDggKzI3Myw5IEBAIGJvb2wgQ29ubmVj dGlvbjo6c2VuZE1lc3NhZ2Uoc3RkOjp1bmlxdWVfcHRyPE1hY2hNZXNzYWdlPiBtZXNzYWdlKQog ICAgICAgICByZXR1cm4gZmFsc2U7CiAKICAgICBkZWZhdWx0OgotICAgICAgICBXZWJLaXQ6OnNl dENyYXNoUmVwb3J0QXBwbGljYXRpb25TcGVjaWZpY0luZm9ybWF0aW9uKChfX2JyaWRnZSBDRlN0 cmluZ1JlZilbTlNTdHJpbmcgc3RyaW5nV2l0aEZvcm1hdDpAIlVuaGFuZGxlZCBlcnJvciBjb2Rl ICV4LCBtZXNzYWdlICclczo6JXMnIiwga3IsIG1lc3NhZ2UtPm1lc3NhZ2VSZWNlaXZlck5hbWUo KS5kYXRhKCksIG1lc3NhZ2UtPm1lc3NhZ2VOYW1lKCkuZGF0YSgpXSk7Ci0gICAgICAgIENSQVNI KCk7CisgICAgICAgIENTdHJpbmcgbWVzc2FnZU5hbWUgPSBtYWtlU3RyaW5nKG1lc3NhZ2UtPm1l c3NhZ2VSZWNlaXZlck5hbWUoKS5kYXRhKCksICI6OiIsIG1lc3NhZ2UtPm1lc3NhZ2VOYW1lKCku ZGF0YSgpKS51dGY4KCk7CisgICAgICAgIFdlYktpdDo6c2V0Q3Jhc2hSZXBvcnRBcHBsaWNhdGlv blNwZWNpZmljSW5mb3JtYXRpb24oKF9fYnJpZGdlIENGU3RyaW5nUmVmKVtOU1N0cmluZyBzdHJp bmdXaXRoRm9ybWF0OkAiVW5oYW5kbGVkIGVycm9yIGNvZGUgJXgsIG1lc3NhZ2UgJyVzJyIsIGty LCBtZXNzYWdlTmFtZS5kYXRhKCldKTsKKyAgICAgICAgQ1JBU0hfV0lUSF9JTkZPKGtyLCBtZXNz YWdlTmFtZS5oYXNoKCkpOwogICAgIH0KIH0KIAo= 387113 2020-01-08 10:35:50 -0800 2020-01-08 11:26:11 -0800 Patch for landing bug-205419-20200108103549.patch text/plain 2041 ddkilzer U3VidmVyc2lvbiBSZXZpc2lvbjogMjU0MjA0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDg5MzAyM2RhMWQ4YWM4MjU0 ODM4MTMyZGU2OGY5YzI0ZjA3YmVlMTQuLjczYWFiNTM5ZTMzOGRkYjk5NGIyNWNiNjIyN2Q5YTE3 YWNiZmVlN2EgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMjAtMDEtMDggIERhdmlkIEtp bHplciAgPGRka2lsemVyQGFwcGxlLmNvbT4KKworICAgICAgICBJUEM6OkNvbm5lY3Rpb246OnNl bmRNZXNzYWdlKCkgc2hvdWxkIHVzZSBDUkFTSF9XSVRIX0lORk8oKQorICAgICAgICA8aHR0cHM6 Ly93ZWJraXQub3JnL2IvMjA1NDE5PgorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNTgwNTg2NjE+ CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTWFyayBMYW0uCisKKyAgICAgICAgKiBQbGF0Zm9ybS9J UEMvY29jb2EvQ29ubmVjdGlvbkNvY29hLm1tOgorICAgICAgICAoSVBDOjpDb25uZWN0aW9uOjpz ZW5kTWVzc2FnZSk6CisgICAgICAgIC0gU3dpdGNoIGZyb20gQ1JBU0goKSB0byBDUkFTSF9XSVRI X0lORk8oKS4KKwogMjAyMC0wMS0wOCAgVHJ1aXR0IFNhdmVsbCAgPHRzYXZlbGxAYXBwbGUuY29t PgogCiAgICAgICAgIFVucmV2aWV3ZWQsIHJvbGxpbmcgb3V0IHIyNTQxNzQuCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViS2l0L1BsYXRmb3JtL0lQQy9jb2NvYS9Db25uZWN0aW9uQ29jb2EubW0gYi9T b3VyY2UvV2ViS2l0L1BsYXRmb3JtL0lQQy9jb2NvYS9Db25uZWN0aW9uQ29jb2EubW0KaW5kZXgg ZjcwMjFkNzI4NDE4YTg4MWE3OTU4MDViMjZiMjdmMDVjZDlhMjdhYS4uYTQwNzQyYjQ5NzA2ODU4 YWExMzI3OGNhZGQxMDIzNmNhNjg2YjUxMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9QbGF0 Zm9ybS9JUEMvY29jb2EvQ29ubmVjdGlvbkNvY29hLm1tCisrKyBiL1NvdXJjZS9XZWJLaXQvUGxh dGZvcm0vSVBDL2NvY29hL0Nvbm5lY3Rpb25Db2NvYS5tbQpAQCAtMzksNiArMzksNyBAQAogI2lt cG9ydCA8d3RmL01hY2hTZW5kUmlnaHQuaD4KICNpbXBvcnQgPHd0Zi9SdW5Mb29wLmg+CiAjaW1w b3J0IDx3dGYvc3BpL2Rhcndpbi9YUENTUEkuaD4KKyNpbXBvcnQgPHd0Zi90ZXh0L1N0cmluZ0Nv bmNhdGVuYXRlLmg+CiAKICNpZiBQTEFURk9STShJT1NfRkFNSUxZKQogI2ltcG9ydCAiUHJvY2Vz c0Fzc2VydGlvbi5oIgpAQCAtMjcyLDggKzI3Myw5IEBAIGJvb2wgQ29ubmVjdGlvbjo6c2VuZE1l c3NhZ2Uoc3RkOjp1bmlxdWVfcHRyPE1hY2hNZXNzYWdlPiBtZXNzYWdlKQogICAgICAgICByZXR1 cm4gZmFsc2U7CiAKICAgICBkZWZhdWx0OgotICAgICAgICBXZWJLaXQ6OnNldENyYXNoUmVwb3J0 QXBwbGljYXRpb25TcGVjaWZpY0luZm9ybWF0aW9uKChfX2JyaWRnZSBDRlN0cmluZ1JlZilbTlNT dHJpbmcgc3RyaW5nV2l0aEZvcm1hdDpAIlVuaGFuZGxlZCBlcnJvciBjb2RlICV4LCBtZXNzYWdl ICclczo6JXMnIiwga3IsIG1lc3NhZ2UtPm1lc3NhZ2VSZWNlaXZlck5hbWUoKS5kYXRhKCksIG1l c3NhZ2UtPm1lc3NhZ2VOYW1lKCkuZGF0YSgpXSk7Ci0gICAgICAgIENSQVNIKCk7CisgICAgICAg IENTdHJpbmcgbWVzc2FnZU5hbWUgPSBtYWtlU3RyaW5nKG1lc3NhZ2UtPm1lc3NhZ2VSZWNlaXZl ck5hbWUoKS5kYXRhKCksICI6OiIsIG1lc3NhZ2UtPm1lc3NhZ2VOYW1lKCkuZGF0YSgpKS51dGY4 KCk7CisgICAgICAgIFdlYktpdDo6c2V0Q3Jhc2hSZXBvcnRBcHBsaWNhdGlvblNwZWNpZmljSW5m b3JtYXRpb24oKF9fYnJpZGdlIENGU3RyaW5nUmVmKVtOU1N0cmluZyBzdHJpbmdXaXRoRm9ybWF0 OkAiVW5oYW5kbGVkIGVycm9yIGNvZGUgJXgsIG1lc3NhZ2UgJyVzJywgaGFzaCAlZCIsIGtyLCBt ZXNzYWdlTmFtZS5kYXRhKCksIG1lc3NhZ2VOYW1lLmhhc2goKV0pOworICAgICAgICBDUkFTSF9X SVRIX0lORk8oa3IsIG1lc3NhZ2VOYW1lLmhhc2goKSk7CiAgICAgfQogfQogCg==