<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>205385</bug_id>
          
          <creation_ts>2019-12-18 03:17:03 -0800</creation_ts>
          <short_desc>Missing headers in worker files cause random build failures when adding new files</short_desc>
          <delta_ts>2019-12-18 04:08:21 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebCore Misc.</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          <blocked>202525</blocked>
    
    <blocked>202574</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Chris Lord">clord</reporter>
          <assigned_to name="Chris Lord">clord</assigned_to>
          <cc>cdumez</cc>
    
    <cc>commit-queue</cc>
    
    <cc>fujii</cc>
    
    <cc>rniwa</cc>
    
    <cc>ross.kirsling</cc>
    
    <cc>webkit-bug-importer</cc>
    
    <cc>youennf</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1599734</commentid>
    <comment_count>0</comment_count>
    <who name="Chris Lord">clord</who>
    <bug_when>2019-12-18 03:17:03 -0800</bug_when>
    <thetext>I&apos;ve had a couple of patches hit by this - there are at least two missing headers that while cause no problems now, can cause problems when you add new files (and, I assume, change the grouping of unified sources). I&apos;m going to deal with that separately here rather than with unrelated changes.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1599735</commentid>
    <comment_count>1</comment_count>
      <attachid>385952</attachid>
    <who name="Chris Lord">clord</who>
    <bug_when>2019-12-18 03:19:56 -0800</bug_when>
    <thetext>Created attachment 385952
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1599742</commentid>
    <comment_count>2</comment_count>
      <attachid>385952</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2019-12-18 04:07:07 -0800</bug_when>
    <thetext>Comment on attachment 385952
Patch

Clearing flags on attachment: 385952

Committed r253677: &lt;https://trac.webkit.org/changeset/253677&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1599743</commentid>
    <comment_count>3</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2019-12-18 04:07:09 -0800</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1599744</commentid>
    <comment_count>4</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2019-12-18 04:08:21 -0800</bug_when>
    <thetext>&lt;rdar://problem/58039428&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>385952</attachid>
            <date>2019-12-18 03:19:56 -0800</date>
            <delta_ts>2019-12-18 04:07:07 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-205385-20191218111955.patch</filename>
            <type>text/plain</type>
            <size>1941</size>
            <attacher name="Chris Lord">clord</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjUzNjc1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOWFkNDU5ODgwYjJjNzcx
NjhmODk4ZDQwMWY2YzM1NzhmOGY4YjZmZC4uMTI5MThlZDAzZTA4ZDhlMGRjMGMyNmRkM2RjM2Y5
OWFkMGI5ZGZmZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE5LTEyLTE4ICBDaHJp
cyBMb3JkICA8Y2xvcmRAaWdhbGlhLmNvbT4KKworICAgICAgICBNaXNzaW5nIGhlYWRlcnMgaW4g
d29ya2VyIGZpbGVzIGNhdXNlIHJhbmRvbSBidWlsZCBmYWlsdXJlcyB3aGVuIGFkZGluZyBuZXcg
ZmlsZXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIw
NTM4NQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE5v
IG5ldyB0ZXN0cywgbm8gYmVoYXZpb3JhbCBjaGFuZ2VzLgorCisgICAgICAgICogd29ya2Vycy9z
ZXJ2aWNlL2NvbnRleHQvU2VydmljZVdvcmtlclRocmVhZFByb3h5LmNwcDoKKyAgICAgICAgKiB3
b3JrZXJzL3NlcnZpY2Uvc2VydmVyL1NXU2VydmVyUmVnaXN0cmF0aW9uLmNwcDoKKwogMjAxOS0x
MC0wNCAgQ2hyaXMgTG9yZCAgPGNsb3JkQGlnYWxpYS5jb20+CiAKICAgICAgICAgcmVxdWVzdEFu
aW1hdGlvbkZyYW1lIGFuZCBjYW5jZWxBbmltYXRpb25GcmFtZSBzaG91bGQgYmUgcHJlc2VudCBv
biBEZWRpY2F0ZWRXb3JrZXJHbG9iYWxTY29wZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUv
d29ya2Vycy9zZXJ2aWNlL2NvbnRleHQvU2VydmljZVdvcmtlclRocmVhZFByb3h5LmNwcCBiL1Nv
dXJjZS9XZWJDb3JlL3dvcmtlcnMvc2VydmljZS9jb250ZXh0L1NlcnZpY2VXb3JrZXJUaHJlYWRQ
cm94eS5jcHAKaW5kZXggN2E5ODViYTRiOGVhNjAzNTRjZmU2NWUwYWY2Y2ZjY2RiODcwNDJhZi4u
NGFkYjA5MTBhOTQzNmMwNWZhNjZjMmNiM2NjZjJhMzc3ZWYzYjIyNCAxMDA2NDQKLS0tIGEvU291
cmNlL1dlYkNvcmUvd29ya2Vycy9zZXJ2aWNlL2NvbnRleHQvU2VydmljZVdvcmtlclRocmVhZFBy
b3h5LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS93b3JrZXJzL3NlcnZpY2UvY29udGV4dC9TZXJ2
aWNlV29ya2VyVGhyZWFkUHJveHkuY3BwCkBAIC0yOSw2ICsyOSw3IEBACiAjaWYgRU5BQkxFKFNF
UlZJQ0VfV09SS0VSKQogCiAjaW5jbHVkZSAiQ2FjaGVTdG9yYWdlUHJvdmlkZXIuaCIKKyNpbmNs
dWRlICJFdmVudExvb3AuaCIKICNpbmNsdWRlICJFdmVudE5hbWVzLmgiCiAjaW5jbHVkZSAiRmV0
Y2hMb2FkZXIuaCIKICNpbmNsdWRlICJGcmFtZS5oIgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv
cmUvd29ya2Vycy9zZXJ2aWNlL3NlcnZlci9TV1NlcnZlclJlZ2lzdHJhdGlvbi5jcHAgYi9Tb3Vy
Y2UvV2ViQ29yZS93b3JrZXJzL3NlcnZpY2Uvc2VydmVyL1NXU2VydmVyUmVnaXN0cmF0aW9uLmNw
cAppbmRleCBjMjliNDYyNzg5MGVmOWI2Nzc4ZDI3OTdkZjY0YmY3ZjE5ZjNiOWNhLi45MGExNmQ3
YjM0OTFiZWIwMTY3ZDYzZDUxOGE2N2Q4ZGFmYWFhNzhkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi
Q29yZS93b3JrZXJzL3NlcnZpY2Uvc2VydmVyL1NXU2VydmVyUmVnaXN0cmF0aW9uLmNwcAorKysg
Yi9Tb3VyY2UvV2ViQ29yZS93b3JrZXJzL3NlcnZpY2Uvc2VydmVyL1NXU2VydmVyUmVnaXN0cmF0
aW9uLmNwcApAQCAtMjgsNiArMjgsNyBAQAogCiAjaWYgRU5BQkxFKFNFUlZJQ0VfV09SS0VSKQog
CisjaW5jbHVkZSAiTG9nZ2luZy5oIgogI2luY2x1ZGUgIlNXU2VydmVyLmgiCiAjaW5jbHVkZSAi
U1dTZXJ2ZXJUb0NvbnRleHRDb25uZWN0aW9uLmgiCiAjaW5jbHVkZSAiU1dTZXJ2ZXJXb3JrZXIu
aCIK
</data>

          </attachment>
      

    </bug>

</bugzilla>