205339 2019-12-17 07:59:16 -0800 [GTK][WPE] OffscreenCanvas worker tests that call drawImage crash in debug builds 2019-12-18 01:03:18 -0800 1 1 1 Unclassified WebKit Canvas WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 clord clord cgarcia commit-queue dino ggaren sabouhallawa sam simon.fraser webkit-bug-importer zimmermann oldest_to_newest 1599420 0 clord 2019-12-17 07:59:16 -0800 Any test that calls OffscreenCanvasRenderingContext2D.drawImage inside a worker will crash in debug builds for the same reasons as the crashes fixed in bug 203884 (calling copyImage, which calls code that isn't safe to run off the main thread). Again, there's no actual need to go through this code path, so the fix is to just use the shorter path that doesn't involve unnecessarily creating an Image object. Patch almost done. 1599438 1 385893 clord 2019-12-17 08:35:35 -0800 Created attachment 385893 Patch 1599715 2 385893 commit-queue 2019-12-18 01:02:52 -0800 Comment on attachment 385893 Patch Clearing flags on attachment: 385893 Committed r253675: <https://trac.webkit.org/changeset/253675> 1599716 3 commit-queue 2019-12-18 01:02:54 -0800 All reviewed patches have been landed. Closing bug. 1599717 4 webkit-bug-importer 2019-12-18 01:03:18 -0800 <rdar://problem/58036434> 385893 2019-12-17 08:35:35 -0800 2019-12-18 01:02:52 -0800 Patch bug-205339-20191217163534.patch text/plain 4573 clord U3VidmVyc2lvbiBSZXZpc2lvbjogMjUzNjE0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZTc1MTY3N2FkYzFjMWY4 Yzc2NWEyZTYxZDEwNDU1NzJmZTFmZTEzOS4uZTc2ZmRmY2JhNjM4YTYyN2NhZjYzMDcxMGM3YTIz ZGQwYTc2ODVhMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDE5LTEyLTE3ICBDaHJp cyBMb3JkICA8Y2xvcmRAaWdhbGlhLmNvbT4KKworICAgICAgICBbR1RLXVtXUEVdIE9mZnNjcmVl bkNhbnZhcyB3b3JrZXIgdGVzdHMgdGhhdCBjYWxsIGRyYXdJbWFnZSBjcmFzaCBpbiBkZWJ1ZyBi dWlsZHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIw NTMzOQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIERv bid0IHVubmVjZXNzYXJpbHkgY3JlYXRlIGFuIEltYWdlIG9iamVjdCBpbiB0aGUgQ2Fpcm8gZ3Jh cGhpY3MKKyAgICAgICAgYmFja2VuZCB3aGVuIHVzaW5nIGRyYXdJbWFnZS9kcmF3UGF0dGVybi4g RG9pbmcgc28gY2FsbHMgY29kZSB0aGF0CisgICAgICAgIGlzbid0IHNhZmUgdG8gdXNlIG9mZi1t YWluLXRocmVhZCBhbmQgY2F1c2VzIE9mZnNjcmVlbkNhbnZhcyB3b3JrZXIKKyAgICAgICAgdGVz dHMgdG8gY3Jhc2ggaW4gZGVidWcgYnVpbGRzLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cywgbm8g YmVoYXZpb3JhbCBjaGFuZ2VzLgorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvY2Fpcm8v SW1hZ2VCdWZmZXJDYWlyby5jcHA6CisgICAgICAgIChXZWJDb3JlOjpjYWlyb1N1cmZhY2VDb3B5 KToKKyAgICAgICAgKFdlYkNvcmU6OmNhaXJvU3VyZmFjZUNvZXJjZVRvSW1hZ2UpOgorICAgICAg ICAoV2ViQ29yZTo6SW1hZ2VCdWZmZXI6OmRyYXcpOgorICAgICAgICAoV2ViQ29yZTo6SW1hZ2VC dWZmZXI6OmRyYXdQYXR0ZXJuKToKKwogMjAxOS0xMi0xNyAgeW91ZW5uIGZhYmxldCAgPHlvdWVu bkBhcHBsZS5jb20+CiAKICAgICAgICAgRmlsZUxpc3Qgc2hvdWxkIGJlIGV4cG9zZWQgdG8gd29y a2VycwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2Fpcm8v SW1hZ2VCdWZmZXJDYWlyby5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9j YWlyby9JbWFnZUJ1ZmZlckNhaXJvLmNwcAppbmRleCA1NTcxMDZjZDI4OGEwYzA3MGFiZmZiZTlj NDgxNWUxMThjZTZkMjE4Li42YjY3ZjU1ZGM5OGIwNzY2YTAzMWMzYTRlN2I5MDYwZmRiOGI1MDRl IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jYWlyby9JbWFn ZUJ1ZmZlckNhaXJvLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9j YWlyby9JbWFnZUJ1ZmZlckNhaXJvLmNwcApAQCAtMjI1LDEyICsyMjUsOCBAQCB2b2lkIEltYWdl QnVmZmVyRGF0YTo6Y3JlYXRlQ2Fpcm9HTFN1cmZhY2UoKQogI2VuZGlmCiAKIHN0YXRpYyBSZWZQ dHI8Y2Fpcm9fc3VyZmFjZV90PgotY2Fpcm9TdXJmYWNlQ29lcmNlVG9JbWFnZShjYWlyb19zdXJm YWNlX3QqIHN1cmZhY2UpCitjYWlyb1N1cmZhY2VDb3B5KGNhaXJvX3N1cmZhY2VfdCogc3VyZmFj ZSkKIHsKLSAgICBpZiAoY2Fpcm9fc3VyZmFjZV9nZXRfdHlwZShzdXJmYWNlKSA9PSBDQUlST19T VVJGQUNFX1RZUEVfSU1BR0UKLSAgICAgICAgJiYgY2Fpcm9fc3VyZmFjZV9nZXRfY29udGVudChz dXJmYWNlKSA9PSBDQUlST19DT05URU5UX0NPTE9SX0FMUEhBKQotICAgICAgICByZXR1cm4gc3Vy ZmFjZTsKLQogICAgIGF1dG8gY29weSA9IGFkb3B0UmVmKGNhaXJvX2ltYWdlX3N1cmZhY2VfY3Jl YXRlKENBSVJPX0ZPUk1BVF9BUkdCMzIsCiAgICAgICAgIGNhaXJvX2ltYWdlX3N1cmZhY2VfZ2V0 X3dpZHRoKHN1cmZhY2UpLAogICAgICAgICBjYWlyb19pbWFnZV9zdXJmYWNlX2dldF9oZWlnaHQo c3VyZmFjZSkpKTsKQEAgLTI0Myw2ICsyMzksMTYgQEAgY2Fpcm9TdXJmYWNlQ29lcmNlVG9JbWFn ZShjYWlyb19zdXJmYWNlX3QqIHN1cmZhY2UpCiAgICAgcmV0dXJuIGNvcHk7CiB9CiAKK3N0YXRp YyBSZWZQdHI8Y2Fpcm9fc3VyZmFjZV90PgorY2Fpcm9TdXJmYWNlQ29lcmNlVG9JbWFnZShjYWly b19zdXJmYWNlX3QqIHN1cmZhY2UpCit7CisgICAgaWYgKGNhaXJvX3N1cmZhY2VfZ2V0X3R5cGUo c3VyZmFjZSkgPT0gQ0FJUk9fU1VSRkFDRV9UWVBFX0lNQUdFCisgICAgICAgICYmIGNhaXJvX3N1 cmZhY2VfZ2V0X2NvbnRlbnQoc3VyZmFjZSkgPT0gQ0FJUk9fQ09OVEVOVF9DT0xPUl9BTFBIQSkK KyAgICAgICAgcmV0dXJuIHN1cmZhY2U7CisKKyAgICByZXR1cm4gY2Fpcm9TdXJmYWNlQ29weShz dXJmYWNlKTsKK30KKwogVmVjdG9yPHVpbnQ4X3Q+IEltYWdlQnVmZmVyOjp0b0JHUkFEYXRhKCkg Y29uc3QKIHsKICAgICBhdXRvIHN1cmZhY2UgPSBjYWlyb1N1cmZhY2VDb2VyY2VUb0ltYWdlKG1f ZGF0YS5tX3N1cmZhY2UuZ2V0KCkpOwpAQCAtMzU2LDE2ICszNjIsMjcgQEAgdm9pZCBJbWFnZUJ1 ZmZlcjo6ZHJhd0NvbnN1bWluZyhzdGQ6OnVuaXF1ZV9wdHI8SW1hZ2VCdWZmZXI+IGltYWdlQnVm ZmVyLCBHcmFwaGkKIAogdm9pZCBJbWFnZUJ1ZmZlcjo6ZHJhdyhHcmFwaGljc0NvbnRleHQmIGRl c3RpbmF0aW9uQ29udGV4dCwgY29uc3QgRmxvYXRSZWN0JiBkZXN0UmVjdCwgY29uc3QgRmxvYXRS ZWN0JiBzcmNSZWN0LCAgY29uc3QgSW1hZ2VQYWludGluZ09wdGlvbnMmIG9wdGlvbnMpCiB7Ci0g ICAgQmFja2luZ1N0b3JlQ29weSBjb3B5TW9kZSA9ICZkZXN0aW5hdGlvbkNvbnRleHQgPT0gJmNv bnRleHQoKSA/IENvcHlCYWNraW5nU3RvcmUgOiBEb250Q29weUJhY2tpbmdTdG9yZTsKLSAgICBS ZWZQdHI8SW1hZ2U+IGltYWdlID0gY29weUltYWdlKGNvcHlNb2RlKTsKLSAgICBkZXN0aW5hdGlv bkNvbnRleHQuZHJhd0ltYWdlKCppbWFnZSwgZGVzdFJlY3QsIHNyY1JlY3QsIG9wdGlvbnMpOwor ICAgIGlmIChkZXN0aW5hdGlvbkNvbnRleHQucGFpbnRpbmdEaXNhYmxlZCgpKQorICAgICAgICBy ZXR1cm47CisKKyAgICBpZiAoYXV0byBzdXJmYWNlID0gbmF0aXZlSW1hZ2UoKSkgeworICAgICAg ICBpZiAoJmRlc3RpbmF0aW9uQ29udGV4dCA9PSAmY29udGV4dCgpKQorICAgICAgICAgICAgc3Vy ZmFjZSA9IGNhaXJvU3VyZmFjZUNvcHkoc3VyZmFjZS5nZXQoKSk7CisKKyAgICAgICAgSW50ZXJw b2xhdGlvblF1YWxpdHlNYWludGFpbmVyIGludGVycG9sYXRpb25RdWFsaXR5Rm9yVGhpc1Njb3Bl KGRlc3RpbmF0aW9uQ29udGV4dCwgb3B0aW9ucy5pbnRlcnBvbGF0aW9uUXVhbGl0eSgpKTsKKyAg ICAgICAgY29uc3QgYXV0byYgZGVzdGluYXRpb25Db250ZXh0U3RhdGUgPSBkZXN0aW5hdGlvbkNv bnRleHQuc3RhdGUoKTsKKyAgICAgICAgZHJhd05hdGl2ZUltYWdlKCpkZXN0aW5hdGlvbkNvbnRl eHQucGxhdGZvcm1Db250ZXh0KCksIHN1cmZhY2UuZ2V0KCksIGRlc3RSZWN0LCBzcmNSZWN0LCB7 IG9wdGlvbnMsIGRlc3RpbmF0aW9uQ29udGV4dFN0YXRlLmltYWdlSW50ZXJwb2xhdGlvblF1YWxp dHkgfSwgZGVzdGluYXRpb25Db250ZXh0U3RhdGUuYWxwaGEsIFdlYkNvcmU6OkNhaXJvOjpTaGFk b3dTdGF0ZShkZXN0aW5hdGlvbkNvbnRleHRTdGF0ZSkpOworICAgIH0KIH0KIAogdm9pZCBJbWFn ZUJ1ZmZlcjo6ZHJhd1BhdHRlcm4oR3JhcGhpY3NDb250ZXh0JiBjb250ZXh0LCBjb25zdCBGbG9h dFJlY3QmIGRlc3RSZWN0LCBjb25zdCBGbG9hdFJlY3QmIHNyY1JlY3QsIGNvbnN0IEFmZmluZVRy YW5zZm9ybSYgcGF0dGVyblRyYW5zZm9ybSwKLSAgICBjb25zdCBGbG9hdFBvaW50JiBwaGFzZSwg Y29uc3QgRmxvYXRTaXplJiBzcGFjaW5nLCBjb25zdCBJbWFnZVBhaW50aW5nT3B0aW9ucyYgb3B0 aW9ucykKKyAgICBjb25zdCBGbG9hdFBvaW50JiBwaGFzZSwgY29uc3QgRmxvYXRTaXplJiwgY29u c3QgSW1hZ2VQYWludGluZ09wdGlvbnMmIG9wdGlvbnMpCiB7Ci0gICAgaWYgKFJlZlB0cjxJbWFn ZT4gaW1hZ2UgPSBjb3B5SW1hZ2UoRG9udENvcHlCYWNraW5nU3RvcmUpKQotICAgICAgICBpbWFn ZS0+ZHJhd1BhdHRlcm4oY29udGV4dCwgZGVzdFJlY3QsIHNyY1JlY3QsIHBhdHRlcm5UcmFuc2Zv cm0sIHBoYXNlLCBzcGFjaW5nLCBvcHRpb25zKTsKKyAgICBpZiAoY29udGV4dC5wYWludGluZ0Rp c2FibGVkKCkpCisgICAgICAgIHJldHVybjsKKworICAgIGlmIChhdXRvIHN1cmZhY2UgPSBuYXRp dmVJbWFnZSgpKQorICAgICAgICBDYWlybzo6ZHJhd1BhdHRlcm4oKmNvbnRleHQucGxhdGZvcm1D b250ZXh0KCksIHN1cmZhY2UuZ2V0KCksIG1fc2l6ZSwgZGVzdFJlY3QsIHNyY1JlY3QsIHBhdHRl cm5UcmFuc2Zvcm0sIHBoYXNlLCBvcHRpb25zKTsKIH0KIAogdm9pZCBJbWFnZUJ1ZmZlcjo6cGxh dGZvcm1UcmFuc2Zvcm1Db2xvclNwYWNlKGNvbnN0IHN0ZDo6YXJyYXk8dWludDhfdCwgMjU2PiYg bG9va1VwVGFibGUpCg==