205335 2019-12-17 06:30:13 -0800 [GTK][WPE] Enable WebGL by default 2020-01-21 03:28:18 -0800 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build PC Linux RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=205334 P2 Normal --- 1 mcatanzaro webkit-unassigned aperez berto bugs-noreply cgarcia ews-watchlist gustavo oldest_to_newest 1599389 0 mcatanzaro 2019-12-17 06:30:13 -0800 I noticed WebGL is still disabled by default. This is weird since it's been mature for a long time now. I would flip the default similarly to how we enabled MSE in bug #190243. Note: bug #69706 attempted to do this, but failed because there's also a runtime setting. 1608956 1 388286 cgarcia 2020-01-21 01:10:59 -0800 Created attachment 388286 Patch 1608957 2 ews-watchlist 2020-01-21 01:12:07 -0800 Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API 1608965 3 388286 aperez 2020-01-21 02:00:09 -0800 Comment on attachment 388286 Patch Patch LGTM, but let's fix the indentation issue reported by the style checker while at it before commiting :) 1608966 4 aperez 2020-01-21 02:00:55 -0800 Oh, and for the record I agree that it seems like a very good idea to have WebGL enabled by default. 1608975 5 cgarcia 2020-01-21 03:28:18 -0800 Committed r254848: <https://trac.webkit.org/changeset/254848> 388286 2020-01-21 01:10:59 -0800 2020-01-21 02:00:09 -0800 Patch wk2-webgl-setting.diff text/plain 2385 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9nbGliL1dlYktpdFNldHRp bmdzLmNwcCBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9nbGliL1dlYktpdFNldHRpbmdz LmNwcAppbmRleCBiNjhjOTEzMWIzMC4uZTE0ZmJjNTcyNmMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJLaXQvVUlQcm9jZXNzL0FQSS9nbGliL1dlYktpdFNldHRpbmdzLmNwcAorKysgYi9Tb3VyY2Uv V2ViS2l0L1VJUHJvY2Vzcy9BUEkvZ2xpYi9XZWJLaXRTZXR0aW5ncy5jcHAKQEAgLTEwNjAsMTYg KzEwNjAsMTUgQEAgc3RhdGljIHZvaWQgd2Via2l0X3NldHRpbmdzX2NsYXNzX2luaXQoV2ViS2l0 U2V0dGluZ3NDbGFzcyoga2xhc3MpCiAgICAgLyoqCiAgICAgKiBXZWJLaXRTZXR0aW5nczplbmFi bGUtd2ViZ2w6CiAgICAgKgotICAgICogRW5hYmxlIG9yIGRpc2FibGUgc3VwcG9ydCBmb3IgV2Vi R0wgb24gcGFnZXMuIFdlYkdMIGlzIGFuIGV4cGVyaW1lbnRhbAotICAgICogcHJvcG9zYWwgZm9y IGFsbG93aW5nIHdlYiBwYWdlcyB0byB1c2UgT3BlbkdMIEVTLWxpa2UgY2FsbHMgZGlyZWN0bHku IFRoZQotICAgICogc3RhbmRhcmQgaXMgY3VycmVudGx5IGEgd29yay1pbi1wcm9ncmVzcyBieSB0 aGUgS2hyb25vcyBHcm91cC4KKyAgICAqIEVuYWJsZSBvciBkaXNhYmxlIHN1cHBvcnQgZm9yIFdl YkdMIG9uIHBhZ2VzLiBXZWJHTCBlbmFibGVzIHdlYgorICAgICogY29udGVudCB0byB1c2UgYW4g QVBJIGJhc2VkIG9uIE9wZW5HTCBFUyAyLjAuCiAgICAgKi8KICAgICBnX29iamVjdF9jbGFzc19p bnN0YWxsX3Byb3BlcnR5KGdPYmplY3RDbGFzcywKICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgIFBST1BfRU5BQkxFX1dFQkdMLAogICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgZ19wYXJhbV9zcGVjX2Jvb2xlYW4oImVuYWJsZS13ZWJnbCIsCiAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBfKCJFbmFibGUg V2ViR0wiKSwKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgIF8oIldoZXRoZXIgV2ViR0wgY29udGVudCBzaG91bGQgYmUgcmVuZGVyZWQiKSwK LSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg IEZBTFNFLAorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgVFJVRSwKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgIHJlYWRXcml0ZUNvbnN0cnVjdFBhcmFtRmxhZ3MpKTsKIAogICAgIC8q KgpkaWZmIC0tZ2l0IGEvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJLaXRHTGliL1Rlc3RX ZWJLaXRTZXR0aW5ncy5jcHAgYi9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktpdEdMaWIv VGVzdFdlYktpdFNldHRpbmdzLmNwcAppbmRleCA0NjgzZmI4Yzk4Yy4uMDI2YTM4ODcyYmEgMTAw NjQ0Ci0tLSBhL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV2ViS2l0R0xpYi9UZXN0V2ViS2l0 U2V0dGluZ3MuY3BwCisrKyBiL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV2ViS2l0R0xpYi9U ZXN0V2ViS2l0U2V0dGluZ3MuY3BwCkBAIC0yMzYsMTAgKzIzNiwxMCBAQCBzdGF0aWMgdm9pZCB0 ZXN0V2ViS2l0U2V0dGluZ3MoVGVzdCosIGdjb25zdHBvaW50ZXIpCiAgICAgd2Via2l0X3NldHRp bmdzX3NldF9lbmFibGVfd2ViYXVkaW8oc2V0dGluZ3MsIEZBTFNFKTsKICAgICBnX2Fzc2VydF9m YWxzZSh3ZWJraXRfc2V0dGluZ3NfZ2V0X2VuYWJsZV93ZWJhdWRpbyhzZXR0aW5ncykpOwogCi0g ICAgLy8gV2ViR0wgaXMgZGlzYWJsZWQgYnkgZGVmYXVsdC4KLSAgICBnX2Fzc2VydF9mYWxzZSh3 ZWJraXRfc2V0dGluZ3NfZ2V0X2VuYWJsZV93ZWJnbChzZXR0aW5ncykpOwotICAgIHdlYmtpdF9z ZXR0aW5nc19zZXRfZW5hYmxlX3dlYmdsKHNldHRpbmdzLCBUUlVFKTsKKyAgICAvLyBXZWJHTCBp cyBlbmFibGVkIGJ5IGRlZmF1bHQuCiAgICAgZ19hc3NlcnRfdHJ1ZSh3ZWJraXRfc2V0dGluZ3Nf Z2V0X2VuYWJsZV93ZWJnbChzZXR0aW5ncykpOworICAgIHdlYmtpdF9zZXR0aW5nc19zZXRfZW5h YmxlX3dlYmdsKHNldHRpbmdzLCBGQUxTRSk7CisgICAgZ19hc3NlcnRfZmFsc2Uod2Via2l0X3Nl dHRpbmdzX2dldF9lbmFibGVfd2ViZ2woc2V0dGluZ3MpKTsKIAogICAgIC8vIEFsbG93IE1vZGFs IERpYWxvZ3MgaXMgZGlzYWJsZWQgYnkgZGVmYXVsdC4KICAgICBnX2Fzc2VydF9mYWxzZSh3ZWJr aXRfc2V0dGluZ3NfZ2V0X2FsbG93X21vZGFsX2RpYWxvZ3Moc2V0dGluZ3MpKTsK