205334 2019-12-17 06:28:43 -0800 [GTK][WPE] Enable WebAudio by default 2020-01-21 03:15:12 -0800 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build PC Linux RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=205335 P2 Normal --- 1 mcatanzaro webkit-unassigned aperez berto bugs-noreply cgarcia ews-watchlist gustavo oldest_to_newest 1599388 0 mcatanzaro 2019-12-17 06:28:43 -0800 I noticed WebAudio is still disabled by default. This is weird since it's been mature for a long time now. I would flip the default similarly to how we enabled MSE in bug #190243. 1608954 1 388285 cgarcia 2020-01-21 01:06:33 -0800 Created attachment 388285 Patch 1608955 2 ews-watchlist 2020-01-21 01:08:15 -0800 Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API 1608967 3 388285 aperez 2020-01-21 02:06:46 -0800 Comment on attachment 388285 Patch LGTM, but please make the style checker pass before landing :) 1608974 4 cgarcia 2020-01-21 03:15:12 -0800 Committed r254847: <https://trac.webkit.org/changeset/254847> 388285 2020-01-21 01:06:33 -0800 2020-01-21 02:06:46 -0800 Patch wk2-web-audio-setting.diff text/plain 3689 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9DaGFu Z2VMb2cKaW5kZXggYWNhMWU5YzJjMGUuLjg2NDY3ODRhYTFhIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0L0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0L0NoYW5nZUxvZwpAQCAtMSwzICsx LDEzIEBACisyMDIwLTAxLTIxICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNnYXJjaWFAaWdhbGlh LmNvbT4KKworICAgICAgICBbR1RLXVtXUEVdIEVuYWJsZSBXZWJBdWRpbyBieSBkZWZhdWx0Cisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDUzMzQKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFVJUHJvY2Vz cy9BUEkvZ2xpYi9XZWJLaXRTZXR0aW5ncy5jcHA6CisgICAgICAgICh3ZWJraXRfc2V0dGluZ3Nf Y2xhc3NfaW5pdCk6CisKIDIwMjAtMDEtMjEgIHlvdWVubiBmYWJsZXQgIDx5b3Vlbm5AYXBwbGUu Y29tPgogCiAgICAgICAgIExvZyB0aGUgZGVzdGluYXRpb24gb2YgYSBsb2FkIHdoZW4gaGl0dGlu ZyBuZXR3b3JrIHByb2Nlc3MKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQ SS9nbGliL1dlYktpdFNldHRpbmdzLmNwcCBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9n bGliL1dlYktpdFNldHRpbmdzLmNwcAppbmRleCA4ZDBhMTYyY2MyNC4uYjY4YzkxMzFiMzAgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9nbGliL1dlYktpdFNldHRpbmdz LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvZ2xpYi9XZWJLaXRTZXR0aW5n cy5jcHAKQEAgLTEwNDUsMTggKzEwNDUsMTYgQEAgc3RhdGljIHZvaWQgd2Via2l0X3NldHRpbmdz X2NsYXNzX2luaXQoV2ViS2l0U2V0dGluZ3NDbGFzcyoga2xhc3MpCiAgICAgICoKICAgICAgKgog ICAgICAqIEVuYWJsZSBvciBkaXNhYmxlIHN1cHBvcnQgZm9yIFdlYkF1ZGlvIG9uIHBhZ2VzLiBX ZWJBdWRpbyBpcyBhbgotICAgICAqIGV4cGVyaW1lbnRhbCBwcm9wb3NhbCBmb3IgYWxsb3dpbmcg d2ViIHBhZ2VzIHRvIGdlbmVyYXRlIEF1ZGlvCi0gICAgICogV0FWRSBkYXRhIGZyb20gSmF2YVNj cmlwdC4gVGhlIHN0YW5kYXJkIGlzIGN1cnJlbnRseSBhCi0gICAgICogd29yay1pbi1wcm9ncmVz cyBieSB0aGUgVzNDIEF1ZGlvIFdvcmtpbmcgR3JvdXAuCisgICAgICogQVBJIGZvciBwcm9jZXNz aW5nIGFuZCBzeW50aGVzaXppbmcgYXVkaW8gaW4gd2ViIGFwcGxpY2F0aW9ucwogICAgICAqCi0g ICAgICogU2VlIGFsc28gaHR0cHM6Ly9kdmNzLnczLm9yZy9oZy9hdWRpby9yYXctZmlsZS90aXAv d2ViYXVkaW8vc3BlY2lmaWNhdGlvbi5odG1sCisgICAgICogU2VlIGFsc28gaHR0cHM6Ly93ZWJh dWRpby5naXRodWIuaW8vd2ViLWF1ZGlvLWFwaQogICAgICAqLwogICAgIGdfb2JqZWN0X2NsYXNz X2luc3RhbGxfcHJvcGVydHkoZ09iamVjdENsYXNzLAogICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgUFJPUF9FTkFCTEVfV0VCQVVESU8sCiAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICBnX3BhcmFtX3NwZWNfYm9vbGVhbigiZW5hYmxlLXdlYmF1ZGlvIiwKICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIF8o IkVuYWJsZSBXZWJBdWRpbyIpLAogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgXygiV2hldGhlciBXZWJBdWRpbyBjb250ZW50IHNob3VsZCBi ZSBoYW5kbGVkIiksCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICBGQUxTRSwKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgIFRSVUUsCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICByZWFkV3JpdGVDb25zdHJ1Y3RQYXJhbUZsYWdz KSk7CiAKICAgICAvKioKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5n ZUxvZwppbmRleCA2ZDQxZTc3MzcyMi4uYmYxMWZjNjhiNzAgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0No YW5nZUxvZworKysgYi9Ub29scy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAyMC0wMS0y MSAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGlnYWxpYS5jb20+CisKKyAgICAgICAg W0dUS11bV1BFXSBFbmFibGUgV2ViQXVkaW8gYnkgZGVmYXVsdAorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjA1MzM0CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVXBkYXRlIHRoZSB1bml0IHRlc3QuCisKKyAg ICAgICAgKiBUZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktpdEdMaWIvVGVzdFdlYktpdFNldHRpbmdz LmNwcDoKKyAgICAgICAgKHRlc3RXZWJLaXRTZXR0aW5ncyk6CisKIDIwMjAtMDEtMjAgIFNhbSBX ZWluaWcgIDx3ZWluaWdAYXBwbGUuY29tPgogCiAgICAgICAgIFBsYXRmb3JtLmggaXMgb3V0IG9m IGNvbnRyb2wgUGFydCA4OiBNYWNyb3MgYXJlIHVzZWQgaW5jb25zaXN0ZW50bHkKZGlmZiAtLWdp dCBhL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV2ViS2l0R0xpYi9UZXN0V2ViS2l0U2V0dGlu Z3MuY3BwIGIvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJLaXRHTGliL1Rlc3RXZWJLaXRT ZXR0aW5ncy5jcHAKaW5kZXggOGU5OTQ0YWQxYmIuLjQ2ODNmYjhjOThjIDEwMDY0NAotLS0gYS9U b29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktpdEdMaWIvVGVzdFdlYktpdFNldHRpbmdzLmNw cAorKysgYi9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktpdEdMaWIvVGVzdFdlYktpdFNl dHRpbmdzLmNwcApAQCAtMjMxLDEwICsyMzEsMTAgQEAgc3RhdGljIHZvaWQgdGVzdFdlYktpdFNl dHRpbmdzKFRlc3QqLCBnY29uc3Rwb2ludGVyKQogICAgIHdlYmtpdF9zZXR0aW5nc19zZXRfcHJp bnRfYmFja2dyb3VuZHMoc2V0dGluZ3MsIEZBTFNFKTsKICAgICBnX2Fzc2VydF9mYWxzZSh3ZWJr aXRfc2V0dGluZ3NfZ2V0X3ByaW50X2JhY2tncm91bmRzKHNldHRpbmdzKSk7CiAKLSAgICAvLyBX ZWJBdWRpbyBpcyBkaXNhYmxlZCBieSBkZWZhdWx0LgotICAgIGdfYXNzZXJ0X2ZhbHNlKHdlYmtp dF9zZXR0aW5nc19nZXRfZW5hYmxlX3dlYmF1ZGlvKHNldHRpbmdzKSk7Ci0gICAgd2Via2l0X3Nl dHRpbmdzX3NldF9lbmFibGVfd2ViYXVkaW8oc2V0dGluZ3MsIFRSVUUpOworICAgIC8vIFdlYkF1 ZGlvIGlzIGVuYWJsZWQgYnkgZGVmYXVsdC4KICAgICBnX2Fzc2VydF90cnVlKHdlYmtpdF9zZXR0 aW5nc19nZXRfZW5hYmxlX3dlYmF1ZGlvKHNldHRpbmdzKSk7CisgICAgd2Via2l0X3NldHRpbmdz X3NldF9lbmFibGVfd2ViYXVkaW8oc2V0dGluZ3MsIEZBTFNFKTsKKyAgICBnX2Fzc2VydF9mYWxz ZSh3ZWJraXRfc2V0dGluZ3NfZ2V0X2VuYWJsZV93ZWJhdWRpbyhzZXR0aW5ncykpOwogCiAgICAg Ly8gV2ViR0wgaXMgZGlzYWJsZWQgYnkgZGVmYXVsdC4KICAgICBnX2Fzc2VydF9mYWxzZSh3ZWJr aXRfc2V0dGluZ3NfZ2V0X2VuYWJsZV93ZWJnbChzZXR0aW5ncykpOwo=