205331 2019-12-17 02:59:09 -0800 [GLIB] jsc_context_evaluate_in_object should take the API lock before calling setGlobalScopeExtension 2019-12-17 06:14:27 -0800 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 cgarcia webkit-unassigned ews-watchlist keith_miller mark.lam msaboff saam tzagallo webkit-bug-importer zan oldest_to_newest 1599354 0 cgarcia 2019-12-17 02:59:09 -0800 We are now getting a crash due to an assert because the api lock is not held 1599355 1 385873 cgarcia 2019-12-17 03:00:53 -0800 Created attachment 385873 Patch 1599377 2 cgarcia 2019-12-17 06:13:21 -0800 Committed r253624: <https://trac.webkit.org/changeset/253624> 1599379 3 webkit-bug-importer 2019-12-17 06:14:27 -0800 <rdar://problem/58004468> 385873 2019-12-17 03:00:53 -0800 2019-12-17 06:09:50 -0800 Patch jsc-eval-in-object-crash.diff text/plain 2124 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9BUEkvZ2xpYi9KU0NDb250ZXh0LmNw cCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9BUEkvZ2xpYi9KU0NDb250ZXh0LmNwcAppbmRleCAw ZTgwMzEyNGIyNi4uYWI4MDlkZDcxZjAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29y ZS9BUEkvZ2xpYi9KU0NDb250ZXh0LmNwcAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQVBJ L2dsaWIvSlNDQ29udGV4dC5jcHAKQEAgLTg5NCw4ICs4OTQsOCBAQCBKU0NWYWx1ZSoganNjX2Nv bnRleHRfZXZhbHVhdGVfaW5fb2JqZWN0KEpTQ0NvbnRleHQqIGNvbnRleHQsIGNvbnN0IGNoYXIq IGNvZGUsCiAgICAgICAgIGluc3RhbmNlID8ganNjQ2xhc3NDcmVhdGVDb250ZXh0V2l0aEpTV3Jh cHBlcihvYmplY3RDbGFzcywgY29udGV4dCwgaW5zdGFuY2UpIDogSlNHbG9iYWxDb250ZXh0Q3Jl YXRlSW5Hcm91cChqc2NWaXJ0dWFsTWFjaGluZUdldENvbnRleHRHcm91cChjb250ZXh0LT5wcml2 LT52bS5nZXQoKSksIG51bGxwdHIpKTsKICAgICBKU0M6OkpTR2xvYmFsT2JqZWN0KiBnbG9iYWxP YmplY3QgPSB0b0pTKG9iamVjdENvbnRleHQuZ2V0KCkpOwogICAgIEpTQzo6Vk0mIHZtID0gZ2xv YmFsT2JqZWN0LT52bSgpOwotICAgIGF1dG8qIGpzT2JqZWN0ID0gZ2xvYmFsT2JqZWN0OwotICAg IGpzT2JqZWN0LT5zZXRHbG9iYWxTY29wZUV4dGVuc2lvbihKU0M6OkpTV2l0aFNjb3BlOjpjcmVh dGUodm0sIGpzT2JqZWN0LCBqc09iamVjdC0+Z2xvYmFsU2NvcGUoKSwgdG9KUyhKU0NvbnRleHRH ZXRHbG9iYWxPYmplY3QoY29udGV4dC0+cHJpdi0+anNDb250ZXh0LmdldCgpKSkpKTsKKyAgICBK U0M6OkpTTG9ja0hvbGRlciBsb2NrZXIoZ2xvYmFsT2JqZWN0KTsKKyAgICBnbG9iYWxPYmplY3Qt PnNldEdsb2JhbFNjb3BlRXh0ZW5zaW9uKEpTQzo6SlNXaXRoU2NvcGU6OmNyZWF0ZSh2bSwgZ2xv YmFsT2JqZWN0LCBnbG9iYWxPYmplY3QtPmdsb2JhbFNjb3BlKCksIHRvSlMoSlNDb250ZXh0R2V0 R2xvYmFsT2JqZWN0KGNvbnRleHQtPnByaXYtPmpzQ29udGV4dC5nZXQoKSkpKSk7CiAgICAgSlNW YWx1ZVJlZiBleGNlcHRpb24gPSBudWxscHRyOwogICAgIEpTVmFsdWVSZWYgcmVzdWx0ID0gZXZh bHVhdGVTY3JpcHRJbkNvbnRleHQob2JqZWN0Q29udGV4dC5nZXQoKSwgU3RyaW5nOjpmcm9tVVRG OChjb2RlLCBsZW5ndGggPCAwID8gc3RybGVuKGNvZGUpIDogbGVuZ3RoKSwgdXJpLCBsaW5lTnVt YmVyLCAmZXhjZXB0aW9uKTsKICAgICBpZiAoanNjQ29udGV4dEhhbmRsZUV4Y2VwdGlvbklmTmVl ZGVkKGNvbnRleHQsIGV4Y2VwdGlvbikpCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA5ZWNj NDRiZWRkZS4uMDY4MDcxYjI1MzkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9D aGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsx LDE1IEBACisyMDE5LTEyLTE3ICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNnYXJjaWFAaWdhbGlh LmNvbT4KKworICAgICAgICBbR0xJQl0ganNjX2NvbnRleHRfZXZhbHVhdGVfaW5fb2JqZWN0IHNo b3VsZCB0YWtlIHRoZSBBUEkgbG9jayBiZWZvcmUgY2FsbGluZyBzZXRHbG9iYWxTY29wZUV4dGVu c2lvbgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjA1 MzMxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV2Ug YXJlIG5vdyBnZXR0aW5nIGEgY3Jhc2ggZHVlIHRvIGFuIGFzc2VydCBiZWNhdXNlIHRoZSBhcGkg bG9jayBpcyBub3QgaGVsZC4KKworICAgICAgICAqIEFQSS9nbGliL0pTQ0NvbnRleHQuY3BwOgor ICAgICAgICAoanNjX2NvbnRleHRfZXZhbHVhdGVfaW5fb2JqZWN0KToKKwogMjAxOS0xMS0xMiAg Q2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGlnYWxpYS5jb20+CiAKICAgICAgICAgV2Vi RHJpdmVyOiBmaXggaGFuZGxpbmcgb2Ygc2Vzc2lvbiB0aW1lb3V0cyBmb3IgdmFsdWVzIGhpZ2hl ciB0aGFuIE1BWF9JTlQK