205330 2019-12-17 01:50:24 -0800 [GTK][WPE] IndexedDB directory set in WebsiteDataManager is ignored 2019-12-17 06:28:32 -0800 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED Gtk, Regression P2 Normal --- 1 cgarcia webkit-unassigned achristensen berto bugs-noreply cdumez ews-watchlist gustavo youennf oldest_to_newest 1599324 0 cgarcia 2019-12-17 01:50:24 -0800 There are two problems here: 1- WebKitWebsiteDataManager is no longer setting the indexedDB directory to the WEbsiteDatastore configuration. It seems the code was removed by mistake in r249778 when rolling out r249768. 2- The WebProcessPool is not considering the primary WebsiteDataStore for indexedDB configuration. This was caught by test /webkit/WebKitWebsiteData/configuration 1599330 1 385866 cgarcia 2019-12-17 01:54:52 -0800 Created attachment 385866 Patch 1599332 2 ews-watchlist 2019-12-17 01:55:45 -0800 Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API 1599376 3 cgarcia 2019-12-17 06:12:51 -0800 Could a WebKit2 owner check the cross-platform change, please? Youenn? 1599381 4 385866 youennf 2019-12-17 06:21:09 -0800 Comment on attachment 385866 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=385866&action=review > Source/WebKit/UIProcess/WebProcessPool.cpp:540 > parameters.defaultDataStoreParameters.indexedDatabaseDirectory = WebKit::WebsiteDataStore::defaultDataStore()->parameters().indexedDatabaseDirectory; LGTM. There is some pre-existing inconsistencies in this method with withWebsiteDataStore . Some other parameters like parameters.defaultDataStoreParameters.networkSessionParameters.networkCacheDirectory also check for withWebsiteDataStore. 1599386 5 cgarcia 2019-12-17 06:27:20 -0800 (In reply to youenn fablet from comment #4) > Comment on attachment 385866 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=385866&action=review > > > Source/WebKit/UIProcess/WebProcessPool.cpp:540 > > parameters.defaultDataStoreParameters.indexedDatabaseDirectory = WebKit::WebsiteDataStore::defaultDataStore()->parameters().indexedDatabaseDirectory; > > LGTM. Thanks! > There is some pre-existing inconsistencies in this method with > withWebsiteDataStore . > Some other parameters like > parameters.defaultDataStoreParameters.networkSessionParameters. > networkCacheDirectory also check for withWebsiteDataStore. Yes, I noticed it too, but I wasn't sure what the expected behavior was in the end. 1599387 6 cgarcia 2019-12-17 06:28:32 -0800 Committed r253626: <https://trac.webkit.org/changeset/253626> 385866 2019-12-17 01:54:52 -0800 2019-12-17 06:21:09 -0800 Patch wk2-indexeddb-config.diff text/plain 3718 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9DaGFu Z2VMb2cKaW5kZXggNTQ4NDRhMjZmZjkuLjk2ZTI1NjY2ODJhIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0L0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0L0NoYW5nZUxvZwpAQCAtMSwzICsx LDI0IEBACisyMDE5LTEyLTE3ICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNnYXJjaWFAaWdhbGlh LmNvbT4KKworICAgICAgICBbR1RLXVtXUEVdIEluZGV4ZWREQiBkaXJlY3Rvcnkgc2V0IGluIFdl YnNpdGVEYXRhTWFuYWdlciBpcyBpZ25vcmVkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0yMDUzMzAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBUaGVyZSBhcmUgdHdvIHByb2JsZW1zIGhlcmU6CisKKyAgICAg ICAgICAxLSBXZWJLaXRXZWJzaXRlRGF0YU1hbmFnZXIgaXMgbm8gbG9uZ2VyIHNldHRpbmcgdGhl IGluZGV4ZWREQiBkaXJlY3RvcnkgdG8gdGhlIFdlYnNpdGVEYXRhc3RvcmUKKyAgICAgICAgICAg ICBjb25maWd1cmF0aW9uLiBJdCBzZWVtcyB0aGUgY29kZSB3YXMgcmVtb3ZlZCBieSBtaXN0YWtl IGluIHIyNDk3Nzggd2hlbiByb2xsaW5nIG91dCByMjQ5NzY4LgorICAgICAgICAgIDItIFRoZSBX ZWJQcm9jZXNzUG9vbCBpcyBub3QgY29uc2lkZXJpbmcgdGhlIHByaW1hcnkgV2Vic2l0ZURhdGFT dG9yZSBmb3IgaW5kZXhlZERCIGNvbmZpZ3VyYXRpb24uCisKKyAgICAgICAgRml4ZXM6IC93ZWJr aXQvV2ViS2l0V2Vic2l0ZURhdGEvZGF0YWJhc2VzCisgICAgICAgICAgICAgICAvd2Via2l0L1dl YktpdFdlYnNpdGVEYXRhL2NvbmZpZ3VyYXRpb24KKworICAgICAgICAqIFVJUHJvY2Vzcy9BUEkv Z2xpYi9XZWJLaXRXZWJzaXRlRGF0YU1hbmFnZXIuY3BwOgorICAgICAgICAod2Via2l0V2Vic2l0 ZURhdGFNYW5hZ2VyR2V0RGF0YVN0b3JlKToKKyAgICAgICAgKiBVSVByb2Nlc3MvV2ViUHJvY2Vz c1Bvb2wuY3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJQcm9jZXNzUG9vbDo6ZW5zdXJlTmV0d29y a1Byb2Nlc3MpOgorCiAyMDE5LTEyLTE2ICB5b3Vlbm4gZmFibGV0ICA8eW91ZW5uQGFwcGxlLmNv bT4KIAogICAgICAgICBSZXNldCBjYWNoZWQgZ2V0VXNlck1lZGlhIHF1ZXJpZXMgd2hlbiBjYWxs aW5nIHN0b3BNZWRpYUNhcHR1cmUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNz L0FQSS9nbGliL1dlYktpdFdlYnNpdGVEYXRhTWFuYWdlci5jcHAgYi9Tb3VyY2UvV2ViS2l0L1VJ UHJvY2Vzcy9BUEkvZ2xpYi9XZWJLaXRXZWJzaXRlRGF0YU1hbmFnZXIuY3BwCmluZGV4IGJmMDli OTJmZDUzLi45ODljNDMzOWZiYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3Mv QVBJL2dsaWIvV2ViS2l0V2Vic2l0ZURhdGFNYW5hZ2VyLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0 L1VJUHJvY2Vzcy9BUEkvZ2xpYi9XZWJLaXRXZWJzaXRlRGF0YU1hbmFnZXIuY3BwCkBAIC0zOTIs NiArMzkyLDggQEAgV2ViS2l0OjpXZWJzaXRlRGF0YVN0b3JlJiB3ZWJraXRXZWJzaXRlRGF0YU1h bmFnZXJHZXREYXRhU3RvcmUoV2ViS2l0V2Vic2l0ZURhdGEKICAgICAgICAgICAgIFdlYktpdDo6 V2Vic2l0ZURhdGFTdG9yZTo6ZGVmYXVsdE5ldHdvcmtDYWNoZURpcmVjdG9yeSgpIDogRmlsZVN5 c3RlbTo6cGF0aEJ5QXBwZW5kaW5nQ29tcG9uZW50KEZpbGVTeXN0ZW06OnN0cmluZ0Zyb21GaWxl U3lzdGVtUmVwcmVzZW50YXRpb24ocHJpdi0+ZGlza0NhY2hlRGlyZWN0b3J5LmdldCgpKSwgbmV0 d29ya0NhY2hlU3ViZGlyZWN0b3J5KSk7CiAgICAgICAgIGNvbmZpZ3VyYXRpb24tPnNldEFwcGxp Y2F0aW9uQ2FjaGVEaXJlY3RvcnkoIXByaXYtPmFwcGxpY2F0aW9uQ2FjaGVEaXJlY3RvcnkgPwog ICAgICAgICAgICAgV2ViS2l0OjpXZWJzaXRlRGF0YVN0b3JlOjpkZWZhdWx0QXBwbGljYXRpb25D YWNoZURpcmVjdG9yeSgpIDogRmlsZVN5c3RlbTo6c3RyaW5nRnJvbUZpbGVTeXN0ZW1SZXByZXNl bnRhdGlvbihwcml2LT5hcHBsaWNhdGlvbkNhY2hlRGlyZWN0b3J5LmdldCgpKSk7CisgICAgICAg IGNvbmZpZ3VyYXRpb24tPnNldEluZGV4ZWREQkRhdGFiYXNlRGlyZWN0b3J5KCFwcml2LT5pbmRl eGVkREJEaXJlY3RvcnkgPworICAgICAgICAgICAgV2ViS2l0OjpXZWJzaXRlRGF0YVN0b3JlOjpk ZWZhdWx0SW5kZXhlZERCRGF0YWJhc2VEaXJlY3RvcnkoKSA6IEZpbGVTeXN0ZW06OnN0cmluZ0Zy b21GaWxlU3lzdGVtUmVwcmVzZW50YXRpb24ocHJpdi0+aW5kZXhlZERCRGlyZWN0b3J5LmdldCgp KSk7CiAgICAgICAgIGNvbmZpZ3VyYXRpb24tPnNldFdlYlNRTERhdGFiYXNlRGlyZWN0b3J5KCFw cml2LT53ZWJTUUxEaXJlY3RvcnkgPwogICAgICAgICAgICAgV2ViS2l0OjpXZWJzaXRlRGF0YVN0 b3JlOjpkZWZhdWx0V2ViU1FMRGF0YWJhc2VEaXJlY3RvcnkoKSA6IEZpbGVTeXN0ZW06OnN0cmlu Z0Zyb21GaWxlU3lzdGVtUmVwcmVzZW50YXRpb24ocHJpdi0+d2ViU1FMRGlyZWN0b3J5LmdldCgp KSk7CiAgICAgICAgIGNvbmZpZ3VyYXRpb24tPnNldEhTVFNTdG9yYWdlRGlyZWN0b3J5KCFwcml2 LT5oc3RzQ2FjaGVEaXJlY3RvcnkgPwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9VSVByb2Nl c3MvV2ViUHJvY2Vzc1Bvb2wuY3BwIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvV2ViUHJvY2Vz c1Bvb2wuY3BwCmluZGV4IDM1YTU3YmU5MWU4Li4zZGViMGY4ZWQzYyAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYktpdC9VSVByb2Nlc3MvV2ViUHJvY2Vzc1Bvb2wuY3BwCisrKyBiL1NvdXJjZS9XZWJL aXQvVUlQcm9jZXNzL1dlYlByb2Nlc3NQb29sLmNwcApAQCAtNTM0LDcgKzUzNCw5IEBAIE5ldHdv cmtQcm9jZXNzUHJveHkmIFdlYlByb2Nlc3NQb29sOjplbnN1cmVOZXR3b3JrUHJvY2VzcyhXZWJz aXRlRGF0YVN0b3JlKiB3aXRoCiAgICAgLy8gKioqKioqKioqCiAgICAgLy8gSU1QT1JUQU5UOiBE byBub3QgY2hhbmdlIHRoZSBkaXJlY3Rvcnkgc3RydWN0dXJlIGZvciBpbmRleGVkIGRhdGFiYXNl cyBvbiBkaXNrIHdpdGhvdXQgZmlyc3QgY29uc3VsdGluZyBhIHJldmlld2VyIGZyb20gQXBwbGUg KDxyZGFyOi8vcHJvYmxlbS8xNzQ1NDcxMj4pCiAgICAgLy8gKioqKioqKioqCi0gICAgaWYgKFdl YktpdDo6V2Vic2l0ZURhdGFTdG9yZTo6ZGVmYXVsdERhdGFTdG9yZUV4aXN0cygpKQorICAgIGlm IChtX3dlYnNpdGVEYXRhU3RvcmUpCisgICAgICAgIHBhcmFtZXRlcnMuZGVmYXVsdERhdGFTdG9y ZVBhcmFtZXRlcnMuaW5kZXhlZERhdGFiYXNlRGlyZWN0b3J5ID0gbV93ZWJzaXRlRGF0YVN0b3Jl LT5yZXNvbHZlZEluZGV4ZWREYXRhYmFzZURpcmVjdG9yeSgpOworICAgIGVsc2UgaWYgKFdlYktp dDo6V2Vic2l0ZURhdGFTdG9yZTo6ZGVmYXVsdERhdGFTdG9yZUV4aXN0cygpKQogICAgICAgICBw YXJhbWV0ZXJzLmRlZmF1bHREYXRhU3RvcmVQYXJhbWV0ZXJzLmluZGV4ZWREYXRhYmFzZURpcmVj dG9yeSA9IFdlYktpdDo6V2Vic2l0ZURhdGFTdG9yZTo6ZGVmYXVsdERhdGFTdG9yZSgpLT5wYXJh bWV0ZXJzKCkuaW5kZXhlZERhdGFiYXNlRGlyZWN0b3J5OwogICAgIAogICAgIGlmICghcGFyYW1l dGVycy5kZWZhdWx0RGF0YVN0b3JlUGFyYW1ldGVycy5pbmRleGVkRGF0YWJhc2VEaXJlY3Rvcnku aXNFbXB0eSgpKSB7Cg==