205320 2019-12-16 19:19:33 -0800 Update Check webkit style to allow for auto with pairs in c++ 2019-12-17 13:07:38 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 megan_gardner megan_gardner commit-queue ews-watchlist glenn jbedard thorton webkit-bug-importer oldest_to_newest 1599254 0 megan_gardner 2019-12-16 19:19:33 -0800 Update Check webkit style to allow for auto with pairs in c++ 1599255 1 385846 megan_gardner 2019-12-16 19:23:28 -0800 Created attachment 385846 Patch 1599256 2 webkit-bug-importer 2019-12-16 19:24:35 -0800 <rdar://problem/57994384> 1599403 3 385846 jbedard 2019-12-17 07:06:42 -0800 Comment on attachment 385846 Patch Can we either add a test, or update an existing test in Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py for this? 1599452 4 385898 megan_gardner 2019-12-17 09:57:49 -0800 Created attachment 385898 Patch 1599524 5 385898 commit-queue 2019-12-17 13:07:36 -0800 Comment on attachment 385898 Patch Clearing flags on attachment: 385898 Committed r253641: <https://trac.webkit.org/changeset/253641> 1599525 6 commit-queue 2019-12-17 13:07:38 -0800 All reviewed patches have been landed. Closing bug. 385846 2019-12-16 19:23:28 -0800 2019-12-17 09:57:48 -0800 Patch bug-205320-20191216192327.patch text/plain 1623 megan_gardner U3VidmVyc2lvbiBSZXZpc2lvbjogMjUzNjA4CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggOWVkYjQwMTExZTVkZGQ1NjBjYTgzZWVkZGUxZmJjYWNm NDJkZWQ0NC4uZDhjYTI3MmQ3NWMzNDI0YTU3ZDUwZDU4MGUxN2NmNzUxNjdhYWMxYiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1 IEBACisyMDE5LTEyLTE2ICBNZWdhbiBHYXJkbmVyICA8bWVnYW5fZ2FyZG5lckBhcHBsZS5jb20+ CisKKyAgICAgICAgVXBkYXRlIENoZWNrIHdlYmtpdCBzdHlsZSB0byBhbGxvdyBmb3IgYXV0byB3 aXRoIHBhaXJzIGluIGMrKworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MjA1MzIwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgQWxsb3cgZm9yIHNwYWNlcyBiZXR3ZWVuIGF1dG8gYW5kIGJyYWtldHMgd2hlbiB1 c2luZyBhdXRvIHdpdGggcGFpcnMuCisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L3N0eWxl L2NoZWNrZXJzL2NwcC5weToKKyAgICAgICAgKGNoZWNrX3NwYWNpbmcpOgorCiAyMDE5LTEyLTE2 ICBXZW5zb24gSHNpZWggIDx3ZW5zb25faHNpZWhAYXBwbGUuY29tPgogCiAgICAgICAgIC1bVUlX S0RvY3VtZW50Q29udGV4dCBtYXJrZWRUZXh0UmFuZ2VdIGlzIHdyb25nIHdoZW4gdGhlIGNhcmV0 IGlzIG5vdCBhdCB0aGUgc3RhcnQgb2YgbWFya2VkIHRleHQKZGlmZiAtLWdpdCBhL1Rvb2xzL1Nj cmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcnMvY3BwLnB5IGIvVG9vbHMvU2NyaXB0cy93ZWJr aXRweS9zdHlsZS9jaGVja2Vycy9jcHAucHkKaW5kZXggZTEyNjE3ZWUzMzVhYjIwZTY5ZDY4NDc0 MGQ0ZTU1Yzg5YTA2NmU2NC4uZDI0YjRlNjI1ODkzMjg5NmM2NmQzMWZhZThiYWI2N2IwNGNhOTI1 NyAxMDA2NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2Vycy9jcHAu cHkKKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2Vycy9jcHAucHkKQEAg LTIwNzAsNyArMjA3MCw3IEBAIGRlZiBjaGVja19zcGFjaW5nKGZpbGVfZXh0ZW5zaW9uLCBjbGVh bl9saW5lcywgbGluZV9udW1iZXIsIGZpbGVfc3RhdGUsIGVycm9yKToKICAgICAjICdkZWxldGUg W10nIG9yICduZXcgY2hhciAqIFtdJy4gT2JqZWN0aXZlLUMgY2FuJ3QgZm9sbG93IHRoaXMgcnVs ZQogICAgICMgYmVjYXVzZSBvZiBtZXRob2QgY2FsbHMuCiAgICAgaWYgZmlsZV9leHRlbnNpb24g IT0gJ21tJyBhbmQgZmlsZV9leHRlbnNpb24gIT0gJ20nOgotICAgICAgICBpZiBzZWFyY2gocidc d1xzK1xbJywgbGluZSkgYW5kIG5vdCBzZWFyY2gocicoZGVsZXRlfHJldHVybilccytcWycsIGxp bmUpOgorICAgICAgICBpZiBzZWFyY2gocidcd1xzK1xbJywgbGluZSkgYW5kIG5vdCBzZWFyY2go cicoZGVsZXRlfHJldHVybnxhdXRvKVxzK1xbJywgbGluZSk6CiAgICAgICAgICAgICBlcnJvcihs aW5lX251bWJlciwgJ3doaXRlc3BhY2UvYnJhY2tldHMnLCA1LAogICAgICAgICAgICAgICAgICAg J0V4dHJhIHNwYWNlIGJlZm9yZSBbLicpCiAK 385898 2019-12-17 09:57:49 -0800 2019-12-17 13:07:36 -0800 Patch bug-205320-20191217095748.patch text/plain 2528 megan_gardner U3VidmVyc2lvbiBSZXZpc2lvbjogMjUzNjA4CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggOWVkYjQwMTExZTVkZGQ1NjBjYTgzZWVkZGUxZmJjYWNm NDJkZWQ0NC4uYTU4MzMyNzk2ZDljM2U0YmY3NTBlOTRjYmFmZmE2ZTA5MjJhNGI2NyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3 IEBACisyMDE5LTEyLTE3ICBNZWdhbiBHYXJkbmVyICA8bWVnYW5fZ2FyZG5lckBhcHBsZS5jb20+ CisKKyAgICAgICAgVXBkYXRlIENoZWNrIHdlYmtpdCBzdHlsZSB0byBhbGxvdyBmb3IgYXV0byB3 aXRoIHBhaXJzIGluIGMrKworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MjA1MzIwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgQWxsb3cgZm9yIHNwYWNlcyBiZXR3ZWVuIGF1dG8gYW5kIGJyYWtldHMgd2hlbiB1 c2luZyBhdXRvIHdpdGggcGFpcnMuCisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L3N0eWxl L2NoZWNrZXJzL2NwcC5weToKKyAgICAgICAgKGNoZWNrX3NwYWNpbmcpOgorICAgICAgICAqIFNj cmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcnMvY3BwX3VuaXR0ZXN0LnB5OgorICAgICAgICAo Q3BwU3R5bGVUZXN0KToKKwogMjAxOS0xMi0xNiAgV2Vuc29uIEhzaWVoICA8d2Vuc29uX2hzaWVo QGFwcGxlLmNvbT4KIAogICAgICAgICAtW1VJV0tEb2N1bWVudENvbnRleHQgbWFya2VkVGV4dFJh bmdlXSBpcyB3cm9uZyB3aGVuIHRoZSBjYXJldCBpcyBub3QgYXQgdGhlIHN0YXJ0IG9mIG1hcmtl ZCB0ZXh0CmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJz L2NwcC5weSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcnMvY3BwLnB5Cmlu ZGV4IGUxMjYxN2VlMzM1YWIyMGU2OWQ2ODQ3NDBkNGU1NWM4OWEwNjZlNjQuLmQyNGI0ZTYyNTg5 MzI4OTZjNjZkMzFmYWU4YmFiNjdiMDRjYTkyNTcgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMv d2Via2l0cHkvc3R5bGUvY2hlY2tlcnMvY3BwLnB5CisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0 cHkvc3R5bGUvY2hlY2tlcnMvY3BwLnB5CkBAIC0yMDcwLDcgKzIwNzAsNyBAQCBkZWYgY2hlY2tf c3BhY2luZyhmaWxlX2V4dGVuc2lvbiwgY2xlYW5fbGluZXMsIGxpbmVfbnVtYmVyLCBmaWxlX3N0 YXRlLCBlcnJvcik6CiAgICAgIyAnZGVsZXRlIFtdJyBvciAnbmV3IGNoYXIgKiBbXScuIE9iamVj dGl2ZS1DIGNhbid0IGZvbGxvdyB0aGlzIHJ1bGUKICAgICAjIGJlY2F1c2Ugb2YgbWV0aG9kIGNh bGxzLgogICAgIGlmIGZpbGVfZXh0ZW5zaW9uICE9ICdtbScgYW5kIGZpbGVfZXh0ZW5zaW9uICE9 ICdtJzoKLSAgICAgICAgaWYgc2VhcmNoKHInXHdccytcWycsIGxpbmUpIGFuZCBub3Qgc2VhcmNo KHInKGRlbGV0ZXxyZXR1cm4pXHMrXFsnLCBsaW5lKToKKyAgICAgICAgaWYgc2VhcmNoKHInXHdc cytcWycsIGxpbmUpIGFuZCBub3Qgc2VhcmNoKHInKGRlbGV0ZXxyZXR1cm58YXV0bylccytcWycs IGxpbmUpOgogICAgICAgICAgICAgZXJyb3IobGluZV9udW1iZXIsICd3aGl0ZXNwYWNlL2JyYWNr ZXRzJywgNSwKICAgICAgICAgICAgICAgICAgICdFeHRyYSBzcGFjZSBiZWZvcmUgWy4nKQogCmRp ZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJzL2NwcF91bml0 dGVzdC5weSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcnMvY3BwX3VuaXR0 ZXN0LnB5CmluZGV4IDA3NDYyOGY3ODZhZjk2YTJjZDhhNGE5YzhhNmJjNWQ2NWEwOTdkYzkuLjM0 MGU0OTI5NTc5MGNmOTI2MTQ4MDk3YTk3YmIxNThmN2M3MDg0MGYgMTAwNjQ0Ci0tLSBhL1Rvb2xz L1NjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcnMvY3BwX3VuaXR0ZXN0LnB5CisrKyBiL1Rv b2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcnMvY3BwX3VuaXR0ZXN0LnB5CkBAIC0y MTI1LDYgKzIxMjUsNyBAQCBjbGFzcyBDcHBTdHlsZVRlc3QoQ3BwU3R5bGVUZXN0QmFzZSk6CiAK ICAgICBkZWYgdGVzdF9zcGFjaW5nX2JlZm9yZV9icmFja2V0cyhzZWxmKToKICAgICAgICAgc2Vs Zi5hc3NlcnRfbGludCgnZGVsZXRlIFtdIGJhc2U7JywgJycpCisgICAgICAgIHNlbGYuYXNzZXJ0 X2xpbnQoJ2F1dG8gW2ZvbywgYmFyXSA9IGdldEZvb0FuZEJhcigpOycsICcnKQogICAgICAgICAj IFNlZSBTT0ZUX0xJTktfQ0xBU1NfRk9SX0hFQURFUigpIG1hY3JvIGluIFNvZnRMaW5raW5nLmgu CiAgICAgICAgIHNlbGYuYXNzZXJ0X2xpbnQoJyAgICAgICAgcmV0dXJuIFtnZXRfIyNmcmFtZXdv cmsjI18jI2NsYXNzTmFtZSMjQ2xhc3MoKSBhbGxvY107IFxcJywgJycpCiAgICAgICAgIHNlbGYu YXNzZXJ0X2xpbnQoJyAgICAgICAgbV90YXNrRnVuY3Rpb24gPSBbY2FsbGVlLCBtZXRob2QsIGFy Z3VtZW50cy4uLl0geycsICcnKQo=