205306 2019-12-16 15:16:06 -0800 ANGLE: Fix last WebGL conformance regressions 2020-03-11 17:12:09 -0700 1 1 1 Unclassified WebKit ANGLE WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 198948 1 jdarpinian jdarpinian achristensen cdumez commit-queue dino esprehn+autocc ews-watchlist graouts gyuyoung.kim justin_fan kbr kondapallykalyan webkit-bug-importer oldest_to_newest 1599150 0 jdarpinian 2019-12-16 15:16:06 -0800 ANGLE: Fix last WebGL conformance regressions 1599152 1 385815 jdarpinian 2019-12-16 15:19:41 -0800 Created attachment 385815 ANGLE: Fix last WebGL conformance regressions 1599190 2 kbr 2019-12-16 16:07:54 -0800 Fantastic work James! Could you add a comment here with the names of the tests that are now fixed? 1599195 3 jdarpinian 2019-12-16 16:20:11 -0800 non-ascii-comments.vert.html for the non-ascii comments fix. For the alpha:false antialias:true fix, I don't have a list of the fixed tests, it was a bunch of random ones that just happened to use that combination. 1599535 4 justin_fan 2019-12-17 13:18:52 -0800 r=me! I've pinged Dean since I'm not an official reviewer. 1599581 5 385815 commit-queue 2019-12-17 15:18:34 -0800 Comment on attachment 385815 ANGLE: Fix last WebGL conformance regressions Rejecting attachment 385815 from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'validate-changelog', '--check-oops', '--non-interactive', 385815, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit /Volumes/Data/EWS/WebKit/Source/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: https://webkit-queues.webkit.org/results/13292616 1599620 6 385928 jdarpinian 2019-12-17 16:34:30 -0800 Created attachment 385928 Fix missing Reviewed by line in ChangeLog 1599621 7 jdarpinian 2019-12-17 16:35:39 -0800 Sorry, I accidentally removed the "Reviewed by" line in my changelog. 1600417 8 385928 commit-queue 2019-12-19 12:04:21 -0800 Comment on attachment 385928 Fix missing Reviewed by line in ChangeLog Clearing flags on attachment: 385928 Committed r253779: <https://trac.webkit.org/changeset/253779> 1600418 9 commit-queue 2019-12-19 12:04:23 -0800 All reviewed patches have been landed. Closing bug. 1600420 10 webkit-bug-importer 2019-12-19 12:05:49 -0800 <rdar://problem/58087484> 385815 2019-12-16 15:19:41 -0800 2019-12-17 16:34:28 -0800 ANGLE: Fix last WebGL conformance regressions bug-205306-20191216151940.patch text/plain 3221 jdarpinian U3VidmVyc2lvbiBSZXZpc2lvbjogMjUzNTcxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNmZkOTQxYjE4YjEwZmE3 MmYwMTFhZjAyMWU4MmM5NTgxZmY1NzdmNC4uOTUxN2E3Mjk4NzY0ZWQ2ODQwNDEyZjRkNWY4OGNj MzljYjE0NTZjOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE5LTEyLTE2ICBKYW1l cyBEYXJwaW5pYW4gIDxqZGFycGluaWFuQGNocm9taXVtLm9yZz4KKworICAgICAgICBBTkdMRTog Rml4IGxhc3QgV2ViR0wgY29uZm9ybWFuY2UgcmVncmVzc2lvbnMKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwNTMwNgorCisgICAgICAgIEZpeGVzIHRo ZSBsYXN0IGZldyBXZWJHTCBjb25mb3JtYW5jZSByZWdyZXNzaW9ucyB3aGVuIGVuYWJsaW5nIEFO R0xFIG9uIEFNRCBHUFVzIG9uIE1hYy4KKyAgICAgICAgVGhlIGNvbWJpbmF0aW9uIG9mIGFscGhh OmZhbHNlIGFuZCBhbnRpYWxpYXM6dHJ1ZSB3YXMgYnJva2VuLCBhbmQgdmFsaWRhdGlvbiBvZgor ICAgICAgICBub24tYXNjaWkgY2hhcmFjdGVycyBpbiBjb21tZW50cyB3YXMgYnJva2VuIGJ5IGEg cmVjZW50IGNoYW5nZSB0byB0aGUgdGVzdC4KKworICAgICAgICAqIGh0bWwvY2FudmFzL1dlYkdM UmVuZGVyaW5nQ29udGV4dEJhc2UuY3BwOgorICAgICAgICAoV2ViQ29yZTo6V2ViR0xSZW5kZXJp bmdDb250ZXh0QmFzZTo6c2hhZGVyU291cmNlKToKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGlj cy9hbmdsZS9HcmFwaGljc0NvbnRleHQzREFOR0xFLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6Okdy YXBoaWNzQ29udGV4dDNEOjpyZXNoYXBlRkJPcyk6CisKIDIwMTktMTItMTYgIEFudHRpIEtvaXZp c3RvICA8YW50dGlAYXBwbGUuY29tPgogCiAgICAgICAgIFJlbW92ZSBkaXNwbGF5OmNvbnRlbnRz IGZlYXR1cmUgZmxhZwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaHRtbC9jYW52YXMvV2Vi R0xSZW5kZXJpbmdDb250ZXh0QmFzZS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL2NhbnZhcy9X ZWJHTFJlbmRlcmluZ0NvbnRleHRCYXNlLmNwcAppbmRleCA5MzlhYmI4OWQ2NTczMjMzYmUxMjBh YTU5ZDcyMGE5MDQzODYyYzI3Li5hYzdlNmFlYWUzOWU5YzZmZGYxZmUzZTBiMTdiZjUwZTVhZTA3 NTQwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9odG1sL2NhbnZhcy9XZWJHTFJlbmRlcmlu Z0NvbnRleHRCYXNlLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL2NhbnZhcy9XZWJHTFJl bmRlcmluZ0NvbnRleHRCYXNlLmNwcApAQCAtMzY0OCwxMSArMzY0OCwxNSBAQCB2b2lkIFdlYkdM UmVuZGVyaW5nQ29udGV4dEJhc2U6OnNoYWRlclNvdXJjZShXZWJHTFNoYWRlciogc2hhZGVyLCBj b25zdCBTdHJpbmcmCiB7CiAgICAgaWYgKGlzQ29udGV4dExvc3RPclBlbmRpbmcoKSB8fCAhdmFs aWRhdGVXZWJHTE9iamVjdCgic2hhZGVyU291cmNlIiwgc2hhZGVyKSkKICAgICAgICAgcmV0dXJu OworI2lmIFVTRShBTkdMRSkKKyAgICBtX2NvbnRleHQtPnNoYWRlclNvdXJjZShvYmplY3RPclpl cm8oc2hhZGVyKSwgc3RyaW5nKTsKKyNlbHNlCiAgICAgU3RyaW5nIHN0cmluZ1dpdGhvdXRDb21t ZW50cyA9IFN0cmlwQ29tbWVudHMoc3RyaW5nKS5yZXN1bHQoKTsKICAgICBpZiAoIXZhbGlkYXRl U3RyaW5nKCJzaGFkZXJTb3VyY2UiLCBzdHJpbmdXaXRob3V0Q29tbWVudHMpKQogICAgICAgICBy ZXR1cm47Ci0gICAgc2hhZGVyLT5zZXRTb3VyY2Uoc3RyaW5nKTsKICAgICBtX2NvbnRleHQtPnNo YWRlclNvdXJjZShvYmplY3RPclplcm8oc2hhZGVyKSwgc3RyaW5nV2l0aG91dENvbW1lbnRzKTsK KyNlbmRpZgorICAgIHNoYWRlci0+c2V0U291cmNlKHN0cmluZyk7CiB9CiAKIHZvaWQgV2ViR0xS ZW5kZXJpbmdDb250ZXh0QmFzZTo6c3RlbmNpbEZ1bmMoR0MzRGVudW0gZnVuYywgR0MzRGludCBy ZWYsIEdDM0R1aW50IG1hc2spCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9n cmFwaGljcy9hbmdsZS9HcmFwaGljc0NvbnRleHQzREFOR0xFLmNwcCBiL1NvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL2dyYXBoaWNzL2FuZ2xlL0dyYXBoaWNzQ29udGV4dDNEQU5HTEUuY3BwCmluZGV4 IDZiNWJlMTA0YmQwM2NhZDYzN2VjMjAyZTc5MzkxZGZjMTM2ZDQ5MGEuLjk2OGE4NzUyOGNjMjNk NjkzZmY0YjExMjc2MWMxNDRlNTE1NWQ0NzAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL2dyYXBoaWNzL2FuZ2xlL0dyYXBoaWNzQ29udGV4dDNEQU5HTEUuY3BwCisrKyBiL1Nv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2FuZ2xlL0dyYXBoaWNzQ29udGV4dDNEQU5H TEUuY3BwCkBAIC0xNjUsNyArMTY1LDcgQEAgYm9vbCBHcmFwaGljc0NvbnRleHQzRDo6cmVzaGFw ZUZCT3MoY29uc3QgSW50U2l6ZSYgc2l6ZSkKICAgICAgICAgR0xpbnQgc2FtcGxlQ291bnQgPSBz dGQ6Om1pbig0LCBtYXhTYW1wbGVDb3VudCk7CiAgICAgICAgIGdsOjpCaW5kRnJhbWVidWZmZXIo R0xfRlJBTUVCVUZGRVIsIG1fbXVsdGlzYW1wbGVGQk8pOwogICAgICAgICBnbDo6QmluZFJlbmRl cmJ1ZmZlcihHTF9SRU5ERVJCVUZGRVIsIG1fbXVsdGlzYW1wbGVDb2xvckJ1ZmZlcik7Ci0gICAg ICAgIGdldEV4dGVuc2lvbnMoKS5yZW5kZXJidWZmZXJTdG9yYWdlTXVsdGlzYW1wbGUoR0xfUkVO REVSQlVGRkVSLCBzYW1wbGVDb3VudCwgR0xfUkdCQTgsIHdpZHRoLCBoZWlnaHQpOworICAgICAg ICBnZXRFeHRlbnNpb25zKCkucmVuZGVyYnVmZmVyU3RvcmFnZU11bHRpc2FtcGxlKEdMX1JFTkRF UkJVRkZFUiwgc2FtcGxlQ291bnQsIG1faW50ZXJuYWxDb2xvckZvcm1hdCwgd2lkdGgsIGhlaWdo dCk7CiAgICAgICAgIGdsOjpGcmFtZWJ1ZmZlclJlbmRlcmJ1ZmZlcihHTF9GUkFNRUJVRkZFUiwg R0xfQ09MT1JfQVRUQUNITUVOVDAsIEdMX1JFTkRFUkJVRkZFUiwgbV9tdWx0aXNhbXBsZUNvbG9y QnVmZmVyKTsKICAgICAgICAgaWYgKG1fYXR0cnMuc3RlbmNpbCB8fCBtX2F0dHJzLmRlcHRoKSB7 CiAgICAgICAgICAgICBnbDo6QmluZFJlbmRlcmJ1ZmZlcihHTF9SRU5ERVJCVUZGRVIsIG1fbXVs dGlzYW1wbGVEZXB0aFN0ZW5jaWxCdWZmZXIpOwo= 385928 2019-12-17 16:34:30 -0800 2019-12-19 12:04:21 -0800 Fix missing Reviewed by line in ChangeLog bug-205306-20191217163429.patch text/plain 3260 jdarpinian U3VidmVyc2lvbiBSZXZpc2lvbjogMjUzNTcxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNmZkOTQxYjE4YjEwZmE3 MmYwMTFhZjAyMWU4MmM5NTgxZmY1NzdmNC4uNmRkYTQxYzQwZWEyNTA4ZDk3MDFkNzgxMDM1ZGM5 ZDBmMjk1ZmY5MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDE5LTEyLTE2ICBKYW1l cyBEYXJwaW5pYW4gIDxqZGFycGluaWFuQGNocm9taXVtLm9yZz4KKworICAgICAgICBBTkdMRTog Rml4IGxhc3QgV2ViR0wgY29uZm9ybWFuY2UgcmVncmVzc2lvbnMKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwNTMwNgorCisgICAgICAgIEZpeGVzIHRo ZSBsYXN0IGZldyBXZWJHTCBjb25mb3JtYW5jZSByZWdyZXNzaW9ucyB3aGVuIGVuYWJsaW5nIEFO R0xFIG9uIEFNRCBHUFVzIG9uIE1hYy4KKyAgICAgICAgVGhlIGNvbWJpbmF0aW9uIG9mIGFscGhh OmZhbHNlIGFuZCBhbnRpYWxpYXM6dHJ1ZSB3YXMgYnJva2VuLCBhbmQgdmFsaWRhdGlvbiBvZgor ICAgICAgICBub24tYXNjaWkgY2hhcmFjdGVycyBpbiBjb21tZW50cyB3YXMgYnJva2VuIGJ5IGEg cmVjZW50IGNoYW5nZSB0byB0aGUgdGVzdC4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICAqIGh0bWwvY2FudmFzL1dlYkdMUmVuZGVyaW5nQ29udGV4dEJh c2UuY3BwOgorICAgICAgICAoV2ViQ29yZTo6V2ViR0xSZW5kZXJpbmdDb250ZXh0QmFzZTo6c2hh ZGVyU291cmNlKToKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9hbmdsZS9HcmFwaGljc0Nv bnRleHQzREFOR0xFLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkdyYXBoaWNzQ29udGV4dDNEOjpy ZXNoYXBlRkJPcyk6CisKIDIwMTktMTItMTYgIEFudHRpIEtvaXZpc3RvICA8YW50dGlAYXBwbGUu Y29tPgogCiAgICAgICAgIFJlbW92ZSBkaXNwbGF5OmNvbnRlbnRzIGZlYXR1cmUgZmxhZwpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaHRtbC9jYW52YXMvV2ViR0xSZW5kZXJpbmdDb250ZXh0 QmFzZS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL2NhbnZhcy9XZWJHTFJlbmRlcmluZ0NvbnRl eHRCYXNlLmNwcAppbmRleCA5MzlhYmI4OWQ2NTczMjMzYmUxMjBhYTU5ZDcyMGE5MDQzODYyYzI3 Li5hYzdlNmFlYWUzOWU5YzZmZGYxZmUzZTBiMTdiZjUwZTVhZTA3NTQwIDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViQ29yZS9odG1sL2NhbnZhcy9XZWJHTFJlbmRlcmluZ0NvbnRleHRCYXNlLmNwcAor KysgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL2NhbnZhcy9XZWJHTFJlbmRlcmluZ0NvbnRleHRCYXNl LmNwcApAQCAtMzY0OCwxMSArMzY0OCwxNSBAQCB2b2lkIFdlYkdMUmVuZGVyaW5nQ29udGV4dEJh c2U6OnNoYWRlclNvdXJjZShXZWJHTFNoYWRlciogc2hhZGVyLCBjb25zdCBTdHJpbmcmCiB7CiAg ICAgaWYgKGlzQ29udGV4dExvc3RPclBlbmRpbmcoKSB8fCAhdmFsaWRhdGVXZWJHTE9iamVjdCgi c2hhZGVyU291cmNlIiwgc2hhZGVyKSkKICAgICAgICAgcmV0dXJuOworI2lmIFVTRShBTkdMRSkK KyAgICBtX2NvbnRleHQtPnNoYWRlclNvdXJjZShvYmplY3RPclplcm8oc2hhZGVyKSwgc3RyaW5n KTsKKyNlbHNlCiAgICAgU3RyaW5nIHN0cmluZ1dpdGhvdXRDb21tZW50cyA9IFN0cmlwQ29tbWVu dHMoc3RyaW5nKS5yZXN1bHQoKTsKICAgICBpZiAoIXZhbGlkYXRlU3RyaW5nKCJzaGFkZXJTb3Vy Y2UiLCBzdHJpbmdXaXRob3V0Q29tbWVudHMpKQogICAgICAgICByZXR1cm47Ci0gICAgc2hhZGVy LT5zZXRTb3VyY2Uoc3RyaW5nKTsKICAgICBtX2NvbnRleHQtPnNoYWRlclNvdXJjZShvYmplY3RP clplcm8oc2hhZGVyKSwgc3RyaW5nV2l0aG91dENvbW1lbnRzKTsKKyNlbmRpZgorICAgIHNoYWRl ci0+c2V0U291cmNlKHN0cmluZyk7CiB9CiAKIHZvaWQgV2ViR0xSZW5kZXJpbmdDb250ZXh0QmFz ZTo6c3RlbmNpbEZ1bmMoR0MzRGVudW0gZnVuYywgR0MzRGludCByZWYsIEdDM0R1aW50IG1hc2sp CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9hbmdsZS9HcmFw aGljc0NvbnRleHQzREFOR0xFLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNz L2FuZ2xlL0dyYXBoaWNzQ29udGV4dDNEQU5HTEUuY3BwCmluZGV4IDZiNWJlMTA0YmQwM2NhZDYz N2VjMjAyZTc5MzkxZGZjMTM2ZDQ5MGEuLjk2OGE4NzUyOGNjMjNkNjkzZmY0YjExMjc2MWMxNDRl NTE1NWQ0NzAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Fu Z2xlL0dyYXBoaWNzQ29udGV4dDNEQU5HTEUuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL2dyYXBoaWNzL2FuZ2xlL0dyYXBoaWNzQ29udGV4dDNEQU5HTEUuY3BwCkBAIC0xNjUsNyAr MTY1LDcgQEAgYm9vbCBHcmFwaGljc0NvbnRleHQzRDo6cmVzaGFwZUZCT3MoY29uc3QgSW50U2l6 ZSYgc2l6ZSkKICAgICAgICAgR0xpbnQgc2FtcGxlQ291bnQgPSBzdGQ6Om1pbig0LCBtYXhTYW1w bGVDb3VudCk7CiAgICAgICAgIGdsOjpCaW5kRnJhbWVidWZmZXIoR0xfRlJBTUVCVUZGRVIsIG1f bXVsdGlzYW1wbGVGQk8pOwogICAgICAgICBnbDo6QmluZFJlbmRlcmJ1ZmZlcihHTF9SRU5ERVJC VUZGRVIsIG1fbXVsdGlzYW1wbGVDb2xvckJ1ZmZlcik7Ci0gICAgICAgIGdldEV4dGVuc2lvbnMo KS5yZW5kZXJidWZmZXJTdG9yYWdlTXVsdGlzYW1wbGUoR0xfUkVOREVSQlVGRkVSLCBzYW1wbGVD b3VudCwgR0xfUkdCQTgsIHdpZHRoLCBoZWlnaHQpOworICAgICAgICBnZXRFeHRlbnNpb25zKCku cmVuZGVyYnVmZmVyU3RvcmFnZU11bHRpc2FtcGxlKEdMX1JFTkRFUkJVRkZFUiwgc2FtcGxlQ291 bnQsIG1faW50ZXJuYWxDb2xvckZvcm1hdCwgd2lkdGgsIGhlaWdodCk7CiAgICAgICAgIGdsOjpG cmFtZWJ1ZmZlclJlbmRlcmJ1ZmZlcihHTF9GUkFNRUJVRkZFUiwgR0xfQ09MT1JfQVRUQUNITUVO VDAsIEdMX1JFTkRFUkJVRkZFUiwgbV9tdWx0aXNhbXBsZUNvbG9yQnVmZmVyKTsKICAgICAgICAg aWYgKG1fYXR0cnMuc3RlbmNpbCB8fCBtX2F0dHJzLmRlcHRoKSB7CiAgICAgICAgICAgICBnbDo6 QmluZFJlbmRlcmJ1ZmZlcihHTF9SRU5ERVJCVUZGRVIsIG1fbXVsdGlzYW1wbGVEZXB0aFN0ZW5j aWxCdWZmZXIpOwo=