<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>205298</bug_id>
          
          <creation_ts>2019-12-16 14:01:00 -0800</creation_ts>
          <short_desc>Re-tune JSC tests timeout value now that we can timeout based on CPU time.</short_desc>
          <delta_ts>2019-12-17 15:14:23 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>JavaScriptCore</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>ASSIGNED</bug_status>
          <resolution></resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          <dependson>205279</dependson>
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Mark Lam">mark.lam</reporter>
          <assigned_to name="Mark Lam">mark.lam</assigned_to>
          <cc>ap</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1599085</commentid>
    <comment_count>0</comment_count>
    <who name="Mark Lam">mark.lam</who>
    <bug_when>2019-12-16 14:01:00 -0800</bug_when>
    <thetext>Also
(1) investigate removing s_timeoutMultiplier.  It was only needed to pad the timeout value for some tests.
(2) investigate unskipping tests that were previously flaky due to timeouts.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1599577</commentid>
    <comment_count>1</comment_count>
    <who name="Mark Lam">mark.lam</who>
    <bug_when>2019-12-17 15:14:23 -0800</bug_when>
    <thetext>After playing with the timeout values for the JSC tests a bit, I came to the following conclusion:

(In reply to Mark Lam from comment #0)
&gt; Also
&gt; (1) investigate removing s_timeoutMultiplier.  It was only needed to pad the
&gt; timeout value for some tests.

We should keep this option because it allows us to grant more time to certain tests that are intrinsically long running, without having to lengthen the timeout value for all tests.

I also think we should not change the current timeout values.  Our tests are already tuned for these timeout values.  Shortening the timeout values will only cause more churn to add --timeoutMultipliers to the new tests that will start timing out.  I don&apos;t think there&apos;s much value in that given the current timeout value isn&apos;t prohibitively long.

&gt; (2) investigate unskipping tests that were previously flaky due to timeouts.

Still need to investigate this.</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>