205293 2019-12-16 12:19:34 -0800 Fix btjs on current lldb 2019-12-16 13:51:27 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 keith_miller keith_miller ap commit-queue jbedard mark.lam webkit-bug-importer oldest_to_newest 1599020 0 keith_miller 2019-12-16 12:19:34 -0800 Fix btjs on current lldb 1599022 1 385793 keith_miller 2019-12-16 12:19:53 -0800 Created attachment 385793 Patch 1599023 2 385793 mark.lam 2019-12-16 12:22:40 -0800 Comment on attachment 385793 Patch r=me 1599048 3 385793 commit-queue 2019-12-16 12:58:52 -0800 Comment on attachment 385793 Patch Clearing flags on attachment: 385793 Committed r253572: <https://trac.webkit.org/changeset/253572> 1599049 4 commit-queue 2019-12-16 12:58:53 -0800 All reviewed patches have been landed. Closing bug. 1599050 5 webkit-bug-importer 2019-12-16 12:59:18 -0800 <rdar://problem/57981841> 1599063 6 ap 2019-12-16 13:23:06 -0800 We have tests for lldb_webkit, can one be added here? 1599067 7 keith_miller 2019-12-16 13:30:53 -0800 (In reply to Alexey Proskuryakov from comment #6) > We have tests for lldb_webkit, can one be added here? I couldn't figure out how to get the tests to run. Do we run them in automation? 1599080 8 jbedard 2019-12-16 13:51:27 -0800 (In reply to Keith Miller from comment #7) > (In reply to Alexey Proskuryakov from comment #6) > > We have tests for lldb_webkit, can one be added here? > > I couldn't figure out how to get the tests to run. Do we run them in > automation? There is a script, test-lldb-webkit. No, they are not currently run in automation, but that is imminently changing (waiting on https://bugs.webkit.org/show_bug.cgi?id=205271 to land) 385793 2019-12-16 12:19:53 -0800 2019-12-16 12:58:52 -0800 Patch bug-205293-20191216121939.patch text/plain 3929 keith_miller U3VidmVyc2lvbiBSZXZpc2lvbjogMjUzNDQxCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggOTc4MTgyNjUxYjEyZjRhNzZiMmFlNTMzNTgyNGM5ZGRk MmJkODBiMi4uMjQ2ZjQzM2EyODIzOTY5YzJjNzY3MDRhZjU4MzU3OWM3YzIwY2Y0ZSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEz IEBACisyMDE5LTEyLTE2ICBLZWl0aCBNaWxsZXIgIDxrZWl0aF9taWxsZXJAYXBwbGUuY29tPgor CisgICAgICAgIEZpeCBidGpzIG9uIGN1cnJlbnQgbGxkYgorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjA1MjkzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBsbGRiL2xsZGJfd2Via2l0LnB5OgorICAgICAg ICAoYnRqcyk6CisKIDIwMTktMTItMTIgIFBlciBBcm5lIFZvbGxhbiAgPHB2b2xsYW5AYXBwbGUu Y29tPgogCiAgICAgICAgIFtpT1NdIERlbnkgbWFjaCBsb29rdXAgYWNjZXNzIHRvIGNvbnRlbnQg ZmlsdGVyIHNlcnZpY2UgaW4gdGhlIFdlYkNvbnRlbnQgc2FuZGJveApkaWZmIC0tZ2l0IGEvVG9v bHMvbGxkYi9sbGRiX3dlYmtpdC5weSBiL1Rvb2xzL2xsZGIvbGxkYl93ZWJraXQucHkKaW5kZXgg MWI0ZWI5ODE4NTFiZmU2ZjQzYmU1ZWZkYzg2ZDAzYjBkZmM2YTQ5YS4uY2I2YzNjN2IwNTFkMDNl ZWI0ZDViOGE3ZWNhZmM3NDA1NDI5YWFiYyAxMDA2NDQKLS0tIGEvVG9vbHMvbGxkYi9sbGRiX3dl YmtpdC5weQorKysgYi9Ub29scy9sbGRiL2xsZGJfd2Via2l0LnB5CkBAIC0yNjksMTMgKzI2OSwx MyBAQCBkZWYgYnRqcyhkZWJ1Z2dlciwgY29tbWFuZCwgcmVzdWx0LCBpbnRlcm5hbF9kaWN0KToK ICAgICBwcm9jZXNzID0gdGFyZ2V0LkdldFByb2Nlc3MoKQogICAgIHRocmVhZCA9IHByb2Nlc3Mu R2V0U2VsZWN0ZWRUaHJlYWQoKQogCi0gICAgaWYgdGFyZ2V0LkZpbmRGdW5jdGlvbnMoIkpTQzo6 RXhlY1N0YXRlOjpkZXNjcmliZUZyYW1lIikuR2V0U2l6ZSgpIG9yIHRhcmdldC5GaW5kRnVuY3Rp b25zKCJfWk4zSlNDOUV4ZWNTdGF0ZTEzZGVzY3JpYmVGcmFtZUV2IikuR2V0U2l6ZSgpOgorICAg IGlmIHRhcmdldC5GaW5kRnVuY3Rpb25zKCJKU0M6OkNhbGxGcmFtZTo6ZGVzY3JpYmVGcmFtZSIp LkdldFNpemUoKSBvciB0YXJnZXQuRmluZEZ1bmN0aW9ucygiX1pOM0pTQzlDYWxsRnJhbWUxM2Rl c2NyaWJlRnJhbWVFdiIpLkdldFNpemUoKToKICAgICAgICAgYW5ub3RhdGVKU0ZyYW1lcyA9IFRy dWUKICAgICBlbHNlOgogICAgICAgICBhbm5vdGF0ZUpTRnJhbWVzID0gRmFsc2UKIAogICAgIGlm IG5vdCBhbm5vdGF0ZUpTRnJhbWVzOgotICAgICAgICBwcmludCgiV2FybmluZzogQ2FuJ3QgZmlu ZCBKU0M6OkV4ZWNTdGF0ZTo6ZGVzY3JpYmVGcmFtZSgpIGluIGV4ZWN1dGFibGUgdG8gYW5ub3Rh dGUgSmF2YVNjcmlwdCBmcmFtZXMiKQorICAgICAgICBwcmludCgiV2FybmluZzogQ2FuJ3QgZmlu ZCBKU0M6OkNhbGxGcmFtZTo6ZGVzY3JpYmVGcmFtZSgpIGluIGV4ZWN1dGFibGUgdG8gYW5ub3Rh dGUgSmF2YVNjcmlwdCBmcmFtZXMiKQogCiAgICAgYmFja3RyYWNlRGVwdGggPSB0aHJlYWQuR2V0 TnVtRnJhbWVzKCkKIApAQCAtMjg2LDcgKzI4Niw4IEBAIGRlZiBidGpzKGRlYnVnZ2VyLCBjb21t YW5kLCByZXN1bHQsIGludGVybmFsX2RpY3QpOgogICAgICAgICAgICAgcmV0dXJuCiAKICAgICB0 aHJlYWRGb3JtYXQgPSAnKiB0aHJlYWQgI3tudW19OiB0aWQgPSB7dGlkOiN4fSwge3BjQWRkcjon ICsgYWRkcmVzc0Zvcm1hdCArICd9LCBxdWV1ZSA9IFwne3F1ZXVlTmFtZX0sIHN0b3AgcmVhc29u ID0ge3N0b3BSZWFzb259JwotICAgIHByaW50KHRocmVhZEZvcm1hdC5mb3JtYXQobnVtPXRocmVh ZC5HZXRJbmRleElEKCksIHRpZD10aHJlYWQuR2V0VGhyZWFkSUQoKSwgcGNBZGRyPXRocmVhZC5H ZXRGcmFtZUF0SW5kZXgoMCkuR2V0UEMoKSwgcXVldWVOYW1lPXRocmVhZC5HZXRRdWV1ZU5hbWUo KSwgc3RvcFJlYXNvbj10aHJlYWQuR2V0U3RvcERlc2NyaXB0aW9uKDMwKSkpCisgICAgIyBGSVhN RTogR2V0U3RvcERlc2NyaXB0aW9uIG5lZWRzIHRvIGJlIHBhc3MgYSBzdHVwaWRseSBsYXJnZSBs ZW5ndGggYmVjYXVzZSBsbGRiIGhhcyB3ZWlyZCB1dGYtOCBlbmNvZGluZyBlcnJvcnMgaWYgaXQn cyB0b28gc21hbGwuIFNlZTogcmRhcjovL3Byb2JsZW0vNTc5ODA1OTkKKyAgICBwcmludCh0aHJl YWRGb3JtYXQuZm9ybWF0KG51bT10aHJlYWQuR2V0SW5kZXhJRCgpLCB0aWQ9dGhyZWFkLkdldFRo cmVhZElEKCksIHBjQWRkcj10aHJlYWQuR2V0RnJhbWVBdEluZGV4KDApLkdldFBDKCksIHF1ZXVl TmFtZT10aHJlYWQuR2V0UXVldWVOYW1lKCksIHN0b3BSZWFzb249dGhyZWFkLkdldFN0b3BEZXNj cmlwdGlvbigzMDApKSkKIAogICAgIGZvciBmcmFtZSBpbiB0aHJlYWQ6CiAgICAgICAgIGlmIGJh Y2t0cmFjZURlcHRoIDwgMToKQEAgLTI5OCwxMyArMjk5LDExIEBAIGRlZiBidGpzKGRlYnVnZ2Vy LCBjb21tYW5kLCByZXN1bHQsIGludGVybmFsX2RpY3QpOgogCiAgICAgICAgIGlmIGFubm90YXRl SlNGcmFtZXMgYW5kIG5vdCBmcmFtZSBvciBub3QgZnJhbWUuR2V0U3ltYm9sKCkgb3IgZnJhbWUu R2V0U3ltYm9sKCkuR2V0TmFtZSgpID09ICJsbGludF9lbnRyeSI6CiAgICAgICAgICAgICBjYWxs RnJhbWUgPSBmcmFtZS5HZXRTUCgpCi0gICAgICAgICAgICBKU0ZyYW1lRGVzY3JpcHRpb24gPSBm cmFtZS5FdmFsdWF0ZUV4cHJlc3Npb24oIigoSlNDOjpFeGVjU3RhdGUqKTB4JXgpLT5kZXNjcmli ZUZyYW1lKCkiICUgZnJhbWUuR2V0RlAoKSkuR2V0U3VtbWFyeSgpCisgICAgICAgICAgICBKU0Zy YW1lRGVzY3JpcHRpb24gPSBmcmFtZS5FdmFsdWF0ZUV4cHJlc3Npb24oIigoSlNDOjpDYWxsRnJh bWUqKTB4JXgpLT5kZXNjcmliZUZyYW1lKCkiICUgZnJhbWUuR2V0RlAoKSkuR2V0U3VtbWFyeSgp CiAgICAgICAgICAgICBpZiBub3QgSlNGcmFtZURlc2NyaXB0aW9uOgotICAgICAgICAgICAgICAg IEpTRnJhbWVEZXNjcmlwdGlvbiA9IGZyYW1lLkV2YWx1YXRlRXhwcmVzc2lvbigiKChKU0M6OkNh bGxGcmFtZSopMHgleCktPmRlc2NyaWJlRnJhbWUoKSIgJSBmcmFtZS5HZXRGUCgpKS5HZXRTdW1t YXJ5KCkKLSAgICAgICAgICAgIGlmIG5vdCBKU0ZyYW1lRGVzY3JpcHRpb246Ci0gICAgICAgICAg ICAgICAgSlNGcmFtZURlc2NyaXB0aW9uID0gZnJhbWUuRXZhbHVhdGVFeHByZXNzaW9uKCIoY2hh ciopX1pOM0pTQzlFeGVjU3RhdGUxM2Rlc2NyaWJlRnJhbWVFdigweCV4KSIgJSBmcmFtZS5HZXRG UCgpKS5HZXRTdW1tYXJ5KCkKKyAgICAgICAgICAgICAgICBKU0ZyYW1lRGVzY3JpcHRpb24gPSBm cmFtZS5FdmFsdWF0ZUV4cHJlc3Npb24oIihjaGFyKilfWk4zSlNDOUNhbGxGcmFtZTEzZGVzY3Jp YmVGcmFtZUV2KDB4JXgpIiAlIGZyYW1lLkdldEZQKCkpLkdldFN1bW1hcnkoKQogICAgICAgICAg ICAgaWYgSlNGcmFtZURlc2NyaXB0aW9uOgotICAgICAgICAgICAgICAgIEpTRnJhbWVEZXNjcmlw dGlvbiA9IHN0cmluZy5zdHJpcChKU0ZyYW1lRGVzY3JpcHRpb24sICciJykKKyAgICAgICAgICAg ICAgICBKU0ZyYW1lRGVzY3JpcHRpb24gPSBKU0ZyYW1lRGVzY3JpcHRpb24uc3RyaXAoJyInKQog ICAgICAgICAgICAgICAgIGZyYW1lRm9ybWF0ID0gJyAgICBmcmFtZSAje251bX06IHthZGRyOicg KyBhZGRyZXNzRm9ybWF0ICsgJ30ge2Rlc2N9JwogICAgICAgICAgICAgICAgIHByaW50KGZyYW1l Rm9ybWF0LmZvcm1hdChudW09ZnJhbWUuR2V0RnJhbWVJRCgpLCBhZGRyPWZyYW1lLkdldFBDKCks IGRlc2M9SlNGcmFtZURlc2NyaXB0aW9uKSkKICAgICAgICAgICAgICAgICBjb250aW51ZQo=