205270 2019-12-16 07:25:34 -0800 [GStreamer][WPE] Fix regressions related to our 'Fix GStreamer capturer mock' patch 2019-12-17 02:12:28 -0800 1 1 1 Unclassified WebKit WebRTC WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 tsaunier tsaunier commit-queue eric.carlson ews-watchlist glenn hta jer.noble philipj pnormand sergio tommyw webkit-bug-importer youennf oldest_to_newest 1598872 0 tsaunier 2019-12-16 07:25:34 -0800 See patch 1598873 1 385763 tsaunier 2019-12-16 07:27:32 -0800 Created attachment 385763 Patch 1598877 2 385763 pnormand 2019-12-16 07:33:52 -0800 Comment on attachment 385763 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=385763&action=review > LayoutTests/webrtc/peer-connection-audio-mute.html:34 > - return navigator.mediaDevices.getUserMedia({audio: true}).then((localStream) => { > + return navigator.mediaDevices.getUserMedia({audio: { echoCancellation : false}}).then((localStream) => { Why this change? 1598893 3 tsaunier 2019-12-16 07:59:00 -0800 (In reply to Philippe Normand from comment #2) > Comment on attachment 385763 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=385763&action=review > > > LayoutTests/webrtc/peer-connection-audio-mute.html:34 > > - return navigator.mediaDevices.getUserMedia({audio: true}).then((localStream) => { > > + return navigator.mediaDevices.getUserMedia({audio: { echoCancellation : false}}).then((localStream) => { > > Why this change? Because the test expects no echo cancelation and apple ports mock default to echoCancellation=false but this is not correct. see https://bugs.webkit.org/show_bug.cgi?id=205057 1599340 4 385763 commit-queue 2019-12-17 02:11:46 -0800 Comment on attachment 385763 Patch Clearing flags on attachment: 385763 Committed r253617: <https://trac.webkit.org/changeset/253617> 1599341 5 commit-queue 2019-12-17 02:11:47 -0800 All reviewed patches have been landed. Closing bug. 1599342 6 webkit-bug-importer 2019-12-17 02:12:28 -0800 <rdar://problem/58001072> 385763 2019-12-16 07:27:32 -0800 2019-12-17 02:11:46 -0800 Patch bug-205270-20191216122730.patch text/plain 4805 tsaunier U3VidmVyc2lvbiBSZXZpc2lvbjogMjUzNTQ1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggN2E3ZmYwOGM2ODMxZTUx YmNlOGMzZjVhZTRhNTc0Nzg5MmFiMThiOC4uNzk3NzU3NjU1OTM0ZTM1NTU4ZDhlYzk0ZTg0ZmRj MDAwN2VhMzI2MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE5LTEyLTE2ICBUaGli YXVsdCBTYXVuaWVyICA8dHNhdW5pZXJAaWdhbGlhLmNvbT4KKworICAgICAgICBbR1N0cmVhbWVy XVtXUEVdIEZpeCByZWdyZXNzaW9ucyByZWxhdGVkIHRvIG91ciAnRml4IEdTdHJlYW1lciBjYXB0 dXJlciBtb2NrJyBwYXRjaAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MjA1MjcwCisKKyAgICAgICAgTW9ja0dTdHJlYW1lckF1ZGlvQ2FwdHVyZVNvdXJj ZSByaWdodGZ1bGx5IGRlZmF1bHRzIHRvIGVjaG9DYW5jZWxsYXRpb249VHJ1ZSwKKyAgICAgICAg c2VlIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDUwNTcKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGlzIGZpeGVzIGV4 aXN0aW5nIHRlc3RzCisKKyAgICAgICAgKiBwbGF0Zm9ybS9tZWRpYXN0cmVhbS9nc3RyZWFtZXIv TW9ja0dTdHJlYW1lckF1ZGlvQ2FwdHVyZVNvdXJjZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpX cmFwcGVkTW9ja1JlYWx0aW1lQXVkaW9Tb3VyY2U6OmFkZEh1bSk6CisKIDIwMTktMTItMTYgIHlv dWVubiBmYWJsZXQgIDx5b3Vlbm5AYXBwbGUuY29tPgogCiAgICAgICAgIFNlY3VyaXR5T3JpZ2lu IHNob3VsZCBiZSB1bmlxdWUgZm9yIG51bGwgYmxvYiBVUkxzIHRoYXQgaGF2ZSBiZWVuIHVucmVn aXN0ZXJlZApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbWVkaWFzdHJlYW0v Z3N0cmVhbWVyL01vY2tHU3RyZWFtZXJBdWRpb0NhcHR1cmVTb3VyY2UuY3BwIGIvU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vbWVkaWFzdHJlYW0vZ3N0cmVhbWVyL01vY2tHU3RyZWFtZXJBdWRpb0Nh cHR1cmVTb3VyY2UuY3BwCmluZGV4IDQzZTFjOTE0MTQzNjBlZWUzYmEzOGU1YzZmY2Q2NzE0YjQ3 MjhhM2IuLjJkZWYzY2VhOGU1Y2ZmZGEyYjk1NGQ5ZjQwMWM3OTkxYmE1NWQ3NjYgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21lZGlhc3RyZWFtL2dzdHJlYW1lci9Nb2NrR1N0 cmVhbWVyQXVkaW9DYXB0dXJlU291cmNlLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9tZWRpYXN0cmVhbS9nc3RyZWFtZXIvTW9ja0dTdHJlYW1lckF1ZGlvQ2FwdHVyZVNvdXJjZS5j cHAKQEAgLTYzLDcgKzYzLDcgQEAgcHVibGljOgogICAgIHZvaWQgYWRkSHVtKGZsb2F0IGFtcGxp dHVkZSwgZmxvYXQgZnJlcXVlbmN5LCBmbG9hdCBzYW1wbGVSYXRlLCB1aW50NjRfdCBzdGFydCwg ZmxvYXQgKnAsIHVpbnQ2NF90IGNvdW50KQogICAgIHsKICAgICAgICAgaWYgKGVjaG9DYW5jZWxs YXRpb24oKSkgewotICAgICAgICAgICAgR1NUX0RFQlVHKCJlY2hvIGNhbmNlbCBvZmYuLi4sIG5v IGh1bSIpOworICAgICAgICAgICAgR1NUX0RFQlVHKCJlY2hvIGNhbmNlbC4uLiwgbm8gaHVtIik7 CiAgICAgICAgICAgICByZXR1cm47CiAgICAgICAgIH0KICAgICAgICAgZmxvYXQgaHVtUGVyaW9k ID0gc2FtcGxlUmF0ZSAvIGZyZXF1ZW5jeTsKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5n ZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCBmYzY3YzlhNTBmZjdkZWEyYTc2NmE3 N2UyZjA5Yzc2YTkxNWFkZTE5Li5kNDE3MjZjNTdiN2I2MTQzMzAzNDY4MGY0NDZkYTdjZDUwYWNh NjNhIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMv Q2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTktMTItMTYgIFRoaWJhdWx0IFNhdW5pZXIg IDx0c2F1bmllckBpZ2FsaWEuY29tPgorCisgICAgICAgIFtHU3RyZWFtZXJdW1dQRV0gRml4IHJl Z3Jlc3Npb25zIHJlbGF0ZWQgdG8gb3VyICdGaXggR1N0cmVhbWVyIGNhcHR1cmVyIG1vY2snIHBh dGNoCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDUy NzAKKworICAgICAgICBTa2lwIEdQVVByb2Nlc3MgcmVsYXRlZCB0ZXN0cworCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogcGxhdGZvcm0vZ3RrL1Rlc3RF eHBlY3RhdGlvbnM6CisgICAgICAgICogcGxhdGZvcm0vd3BlL1Rlc3RFeHBlY3RhdGlvbnM6Cisg ICAgICAgICogd2VicnRjL3BlZXItY29ubmVjdGlvbi1hdWRpby1tdXRlLmh0bWw6CisKIDIwMTkt MTItMTYgIHlvdWVubiBmYWJsZXQgIDx5b3Vlbm5AYXBwbGUuY29tPgogCiAgICAgICAgIFNlY3Vy aXR5T3JpZ2luIHNob3VsZCBiZSB1bmlxdWUgZm9yIG51bGwgYmxvYiBVUkxzIHRoYXQgaGF2ZSBi ZWVuIHVucmVnaXN0ZXJlZApkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZ3RrL1Rl c3RFeHBlY3RhdGlvbnMgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9ndGsvVGVzdEV4cGVjdGF0aW9u cwppbmRleCA0ZjZkZGMyMjFhNWRiN2ZhMGU1ODI3ZjMyMDM1YWViNjBhODEwMDNkLi5jYjkwYmVm YWNlZDA4NGZiZDY4YjQ1ZTkwMWQ0Mzc3MTU4YTgwMzk1IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0 cy9wbGF0Zm9ybS9ndGsvVGVzdEV4cGVjdGF0aW9ucworKysgYi9MYXlvdXRUZXN0cy9wbGF0Zm9y bS9ndGsvVGVzdEV4cGVjdGF0aW9ucwpAQCAtNTkyLDYgKzU5Miw5IEBAIHdlYmtpdC5vcmcvYi8x Njk4MTEgZmFzdC9tZWRpYXN0cmVhbS9jYXB0dXJlU3RyZWFtL2NhbnZhczNkLmh0bWwgWyBDcmFz aCBUaW1lb3V0CiAKIHdlYmtpdC5vcmcvYi8xOTA1NzYgZmFzdC9tZWRpYXN0cmVhbS9nZXQtdXNl ci1tZWRpYS1kZXZpY2UtaWQuaHRtbCBbIEZhaWx1cmUgXQogCisjIE5vIHN1cHBvcnQgZm9yIEdQ VVByb2Nlc3MgeWV0CitmYXN0L21lZGlhc3RyZWFtL2NhcHR1cmVBdWRpb0luR1BVUHJvY2Vzcy5o dG1sIFsgU2tpcCBdCisKICMgUmVxdWlyZXMgUmVzb2x1dGlvbiBNZWRpYSBRdWVyeSBzdXBwb3J0 CiB3ZWJraXQub3JnL2IvMTAwMTM3IGZhc3QvbWVkaWEvbXEtcmVzb2x1dGlvbi5odG1sIFsgRmFp bHVyZSBdCiB3ZWJraXQub3JnL2IvMTAwMTM3IGZhc3QvbWVkaWEvbXEtcmVzb2x1dGlvbi1kcGkt ZHBjbS13YXJuaW5nLmh0bWwgWyBGYWlsdXJlIF0KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3Bs YXRmb3JtL3dwZS9UZXN0RXhwZWN0YXRpb25zIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vd3BlL1Rl c3RFeHBlY3RhdGlvbnMKaW5kZXggMmY3YmJjMjM4MGNkMjBiNmYwMjU1OTczYTUwYjUxODI0NWVj ZWZhYi4uZjUyMzYzODA3OGE3NzNlNGE0Zjc5YWFlN2M3ODk1MGE5MWM1YjQzNSAxMDA2NDQKLS0t IGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vd3BlL1Rlc3RFeHBlY3RhdGlvbnMKKysrIGIvTGF5b3V0 VGVzdHMvcGxhdGZvcm0vd3BlL1Rlc3RFeHBlY3RhdGlvbnMKQEAgLTEyNiw2ICsxMjYsOSBAQCB3 ZWJraXQub3JnL2IvMTY5ODExIGZhc3QvbWVkaWFzdHJlYW0vY2FwdHVyZVN0cmVhbS9jYW52YXMz ZC5odG1sIFsgQ3Jhc2ggVGltZW91dAogCiB3ZWJraXQub3JnL2IvMTkwNTc2IGZhc3QvbWVkaWFz dHJlYW0vZ2V0LXVzZXItbWVkaWEtZGV2aWNlLWlkLmh0bWwgWyBGYWlsdXJlIF0KIAorIyBObyBz dXBwb3J0IGZvciBHUFVQcm9jZXNzIHlldAorZmFzdC9tZWRpYXN0cmVhbS9jYXB0dXJlQXVkaW9J bkdQVVByb2Nlc3MuaHRtbCBbIFNraXAgXQorCiAjIE1lZGlhUmVjb3JkZXIgaXMgbm90IGN1cnJl bnRseSBpbXBsZW1lbnRlZAogaHR0cC93cHQvbWVkaWFyZWNvcmRlciBbIFNraXAgXQogaW1wb3J0 ZWQvdzNjL3dlYi1wbGF0Zm9ybS10ZXN0cy9tZWRpYWNhcHR1cmUtcmVjb3JkIFsgU2tpcCBdCmRp ZmYgLS1naXQgYS9MYXlvdXRUZXN0cy93ZWJydGMvcGVlci1jb25uZWN0aW9uLWF1ZGlvLW11dGUu aHRtbCBiL0xheW91dFRlc3RzL3dlYnJ0Yy9wZWVyLWNvbm5lY3Rpb24tYXVkaW8tbXV0ZS5odG1s CmluZGV4IDBmMjBjMzk4NGM4M2E2YmYzYzFjZjA3Y2UxODc1MWFhZWUxYjVjMjIuLjRhZDYxNjdl NjIzMjYxOWUzZjk1YzI0YmViYzE2NWIyOTZiODI4OTEgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3Rz L3dlYnJ0Yy9wZWVyLWNvbm5lY3Rpb24tYXVkaW8tbXV0ZS5odG1sCisrKyBiL0xheW91dFRlc3Rz L3dlYnJ0Yy9wZWVyLWNvbm5lY3Rpb24tYXVkaW8tbXV0ZS5odG1sCkBAIC0zMSw3ICszMSw3IEBA CiAgICAgICAgIH0KIAogICAgICAgICB2YXIgbG9jYWxUcmFjazsKLSAgICAgICAgcmV0dXJuIG5h dmlnYXRvci5tZWRpYURldmljZXMuZ2V0VXNlck1lZGlhKHthdWRpbzogdHJ1ZX0pLnRoZW4oKGxv Y2FsU3RyZWFtKSA9PiB7CisgICAgICAgIHJldHVybiBuYXZpZ2F0b3IubWVkaWFEZXZpY2VzLmdl dFVzZXJNZWRpYSh7YXVkaW86IHsgZWNob0NhbmNlbGxhdGlvbiA6IGZhbHNlfX0pLnRoZW4oKGxv Y2FsU3RyZWFtKSA9PiB7CiAgICAgICAgICAgICBsb2NhbFRyYWNrID0gbG9jYWxTdHJlYW0uZ2V0 QXVkaW9UcmFja3MoKVswXTsKICAgICAgICAgICAgIHJldHVybiBuZXcgUHJvbWlzZSgocmVzb2x2 ZSwgcmVqZWN0KSA9PiB7CiAgICAgICAgICAgICAgICAgY3JlYXRlQ29ubmVjdGlvbnMoKGZpcnN0 Q29ubmVjdGlvbikgPT4gewo=