205265 2019-12-16 05:14:20 -0800 check-webkit-style: allow underscores for public symbols in JSC GLIB API 2019-12-17 02:18:22 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 cgarcia webkit-unassigned ews-watchlist glenn jbedard webkit-bug-importer oldest_to_newest 1598838 0 cgarcia 2019-12-16 05:14:20 -0800 Add an exception for symbols starting with jsc_ in glib directories. 1598839 1 385753 cgarcia 2019-12-16 05:15:32 -0800 Created attachment 385753 Patch 1599344 2 cgarcia 2019-12-17 02:17:26 -0800 Committed r253618: <https://trac.webkit.org/changeset/253618> 1599346 3 webkit-bug-importer 2019-12-17 02:18:22 -0800 <rdar://problem/58001179> 385753 2019-12-16 05:15:32 -0800 2019-12-16 07:37:17 -0800 Patch wpy-checker-jsc.diff text/plain 3252 cgarcia ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCAxMDc3 MjU5ZDcxZC4uOWQ2Y2EwMWRmOTYgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0NoYW5nZUxvZworKysgYi9U b29scy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNyBAQAorMjAxOS0xMi0xNiAgQ2FybG9zIEdhcmNp YSBDYW1wb3MgIDxjZ2FyY2lhQGlnYWxpYS5jb20+CisKKyAgICAgICAgY2hlY2std2Via2l0LXN0 eWxlOiBhbGxvdyB1bmRlcnNjb3JlcyBmb3IgcHVibGljIHN5bWJvbHMgaW4gSlNDIEdMSUIgQVBJ CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDUyNjUK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGQgYW4g ZXhjZXB0aW9uIGZvciBzeW1ib2xzIHN0YXJ0aW5nIHdpdGgganNjXyBpbiBnbGliIGRpcmVjdG9y aWVzLgorCisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2Vycy9jcHAucHk6 CisgICAgICAgIChjaGVja19pZGVudGlmaWVyX25hbWVfaW5fZGVjbGFyYXRpb24pOgorICAgICAg ICAqIFNjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcnMvY3BwX3VuaXR0ZXN0LnB5OgorICAg ICAgICAoV2ViS2l0U3R5bGVUZXN0LnRlc3RfbmFtZXMpOgorCiAyMDE5LTEyLTE2ICBDYXJsb3Mg R2FyY2lhIENhbXBvcyAgPGNnYXJjaWFAaWdhbGlhLmNvbT4KIAogICAgICAgICBbR0xJQl0gQWRk IEdMaWIgc3BlY2lmaWMgQVBJIGZvciBKU0MgSlNWYWx1ZVJlZi5oJ3MgSlNWYWx1ZU1ha2VGcm9t SlNPTlN0cmluZyBhbmQgSlNWYWx1ZUNyZWF0ZUpTT05TdHJpbmcgbWV0aG9kcwpkaWZmIC0tZ2l0 IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2Vycy9jcHAucHkgYi9Ub29scy9T Y3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJzL2NwcC5weQppbmRleCBlMTI2MTdlZTMzNS4u Y2Q5ODM3YmZiMzYgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hl Y2tlcnMvY3BwLnB5CisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcnMv Y3BwLnB5CkBAIC0zNjM4LDYgKzM2MzgsNyBAQCBkZWYgY2hlY2tfaWRlbnRpZmllcl9uYW1lX2lu X2RlY2xhcmF0aW9uKGZpbGVuYW1lLCBsaW5lX251bWJlciwgbGluZSwgZmlsZV9zdGF0ZQogICAg ICAgICAgICAgIyBWYXJpb3VzIGV4Y2VwdGlvbnMgdG8gdGhlIHJ1bGU6IEphdmFTY3JpcHQgb3Ag Y29kZXMgZnVuY3Rpb25zLCBjb25zdF9pdGVyYXRvci4KICAgICAgICAgICAgIGlmIChub3QgKGZp bGVuYW1lLmZpbmQoJ0phdmFTY3JpcHRDb3JlJykgPj0gMCBhbmQgKG1vZGlmaWVkX2lkZW50aWZp ZXIuZmluZCgnb3BfJykgPj0gMCBvciBtb2RpZmllZF9pZGVudGlmaWVyLmZpbmQoJ2ludHJpbnNp Y18nKSA+PSAwKSkKICAgICAgICAgICAgICAgICBhbmQgbm90ICgoJ2d0aycgaW4gZmlsZW5hbWUg b3IgJ2dsaWInIGluIGZpbGVuYW1lIG9yICd3cGUnIGluIGZpbGVuYW1lIG9yICdhdGsnIGluIGZp bGVuYW1lKSBhbmQgbW9kaWZpZWRfaWRlbnRpZmllci5zdGFydHN3aXRoKCd3ZWJraXRfJykpCisg ICAgICAgICAgICAgICAgYW5kIG5vdCAoJ2dsaWInIGluIGZpbGVuYW1lIGFuZCBtb2RpZmllZF9p ZGVudGlmaWVyLnN0YXJ0c3dpdGgoJ2pzY18nKSkKICAgICAgICAgICAgICAgICBhbmQgbm90IG1v ZGlmaWVkX2lkZW50aWZpZXIuc3RhcnRzd2l0aCgndHN0XycpCiAgICAgICAgICAgICAgICAgYW5k IG5vdCBtb2RpZmllZF9pZGVudGlmaWVyLnN0YXJ0c3dpdGgoJ3dlYmtpdF9kb21fb2JqZWN0Xycp CiAgICAgICAgICAgICAgICAgYW5kIG5vdCBtb2RpZmllZF9pZGVudGlmaWVyLnN0YXJ0c3dpdGgo J3dlYmtpdF9zb3VwJykKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5bGUv Y2hlY2tlcnMvY3BwX3VuaXR0ZXN0LnB5IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9j aGVja2Vycy9jcHBfdW5pdHRlc3QucHkKaW5kZXggMDc0NjI4Zjc4NmEuLmUzYTQ2OTViOWI4IDEw MDY0NAotLS0gYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJzL2NwcF91bml0 dGVzdC5weQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJzL2NwcF91 bml0dGVzdC5weQpAQCAtNTQ3MSw2ICs1NDcxLDE1IEBAIGNsYXNzIFdlYktpdFN0eWxlVGVzdChD cHBTdHlsZVRlc3RCYXNlKToKICAgICAgICAgICAgICdvdGhlcmtpdF93ZWJfdmlld19sb2FkIGlz IGluY29ycmVjdGx5IG5hbWVkLiBEb25cJ3QgdXNlIHVuZGVyc2NvcmVzIGluIHlvdXIgaWRlbnRp ZmllciBuYW1lcy4nCiAgICAgICAgICAgICAnICBbcmVhZGFiaWxpdHkvbmFtaW5nL3VuZGVyc2Nv cmVzXSBbNF0nLCAnU291cmNlL1dlYmtpdC93ZWJraXQvZm9vLmNwcCcpCiAKKyAgICAgICAgIyBU aGVyZSBpcyBhbiBleGNlcHRpb24gZm9yIEdMaWIgSmF2YVNjcmlwdENvcmUgQVBJLgorICAgICAg ICBzZWxmLmFzc2VydF9saW50KCdKU0NWYWx1ZSoganNjX3ZhbHVlX25ld19udWxsKEpTQ0NvbnRl eHQqIGNvbnRleHQpJywgJycsICdTb3VyY2UvSmF2YVNjcmlwdENvcmUvQVBJL2dsaWIvSlNDVmFs dWUuY3BwJykKKyAgICAgICAgc2VsZi5hc3NlcnRfbGludCgndm9pZCBteV9mdW5jdGlvbihpbnQg dmFyaWFibGVfMSknLAorICAgICAgICAgICAgICAgICAgICAgICAgIFsnbXlfZnVuY3Rpb24nICsg bmFtZV91bmRlcnNjb3JlX2Vycm9yX21lc3NhZ2UsCisgICAgICAgICAgICAgICAgICAgICAgICAg ICd2YXJpYWJsZV8xJyArIG5hbWVfdW5kZXJzY29yZV9lcnJvcl9tZXNzYWdlXSwKKyAgICAgICAg ICAgICAgICAgICAgICAgICAnU291cmNlL0phdmFTY3JpcHRDb3JlL0FQSS9nbGliL0pTQ1ZhbHVl LmNwcCcpCisgICAgICAgIHNlbGYuYXNzZXJ0X2xpbnQoJ2dib29sZWFuIGpzY192YWx1ZV9pc191 bmRlZmluZWQoSlNDVmFsdWUqIHZhbHVlKScsCisgICAgICAgICAgICAgICAgICAgICAgICAgJ2pz Y192YWx1ZV9pc191bmRlZmluZWQnICsgbmFtZV91bmRlcnNjb3JlX2Vycm9yX21lc3NhZ2UpCisK ICAgICAgICAgIyBUaGVyZSBpcyBhbiBleGNlcHRpb24gZm9yIHNvbWUgdW5pdCB0ZXN0cyB0aGF0 IGJlZ2luIHdpdGggInRzdF8iLgogICAgICAgICBzZWxmLmFzc2VydF9saW50KCd2b2lkIHRzdF9R V2ViRnJhbWU6OmFycmF5T2JqZWN0RW51bWVyYWJsZShpbnQgdmFyMSwgaW50IHZhcjIpJywgJycp CiAK