205252 2019-12-15 08:44:37 -0800 [LFC][IFC] Add basic support for hanging content 2019-12-15 09:00:23 -0800 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 zalan zalan bfulgham koivisto simon.fraser webkit-bug-importer zalan oldest_to_newest 1598745 0 zalan 2019-12-15 08:44:37 -0800 https://www.w3.org/TR/css-text-3/#hanging 1598746 1 webkit-bug-importer 2019-12-15 08:45:05 -0800 <rdar://problem/57947773> 1598747 2 385721 zalan 2019-12-15 08:51:47 -0800 Created attachment 385721 Patch 1598748 3 385721 koivisto 2019-12-15 08:56:34 -0800 Comment on attachment 385721 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=385721&action=review > Source/WebCore/ChangeLog:3 > + [LFC][IFC] Add basic supporting for hanging content support 1598749 4 zalan 2019-12-15 09:00:23 -0800 Committed r253537: <https://trac.webkit.org/changeset/253537> 385721 2019-12-15 08:51:47 -0800 2019-12-15 08:55:17 -0800 Patch bug-205252-20191215085146.patch text/plain 7445 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMjUzNTM1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNjYxOGFmYWZmYmUwN2Yy ZTI2NzRmNzNhOGFkMGY3YzM0N2IyOGRkYS4uNTJjZjRhNjdiZjQwM2VmMDgxNWVlNzdhNTg1Zjlk YjEyNGE2MjUzYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI5IEBACisyMDE5LTEyLTE1ICBaYWxh biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgW0xGQ11bSUZDXSBBZGQgYmFz aWMgc3VwcG9ydGluZyBmb3IgaGFuZ2luZyBjb250ZW50CisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDUyNTIKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVt LzU3OTQ3NzczPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIENvbGxlY3QgdGhlIGhhbmdpbmcgY29udGVudCBhZnRlciBjb2xsYXBzaW5nIHRyYWlsaW5n IHdoaXRlc3BhY2UgYW5kIGFkanVzdAorICAgICAgICB0aGUgYXZhaWxhYmxlIHNwYWNlIHdoZW4g Y29tcHV0aW5nIHRoZSBleHRyYSB3aWR0aCBmb3IgaG9yaXpvbnRhbCBhbGlnbm1lbnQuCisKKyAg ICAgICAgSUZDIHBhc3NlcyBpbXBvcnRlZC93M2Mvd2ViLXBsYXRmb3JtLXRlc3RzL2Nzcy9jc3Mt dGV4dC8gZGlyZWN0b3J5IG5vdy4KKworICAgICAgICAqIGxheW91dC9pbmxpbmVmb3JtYXR0aW5n L0lubGluZUxpbmVCdWlsZGVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkxheW91dDo6TGluZUJ1 aWxkZXI6OmluaXRpYWxpemUpOgorICAgICAgICAoV2ViQ29yZTo6TGF5b3V0OjpMaW5lQnVpbGRl cjo6Y2xvc2UpOgorICAgICAgICAoV2ViQ29yZTo6TGF5b3V0OjpMaW5lQnVpbGRlcjo6YWxpZ25D b250ZW50SG9yaXpvbnRhbGx5IGNvbnN0KToKKyAgICAgICAgKFdlYkNvcmU6OkxheW91dDo6TGlu ZUJ1aWxkZXI6OmNvbGxlY3RIYW5naW5nQ29udGVudCk6CisgICAgICAgIChXZWJDb3JlOjpMYXlv dXQ6OkxpbmVCdWlsZGVyOjphcHBlbmRUZXh0Q29udGVudCk6CisgICAgICAgICogbGF5b3V0L2lu bGluZWZvcm1hdHRpbmcvSW5saW5lTGluZUJ1aWxkZXIuaDoKKyAgICAgICAgKFdlYkNvcmU6Okxh eW91dDo6TGluZUJ1aWxkZXI6OkhhbmdpbmdDb250ZW50Ojp3aWR0aCBjb25zdCk6CisgICAgICAg IChXZWJDb3JlOjpMYXlvdXQ6OkxpbmVCdWlsZGVyOjpIYW5naW5nQ29udGVudDo6aXNDb25kaXRp b25hbCBjb25zdCk6CisgICAgICAgIChXZWJDb3JlOjpMYXlvdXQ6OkxpbmVCdWlsZGVyOjpIYW5n aW5nQ29udGVudDo6c2V0SXNDb25kaXRpb25hbCk6CisgICAgICAgIChXZWJDb3JlOjpMYXlvdXQ6 OkxpbmVCdWlsZGVyOjpIYW5naW5nQ29udGVudDo6ZXhwYW5kKToKKyAgICAgICAgKFdlYkNvcmU6 OkxheW91dDo6TGluZUJ1aWxkZXI6OkhhbmdpbmdDb250ZW50OjpyZXNldCk6CisKIDIwMTktMTIt MTUgIFphbGFuIEJ1anRhcyAgPHphbGFuQGFwcGxlLmNvbT4KIAogICAgICAgICBbTEZDXVtJRkNd IEZpeCBpbXBvcnRlZC93M2Mvd2ViLXBsYXRmb3JtLXRlc3RzL2Nzcy9jc3MtdGV4dC93aGl0ZS1z cGFjZS9icmVhay1zcGFjZXMtMDA5Lmh0bWwKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2xh eW91dC9pbmxpbmVmb3JtYXR0aW5nL0lubGluZUxpbmVCdWlsZGVyLmNwcCBiL1NvdXJjZS9XZWJD b3JlL2xheW91dC9pbmxpbmVmb3JtYXR0aW5nL0lubGluZUxpbmVCdWlsZGVyLmNwcAppbmRleCBl MmIzNjBkYTNiYWZhNTI3YzUzMDM3NGNkMTVlYTljY2UyZWNhOTFkLi40ODc4Y2RkNDk4ZGVjNWU5 OWZhYWQ2ZDU2ZjViYTY0MjE2ZDgzODU3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9sYXlv dXQvaW5saW5lZm9ybWF0dGluZy9JbmxpbmVMaW5lQnVpbGRlci5jcHAKKysrIGIvU291cmNlL1dl YkNvcmUvbGF5b3V0L2lubGluZWZvcm1hdHRpbmcvSW5saW5lTGluZUJ1aWxkZXIuY3BwCkBAIC0x OTEsNiArMTkxLDcgQEAgdm9pZCBMaW5lQnVpbGRlcjo6aW5pdGlhbGl6ZShjb25zdCBDb25zdHJh aW50cyYgY29uc3RyYWludHMpCiAKICAgICBtX2lubGluZUl0ZW1SdW5zLmNsZWFyKCk7CiAgICAg bV90cmltbWFibGVDb250ZW50LnJlc2V0KCk7CisgICAgbV9oYW5naW5nQ29udGVudC5yZXNldCgp OwogICAgIG1fbGluZUlzVmlzdWFsbHlFbXB0eUJlZm9yZVRyaW1tYWJsZUNvbnRlbnQgPSB7IH07 CiB9CiAKQEAgLTIwOCw2ICsyMDksNyBAQCBMaW5lQnVpbGRlcjo6UnVuTGlzdCBMaW5lQnVpbGRl cjo6Y2xvc2UoSXNMYXN0TGluZVdpdGhJbmxpbmVDb250ZW50IGlzTGFzdExpbmVXaQogICAgIC8v IDIuIEpvaW4gdGV4dCBydW5zIHRvZ2V0aGVyIHdoZW4gcG9zc2libGUgW2Zvb11bIF1bYmFyXSAt PiBbZm9vIGJhcl0uCiAgICAgLy8gMy4gQWxpZ24gbWVyZ2VkIHJ1bnMgYm90aCB2ZXJ0aWNhbGx5 IGFuZCBob3Jpem9udGFsbHkuCiAgICAgcmVtb3ZlVHJhaWxpbmdUcmltbWFibGVDb250ZW50KCk7 CisgICAgY29sbGVjdEhhbmdpbmdDb250ZW50KGlzTGFzdExpbmVXaXRoSW5saW5lQ29udGVudCk7 CiAgICAgUnVuTGlzdCBydW5MaXN0OwogICAgIHVuc2lnbmVkIHJ1bkluZGV4ID0gMDsKICAgICB3 aGlsZSAocnVuSW5kZXggPCBtX2lubGluZUl0ZW1SdW5zLnNpemUoKSkgewpAQCAtMzMwLDcgKzMz Miw4IEBAIHZvaWQgTGluZUJ1aWxkZXI6Omp1c3RpZnlSdW5zKFJ1bkxpc3QmIHJ1bkxpc3QpIGNv bnN0CiB2b2lkIExpbmVCdWlsZGVyOjphbGlnbkNvbnRlbnRIb3Jpem9udGFsbHkoUnVuTGlzdCYg cnVuTGlzdCwgSXNMYXN0TGluZVdpdGhJbmxpbmVDb250ZW50IGxhc3RMaW5lKSBjb25zdAogewog ICAgIEFTU0VSVCghbV9za2lwQWxpZ25tZW50KTsKLSAgICBpZiAocnVuTGlzdC5pc0VtcHR5KCkg fHwgYXZhaWxhYmxlV2lkdGgoKSA8PSAwKQorICAgIGF1dG8gYXZhaWxhYmxlV2lkdGggPSB0aGlz LT5hdmFpbGFibGVXaWR0aCgpICsgbV9oYW5naW5nQ29udGVudC53aWR0aCgpOworICAgIGlmIChy dW5MaXN0LmlzRW1wdHkoKSB8fCBhdmFpbGFibGVXaWR0aCA8PSAwKQogICAgICAgICByZXR1cm47 CiAKICAgICBpZiAoaXNUZXh0QWxpZ25KdXN0aWZ5KCkpIHsKQEAgLTM0OSwxMCArMzUyLDEwIEBA IHZvaWQgTGluZUJ1aWxkZXI6OmFsaWduQ29udGVudEhvcml6b250YWxseShSdW5MaXN0JiBydW5M aXN0LCBJc0xhc3RMaW5lV2l0aElubGluCiAgICAgICAgIGNhc2UgVGV4dEFsaWduTW9kZTo6Umln aHQ6CiAgICAgICAgIGNhc2UgVGV4dEFsaWduTW9kZTo6V2ViS2l0UmlnaHQ6CiAgICAgICAgIGNh c2UgVGV4dEFsaWduTW9kZTo6RW5kOgotICAgICAgICAgICAgcmV0dXJuIHN0ZDo6bWF4PElubGlu ZUxheW91dFVuaXQ+KGF2YWlsYWJsZVdpZHRoKCksIDApOworICAgICAgICAgICAgcmV0dXJuIHN0 ZDo6bWF4PElubGluZUxheW91dFVuaXQ+KGF2YWlsYWJsZVdpZHRoLCAwKTsKICAgICAgICAgY2Fz ZSBUZXh0QWxpZ25Nb2RlOjpDZW50ZXI6CiAgICAgICAgIGNhc2UgVGV4dEFsaWduTW9kZTo6V2Vi S2l0Q2VudGVyOgotICAgICAgICAgICAgcmV0dXJuIHN0ZDo6bWF4PElubGluZUxheW91dFVuaXQ+ KGF2YWlsYWJsZVdpZHRoKCkgLyAyLCAwKTsKKyAgICAgICAgICAgIHJldHVybiBzdGQ6Om1heDxJ bmxpbmVMYXlvdXRVbml0PihhdmFpbGFibGVXaWR0aCAvIDIsIDApOwogICAgICAgICBjYXNlIFRl eHRBbGlnbk1vZGU6Okp1c3RpZnk6CiAgICAgICAgICAgICBBU1NFUlRfTk9UX1JFQUNIRUQoKTsK ICAgICAgICAgICAgIGJyZWFrOwpAQCAtMzkzLDYgKzM5NiwyOSBAQCB2b2lkIExpbmVCdWlsZGVy OjpyZW1vdmVUcmFpbGluZ1RyaW1tYWJsZUNvbnRlbnQoKQogICAgIG1fbGluZUlzVmlzdWFsbHlF bXB0eUJlZm9yZVRyaW1tYWJsZUNvbnRlbnQgPSB7IH07CiB9CiAKK3ZvaWQgTGluZUJ1aWxkZXI6 OmNvbGxlY3RIYW5naW5nQ29udGVudChJc0xhc3RMaW5lV2l0aElubGluZUNvbnRlbnQgaXNMYXN0 TGluZVdpdGhJbmxpbmVDb250ZW50KQoreworICAgIC8vIENhbid0IHNldHVwIGhhbmdpbmcgY29u dGVudCB3aXRoIHJlbW92YWJsZSB0cmFpbGluZyB3aGl0c3BhY2VzLgorICAgIEFTU0VSVChtX3Ry aW1tYWJsZUNvbnRlbnQuaXNFbXB0eSgpKTsKKyAgICBpZiAoaXNMYXN0TGluZVdpdGhJbmxpbmVD b250ZW50ID09IElzTGFzdExpbmVXaXRoSW5saW5lQ29udGVudDo6WWVzKQorICAgICAgICBtX2hh bmdpbmdDb250ZW50LnNldElzQ29uZGl0aW9uYWwoKTsKKyAgICBmb3IgKGF1dG8mIGlubGluZUl0 ZW1SdW4gOiBXVEY6Om1ha2VSZXZlcnNlZFJhbmdlKG1faW5saW5lSXRlbVJ1bnMpKSB7CisgICAg ICAgIGlmIChpbmxpbmVJdGVtUnVuLmlzQ29udGFpbmVyU3RhcnQoKSB8fCBpbmxpbmVJdGVtUnVu LmlzQ29udGFpbmVyRW5kKCkpCisgICAgICAgICAgICBjb250aW51ZTsKKyAgICAgICAgaWYgKGlu bGluZUl0ZW1SdW4uaXNMaW5lQnJlYWsoKSkgeworICAgICAgICAgICAgbV9oYW5naW5nQ29udGVu dC5zZXRJc0NvbmRpdGlvbmFsKCk7CisgICAgICAgICAgICBjb250aW51ZTsKKyAgICAgICAgfQor ICAgICAgICBpZiAoIWlubGluZUl0ZW1SdW4uaXNUZXh0KCkgfHwgIWlubGluZUl0ZW1SdW4uaXNX aGl0ZXNwYWNlKCkgfHwgaW5saW5lSXRlbVJ1bi5pc0NvbGxhcHNpYmxlKCkpCisgICAgICAgICAg ICBicmVhazsKKyAgICAgICAgLy8gQ2hlY2sgaWYgd2UgaGF2ZSBhIHByZXNlcnZlZCBvciBodW5n IHdoaXRlc3BhY2UuCisgICAgICAgIGlmIChpbmxpbmVJdGVtUnVuLnN0eWxlKCkud2hpdGVTcGFj ZSgpICE9IFdoaXRlU3BhY2U6OlByZVdyYXApCisgICAgICAgICAgICBicmVhazsKKyAgICAgICAg Ly8gVGhpcyBpcyBlaXRoZXIgYSBub3JtYWwgb3IgY29uZGl0aW9uYWxseSBoYW5naW5nIHRyYWls aW5nIHdoaXRlc3BhY2UuCisgICAgICAgIG1faGFuZ2luZ0NvbnRlbnQuZXhwYW5kKGlubGluZUl0 ZW1SdW4ubG9naWNhbFdpZHRoKCkpOworICAgIH0KK30KKwogdm9pZCBMaW5lQnVpbGRlcjo6bW92 ZUxvZ2ljYWxMZWZ0KElubGluZUxheW91dFVuaXQgZGVsdGEpCiB7CiAgICAgaWYgKCFkZWx0YSkK QEAgLTUwMyw3ICs1MjksNyBAQCB2b2lkIExpbmVCdWlsZGVyOjphcHBlbmRUZXh0Q29udGVudChj b25zdCBJbmxpbmVUZXh0SXRlbSYgaW5saW5lSXRlbSwgSW5saW5lTGF5bwogCiAgICAgbV9saW5l Qm94LmV4cGFuZEhvcml6b250YWxseShsaW5lUnVuLmxvZ2ljYWxXaWR0aCgpKTsKIAotICAgIC8v IEV4aXN0aW5nIHRyYWlsaW5nIHRyaW1tYWJsZSBjb250ZW50IGNhbiBvbmx5IGJlIGV4cGFuZGVk IGlmIHRoZSBjdXJyZW50IHJ1cyBpcyBmdWxseSB0cmltbWFibGUuCisgICAgLy8gRXhpc3Rpbmcg dHJhaWxpbmcgdHJpbW1hYmxlIGNvbnRlbnQgY2FuIG9ubHkgYmUgZXhwYW5kZWQgaWYgdGhlIGN1 cnJlbnQgcnVuIGlzIGZ1bGx5IHRyaW1tYWJsZS4KICAgICBhdXRvIHRyaW1tYWJsZUxpc3ROZWVk c1Jlc2V0ID0gIW1fdHJpbW1hYmxlQ29udGVudC5pc0VtcHR5KCkgJiYgIWxpbmVSdW4uaXNUcmlt bWFibGVXaGl0ZXNwYWNlKCk7CiAgICAgaWYgKHRyaW1tYWJsZUxpc3ROZWVkc1Jlc2V0KQogICAg ICAgICBtX3RyaW1tYWJsZUNvbnRlbnQucmVzZXQoKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL2xheW91dC9pbmxpbmVmb3JtYXR0aW5nL0lubGluZUxpbmVCdWlsZGVyLmggYi9Tb3VyY2Uv V2ViQ29yZS9sYXlvdXQvaW5saW5lZm9ybWF0dGluZy9JbmxpbmVMaW5lQnVpbGRlci5oCmluZGV4 IDlkYTA0ODhmNjYyYjFjZDBjNWNkNjhmNTEwYjU3YzljOGNkYWRkZmQuLjRlZGZkNjVlNTM1YWRm NjM2ODEzYjY0ZWI2MDhiNmI1NzRiODZjOGUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2xh eW91dC9pbmxpbmVmb3JtYXR0aW5nL0lubGluZUxpbmVCdWlsZGVyLmgKKysrIGIvU291cmNlL1dl YkNvcmUvbGF5b3V0L2lubGluZWZvcm1hdHRpbmcvSW5saW5lTGluZUJ1aWxkZXIuaApAQCAtMTQw LDYgKzE0MCw3IEBAIHByaXZhdGU6CiAgICAgdm9pZCBhcHBlbmRMaW5lQnJlYWsoY29uc3QgSW5s aW5lSXRlbSYpOwogCiAgICAgdm9pZCByZW1vdmVUcmFpbGluZ1RyaW1tYWJsZUNvbnRlbnQoKTsK KyAgICB2b2lkIGNvbGxlY3RIYW5naW5nQ29udGVudChJc0xhc3RMaW5lV2l0aElubGluZUNvbnRl bnQpOwogICAgIHZvaWQgYWxpZ25Db250ZW50SG9yaXpvbnRhbGx5KFJ1bkxpc3QmLCBJc0xhc3RM aW5lV2l0aElubGluZUNvbnRlbnQpIGNvbnN0OwogICAgIHZvaWQgYWxpZ25Db250ZW50VmVydGlj YWxseShSdW5MaXN0Jik7CiAKQEAgLTIyMiw5ICsyMjMsMjUgQEAgcHJpdmF0ZToKICAgICAgICAg Ym9vbCBtX2xhc3RSdW5Jc0Z1bGx5VHJpbW1hYmxlIHsgZmFsc2UgfTsKICAgICB9OwogCisgICAg c3RydWN0IEhhbmdpbmdDb250ZW50IHsKKyAgICBwdWJsaWM6CisgICAgICAgIHZvaWQgcmVzZXQo KTsKKworICAgICAgICBJbmxpbmVMYXlvdXRVbml0IHdpZHRoKCkgY29uc3QgeyByZXR1cm4gbV93 aWR0aDsgfQorICAgICAgICBib29sIGlzQ29uZGl0aW9uYWwoKSBjb25zdCB7IHJldHVybiBtX2lz Q29uZGl0aW9uYWw7IH0KKworICAgICAgICB2b2lkIHNldElzQ29uZGl0aW9uYWwoKSB7IG1faXND b25kaXRpb25hbCA9IHRydWU7IH0KKyAgICAgICAgdm9pZCBleHBhbmQoSW5saW5lTGF5b3V0VW5p dCB3aWR0aCkgeyBtX3dpZHRoICs9IHdpZHRoOyB9CisKKyAgICBwcml2YXRlOgorICAgICAgICBi b29sIG1faXNDb25kaXRpb25hbCB7IGZhbHNlIH07CisgICAgICAgIElubGluZUxheW91dFVuaXQg bV93aWR0aCB7IDAgfTsKKyAgICB9OworCiAgICAgY29uc3QgSW5saW5lRm9ybWF0dGluZ0NvbnRl eHQmIG1faW5saW5lRm9ybWF0dGluZ0NvbnRleHQ7CiAgICAgSW5saW5lSXRlbVJ1bkxpc3QgbV9p bmxpbmVJdGVtUnVuczsKICAgICBUcmltbWFibGVDb250ZW50IG1fdHJpbW1hYmxlQ29udGVudDsK KyAgICBIYW5naW5nQ29udGVudCBtX2hhbmdpbmdDb250ZW50OwogICAgIE9wdGlvbmFsPERpc3Bs YXk6OkxpbmVCb3g6OkJhc2VsaW5lPiBtX2luaXRpYWxTdHJ1dDsKICAgICBJbmxpbmVMYXlvdXRV bml0IG1fbGluZUxvZ2ljYWxXaWR0aCB7IDAgfTsKICAgICBPcHRpb25hbDxUZXh0QWxpZ25Nb2Rl PiBtX2hvcml6b250YWxBbGlnbm1lbnQ7CkBAIC0yNDEsNiArMjU4LDEyIEBAIGlubGluZSB2b2lk IExpbmVCdWlsZGVyOjpUcmltbWFibGVDb250ZW50OjpyZXNldCgpCiAgICAgbV9sYXN0UnVuSXNG dWxseVRyaW1tYWJsZSA9IGZhbHNlOwogfQogCitpbmxpbmUgdm9pZCBMaW5lQnVpbGRlcjo6SGFu Z2luZ0NvbnRlbnQ6OnJlc2V0KCkKK3sKKyAgICBtX2lzQ29uZGl0aW9uYWwgPSBmYWxzZTsKKyAg ICBtX3dpZHRoID0gIDA7Cit9CisKIH0KIH0KICNlbmRpZgo=