205250 2019-12-15 05:45:28 -0800 [GTK] Build with USE_WPE_RENDERER=No fails with undefined EGL_WAYLAND_BUFFER_WL, 2020-07-23 15:43:01 -0700 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 emilio emilio alexander bugs-noreply cgarcia commit-queue oldest_to_newest 1598725 0 emilio 2019-12-15 05:45:28 -0800 . 1598726 1 385714 emilio 2019-12-15 05:47:38 -0800 Created attachment 385714 Patch 1598819 2 385714 cgarcia 2019-12-16 02:27:36 -0800 Comment on attachment 385714 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=385714&action=review > Source/WebKit/UIProcess/gtk/WaylandCompositor.cpp:34 > +#include <EGL/eglmesaext.h> Is this header mesa specific? I think we could define it below inside the the #if !defined(PFNEGLBINDWAYLANDDISPLAYWL) for example, or using its own ifdef #define EGL_WAYLAND_BUFFER_WL 0x31D5 We will handle the runtijme failure correctly if the required APIs are not availbale at runtime. 1598846 3 385757 emilio 2019-12-16 05:59:05 -0800 Created attachment 385757 Patch 1598848 4 emilio 2019-12-16 06:02:56 -0800 (In reply to Carlos Garcia Campos from comment #2) > Is this header mesa specific? I think we could define it below inside the > the #if !defined(PFNEGLBINDWAYLANDDISPLAYWL) for example, or using its own > ifdef > > #define EGL_WAYLAND_BUFFER_WL 0x31D5 > > We will handle the runtijme failure correctly if the required APIs are not > availbale at runtime. Sure, that wfm. 1598888 5 385757 commit-queue 2019-12-16 07:56:25 -0800 Comment on attachment 385757 Patch Clearing flags on attachment: 385757 Committed r253553: <https://trac.webkit.org/changeset/253553> 1598889 6 commit-queue 2019-12-16 07:56:27 -0800 All reviewed patches have been landed. Closing bug. 1674422 7 aperez 2020-07-23 15:43:01 -0700 *** Bug 204108 has been marked as a duplicate of this bug. *** 385714 2019-12-15 05:47:38 -0800 2019-12-16 05:59:01 -0800 Patch bug-205250-20191215144737.patch text/plain 1343 emilio U3VidmVyc2lvbiBSZXZpc2lvbjogMjUzNTMxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDYzNTA5M2YyMjMwNmE4Mzc5 NDM4ZGUwMWY0NTljNTUxMTJjNzJiYTQuLmNhOTlhMjUzZWFmYmU3MjlkYjhhMDQ2YzdiMDU0ODBk NmQ0ZTBhMjIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTktMTItMTUgIEVtaWxpbyBD b2JvcyDDgWx2YXJleiAgPGVtaWxpb0BjcmlzYWwuaW8+CisKKyAgICAgICAgW0dUS10gQnVpbGQg d2l0aCBVU0VfV1BFX1JFTkRFUkVSPU5vIGZhaWxzIHdpdGggdW5kZWZpbmVkIEVHTF9XQVlMQU5E X0JVRkZFUl9XTAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MjA1MjUwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgSW5jbHVkZSB0aGUgaGVhZGVyIHRoYXQgZGVmaW5lcyB0aGlzIGNvbnN0YW50LgorCisgICAg ICAgIE5vIG5ldyB0ZXN0cywganVzdCBhIGJ1aWxkIGZpeC4KKworICAgICAgICAqIFVJUHJvY2Vz cy9ndGsvV2F5bGFuZENvbXBvc2l0b3IuY3BwOgorCiAyMDE5LTEyLTE0ICBTaW1vbiBGcmFzZXIg IDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgogCiAgICAgICAgIFJlbmFtZSAiY3VzdG9tRml4ZWRQ b3NpdGlvblJlY3QiIHRvICJsYXlvdXRWaWV3cG9ydFJlY3QiCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViS2l0L1VJUHJvY2Vzcy9ndGsvV2F5bGFuZENvbXBvc2l0b3IuY3BwIGIvU291cmNlL1dlYktp dC9VSVByb2Nlc3MvZ3RrL1dheWxhbmRDb21wb3NpdG9yLmNwcAppbmRleCA4YTE0YzU1MmM4NzI1 MmJhYTk4ZjczMTM1ZGU1MWVlNDUzYWE0YzY4Li4xZTJkODMwMTk5NjlkMjhhMmRmYjUyMzM0YzMx OGRjMzc1MTI4NDQwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9ndGsvV2F5 bGFuZENvbXBvc2l0b3IuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL2d0ay9XYXls YW5kQ29tcG9zaXRvci5jcHAKQEAgLTMxLDYgKzMxLDcgQEAKICNpbmNsdWRlICJXZWJLaXRXYXls YW5kU2VydmVyUHJvdG9jb2wuaCIKICNpbmNsdWRlIDxFR0wvZWdsLmg+CiAjaW5jbHVkZSA8RUdM L2VnbGV4dC5oPgorI2luY2x1ZGUgPEVHTC9lZ2xtZXNhZXh0Lmg+CiAjaW5jbHVkZSA8V2ViQ29y ZS9HTENvbnRleHQuaD4KICNpbmNsdWRlIDxXZWJDb3JlL1BsYXRmb3JtRGlzcGxheVdheWxhbmQu aD4KICNpbmNsdWRlIDxXZWJDb3JlL1JlZ2lvbi5oPgo= 385757 2019-12-16 05:59:05 -0800 2019-12-16 07:56:25 -0800 Patch bug-205250-20191216145904.patch text/plain 1537 emilio U3VidmVyc2lvbiBSZXZpc2lvbjogMjUzNTQ2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDU0ODQ0YTI2ZmY5ZTIwNTA0 MzE1OTZjYjVmNzJlZjgxYmZjMDVkZDUuLjAxMDkyMTExMTczNTU0MjRlYmViNGM5Y2ZlYTY1NWMz YjIyNGQ4ZGMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTktMTItMTUgIEVtaWxpbyBD b2JvcyDDgWx2YXJleiAgPGVtaWxpb0BjcmlzYWwuaW8+CisKKyAgICAgICAgW0dUS10gQnVpbGQg d2l0aCBVU0VfV1BFX1JFTkRFUkVSPU5vIGZhaWxzIHdpdGggdW5kZWZpbmVkIEVHTF9XQVlMQU5E X0JVRkZFUl9XTAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MjA1MjUwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgRGVmaW5lIHRoZSBlbnVtIGlmIG5vdCBwcmVzZW50LgorCisgICAgICAgIE5vIG5ldyB0ZXN0 cywganVzdCBhIGJ1aWxkIGZpeC4KKworICAgICAgICAqIFVJUHJvY2Vzcy9ndGsvV2F5bGFuZENv bXBvc2l0b3IuY3BwOgorCiAyMDE5LTEyLTE2ICB5b3Vlbm4gZmFibGV0ICA8eW91ZW5uQGFwcGxl LmNvbT4KIAogICAgICAgICBSZXNldCBjYWNoZWQgZ2V0VXNlck1lZGlhIHF1ZXJpZXMgd2hlbiBj YWxsaW5nIHN0b3BNZWRpYUNhcHR1cmUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvVUlQcm9j ZXNzL2d0ay9XYXlsYW5kQ29tcG9zaXRvci5jcHAgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9n dGsvV2F5bGFuZENvbXBvc2l0b3IuY3BwCmluZGV4IDhhMTRjNTUyYzg3MjUyYmFhOThmNzMxMzVk ZTUxZWU0NTNhYTRjNjguLmMzNTQwOTlmZTk0OThmZTA2Mjk3NzU2OWQ4ZTRlNGVkY2Y2N2EyMDAg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL2d0ay9XYXlsYW5kQ29tcG9zaXRv ci5jcHAKKysrIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvZ3RrL1dheWxhbmRDb21wb3NpdG9y LmNwcApAQCAtNTgsNiArNTgsMTAgQEAgdHlwZWRlZiBFR0xCb29sZWFuICgqUEZORUdMQklORFdB WUxBTkRESVNQTEFZV0wpIChFR0xEaXNwbGF5LCBzdHJ1Y3Qgd2xfZGlzcGxheSoKIHR5cGVkZWYg RUdMQm9vbGVhbiAoKlBGTkVHTFVOQklORFdBWUxBTkRESVNQTEFZV0wpIChFR0xEaXNwbGF5LCBz dHJ1Y3Qgd2xfZGlzcGxheSopOwogI2VuZGlmCiAKKyNpZiAhZGVmaW5lZChFR0xfV0FZTEFORF9C VUZGRVJfV0wpCisjZGVmaW5lIEVHTF9XQVlMQU5EX0JVRkZFUl9XTCAweDMxRDUKKyNlbmRpZgor CiAjaWYgIWRlZmluZWQoUEZORUdMUVVFUllXQVlMQU5EQlVGRkVSV0wpCiB0eXBlZGVmIEVHTEJv b2xlYW4gKCpQRk5FR0xRVUVSWVdBWUxBTkRCVUZGRVJXTCkgKEVHTERpc3BsYXksIHN0cnVjdCB3 bF9yZXNvdXJjZSosIEVHTGludCBhdHRyaWJ1dGUsIEVHTGludCogdmFsdWUpOwogI2VuZGlmCg==