<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>205249</bug_id>
          
          <creation_ts>2019-12-15 05:39:08 -0800</creation_ts>
          <short_desc>jhbuild fails to configure if gettext 0.20 is installed</short_desc>
          <delta_ts>2019-12-15 10:43:49 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKitGTK</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Emilio Cobos Álvarez (:emilio)">emilio</reporter>
          <assigned_to name="Emilio Cobos Álvarez (:emilio)">emilio</assigned_to>
          <cc>bugs-noreply</cc>
    
    <cc>commit-queue</cc>
    
    <cc>mcatanzaro</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1598723</commentid>
    <comment_count>0</comment_count>
    <who name="Emilio Cobos Álvarez (:emilio)">emilio</who>
    <bug_when>2019-12-15 05:39:08 -0800</bug_when>
    <thetext>Because jhbuild is using gettext 0.19, apparently.

Anyhow I have a fix that should work.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1598724</commentid>
    <comment_count>1</comment_count>
      <attachid>385713</attachid>
    <who name="Emilio Cobos Álvarez (:emilio)">emilio</who>
    <bug_when>2019-12-15 05:43:13 -0800</bug_when>
    <thetext>Created attachment 385713
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1598731</commentid>
    <comment_count>2</comment_count>
      <attachid>385713</attachid>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2019-12-15 06:17:52 -0800</bug_when>
    <thetext>Comment on attachment 385713
Patch

Thanks. This works, but a better solution is to just update jhbuild to 3.35.2 or master, which has already fixed this problem. This will also fix the second problem preventing use of jhbuild-wrapper on Fedora 31: the old version is incompatible with python3.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1598732</commentid>
    <comment_count>3</comment_count>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2019-12-15 06:27:57 -0800</bug_when>
    <thetext>Just change:

jhbuild_revision = &apos;b1d2ebdef165435c048c59192a32ba69d4f2c6dd&apos;

to, say:

jhbuild_revision = &apos;93d37507d0fbf550aa3e96b5d632f3772c0189f0&apos;

And make sure that works.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1598733</commentid>
    <comment_count>4</comment_count>
      <attachid>385715</attachid>
    <who name="Emilio Cobos Álvarez (:emilio)">emilio</who>
    <bug_when>2019-12-15 06:42:26 -0800</bug_when>
    <thetext>Created attachment 385715
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1598734</commentid>
    <comment_count>5</comment_count>
    <who name="Emilio Cobos Álvarez (:emilio)">emilio</who>
    <bug_when>2019-12-15 06:42:55 -0800</bug_when>
    <thetext>(In reply to Michael Catanzaro from comment #3)
&gt; Just change:
&gt; 
&gt; jhbuild_revision = &apos;b1d2ebdef165435c048c59192a32ba69d4f2c6dd&apos;
&gt; 
&gt; to, say:
&gt; 
&gt; jhbuild_revision = &apos;93d37507d0fbf550aa3e96b5d632f3772c0189f0&apos;
&gt; 
&gt; And make sure that works.

Yup, seems to work, thanks!</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1598756</commentid>
    <comment_count>6</comment_count>
      <attachid>385715</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2019-12-15 10:43:47 -0800</bug_when>
    <thetext>Comment on attachment 385715
Patch

Clearing flags on attachment: 385715

Committed r253539: &lt;https://trac.webkit.org/changeset/253539&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1598757</commentid>
    <comment_count>7</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2019-12-15 10:43:49 -0800</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>385713</attachid>
            <date>2019-12-15 05:43:13 -0800</date>
            <delta_ts>2019-12-15 06:42:22 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-205249-20191215144312.patch</filename>
            <type>text/plain</type>
            <size>1589</size>
            <attacher name="Emilio Cobos Álvarez (:emilio)">emilio</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjUzNTMxCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg
Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggODdjNzIyNTU0NzI4YjA0NTI0ZjZiNDIzZmMwMWQxYTVj
MDcwM2JmNS4uNzg5YjY5ZjYxOTc0YThkNmU4NWY5OGI4ZmQwNDVhNmI5MTg5MWFiYyAxMDA2NDQK
LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2
IEBACisyMDE5LTEyLTE1ICBFbWlsaW8gQ29ib3Mgw4FsdmFyZXogIDxlbWlsaW9AY3Jpc2FsLmlv
PgorCisgICAgICAgIFtHVEtdIGpoYnVpbGQgZmFpbHMgdG8gY29uZmlndXJlIGlmIGdldHRleHQg
MC4yMCBpcyBpbnN0YWxsZWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i
dWcuY2dpP2lkPTIwNTI0OQorCisgICAgICAgIEJlY2F1c2UgamhidWlsZCBpcyBzdGlsbCBvbiBh
biBvbGRlciB2ZXJzaW9uIG9mIGdldHRleHQuIEFueWhvdyB3ZQorICAgICAgICBkb24ndCBzZWVt
IHRvIHVzZSBpdCwgc28gaXQgc2VlbXMgcmVhc29uYWJsZSB0byBkaXNhYmxlCisgICAgICAgIG5h
dHVyYWwtbGFuZ3VhZ2Utc3VwcG9ydCBmb3IgamhidWlsZC4KKworICAgICAgICBSZXZpZXdlZCBi
eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGpoYnVpbGQvamhidWlsZC13cmFwcGVyOgor
CiAyMDE5LTEyLTEzICBXZW5zb24gSHNpZWggIDx3ZW5zb25faHNpZWhAYXBwbGUuY29tPgogCiAg
ICAgICAgIFVucmV2aWV3ZWQsIGZpeCB0aGUgbWFjQ2F0YWx5c3QgYnVpbGQgYWZ0ZXIgcjI1MzQ4
NgpkaWZmIC0tZ2l0IGEvVG9vbHMvamhidWlsZC9qaGJ1aWxkLXdyYXBwZXIgYi9Ub29scy9qaGJ1
aWxkL2poYnVpbGQtd3JhcHBlcgppbmRleCAwMjYxNmRiNGNlMWE3Yjk1ZDc2NWQ2OTQxMThjYmVl
ZWQ4NTg2NmYxLi43OTc0ZjFhOWE0MzBhZDI2NTA0OTA1ZTA3NWExZDBhYmJiZmRkNzc4IDEwMDc1
NQotLS0gYS9Ub29scy9qaGJ1aWxkL2poYnVpbGQtd3JhcHBlcgorKysgYi9Ub29scy9qaGJ1aWxk
L2poYnVpbGQtd3JhcHBlcgpAQCAtOTEsNyArOTEsNyBAQCBkZWYgY2xvbmVfamhidWlsZCgpOgog
ZGVmIGluc3RhbGxfamhidWlsZCgpOgogICAgIGlmICJHUkVQX09QVElPTlMiIGluIG9zLmVudmly
b246CiAgICAgICAgIGRlbCBvcy5lbnZpcm9uWydHUkVQX09QVElPTlMnXQotICAgIHByb2Nlc3Mg
PSBzdWJwcm9jZXNzLlBvcGVuKFsnYmFzaCcsICcuL2F1dG9nZW4uc2gnLCAnLS1wcmVmaXg9JXMn
ICUgaW5zdGFsbGF0aW9uX3ByZWZpeF0sIGN3ZD1qaGJ1aWxkX3NvdXJjZV9wYXRoKQorICAgIHBy
b2Nlc3MgPSBzdWJwcm9jZXNzLlBvcGVuKFsnYmFzaCcsICcuL2F1dG9nZW4uc2gnLCAnLS1kaXNh
YmxlLW5scycsICctLXByZWZpeD0lcycgJSBpbnN0YWxsYXRpb25fcHJlZml4XSwgY3dkPWpoYnVp
bGRfc291cmNlX3BhdGgpCiAgICAgcHJvY2Vzcy53YWl0KCkKICAgICBpZiBwcm9jZXNzLnJldHVy
bmNvZGUgIT0gMDoKICAgICAgICAgcmFpc2UgRXhjZXB0aW9uKCdqaGJ1aWxkIGNvbmZpZ3VyZSBm
YWlsZWQgd2l0aCByZXR1cm4gY29kZTogJWknICUgcHJvY2Vzcy5yZXR1cm5jb2RlKQo=
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>385715</attachid>
            <date>2019-12-15 06:42:26 -0800</date>
            <delta_ts>2019-12-15 10:43:47 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-205249-20191215154225.patch</filename>
            <type>text/plain</type>
            <size>1128</size>
            <attacher name="Emilio Cobos Álvarez (:emilio)">emilio</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjUzNTMxCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg
Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggODdjNzIyNTU0NzI4YjA0NTI0ZjZiNDIzZmMwMWQxYTVj
MDcwM2JmNS4uZDdmZTMzNThjZmRmZDg3OTBiZDRlOWRmNmMyYzExNjJmYmUxMWM4NiAxMDA2NDQK
LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0
IEBACisyMDE5LTEyLTE1ICBFbWlsaW8gQ29ib3Mgw4FsdmFyZXogIDxlbWlsaW9AY3Jpc2FsLmlv
PgorCisgICAgICAgIFtHVEtdIGpoYnVpbGQgZmFpbHMgdG8gY29uZmlndXJlIGlmIGdldHRleHQg
MC4yMCBpcyBpbnN0YWxsZWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i
dWcuY2dpP2lkPTIwNTI0OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor
CisgICAgICAgIFVwZGF0ZSBqaGJ1aWxkLgorCisgICAgICAgICogamhidWlsZC9qaGJ1aWxkLXdy
YXBwZXI6CisKIDIwMTktMTItMTMgIFdlbnNvbiBIc2llaCAgPHdlbnNvbl9oc2llaEBhcHBsZS5j
b20+CiAKICAgICAgICAgVW5yZXZpZXdlZCwgZml4IHRoZSBtYWNDYXRhbHlzdCBidWlsZCBhZnRl
ciByMjUzNDg2CmRpZmYgLS1naXQgYS9Ub29scy9qaGJ1aWxkL2poYnVpbGQtd3JhcHBlciBiL1Rv
b2xzL2poYnVpbGQvamhidWlsZC13cmFwcGVyCmluZGV4IDAyNjE2ZGI0Y2UxYTdiOTVkNzY1ZDY5
NDExOGNiZWVlZDg1ODY2ZjEuLmExMjlhYTM5ZjFiODMzOWQ2Mjc0ZGRmMDNhOWYxNzVkODA3NmYz
NjEgMTAwNzU1Ci0tLSBhL1Rvb2xzL2poYnVpbGQvamhidWlsZC13cmFwcGVyCisrKyBiL1Rvb2xz
L2poYnVpbGQvamhidWlsZC13cmFwcGVyCkBAIC0yNCw3ICsyNCw3IEBAIGltcG9ydCBzaGxleAog
aW1wb3J0IHN1YnByb2Nlc3MKIGltcG9ydCBzeXMKIAotamhidWlsZF9yZXZpc2lvbiA9ICdiMWQy
ZWJkZWYxNjU0MzVjMDQ4YzU5MTkyYTMyYmE2OWQ0ZjJjNmRkJworamhidWlsZF9yZXZpc2lvbiA9
ICc5M2QzNzUwN2QwZmJmNTUwYWEzZTk2YjVkNjMyZjM3NzJjMDE4OWYwJwogCiBkZWYgZGV0ZXJt
aW5lX3BsYXRmb3JtKCk6CiAgICAgaWYgJy0tZ3RrJyBpbiBzeXMuYXJndjoK
</data>

          </attachment>
      

    </bug>

</bugzilla>