205246 2019-12-14 21:48:28 -0800 [LFC][IFC] Fix imported/w3c/web-platform-tests/css/css-text/white-space/break-spaces-009.html 2019-12-15 06:09:46 -0800 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 zalan zalan bfulgham koivisto simon.fraser webkit-bug-importer zalan oldest_to_newest 1598700 0 zalan 2019-12-14 21:48:28 -0800 ssia 1598701 1 webkit-bug-importer 2019-12-14 21:48:51 -0800 <rdar://problem/57944015> 1598702 2 385709 zalan 2019-12-14 21:53:29 -0800 Created attachment 385709 Patch 1598706 3 385709 koivisto 2019-12-15 00:07:40 -0800 Comment on attachment 385709 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=385709&action=review > Source/WebCore/layout/inlineformatting/InlineLineBreaker.cpp:286 > + // [ ][ ] : adjacent whitespace content has soft wrap opportunity. > + if (lastUncomittedContent->isText() && downcast<InlineTextItem>(*lastUncomittedContent).isWhitespace()) > + isAtSoftWrapOpportunityBeforeWhitespace = true; break-space might need a new strategy at some point. Creating InlineTextItems for each space is not very efficient at all. 1598730 4 zalan 2019-12-15 06:09:46 -0800 Committed r253535: <https://trac.webkit.org/changeset/253535> 385709 2019-12-14 21:53:29 -0800 2019-12-15 00:07:40 -0800 Patch bug-205246-20191214215329.patch text/plain 2139 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMjUzNTI2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggODYyZjNjZjViNDUxNzIz NjQzY2QxODg1OGM1MDM0Zjc5ZjRkNDc4My4uZGQzODBjOTJmM2FmOTI2YjhkYjUwMjdiMjA3MTZh MjFiMmMxMzY5OCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE5LTEyLTE0ICBaYWxh biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgW0xGQ11bSUZDXSBGaXggaW1w b3J0ZWQvdzNjL3dlYi1wbGF0Zm9ybS10ZXN0cy9jc3MvY3NzLXRleHQvd2hpdGUtc3BhY2UvYnJl YWstc3BhY2VzLTAwOS5odG1sCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0yMDUyNDYKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzU3OTQ0MDE1PgorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEZpeCB0aGUgInNv ZnQgd3JhcCBvcHBvcnR1bml0eSIgY2FzZSB3aGVuIGJvdGggdGhlIGluY29taW5nIGFuZCB0aGUg cHJldmlvdXMgcnVucyBhcmUgd2hpdGVzcGFjZS4KKworICAgICAgICAqIGxheW91dC9pbmxpbmVm b3JtYXR0aW5nL0lubGluZUxpbmVCcmVha2VyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkxheW91 dDo6TGluZUJyZWFrZXI6OkNvbnRlbnQ6OmlzQXRTb2Z0V3JhcE9wcG9ydHVuaXR5KToKKwogMjAx OS0xMi0xNCAgWmFsYW4gQnVqdGFzICA8emFsYW5AYXBwbGUuY29tPgogCiAgICAgICAgIFtMRkNd W0lGQ10gRml4IGltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMvY3NzL2Nzcy10ZXh0L292 ZXJmbG93LXdyYXAvb3ZlcmZsb3ctd3JhcC1icmVhay13b3JkLTAwNi5odG1sCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQvaW5saW5lZm9ybWF0dGluZy9JbmxpbmVMaW5lQnJlYWtl ci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQvaW5saW5lZm9ybWF0dGluZy9JbmxpbmVMaW5l QnJlYWtlci5jcHAKaW5kZXggMDU3M2ZmODMzNjQyNDQ3NTQ1OWFkYmRhMTVhZDdjZTA4YWM4OTYy Mi4uYjU4ZTJiZmYwOTJiOWRiYTM5NzBlMDJkMmJhM2NmODIyY2NlOWEwMSAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkNvcmUvbGF5b3V0L2lubGluZWZvcm1hdHRpbmcvSW5saW5lTGluZUJyZWFrZXIu Y3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2xheW91dC9pbmxpbmVmb3JtYXR0aW5nL0lubGluZUxp bmVCcmVha2VyLmNwcApAQCAtMjgxLDYgKzI4MSw5IEBAIGJvb2wgTGluZUJyZWFrZXI6OkNvbnRl bnQ6OmlzQXRTb2Z0V3JhcE9wcG9ydHVuaXR5KGNvbnN0IElubGluZUl0ZW0mIGlubGluZUl0ZW0s CiAgICAgICAgICAgICAvLyBbcHJpb3IgY29udGVudF1bIF0gKDxzcGFuPnNvbWVfY29udGVudDwv c3Bhbj4gKQogICAgICAgICAgICAgLy8gd2hpdGUtc3BhY2U6IGJyZWFrLXNwYWNlczogbGluZSBi cmVha2luZyBvcHBvcnR1bml0eSBleGlzdHMgYWZ0ZXIgZXZlcnkgcHJlc2VydmVkIHdoaXRlIHNw YWNlIGNoYXJhY3RlciwgYnV0IG5vdCBiZWZvcmUuCiAgICAgICAgICAgICBhdXRvIGlzQXRTb2Z0 V3JhcE9wcG9ydHVuaXR5QmVmb3JlV2hpdGVzcGFjZSA9IGlubGluZUl0ZW0uc3R5bGUoKS53aGl0 ZVNwYWNlKCkgIT0gV2hpdGVTcGFjZTo6QnJlYWtTcGFjZXM7CisgICAgICAgICAgICAvLyBbIF1b IF0gOiBhZGphY2VudCB3aGl0ZXNwYWNlIGNvbnRlbnQgaGFzIHNvZnQgd3JhcCBvcHBvcnR1bml0 eS4KKyAgICAgICAgICAgIGlmIChsYXN0VW5jb21pdHRlZENvbnRlbnQtPmlzVGV4dCgpICYmIGRv d25jYXN0PElubGluZVRleHRJdGVtPigqbGFzdFVuY29taXR0ZWRDb250ZW50KS5pc1doaXRlc3Bh Y2UoKSkKKyAgICAgICAgICAgICAgICBpc0F0U29mdFdyYXBPcHBvcnR1bml0eUJlZm9yZVdoaXRl c3BhY2UgPSB0cnVlOwogICAgICAgICAgICAgcmV0dXJuIGlzQXRTb2Z0V3JhcE9wcG9ydHVuaXR5 QmVmb3JlV2hpdGVzcGFjZTsKICAgICAgICAgfQogICAgICAgICBpZiAobGFzdFVuY29taXR0ZWRD b250ZW50LT5pc0NvbnRhaW5lclN0YXJ0KCkpIHsK