205227 2019-12-13 16:31:58 -0800 Add power metric to perf dashboard 2019-12-15 14:13:20 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 zhifei_fang zhifei_fang ap commit-queue dewei_zhu ews-watchlist glenn jbedard rniwa webkit-bug-importer zhifei_fang oldest_to_newest 1598552 0 zhifei_fang 2019-12-13 16:31:58 -0800 Add power metric to perf dashboard 1598553 1 385656 zhifei_fang 2019-12-13 16:32:25 -0800 Created attachment 385656 Patch 1598594 2 385656 rniwa 2019-12-13 19:11:28 -0800 Comment on attachment 385656 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=385656&action=review > Websites/perf.webkit.org/public/v3/models/metric.js:23 > + 'Power': 'watt', Why not just W? That's the SI unit. Let's also add this to old code in helper-classes.js and v2/data.js. 1598687 3 385703 zhifei_fang 2019-12-14 19:30:31 -0800 Created attachment 385703 Patch 1598688 4 zhifei_fang 2019-12-14 19:36:35 -0800 Sorry, I will add those to data.js and helper-classes.js 1598691 5 385705 zhifei_fang 2019-12-14 19:40:34 -0800 Created attachment 385705 Patch 1598768 6 385705 commit-queue 2019-12-15 14:12:41 -0800 Comment on attachment 385705 Patch Clearing flags on attachment: 385705 Committed r253542: <https://trac.webkit.org/changeset/253542> 1598769 7 commit-queue 2019-12-15 14:12:43 -0800 All reviewed patches have been landed. Closing bug. 1598770 8 webkit-bug-importer 2019-12-15 14:13:20 -0800 <rdar://problem/57951945> 385656 2019-12-13 16:32:25 -0800 2019-12-14 19:30:30 -0800 Patch bug-205227-20191213163224.patch text/plain 1230 zhifei_fang U3VidmVyc2lvbiBSZXZpc2lvbjogMjUzNDU4CmRpZmYgLS1naXQgYS9XZWJzaXRlcy9wZXJmLndl YmtpdC5vcmcvQ2hhbmdlTG9nIGIvV2Vic2l0ZXMvcGVyZi53ZWJraXQub3JnL0NoYW5nZUxvZwpp bmRleCA1ZjNjNDhlNWNhMjkzNjg5NzE5OWI2MDlhYzU0ODZmN2UwYWY4YmU5Li42NzMzZmU5M2Ix NjdmY2FjODg2ODA0NTc0NDRjZjJiODU2OWQ5YWEwIDEwMDY0NAotLS0gYS9XZWJzaXRlcy9wZXJm LndlYmtpdC5vcmcvQ2hhbmdlTG9nCisrKyBiL1dlYnNpdGVzL3BlcmYud2Via2l0Lm9yZy9DaGFu Z2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAxOS0xMi0xMyAgWmhpZmVpIEZhbmcgIDx6aGlmZWlf ZmFuZ0BhcHBsZS5jb20+CisKKyAgICAgICAgQWRkIHBvd2VyIG1ldHJpYyB0byBwZXJmIGRhc2hi b2FyZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjA1 MjI3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBw dWJsaWMvdjMvbW9kZWxzL21ldHJpYy5qczoKKyAgICAgICAgKE1ldHJpYyk6CisKIDIwMTktMTIt MDUgIERld2VpIFpodSAgPGRld2VpX3podUBhcHBsZS5jb20+CiAKICAgICAgICAgQ3VzdG9tIGFu YWx5c2lzIHRhc2sgcGFnZSBzaG91bGQgYWxsb3cgc2NoZWR1bGUgYW55IHRyaWdnZXJhYmxlIGFj Y2VwdGVkIHRlc3RzLgpkaWZmIC0tZ2l0IGEvV2Vic2l0ZXMvcGVyZi53ZWJraXQub3JnL3B1Ymxp Yy92My9tb2RlbHMvbWV0cmljLmpzIGIvV2Vic2l0ZXMvcGVyZi53ZWJraXQub3JnL3B1YmxpYy92 My9tb2RlbHMvbWV0cmljLmpzCmluZGV4IGYwYTIzMjk5M2EzODdkMjU4MzI5OTI0OGQyY2JjYzVi ODAyZTY0Y2IuLjUwNjM0Mjc1NGNiMmZmMWUzMjY0ZDJiNDM0YmU0MmY1YWM4NWFhYjggMTAwNjQ0 Ci0tLSBhL1dlYnNpdGVzL3BlcmYud2Via2l0Lm9yZy9wdWJsaWMvdjMvbW9kZWxzL21ldHJpYy5q cworKysgYi9XZWJzaXRlcy9wZXJmLndlYmtpdC5vcmcvcHVibGljL3YzL21vZGVscy9tZXRyaWMu anMKQEAgLTIwLDYgKzIwLDcgQEAgY2xhc3MgTWV0cmljIGV4dGVuZHMgTGFiZWxlZE9iamVjdCB7 CiAgICAgICAgICAgICAnQWxsb2NhdGlvbnMnOiAnQicsCiAgICAgICAgICAgICAnU2l6ZSc6ICdC JywKICAgICAgICAgICAgICdTY29yZSc6ICdwdCcsCisgICAgICAgICAgICAnUG93ZXInOiAnd2F0 dCcsCiAgICAgICAgIH1bc3VmZml4XTsKICAgICB9CiAK 385703 2019-12-14 19:30:31 -0800 2019-12-14 19:40:33 -0800 Patch bug-205227-20191214193030.patch text/plain 1227 zhifei_fang U3VidmVyc2lvbiBSZXZpc2lvbjogMjUzNDU4CmRpZmYgLS1naXQgYS9XZWJzaXRlcy9wZXJmLndl YmtpdC5vcmcvQ2hhbmdlTG9nIGIvV2Vic2l0ZXMvcGVyZi53ZWJraXQub3JnL0NoYW5nZUxvZwpp bmRleCA1ZjNjNDhlNWNhMjkzNjg5NzE5OWI2MDlhYzU0ODZmN2UwYWY4YmU5Li42NzMzZmU5M2Ix NjdmY2FjODg2ODA0NTc0NDRjZjJiODU2OWQ5YWEwIDEwMDY0NAotLS0gYS9XZWJzaXRlcy9wZXJm LndlYmtpdC5vcmcvQ2hhbmdlTG9nCisrKyBiL1dlYnNpdGVzL3BlcmYud2Via2l0Lm9yZy9DaGFu Z2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAxOS0xMi0xMyAgWmhpZmVpIEZhbmcgIDx6aGlmZWlf ZmFuZ0BhcHBsZS5jb20+CisKKyAgICAgICAgQWRkIHBvd2VyIG1ldHJpYyB0byBwZXJmIGRhc2hi b2FyZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjA1 MjI3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBw dWJsaWMvdjMvbW9kZWxzL21ldHJpYy5qczoKKyAgICAgICAgKE1ldHJpYyk6CisKIDIwMTktMTIt MDUgIERld2VpIFpodSAgPGRld2VpX3podUBhcHBsZS5jb20+CiAKICAgICAgICAgQ3VzdG9tIGFu YWx5c2lzIHRhc2sgcGFnZSBzaG91bGQgYWxsb3cgc2NoZWR1bGUgYW55IHRyaWdnZXJhYmxlIGFj Y2VwdGVkIHRlc3RzLgpkaWZmIC0tZ2l0IGEvV2Vic2l0ZXMvcGVyZi53ZWJraXQub3JnL3B1Ymxp Yy92My9tb2RlbHMvbWV0cmljLmpzIGIvV2Vic2l0ZXMvcGVyZi53ZWJraXQub3JnL3B1YmxpYy92 My9tb2RlbHMvbWV0cmljLmpzCmluZGV4IGYwYTIzMjk5M2EzODdkMjU4MzI5OTI0OGQyY2JjYzVi ODAyZTY0Y2IuLmZjNmU4MjliMGEyZmNiNzJmM2EwMWUzNGNkOTI4MjllNjRkODZmODMgMTAwNjQ0 Ci0tLSBhL1dlYnNpdGVzL3BlcmYud2Via2l0Lm9yZy9wdWJsaWMvdjMvbW9kZWxzL21ldHJpYy5q cworKysgYi9XZWJzaXRlcy9wZXJmLndlYmtpdC5vcmcvcHVibGljL3YzL21vZGVscy9tZXRyaWMu anMKQEAgLTIwLDYgKzIwLDcgQEAgY2xhc3MgTWV0cmljIGV4dGVuZHMgTGFiZWxlZE9iamVjdCB7 CiAgICAgICAgICAgICAnQWxsb2NhdGlvbnMnOiAnQicsCiAgICAgICAgICAgICAnU2l6ZSc6ICdC JywKICAgICAgICAgICAgICdTY29yZSc6ICdwdCcsCisgICAgICAgICAgICAnUG93ZXInOiAndycs CiAgICAgICAgIH1bc3VmZml4XTsKICAgICB9CiAK 385705 2019-12-14 19:40:34 -0800 2019-12-15 14:12:41 -0800 Patch bug-205227-20191214194034.patch text/plain 3071 zhifei_fang U3VidmVyc2lvbiBSZXZpc2lvbjogMjUzNDU4CmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3dl YmtpdHB5L2JlbmNobWFya19ydW5uZXIvYmVuY2htYXJrX3Jlc3VsdHMucHkgYi9Ub29scy9TY3Jp cHRzL3dlYmtpdHB5L2JlbmNobWFya19ydW5uZXIvYmVuY2htYXJrX3Jlc3VsdHMucHkKaW5kZXgg YjIyZTRiM2EzYjQ0M2EyY2UwYzljMDg4YjZkYWMyNmRhMjRlNDhhMi4uOThhMDZiYjMzYmY3MzIz ZTQ3YzgxOWYwYjk5MjllNGFiYTI4NDRjZSAxMDA2NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJr aXRweS9iZW5jaG1hcmtfcnVubmVyL2JlbmNobWFya19yZXN1bHRzLnB5CisrKyBiL1Rvb2xzL1Nj cmlwdHMvd2Via2l0cHkvYmVuY2htYXJrX3J1bm5lci9iZW5jaG1hcmtfcmVzdWx0cy5weQpAQCAt NDQsNiArNDQsNyBAQCBjbGFzcyBCZW5jaG1hcmtSZXN1bHRzKG9iamVjdCk6CiAgICAgICAgICdI ZWFwJzogJ0InLAogICAgICAgICAnQWxsb2NhdGlvbnMnOiAnQicsCiAgICAgICAgICdTY29yZSc6 ICdwdCcsCisgICAgICAgICdQb3dlcic6ICdXJywKICAgICB9CiAgICAgU0lfcHJlZml4ZXMgPSBb J24nLCAndScsICdtJywgJycsICdLJywgJ00nLCAnRycsICdUJywgJ1AnLCAnRSddCiAKZGlmZiAt LWdpdCBhL1dlYnNpdGVzL3BlcmYud2Via2l0Lm9yZy9DaGFuZ2VMb2cgYi9XZWJzaXRlcy9wZXJm LndlYmtpdC5vcmcvQ2hhbmdlTG9nCmluZGV4IDVmM2M0OGU1Y2EyOTM2ODk3MTk5YjYwOWFjNTQ4 NmY3ZTBhZjhiZTkuLjY3MzNmZTkzYjE2N2ZjYWM4ODY4MDQ1NzQ0NGNmMmI4NTY5ZDlhYTAgMTAw NjQ0Ci0tLSBhL1dlYnNpdGVzL3BlcmYud2Via2l0Lm9yZy9DaGFuZ2VMb2cKKysrIGIvV2Vic2l0 ZXMvcGVyZi53ZWJraXQub3JnL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDE5LTEyLTEz ICBaaGlmZWkgRmFuZyAgPHpoaWZlaV9mYW5nQGFwcGxlLmNvbT4KKworICAgICAgICBBZGQgcG93 ZXIgbWV0cmljIHRvIHBlcmYgZGFzaGJvYXJkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0yMDUyMjcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICAqIHB1YmxpYy92My9tb2RlbHMvbWV0cmljLmpzOgorICAgICAg ICAoTWV0cmljKToKKwogMjAxOS0xMi0wNSAgRGV3ZWkgWmh1ICA8ZGV3ZWlfemh1QGFwcGxlLmNv bT4KIAogICAgICAgICBDdXN0b20gYW5hbHlzaXMgdGFzayBwYWdlIHNob3VsZCBhbGxvdyBzY2hl ZHVsZSBhbnkgdHJpZ2dlcmFibGUgYWNjZXB0ZWQgdGVzdHMuCmRpZmYgLS1naXQgYS9XZWJzaXRl cy9wZXJmLndlYmtpdC5vcmcvcHVibGljL2pzL2hlbHBlci1jbGFzc2VzLmpzIGIvV2Vic2l0ZXMv cGVyZi53ZWJraXQub3JnL3B1YmxpYy9qcy9oZWxwZXItY2xhc3Nlcy5qcwppbmRleCAzYzdiMzJl NjIxYzAxODZiNjc2Yzg0YTk5YTMzY2EzYjkwMjdjMjU2Li4xNTg5OWViZDE4NDNiYmIwN2JjMzEw N2JiOWZlZTg1YmExNWM5M2EyIDEwMDY0NAotLS0gYS9XZWJzaXRlcy9wZXJmLndlYmtpdC5vcmcv cHVibGljL2pzL2hlbHBlci1jbGFzc2VzLmpzCisrKyBiL1dlYnNpdGVzL3BlcmYud2Via2l0Lm9y Zy9wdWJsaWMvanMvaGVscGVyLWNsYXNzZXMuanMKQEAgLTE2NCw3ICsxNjQsOSBAQCBmdW5jdGlv biBQZXJmVGVzdFJ1bnMobWV0cmljLCBwbGF0Zm9ybSkgewogICAgICAgICAnSGVhcCc6ICdCJywK ICAgICAgICAgJ0FsbG9jYXRpb25zJzogJ0InLAogICAgICAgICAnU2l6ZSc6ICdCJywKLSAgICAg ICAgJ1Njb3JlJzogJ3B0J31bc3VmZml4XTsKKyAgICAgICAgJ1Njb3JlJzogJ3B0JywKKyAgICAg ICAgJ1Bvd2VyJzogJ1cnCisgICAgfVtzdWZmaXhdOwogCiAgICAgLy8gV2UgY2FuJ3QgZG8gdGhp cyBpbiBQZXJmVGVzdFJlc3VsdCBiZWNhdXNlIGFsbCByZXN1bHRzIGZvciBlYWNoIG1ldHJpYyBu ZWVkIHRvIHNoYXJlIHRoZSBzYW1lIHVuaXQgYW5kIHRoZSBzYW1lIHNjYWxpbmcgZmFjdG9yLgog ICAgIGZ1bmN0aW9uIGNvbXB1dGVTY2FsaW5nRmFjdG9ySWZOZWVkZWQoKSB7CmRpZmYgLS1naXQg YS9XZWJzaXRlcy9wZXJmLndlYmtpdC5vcmcvcHVibGljL3YyL2RhdGEuanMgYi9XZWJzaXRlcy9w ZXJmLndlYmtpdC5vcmcvcHVibGljL3YyL2RhdGEuanMKaW5kZXggNmRhNWRhOGQ4Y2RkNDkzOTA0 MDcyOTZmODhlZDE3ZjU2Mjg3MzM4YS4uYmRjOWFiODYyZDYyZDI3OTI4MWYxZGIyOGUzN2ZiNGZl MzdjZjZlNyAxMDA2NDQKLS0tIGEvV2Vic2l0ZXMvcGVyZi53ZWJraXQub3JnL3B1YmxpYy92Mi9k YXRhLmpzCisrKyBiL1dlYnNpdGVzL3BlcmYud2Via2l0Lm9yZy9wdWJsaWMvdjIvZGF0YS5qcwpA QCAtNDEyLDYgKzQxMiw3IEBAIFJ1bnNEYXRhLnVuaXRGcm9tTWV0cmljTmFtZSA9IGZ1bmN0aW9u IChtZXRyaWNOYW1lKQogICAgICAgICAnQWxsb2NhdGlvbnMnOiAnQicsCiAgICAgICAgICdTaXpl JzogJ0InLAogICAgICAgICAnU2NvcmUnOiAncHQnLAorICAgICAgICAnUG93ZXInOiAnVycKICAg ICB9W3N1ZmZpeF07CiAgICAgcmV0dXJuIHVuaXQ7CiB9CmRpZmYgLS1naXQgYS9XZWJzaXRlcy9w ZXJmLndlYmtpdC5vcmcvcHVibGljL3YzL21vZGVscy9tZXRyaWMuanMgYi9XZWJzaXRlcy9wZXJm LndlYmtpdC5vcmcvcHVibGljL3YzL21vZGVscy9tZXRyaWMuanMKaW5kZXggZjBhMjMyOTkzYTM4 N2QyNTgzMjk5MjQ4ZDJjYmNjNWI4MDJlNjRjYi4uYTNlOTM2OTFjZDcwNzg0MzdkMzU5ZDVlMDdm NzllNGE3MDhkOGQ2ZiAxMDA2NDQKLS0tIGEvV2Vic2l0ZXMvcGVyZi53ZWJraXQub3JnL3B1Ymxp Yy92My9tb2RlbHMvbWV0cmljLmpzCisrKyBiL1dlYnNpdGVzL3BlcmYud2Via2l0Lm9yZy9wdWJs aWMvdjMvbW9kZWxzL21ldHJpYy5qcwpAQCAtMjAsNiArMjAsNyBAQCBjbGFzcyBNZXRyaWMgZXh0 ZW5kcyBMYWJlbGVkT2JqZWN0IHsKICAgICAgICAgICAgICdBbGxvY2F0aW9ucyc6ICdCJywKICAg ICAgICAgICAgICdTaXplJzogJ0InLAogICAgICAgICAgICAgJ1Njb3JlJzogJ3B0JywKKyAgICAg ICAgICAgICdQb3dlcic6ICdXJywKICAgICAgICAgfVtzdWZmaXhdOwogICAgIH0KIAo=